Commit Graph

203 Commits

Author SHA1 Message Date
Rahul Garg ec84c16d75 Fix hipMemcpy3D (#1798)
Fixes #1790 and #1791. hipMemcpy3D still requires further refactoring for different input and output combinations.
2020-02-17 19:35:35 +05:30
Maneesh Gupta 2ec55fde47 [dtests] Fix random timeout failures in hipModuleLoadDataMultThreaded (#1877)
Limit the max threads that are launched to 16.
2020-02-17 11:16:20 +05:30
Maneesh Gupta e085417370 Use deque instead of vector for code readers so that the iterators and references will be stable (#1851)
* Use deque instead of vector for code readers so that the iterators and references will be stable

* Fix compile error

* Assign the iterator

* Add multithreaded test

* Make threads a multiple of hardware concurrency

* Output on failure

* Add setDevice to try and initialize the context on cuda

* Create context for cuda

* Set context on each thread

* Reduce threads on cuda

* Skip test on cuda

* Try to initialize the primary context on cuda

* Push ctx to the stack as current

* Revert "Push ctx to the stack as current"

This reverts commit e8a7cc6957.

* Revert "Try to initialize the primary context on cuda"

This reverts commit 86cdb30195.

* updated test for nvidia path

* Add c++11 option for nvcc

Co-authored-by: satyanveshd <53337087+satyanveshd@users.noreply.github.com>
2020-02-15 09:51:24 +05:30
Satyanvesh Dittakavi 2034ed3561 Add c++11 option for nvcc 2020-02-13 19:48:26 +05:30
Satyanvesh Dittakavi 627d9a1f46 updated test for nvidia path 2020-02-13 16:34:05 +05:30
Paul dd6676dadf Revert "Try to initialize the primary context on cuda"
This reverts commit 86cdb30195.
2020-02-11 12:34:11 -06:00
Paul cd279cd574 Revert "Push ctx to the stack as current"
This reverts commit e8a7cc6957.
2020-02-11 12:34:10 -06:00
Paul e8a7cc6957 Push ctx to the stack as current 2020-02-11 11:46:29 -06:00
Paul 86cdb30195 Try to initialize the primary context on cuda 2020-02-11 11:26:24 -06:00
Paul accdd882dc Skip test on cuda 2020-02-10 17:23:58 -06:00
Paul 5d24a2beef Reduce threads on cuda 2020-02-10 16:37:34 -06:00
Paul 7a6e88480b Set context on each thread 2020-02-10 16:01:53 -06:00
Paul bb145e77ae Create context for cuda 2020-02-10 15:52:34 -06:00
Paul 9494d0e3c9 Add setDevice to try and initialize the context on cuda 2020-02-10 13:37:45 -06:00
Maneesh Gupta d032637934 Revert "Match Occupancy APIs syntax with CUDA (#1625)" (#1857)
Reverting this for now till we figure out how to avoid the build
breakage.

This reverts commit 262ad13dd5.
2020-02-10 10:45:28 +05:30
Paul fb8c7cb3ec Make threads a multiple of hardware concurrency 2020-02-06 16:23:29 -06:00
Paul bf69c7ae32 Add multithreaded test 2020-02-06 16:21:40 -06:00
lthakur 2ef4dead24 [dtest] Update hipLaunchCoopMultiKernel.cpp (#1844)
used reinterpret_cast<uint32_t*> for numBlocks, as expected by hipOccupancyMaxActiveBlocksPerMultiprocessor() api.
2020-02-04 19:37:38 +05:30
gandryey 3c718ebe15 [dtest] RCCL multi device launch test (#1731)
Simple test for hipLaunchCooperativeKernelMultiDevice API.
2020-02-04 08:53:43 +05:30
satyanveshd 262ad13dd5 Match Occupancy APIs syntax with CUDA (#1625)
* Match Occupancy APIs syntax with CUDA and fix tests using these APIs
2020-01-29 13:05:53 -08:00
Evgeny Mankov ed43699a3a Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)
2019-12-30 19:21:09 +03:00
Evgeny Mankov 4aaa2336a8 [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle
2019-12-23 17:01:35 +03:00
Alex Voicu 150e690a3a Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.
2019-12-23 19:11:24 +05:30
Vladislav Sytchenko a91bafca40 Add comments explaining choice on the cap for system memory on Windows. 2019-12-13 21:38:27 -05:00
Vladislav Sytchenko 4c21eed68b Add explicit cast when computing the available amount of system memory. 2019-12-13 21:37:30 -05:00
Vladislav Sytchenko 282367ed6d Reduce the amount of free host memory to 40% of what is reported on Windows, otherwise we can run into OOM situations. 2019-12-11 20:21:12 -05:00
Rahul Garg a369bd4418 Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.
2019-12-06 09:51:53 +05:30
Rahul Garg 261a04580f Fix hipMemcpyWithStream (#1707)
* Fix hipMemcpyWithStream
* Add a dtest for the same.
2019-12-04 11:56:23 +05:30
Sarbojit2019 8a3c36a424 Revert [HIP] Fixed hipStreamAddCallback (#1674)
This reverts commit 97fca3439d.
Addresses SWDEV#212675.
2019-11-20 11:55:46 +05:30
Rahul Garg fa1335f419 [dtest] Rename hipExtLaunchMultiKernelMultiDevice dtest (#1671) 2019-11-19 09:41:13 -08:00
Alex Voicu 355d0bdf95 Add support for extended launch syntax. (#1530)
* Add support for extended launch syntax.

* Add unit test.

* Fix typo

* hipExtLaunchKernelGGL lives in hip_ext.h

Change-Id: Ice32dab0d43475fda65c6a910c11416871a8f2ff

* [dtest] remove redundant include from hipModuleGetGlobal dtest
2019-11-16 22:24:07 -08:00
Sarbojit2019 97fca3439d [HIP] Fixed hipStreamAddCallback [SWDEV#165185] (#1425)
Fixed hipStreamAddCallback() as requested in SWDEV#165185
Added unit test to test the behavior
2019-11-07 13:18:12 +05:30
Rahul Garg dfee3ae279 Rename hip/hip_hcc.h to hip/hip_ext.h (#1341)
* Rename hip/hip_hcc.h to hip/hip_ext.h

* Deprecate hip_hcc.h
2019-11-07 13:17:10 +05:30
Aryan Salmanpour 7a3d592ed0 [hip][tests] Add two more workgroup sizes for testing hipLaunchCooperativeKernel (#1613) 2019-11-05 12:32:46 +05:30
Rahul Garg 1bec1445bb Merge pull request #1582 from amd-lthakur/hipExtMLK
Adding a directed test case for hipExtModuleLaunchKernel() api.
2019-10-31 17:13:26 -07:00
Rahul Garg 07f4431de8 Formatting changes 2019-10-30 18:12:51 -07:00
Rahul Garg cd1435cbc7 Formatting changes ,variable name and check update 2019-10-30 18:09:21 -07:00
Rahul Garg 27221bc823 Revert "Fix occupany APIs (#1560)"
This reverts commit 6c5fbf9b4a.
2019-10-29 11:41:08 -07:00
amd-lthakur 626cd5d07a Excluded the test case for nvcc platform 2019-10-25 15:52:11 +05:30
Rahul Garg 66a3c874c8 [dtest] Fix hipMemset2D test (#1579)
Reverts changes made in #1399. This is a RT api test. For testing hipMemAllocPitch , a new test should be written and that should use correct memset API.
2019-10-25 15:44:05 +05:30
amd-lthakur b2238bacd4 Refactored the file as suggested 2019-10-25 10:44:38 +05:30
amd-lthakur 84fb936dfe Update matmul.cpp 2019-10-25 09:22:07 +05:30
amd-lthakur 9a860e6766 Update hipExtModuleLaunchKernel.cpp 2019-10-25 09:19:49 +05:30
satyanveshd 6c5fbf9b4a Fix occupany APIs (#1560)
Addresses SWDEV-205006
2019-10-24 17:44:47 +05:30
amd-lthakur 0adcc890b0 Adding a directed test case for hipExtModuleLaunchKernel() api. 2019-10-24 15:06:28 +05:30
Vladislav Sytchenko f4440817cb _aligned_malloc() on Windows first takes size, then alignment, which is the opposite of how the similar function behaves on Linux. Memory allocated by it also has to be freed using _aligned_free(), unlike Linux where we can use regular free().
Edit aligned_alloc() macro and add a aligned_free() one to align with the above behaviour.
2019-10-17 18:58:32 -04:00
Vladislav Sytchenko 86d0c5fa5a hipMemset2D and hipMemset3D tests should be passing by default. 2019-10-16 11:02:38 -04:00
Vladislav Sytchenko cc5abec092 In the hipMemset2D and hipMemset3D tests synchronize with the default stream after performing an async memset. 2019-10-15 17:15:49 -04:00
Vladislav Sytchenko f402b6d01a Update indentation in the hipMemset3D test. Replace all tabs with four spaces. 2019-10-15 15:29:14 -04:00
Vladislav Sytchenko c83b6adb33 Add async subtest to hipMemSet3D 2019-10-15 14:24:04 -04:00