Chris Kitching
c08f105982
Use inline initialisers to set default field values
...
A trivial cleanup that helps in a moment..
[ROCm/hip commit: 24fc459f69 ]
2017-10-19 17:08:55 +01:00
Chris Kitching
2584387bfc
Omit now-removed Filename string arg from handleBeginSource
...
[ROCm/hip commit: 7ae6a10c99 ]
2017-10-19 17:08:55 +01:00
Chris Kitching
b2ac8756fc
Cope with Replacements now having llvm::Error returns
...
[ROCm/hip commit: 7e253365f1 ]
2017-10-19 17:08:54 +01:00
Chris Kitching
5e45fd1c7c
Cope with clang 4.0's rename of getNumArgs()
...
Sorry, this one I couldn't do in a perfectly elegant way ;)
[ROCm/hip commit: 575bedb28c ]
2017-10-19 17:08:54 +01:00
Chris Kitching
459b78e997
Remove unnecessary call to Retain() on a smart pointer
...
The Preprocessor smart pointer is held by the CompilerInstance,
and therefore its reference count cannot reach zero until the
CompilerInstance itself is destroyed.
If the CompilerInstance is destroyed, you have more to worry about
than just the preprocessor being deallocated!
Newer versions of the LLVM/Clang API migrated to using
std::shared_ptr, so there is no `Retain()` function (by that
name, anyway). Eliminating this redundant use is a neat and
backward-compatible way to become compatible with newer versions
of the LLVM/Clang API.
[ROCm/hip commit: 0953a7887d ]
2017-10-19 17:08:54 +01:00
Chris Kitching
316faf5fc7
Refer to clang::StringLiteral explicitly
...
Newer versions of llvm/clang mean there is both an
llvm::StringLiteral and a clang::StringLiteral. Since we're
dumping both namespaces wholesale into the global namespace with
`using` declarations, this creates a name collision, which must be
resolved.
This change is backwards-compatible, and fixes a problem you
encounter when using newer versions of the llvm/clang API.
[ROCm/hip commit: 2975d00edc ]
2017-10-19 17:08:54 +01:00
Chris Kitching
24adac896b
Fix two faulty LLVM version checks
...
What we actually want to do here is use the StringRef version in
versions newer than 3.8, and the void one in 3.8 and older.
Checking "major-version >= 3 && minor-version >= 9" does not do
what we want. Consider what this will do for version 4.0, for
which minor-version is zero...
[ROCm/hip commit: 3a2fe40f78 ]
2017-10-19 17:08:54 +01:00
Chris Kitching
7298ba77b2
Use the cache for global variables - not PARENT_SCOPE hacks
...
[ROCm/hip commit: be5a120f90 ]
2017-10-19 17:08:54 +01:00
Chris Kitching
36ac7933cc
Skip lit tests if lit cannot be found
...
[ROCm/hip commit: 9a3faec12c ]
2017-10-19 17:08:54 +01:00
Chris Kitching
6b5ec20965
Don't reinvent find_package
...
PythonInterp is a finder module that ships with cmake. It supports
the conventional interaction with find_package that allows you
to demand success, and particular vesions, without having your
own logic:
https://cmake.org/cmake/help/v3.0/command/find_package.html
[ROCm/hip commit: 764d89dcbe ]
2017-10-19 17:08:53 +01:00
Chris Kitching
05f095db11
Don't be picky about clang versions
...
[ROCm/hip commit: 757b9c3b76 ]
2017-10-19 17:08:53 +01:00
Chris Kitching
ad9f427432
Declare HIPIFY_CLANG_TESTS as a cmake option
...
[ROCm/hip commit: cb948dc7fd ]
2017-10-19 17:08:53 +01:00
Chris Kitching
4252499f72
Use early return to avoid indenting all of CMakeLists.txt
...
[ROCm/hip commit: 51ee1bdc2d ]
2017-10-19 17:08:53 +01:00
Chris Kitching
473297f1a5
Fix broken indentation introduced by previous commit
...
[ROCm/hip commit: 517d46c333 ]
2017-10-19 17:08:53 +01:00
Chris Kitching
9cd878f5c7
Inline a redundant std::vector
...
Looks like a partial refactor..?
[ROCm/hip commit: 4ba2b2e5b8 ]
2017-10-19 14:11:25 +01:00
Chris Kitching
0602fc6124
Allow user-provided -std=* argument to override the default
...
This means any user-provided -std=* argument overrides this one,
allowing use of newer standards.
[ROCm/hip commit: 742526706b ]
2017-10-19 14:11:15 +01:00
Chris Kitching
49feb372f5
Add [[nodiscard]] attribute to hipError_t in C++17 mode
...
This will yield a compiler warning any time you discard an error
return value from an API call.
[ROCm/hip commit: 1d205ab130 ]
2017-10-19 13:34:02 +01:00
Siu Chi Chan
4dc24498af
hipDeviceReset(): make sure to reinitialize the printf buffer in hcc RT
...
[ROCm/hip commit: ccef1cbd6e ]
2017-10-18 16:26:13 -04:00
Evgeny Mankov
65497bfaff
Merge pull request #210 from ChrisKitching/output-hipify
...
[HIPIFY] Alter output file behaviour slightly
[ROCm/hip commit: db7661ccad ]
2017-10-18 21:46:31 +03:00
Chris Kitching
49f9c4feff
Unconditionally append .hip as the default output filename
...
[ROCm/hip commit: 296c5a33ce ]
2017-10-18 19:19:18 +01:00
Chris Kitching
a2629da99c
If an output path is given _use it_
...
Don't append .hip to a user-provided output file...
[ROCm/hip commit: e4e17a56bb ]
2017-10-16 17:32:57 +01:00
Chris Kitching
0c0891836f
Operate on a temp file in-place
...
This copies to the output after operation, instead of working
_on_ the output. This allows includes to work correctly, while
supporting output paths anywhere on the filesystem.
Fixes #208
Fixes #206
[ROCm/hip commit: 2263cb9f72 ]
2017-10-16 17:32:56 +01:00
Evgeny Mankov
0162211c28
[HIPIFY][ #199 ][Partial fix] Fix for cudaLaunchKernel transformation
...
[Synopsis]
If any of kernel arguments is a MACRO its location calculation is wrong (location of its definition is actually calculated).
Thus garbage code is being produced on the place of such a MACRO starting from the end of its actual definition.
[Solution]
Add isMacroBodyExpansion and isMacroArgExpansion checks on kernel arguments.
[ROCm/hip commit: 7ee8e2d51b ]
2017-10-12 20:05:42 +03:00
Evgeny Mankov
75508281a5
[HIPIFY] cmake changes
...
+ standalone build support
+ WIN MSVC support
+ disable lit testing by default
+ to enable lit testing -DHIPIFY_CLANG_TESTS=1 should be specified
Tested builds:
+ hipify-clang standalone {Ubuntu 16.04|Windows 10} {Debug|Release} {x86|x64a} {g++|clang++|MSVC 2017} {llvm 3.8.0|llvm 3.9.0} {-DHIPIFY_CLANG_TESTS=1| }
+ HIP {-DHIPIFY_CLANG_LLVM_DIR=..|} {Ubuntu 16.04} {Debug|Release} {x86|x64a} {hcc} {llvm 3.8.0|llvm 3.9.0} {-DHIPIFY_CLANG_TESTS=1| }
[ROCm/hip commit: 87cf949d39 ]
2017-10-09 20:28:20 +03:00
Evgeny Mankov
65a58a416b
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP
...
[ROCm/hip commit: 557772e6ff ]
2017-10-09 20:17:43 +03:00
Alex Voicu
322cc5f7aa
This fixes incorrect usage of the reader object, which created arcane
...
mismatches when one reader accessed another's section.
[ROCm/hip commit: 70786a5563 ]
2017-10-09 15:46:38 +01:00
Alex Voicu
a45ff026ea
Merge remote-tracking branch 'origin/master' into feature_support_globals_for_module_api
...
[ROCm/hip commit: 0545a49381 ]
2017-10-09 13:28:13 +01:00
Alex Voicu
fbcd3b0aa6
This adds cursory support for globals to the HIP module loading API. The
...
style is purposefully alien so as to signal that HIP experts should turn
it into HIP worthy code as soon as possible.
[ROCm/hip commit: ffffe052b6 ]
2017-10-09 13:27:11 +01:00
Ben Sander
05d5dd2d46
Test cleanup.
...
[ROCm/hip commit: 8e04b33c95 ]
2017-10-07 07:54:10 -07:00
Ben Sander
50ef165727
Add copy_coherency test
...
Test cache managemenent and synchronization between kernel and copy commands
in separate queues.
[ROCm/hip commit: 54d5b52d05 ]
2017-10-07 07:54:10 -07:00
Maneesh Gupta
8b580446c4
Bump HIP version to 1.4 and update release notes
...
Change-Id: I3570dedb32fe5fec6f60565c587a3282a4c6c709
[ROCm/hip commit: ca239ab6ef ]
2017-10-06 10:26:11 +05:30
Evgeny Mankov
643eb7ace7
[HIPIFY] CUDA RT Textures and Arrays support update
...
[ROCm/hip commit: 53ce40ebab ]
2017-10-05 16:38:36 +03:00
Maneesh Gupta
11b4d1c7e3
Merge pull request #188 from gargrahul/texture2D_tests
...
Added Texture 2D object and reference APIs tests
[ROCm/hip commit: 9c7bd55dd7 ]
2017-10-05 12:01:10 +05:30
Maneesh Gupta
710d095874
Merge pull request #194 from bensander/fix_genco_math_path
...
Fix math ordering for --genco mode.
[ROCm/hip commit: c1803c1951 ]
2017-10-03 16:17:34 +05:30
Ben Sander
d1be93bbd9
Fix math ordering for --genco mode.
...
[ROCm/hip commit: 68c2146dc3 ]
2017-10-02 21:52:16 +00:00
Rahul Garg
be4b7099bb
Fixed review comment
...
[ROCm/hip commit: b8aae66424 ]
2017-10-02 17:29:08 +05:30
Rahul Garg
28b92618b7
Fixed review comments
...
[ROCm/hip commit: 19d574d939 ]
2017-10-02 10:57:25 +05:30
Rahul Garg
71552c63ac
Fixed build issue
...
[ROCm/hip commit: f62254a8d8 ]
2017-10-02 10:40:01 +05:30
Rahul Garg
69508f52cc
Fix texture support on HIP/NVCC path
...
[ROCm/hip commit: 470224cf25 ]
2017-10-02 10:40:01 +05:30
Kent Knox
2148ae642b
Making docker_clean_images more resilient
...
To the failure of deleting images.
[ROCm/hip commit: fb561a3821 ]
2017-09-28 14:28:53 -05:00
Maneesh Gupta
ed9ea0aae7
Merge pull request #187 from gargrahul/fix_texture_fetch_issue
...
Fixed hipTexture fetch issue
[ROCm/hip commit: 985eac6446 ]
2017-09-27 08:48:15 +05:30
Kent Knox
1c91749775
Force organization name to be lowercase for docker
...
error building docker image because of CamelCasing
[ROCm/hip commit: 90f1a9626e ]
2017-09-26 14:33:29 -05:00
Rahul Garg
5c9132056f
Added HIT block
...
[ROCm/hip commit: ce13e4afbf ]
2017-09-26 11:39:09 +05:30
Rahul Garg
990f85120a
Added Texture 2D object and reference APIs tests
...
[ROCm/hip commit: 3b7a8fab5b ]
2017-09-26 11:33:23 +05:30
Kent Knox
4536a3b7f8
Modify the path for downloaded artifacts from hcc
...
[ROCm/hip commit: b3038b3ea7 ]
2017-09-24 23:12:42 -05:00
Rahul Garg
8c67dd3b2e
Fixed hipTexture fetch issue
...
[ROCm/hip commit: 9929e8e717 ]
2017-09-25 06:54:29 +05:30
Siu Chi Chan
6884635ae0
ensure the condition is evaluated before applying the negation operator
...
[ROCm/hip commit: 83d9e889a9 ]
2017-09-20 01:38:28 -04:00
Maneesh Gupta
d4919a95cb
Merge pull request #183 from wsttiger/master
...
Remove the conversion of warpSize to be consistent with hipDeviceProp
[ROCm/hip commit: 2db70fe5fd ]
2017-09-20 09:15:18 +05:30
Maneesh Gupta
15caa05c2f
Merge pull request #184 from emankov/master
...
[HIPIFY] Fix typo in doc
[ROCm/hip commit: 9d885ced0d ]
2017-09-20 09:11:50 +05:30
Maneesh Gupta
44d34df638
Merge pull request #161 from kknox/hcc-integration-testing-squash
...
HCC integration testing
[ROCm/hip commit: ae0ab83eb5 ]
2017-09-20 09:10:30 +05:30