Commit Graph

1273 Commits

Author SHA1 Message Date
Pratik Basyal cfd3fee0e2 ROCm Compute Profiler changelog for 7.0 updated (#740)
* ROCm Compute Profiler changelog for 7.0 updated

* Roofline limited support for MI350 removed

* Update CHANGELOG.md
2025-08-27 11:24:49 -04:00
vedithal-amd 323d06c79c [rocprofiler-compute] Add database output format to analyze mode (#748)
Analysis data dump

* Add `--output-format` and `--output-name` option to analyze mode

* Remove `--output` and `-save-dfs` option to analyze mode

* Add documentation on `rocpd` output format and analysis database file

* Create sqlite3 database using object relation mapping (ORM) provided
  by sqlalchemy library

* Fix metrics config to remove metrics marked as `null`, fix `Unit` header, add
  missing `title`

* Add test cases to ensure analysis data dump work
2025-08-26 14:15:05 -04:00
xuchen-amd e8081bd91a Update mi350 output files for unit tests. (#744) 2025-08-25 21:27:10 -04:00
xuchen-amd 5c8b34ddf5 [rocprofiler-compute][TUI] Add interactive metric description (#718) 2025-08-25 15:53:55 -04:00
vedithal-amd 9a02dae75f [rocprofiler-compute] [Bugfix] Fix analysis not working with rocpd (#704)
* fix rocpd roofline

* Improve rocpd test by using dynamic workload folder

* bugfix

* fix ruff format
2025-08-25 11:46:55 -04:00
vedithal-amd 748c9b74d9 Update standalone binary to use python 3.9 (#725)
* Update standalone docker to python 3.9

* Add TUI files

* Fix docker files to work with monorepo

* Update standalone binary documentation
2025-08-25 07:57:08 -04:00
ywang103-amd 2a216ecbc1 pc sampling unit tests (#194) 2025-08-23 10:13:22 -04:00
Taylor Ding b5c8c8bcb1 Eval metrics performance optimizations (#435)
Post-analysis eval metrics performance optimizations.
2025-08-22 16:35:48 -04:00
jamessiddeley-amd 5deeea71df [rocprof-compute] Update Formatting (#671)
* updated rocprof-compute formatting

* fixed ammolite peak variables in parser.py

* format parser.py

* update formatting rocprof_compute_base
2025-08-22 12:22:17 -04:00
xuchen-amd ed877433f3 [rocprofiler-compute][TUI] Updates and refactor. (#703) 2025-08-22 11:02:32 -04:00
xuchen-amd 6bf5648c6d [rocprofiler-compute] Handle amd-smi rocm==6.4.2 json output issue. (#667) 2025-08-21 10:06:04 -04:00
David Galiffi 31c9d3424c Update README.md (#640)
* Update README.md

* Update README.md
2025-08-20 17:39:49 -04:00
xuchen-amd 0bf66a519c [rocprofiler-compute][TUI] Restructure Performance Metrics (#232) 2025-08-20 17:00:54 -04:00
vedithal-amd ed53090c25 Join SQC_* csv files as well (#669) 2025-08-20 15:33:48 -04:00
cfallows-amd 8bc0063f2e Update rocprofiler-compute workflows and CODEOWNERS (#221)
Update super repo codeowners- add Pratik to any doc changes for rocprofiler-compute.
Remove rocprofiler-compute-mi-rhel9.yml from super repo workflow folder- unused and out of date, coverage is already in RHEL8 workflow.
Remove CODEOWNERS, dependabot.yml, and all workflows from the projects/rocprofiler-compute/ project- confirmed these do not do anything anymore after being copied into super repo's main ./github/ section.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

* Add a branch filter for push events

* Update .github/CODEOWNERS

Use reviewers team instead of using the individual profiles.

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

Update owners section for rocprofiler-compute codeowners, fix spacing

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-08-20 11:17:25 -04:00
jamessiddeley-amd 5840940caa [rocprof-compute] Generalize Roofline (#325)
* per kernel analysis Roofline

* added per-kernel eval_metric calculation with display

* fixed typo

* updated tty.py show_all()

* formatting

* fixed ctest failures and updated equations

* formatting

* updated metric descriptoins

* review tweaks

* update docs

* added roofline gui analysis

* updated GUI docs

* updated print statement

* comment tweaks and ran ruff formatting
2025-08-20 09:58:08 -04:00
jamessiddeley-amd 2936a468aa [rocprof-compute] updated formatting workflow and docs (#348)
* updated formatting workflow and docs

* restored requirements.txt
2025-08-14 14:12:24 -04:00
vedithal-amd 80b7e6baee Backport CHANGELOG change from rc4 cherry pick (#342)
* Backport from https://github.com/ROCm/rocprofiler-compute/pull/860
2025-08-13 14:49:53 -04:00
xuchen-amd 483315fd0a Fix amd_smi lookup logic to account for amd-smi>=26.0.0 (#320) 2025-08-13 10:21:45 -04:00
vedithal-amd 63f31859e4 Fix instruction cache metrics (#276)
* Fix IL1 Latency metric

* Add SQC_ICACHE_INFLIGHT_LEVEL counter and corresponding accumulation
  counter to counter definitions

* Add missing coll_level

* Fix descriptions and tests
2025-08-12 14:03:11 -04:00
xuchen-amd 9a4983feac Fix fstring formatting. (#315) 2025-08-12 11:54:58 -04:00
xuchen-amd 0929e6ecc1 [rocprofiler-compute] Update amd smi lookup (#223) 2025-08-11 17:37:33 -04:00
cfallows-amd 3258c69b60 Fix cmake formatting (#222)
Fix formatting of CMakeLists.txt for cmake-format check

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-08-11 16:40:09 -04:00
vedithal-amd 002b9607b6 [rocprofiler-compute] Fix profiling tests (#227)
* Add check for SQC_DCACHE csv in test script

* Fix the list of csv files when profiling in tests
2025-08-11 09:59:34 -04:00
systems-assistant[bot] 58d2a016ce Format source code to PEP8 using Ruff (#36)
* added ruff docs

* style: Run ruff and black before yapf pass

* yapf -r -i (23 fixes)

* fixed conf.py and ran ruff format .

* fixed conf.py 2

* formatted argparser.py

* formatted src/rocprof_compute_analyze

* formatted src/rocprof_compute_profile

* formatted soc_base.py

* formatted rocprof_compute_tui

* formatted gui_components

* formatted src/utils

* formatted tests/

* format extra files

* cleanup

* fix test_utils.py

* fixed typos

* Update pyproject.toml

* Update README.md

* Update test_utils.py

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
Co-authored-by: James Siddeley <James.Siddeley@amd.com>
Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
2025-08-08 15:32:30 -04:00
systems-assistant[bot] d3f9ab25eb Use own counter definition (#91)
* Use own counter definition
  * Do not depend on rocprofiler-sdk counter definition

* Add missing counter definitions for MI100, MI200, MI300, MI350 series
  * Counters added based on register specification
  * This prevents some missing metrics

* Enable SQC_DCACHE_INFLIGHT_LEVEL counter and associated metrics

* Enable TCP_TCP_LATENCY counter and associated counter for all GPUs
  except MI300

* Update TCC_EA_* counters for MI100 to TCC_EA0_*
  * Update MI100 metrics which depend on TCC_EA0_* counters

* Enable accumulation counters for MI100

* Improve rocprof list avail usage to get a better idea of supported
  counters

* Update CHANGELOG

* Move accumulation counters to counter definition

---------

Co-authored-by: Vignesh Edithal <Vignesh.Edithal@amd.com>
2025-08-08 14:39:10 -04:00
vedithal-amd 97d9f35033 Fix ctest and docker to work with monorepo (#181)
* Remove .git folder and git command check in cmake

* Update docker container to work in monorepo
    * Update docker container to mount the top level folder in monorepo
2025-08-08 10:26:57 -04:00
cfallows-amd d8d739f57c Re-add rhel8 roofline binaries (#122)
RHEL8 now being supported until EOS, rebuilding rhel8 bins for rocm7 (previously built for rocm7 rhel9).

Remove roofline-rhel9-rocm7, replace with new roofline-rhel8-rocm7.
Update check for roof bin.
Update any doc mentions of rhel min support version back to rhel8.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-08-07 12:24:02 -04:00
vedithal-amd 2444c20172 Fix cmake to skip textual_fspicker check (#121) 2025-08-07 11:43:22 -04:00
vedithal-amd 448e5dfbcb Backport ROCm 7.0 changelog (#116)
* Backport changelog from ROCm 7.0 RC3 cherry-pick PR
    * https://github.com/ROCm/rocm-systems/pull/93
2025-08-07 00:13:04 -04:00
systems-assistant[bot] 89c74ac3d3 Update Unit of Bandwidth metrics to Gbps (#96)
* Add Utilization to metric name for Bandwidth related metrics whose Unit
  is Percent

* Update Unit of Bandwidth metrics to Gbps
    * Update metric Formula to use total duration as denominator instead of normalization unit.
    * Update metric Description
    * Update metric Unit

* Update CHANGELOG
2025-08-06 18:39:50 -04:00
vedithal-amd 96f6abbc03 Remove marker for test autoconfig (#857)
[ROCm/rocprofiler-compute commit: 874b920edd]
2025-08-06 10:46:04 -04:00
xuchen-amd 34dd26fb07 Enable single pass counter collection (#833)
[ROCm/rocprofiler-compute commit: 6a77d241ed]
2025-08-06 10:35:05 -04:00
vedithal-amd 5084aad00b Fix autogen config test (#856)
* Only check file content hash consistency

* Do not check file modification timestamps since that can be updated by
  git commands

[ROCm/rocprofiler-compute commit: e867524344]
2025-08-05 10:50:32 -04:00
vedithal-amd 30c32c0bd1 Fix L2 cache bandwidth metrics for MI350 (#843)
* Fix L2 cache bandwidth metrics for MI350

* Address review comments

[ROCm/rocprofiler-compute commit: b349e406ed]
2025-08-01 14:00:46 -04:00
vedithal-amd 457b00ca12 Fix metrics description (#853)
* Fix ordering of metrics description

[ROCm/rocprofiler-compute commit: 6902b12e65]
2025-08-01 13:56:29 -04:00
vedithal-amd 2cd1df0db7 Remove duplicate metric descriptions from documentation (#852)
[ROCm/rocprofiler-compute commit: d84863b7af]
2025-08-01 13:33:58 -04:00
Fei Zheng 7a4d187f40 update license files (#849)
[ROCm/rocprofiler-compute commit: 0d6e172679]
2025-08-01 10:14:39 -06:00
xuchen-amd b6a7d72212 TUI: Kernel Selection (#769)
[ROCm/rocprofiler-compute commit: 9ddee8de2e]
2025-08-01 11:31:43 -04:00
Fei Zheng bf05f442b8 Fix pc sampling unit test (#847)
[ROCm/rocprofiler-compute commit: 81daaaecc7]
2025-08-01 09:28:43 -06:00
vedithal-amd 4edffecd3c Backport CHANGELOG changes from 7.0 release (#845)
* Backport CHANGELOG changes from 7.0 release

* Backport CHANGELOG changes from https://github.com/ROCm/rocprofiler-compute/pull/815

[ROCm/rocprofiler-compute commit: 70ebb4a299]
2025-07-31 19:02:50 -04:00
Fei Zheng 666f00a07f Format code (#842)
[ROCm/rocprofiler-compute commit: 6cbda3f1d8]
2025-07-31 08:20:49 -06:00
Fei Zheng 94ce792f39 quick fix how to call v3 with pc sampling
[ROCm/rocprofiler-compute commit: 3a40e4b58c]
2025-07-31 08:17:06 -06:00
dependabot[bot] deefddf2ff Bump rocm-docs-core from 1.21.1 to 1.22.0 in /docs/sphinx (#839)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.21.1 to 1.22.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.21.1...v1.22.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-version: 1.22.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vedithal-amd <Vignesh.Edithal@amd.com>

[ROCm/rocprofiler-compute commit: c7b5a0f43a]
2025-07-30 14:35:32 -04:00
vedithal-amd aa2f74c10f Fix rocprof avail usage (#840)
[ROCm/rocprofiler-compute commit: ea4769f604]
2025-07-30 13:52:55 -04:00
fxmarty-amd 49b5d410e4 bugfix to make amd-smi usage backward compatible (#836)
* Update soc_base.py

Fixes https://github.com/ROCm/rocprofiler-compute/issues/835

Signed-off-by: fxmarty-amd <felmarty@amd.com>

* address comments

---------

Signed-off-by: fxmarty-amd <felmarty@amd.com>

[ROCm/rocprofiler-compute commit: 56d040156e]
2025-07-30 09:40:04 -04:00
David Galiffi 85f6fb540a Update VERSION to 3.3.0 (#838)
Bumping version now that `release/rocm-rel-7.0` has been created

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: 8ad2aa55f2]
2025-07-29 13:02:20 -04:00
vedithal-amd 2966867099 Fix test cases (#837)
* Fix formatting

[ROCm/rocprofiler-compute commit: 80ea339217]
2025-07-28 16:19:45 -04:00
vedithal-amd 17e5892614 Enable rocpd output format with rocprofiler sdk (#790)
* Add `rocpd` choice for `--format-rocprof-output` option
* Add rocpd_data.py which defines SQL queries to extract data from rocpd database
* Use sqlite3 package to read the database
* Add `--retain-rocpd-output` option in profile mode to retain raw
  rocpd database
* Add warning notice to say `--format-rocprof-output rocpd` will be
  default in future release

For rocpd output:
* Use only `pmc_perf.csv` instead of reading individual coll_level results csv files
* Post process csv files using pandas in analysis mode instead of profile mode
* Use ACCUM counters instead of SQ_ACCUM_PREV_HIRES

* Add test cases for rocpd output format
* Fix code formatting issues
* Update CHANGELOG

[ROCm/rocprofiler-compute commit: 03d27c0ba0]
2025-07-28 11:02:28 -04:00
vedithal-amd 97465e7448 add description for MI100 counters (#834)
[ROCm/rocprofiler-compute commit: 6885cb068d]
2025-07-26 15:33:23 -04:00