Commit Graph

5131 Commits

Author SHA1 Message Date
Konstantin Pyzhov adf3b8774e Disable hipStreamSync2 test for hip-clang. 2019-05-20 02:13:30 -04:00
Jenkins 96f4b022ab Merge 'master' into 'amd-master'
Change-Id: Ic1757967f5f1d7982fa304c84f8a4c923dd606c4
2019-05-18 19:59:41 -07:00
Maneesh Gupta 71143b426e Merge pull request #1118 from yxsamliu/fix-build-hiprtc
Fix build failure due to hiprtc for HIP-Clang
2019-05-17 21:38:22 +05:30
Jenkins 0d805b92be Merge 'master' into 'amd-master'
Change-Id: I4189feaa83580761c6fb2d0b636040a40964cbeb
2019-05-17 10:50:29 -04:00
Yaxun Sam Liu d088a8c23b Fix build failure due to hiprtc for HIP-Clang 2019-05-17 09:52:43 -04:00
Aaron Enye Shi 303ba600d6 Fix hipcc exit code when failing 2019-05-16 20:36:58 +00:00
Evgeny Mankov 633323c981 Update README.md 2019-05-16 18:16:17 +03:00
Evgeny Mankov ab865dbf0e Merge pull request #1116 from emankov/master
[HIPIFY][doc] Update README.md
2019-05-16 18:10:09 +03:00
Evgeny Mankov df2a64cf0d [HIPIFY][doc] Update README.md
+ Update logs
+ Formatting
2019-05-16 18:07:11 +03:00
Evgeny Mankov 21518887bc Merge pull request #1115 from emankov/master
[HIPIFY][cuDNN] Add cudnnGetFilter4dDescriptor support
2019-05-16 16:39:34 +03:00
Evgeny Mankov 02f8dfe7d8 [HIPIFY][cuDNN] Add cudnnGetFilter4dDescriptor support
+ Update cudnn_convolution_forward test accordingly
2019-05-16 16:36:23 +03:00
Alex Voicu a538eb705a Add HIPRTC, glorious ersatz for NVRTC (#1097)
* Add ersatz for NVRTC.

* Fix extraneous paren and use correct namespace.

* Use lowerCamelCase (yuck, yuck) consistently.

* Link against FS when building hiprtc lib.

* Correctly mark Manipulators. Fix dual compile.

* Add unit tests. Extend HIT to accept linker options.

* Make sure the HIPRTC library is installed.

* Better logging. Try to auto-detect the target.

* Stop specifying the target explicitly.

* Add missing flavour of `hipModuleLaunchKernel`.

* Program was already destroyed.

* Don't use `--genco`. Fix mangled name trimming.

* Fix HIPRTC breakage due to upstream noise.

* [dtests] Replace RUN -> TEST in hiprtc tests

Change-Id: Ie499e92dfe4e5c94634b1c2b76cf52d241bcfea3

* [hit] Set HIP_PATH to HIP_ROOT_DIR for all tests

Change-Id: Ib0ad1f99bc71c03e363e055dd508a7a4a210680a
2019-05-16 18:28:54 +05:30
Maneesh Gupta 3178ae2f92 Merge pull request #1113 from wenkaidu/hop_count
Use NUMA distance for hop count calculation
2019-05-16 14:16:29 +05:30
Maneesh Gupta 8e9bc62f6e Merge pull request #1112 from kpyzhov/hipModule-test
Upload pre-built kernel binary for hipModule test.
2019-05-16 14:16:18 +05:30
Wenkai Du 56d2dc0022 Use NUMA distance for hop count calculation 2019-05-15 21:50:35 +00:00
Evgeny Mankov 43ad335d3c Merge pull request #1111 from emankov/master
[HIPIFY][tests] Add reverse engineered HIP sample "stream"
2019-05-15 20:18:51 +03:00
Evgeny Mankov 7cc12df514 [HIPIFY][tests] Add reverse engineered HIP sample "stream"
+ Add additional checks for extern __shared__ due to [#1109]
2019-05-15 20:17:03 +03:00
Evgeny Mankov de57a5ba62 Merge pull request #1110 from emankov/master
[HIPIFY][fix][#1109] Do not preserve extern __shared__ for IncompleteArrayType
2019-05-15 20:09:00 +03:00
Evgeny Mankov bf65120156 [HIPIFY][fix][#1109] Do not preserve extern __shared__ for IncompleteArrayType
+ Update tests accordingly
2019-05-15 20:05:56 +03:00
foreman 61bacfd131 P4 to Git Change 1783301 by cpaquot@cpaquot-ocl-lc-lnx on 2019/05/15 11:57:57
SWDEV-189488 - [HIP] Caffe2 TensorTest.TensorSerializationMultiDevices fails
	1. Make sure to set attributes->device to current device for host malloc'd
	2. Return hipSuccess for hipDeviceCanAccessPeer

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#56 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#4 edit
2019-05-15 12:22:50 -04:00
Konstantin Pyzhov 6242377a5c Upload pre-built kernel binary for hipModule test. 2019-05-15 07:19:40 -04:00
Jenkins 6ffc5cb48f Merge 'master' into 'amd-master'
Change-Id: I15e04f87004767e238af9aa1ab9567921594d07f
2019-05-15 05:45:15 -04:00
Evgeny Mankov a0f10ebaa2 Merge pull request #1104 from emankov/master
[HIPIFY][tests] Add reverse engineered HIP sample Profiler
2019-05-14 16:59:36 +03:00
Evgeny Mankov 5e49c25faa [HIPIFY][tests] Add reverse engineered HIP sample Profiler
+ Add missing cuda_profiler_api.h to hip/hip_profile.h transformation.
NOTE: HIP Profiler API is under development. This is NOT WORKING example.
TODO: Find out a way to generate HIP_SCOPED_MARKER, HIP_BEGIN_MARKER, HIP_END_MARKER, declared in hip/hip_profile.h in particular place (signatures are to obtain).
2019-05-14 16:43:44 +03:00
Jenkins b32578d5b9 Merge 'master' into 'amd-master'
Change-Id: I476b12c4e051b47fb2e62dbea709d268d9a2f630
2019-05-14 02:12:10 -07:00
Evgeny Mankov 5da723222e Merge pull request #1102 from emankov/master
[HIPIFY][tests] Add reverse engineered HIP sample hipEvent
2019-05-13 22:14:41 +03:00
Evgeny Mankov 9860dac7fa [HIPIFY][tests] Add reverse engineered HIP sample hipEvent 2019-05-13 22:12:43 +03:00
Evgeny Mankov 4cf53fb09c Merge pull request #1101 from emankov/master
[HIPIFY][tests] Add reverse engineered HIP sample MatrixTranspose
2019-05-13 19:39:16 +03:00
emankov cdc76af186 [HIPIFY][tests] Add reverse engineered HIP sample MatrixTranspose 2019-05-13 19:37:18 +03:00
Jenkins b54dddb6e2 Merge 'master' into 'amd-master'
Change-Id: Ibca6232ef00edf0c11a5db5f6f10a5bcbb963625
2019-05-13 05:46:17 -04:00
Wen-Heng (Jack) Chung a4db991cbf Revert "HACK for SWDEV-173477" (#1004)
* Revert "HACK for SWDEV-173477"

This reverts commit cf7ad0f184.
2019-05-13 14:42:05 +05:30
Maneesh Gupta c9fdb42b91 Merge pull request #1083 from gargrahul/fix_hip_impl_visible_agents
Maintain HIP_VISIBLE_DEVICES for kernel launch
2019-05-13 14:20:18 +05:30
Rahul Garg e1f3dc0c80 Add fine grained host memory lock support (#1095)
* Add fine grained host memory lock support

* Fix default flag check
2019-05-13 11:48:26 +05:30
Nick Curtis fb92feae0e Markdown fixes & Whitespace cleanup for samples (#1096)
* Fix multiline code blocks in README's

* Whitespace cleanup
2019-05-12 19:27:44 +05:30
Maneesh Gupta 0cc7fe8a9f Merge pull request #1094 from mangupta/hit_improvements
[dtests] Add new tests to directed tests
2019-05-12 19:25:21 +05:30
Siu Chi Chan 05a1b696da migrate program_state logic from header into shared library (phase I) (#1077)
* Revert "Revert "Use COMgr to read Kernel Args Metadata (#1006)""

This reverts commit 235c6877c8.

* Revert "Use COMgr to read Kernel Args Metadata (#1006)"

This reverts commit 2c80975e9c.

* Revert "improve program state commentary"

This reverts commit f5e4fff6cc.

* Revert "load program state once per agent"

This reverts commit 2845b4c4b8.

* start moving function_names() into the hip shared lib

* start moving code_object_blobs to a new "state" object

* Consolidate various program state related static objects into a
single program_state object

* minor clean up

* move more stuffs from functional_grid_launch into program_state

* debug make_kernarg

* moving lookup for kernargs size_align into program_state

* clean up old code for kernarg size and alignment

* update hip_module to use newer api in program_state

* Create public member functions for program_state

* move most program state functions into shared library

* Pass the data buffer size to load_executable
Otherwise, it can't figure what the data size is
just from the char* (since the data is not really a string)

* turning free functions in program state into members of program_state_impl

* change the free function globals() into a member of program_state_impl

* replace the static mutex used for populating globals

* moving associate_code_object_symbols_with_host_allocation into
program_state_impl

* move load_code_object_and_freeze_executable into program_state_impl

* moving executables and functions_names into program_state_impl

* moving kernels() into program_state_impl

* moving functions() into program_state_impl

* move get_kernargs into program_state_impl

* moving kernel_descriptor into program_state_impl

* moving kernargs_size_align calculation into program_state_impl

* Changing the handle to program_state_impl to a pointer

* moving program_state_impl into a separate inline source file

* fixing/cleaning up some header file includes

* moving member function for kernargs_size_align into program_state.cpp

* moving Kernel_descriptor into program_state.inl

* add a new class to manage agent globals

* moving all agent globals processing functions into agent_globals_impl

* load program state once per agent

re-merging PR991 against other program state changes

* fix per-agent program state member initialization

* cache executables based on elf name, isa, and agent.

This avoids program state reloading executables after a shared library is dlopened.

re-merging PR1057 against other program state changes

* protect executables cache by a global mutex

* return ref to executables cache

* adapt PR#981 Make hipModuleGetGlobal be in HIP runtime
2019-05-12 19:24:03 +05:30
foreman f8d8559328 P4 to Git Change 1781540 by kpyzhov@hip-vdi-pal-win on 2019/05/10 17:10:30
SWDEV-188234 - Corrected reading binary module file in hipModuleLoad().

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#26 edit
2019-05-10 19:19:11 -04:00
foreman f46de1ed7e P4 to Git Change 1781384 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/05/10 14:00:04
SWDEV-189216 - Export `hipExtModuleLaunchKernel`

	RB: http://ocltc.amd.com/reviews/r/17332/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#16 edit
2019-05-10 15:50:37 -04:00
Jenkins f80450c366 Merge 'master' into 'amd-master'
Change-Id: I390e88de292d69072474b3ed1e5537d2477e9a0f
2019-05-10 11:30:25 -04:00
foreman ed092053e1 P4 to Git Change 1780704 by yaxunl@yaxunl-lc10 on 2019/05/09 13:26:13
SWDEV-145570 - Fix device name mismatch for gfx906.

	For now hip-clang can only emits gfx906 ISA with conservative configurations, i.e. with ecc on and xnack on, therefore it is always gfx906. It is still under discussion how to encode the target id for xnack off or ecc off.

	Therefore, the reasonable solution for now is just allow code object marked as gfx906 to be loaded on any device name that starts with gfx906. We will have more detailed control once hip-clang is able to emit code object for gfx906 with ecc off or xnack off.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#30 edit
2019-05-09 14:19:54 -04:00
Maneesh Gupta e78a09c041 Merge pull request #1084 from mhbliao/hliao/master/api_ext
[hip] Add API `hipExtModuleLaunchKernel` in HIP runtime
2019-05-09 18:26:31 +05:30
Maneesh Gupta 6e573ba430 [dtests] Fix hipModule test for nvcc path
Change-Id: If918b87b848a825242e06b0d552a7be188a1c4b6
2019-05-09 18:17:19 +05:30
Maneesh Gupta e95f7fc1f8 [dtests] Add complex_loading_behavior test
Change-Id: Iadf135cb727a1a3761abef20336d652b159c7dcd
2019-05-09 18:03:42 +05:30
Maneesh Gupta 4b38188e1e [dtests] Add hipModule test to unit tests
Change-Id: I1dac38f8580265e2e9c82d88e4f070a2ff87f60b
2019-05-09 11:36:46 +05:30
Maneesh Gupta dac20b7736 [hit] Add support for BUILD_CMD 2019-05-09 11:36:26 +05:30
Maneesh Gupta db52b0f60f [hit] Remove CUSTOM_CMD
Change-Id: Ia156fe6aab9cfcc11284823ea5131e33eaf962bc
2019-05-09 09:59:18 +05:30
Maneesh Gupta 53dd1df3fa [hit] Rename RUN -> TEST & RUN_NAMED -> TEST_NAMED
Change-Id: I75e24f15129973cee15fc9dac65d678bd2172074
2019-05-09 09:59:18 +05:30
Evgeny Mankov b6ff82a2e6 Merge pull request #1090 from emankov/master
[HIPIFY][python] Initial support of hipify-python generation from hipify-clang
2019-05-08 19:12:08 +03:00
Evgeny Mankov 0f4affde9c [HIPIFY][python] Initial support of hipify-python generation from hipify-clang
+ Only a generation of transformation map of CUDA entities is implemented.
+ 2 hipify-clang options are added: -python, -o-python-map-dir.
+ Explicitly set -roc option for cuda_to_hip_mappings.py generation.
+ Generated file already might be used by pytorch team.
2019-05-08 19:08:55 +03:00
Evgeny Mankov c7243ebdae Merge pull request #1089 from emankov/master
[HIPIFY][perl] Support of hipify-perl generation from hipify-clang: n…
2019-05-08 15:59:45 +03:00