* Enable Lintian Support for ROCM-SMI
* Enable Lintian Support for ROCMINFO
* Updated Lintian Override File Processing
* Update UT Fix for Lintian rocmsmi,rocminfo
* Update UT Fixes, Review Comments
* Update Review Comments - removed extra white spaces, added error check for gzip, date commands
* Update Review Comments - Correcting License Type
* Sync Lintian ChangeLog
* Changelog data sync enhanced
* Update Review Comments, UT fix
* white space cleanup - precommit check
Add an early check in WSL to detect when no supported GPU is available.
otherwise rocm_agent_enumerator will keep retrying rocminfo for one
minute, causing unnecessary delay.
Signed-off-by: Flora Cui <flora.cui@amd.com>
Co-authored-by: harkgill-amd <harkgill@amd.com>
Legal Requirements:
For AMD software being released as open source, add copyright at the top of each new file.
Signed-off-by: Alysa Liu <Alysa.Liu@amd.com>
This PR intends to cover the edge case seen in https://github.com/ROCm/rocm-systems/issues/694.
`hip-config-amd.cmake` uses rocm_agent_enumerator to determine which GPU architecture to target when no target is specified.
https://github.com/ROCm/rocm-systems/blob/9a02dae75f8df9d8f08923d34d06d76e96ced7b4/projects/clr/hipamd/hip-config-amd.cmake.in#L86-L95
On WSL, both `readFromKFD` and `readFromLSPCI` are skipped. If `readFromTargetLstFile()` isn't in use, `readFromROCMINFO()` is called on. If rocminfo times out, it prints the following message to stdout.
```
"Timeout querying rocminfo. Are you compiling with more than 254 threads?"
```
Because this is output and not an explicit error message, `execute_command` in the previous code blocks treats the output as `OUTPUT_VARIABLE` and passes it on as a valid gfx arch which causes these errors in CMake,
```
lang++: error: invalid target ID 'Timeout'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
clang++: error: invalid target ID 'querying'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
clang++: error: invalid target ID 'rocminfo.'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
clang++: error: invalid target ID 'Are'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
clang++: error: invalid target ID 'you'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
clang++: error: invalid target ID 'compiling'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
```
The output can be properly pushed to `ERROR_VARIABLE` if rocm_agent_enumerator pushes the output to stderr instead of stdout. This can be done with the changes to the print statement in this PR or using the `logging` module.
There are many reasons why there may already be a CMAKE_MODULE_PATH defined.
The idiomatic way to extend it in a project is via list(APPEND).
https://github.com/ROCm/rocminfo/pull/97 submitted by @stellaraccident
Co-authored-by: Stella Laurenzo <Stella.Laurenzo@amd.com>
[ROCm/rocminfo commit: 8503ec36ca]
Obey CMAKE_BUILD_TYPE when it is passed on the command line. Previous
behavior remains:
Debug by default
ROCRTST_BLD_TYPE can set build type
[ROCm/rocminfo commit: 0607268260]
Since wslinfo does not exist in docker running on wsl,
change the way to detect wsl environment.
Change-Id: I215eb985a227caeef47483cd51818c84bf1d8a4c
Signed-off-by: Longlong Yao <Longlong.Yao@amd.com>
[ROCm/rocminfo commit: 22ed708c39]
When amdgpu is built into the kernel, /sys/module/amdgpu/initstate will not be created even when the driver is functional. However, test shows /sys/module/amdgpu will be present. Adding an additional check for /sys/module/amdgpu when /sys/module/amdgpu/instate is not present.
Change-Id: Ie5c67c7e1eff8ac1683b211aaec802d0d342aeeb
[ROCm/rocminfo commit: c6f7a17c85]
Removing extra print that was added for backward compatibility.
Change-Id: I12a5346708886861a6e3cd6440830e6425e647d9
[ROCm/rocminfo commit: 9f6d7cdf6b]
kmod dependency is not at all required for rocminfo. Removing the same from the package dependency list
Change-Id: I58f9c4305585c5dd770ea3c6a6298c30c89c31b5
[ROCm/rocminfo commit: 63ff6a4b30]
CPACK is converting /usr/bin/env python3 to /usr/libexec/platform-python in RHEL8.
Undefining __brp_mangle_shebangs will prevent the same
Change-Id: I0803d0a6cc1ddc991e8e9a8e6617436930ef013a
[ROCm/rocminfo commit: aa8a83815e]
yugang-amd
arvindcheru
Mario Limonciello
Flora Cui
David Yat Sin
cfreeamd
Alysa Liu
harkgill-amd
Aaron Liu
Hila, Nino
Mallya, Ameya Keshava
lyndonli
Yat Sin, David
Khatri, Shweta
Su, Daniel
benrichard-amd
Choudhary, Rahul
Chris Freehill
Longlong Yao
Alex Xu
Ranjith Ramakrishnan
dependabot[bot]
amd-jmacaran
Roopa Malavally