AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6,075 Commits 3 Branches 0 Tags
d208afcb368b2ff6498bf3e99a4ecc75e5b8a5b2
Commit Graph

5361 Commits

Author SHA1 Message Date
Rahul Garg d9179cbe70 Fix typo and colon in comment 2019-09-13 03:09:01 +05:30
Rahul Garg 2e9b8e9d0d [HACK] Temporary fix for hipFree for hipManagedMalloc 2019-09-13 02:10:21 +05:30
foreman b0b5c92469 P4 to Git Change 1997621 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/12 14:16:09 
SWDEV-145570 - Fixed some logging issues regarding hip(Ext)ModuleLaunchXXX.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#40 edit
 2019-09-12 14:35:36 -04:00
Evgeny Mankov 4b3889b47e [HIPIFY] Add unsupported fp16 functions 2019-09-12 18:51:25 +03:00
Evgeny Mankov ece8a71bad [HIPIFY] Add more unsupported device functions 2019-09-12 17:53:25 +03:00
Evgeny Mankov 905c6383db [HIPIFY][#1404] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h 2019-09-11 18:07:09 +03:00
Evgeny Mankov ede7e2a094 Merge pull request #1406 from emankov/master 
[HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl)
 2019-09-11 15:49:46 +03:00
Evgeny Mankov 4e3845be83 [HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl) 
+ Enclose template instantiation kernel calls into round brackets, leave regular kernel names unchanged (hipify-perl doesn't handle cases with macros).
+ Fix corresponding tests.

PS. hipify-perl couldn't handle correctly the following cases due to macros expansion disability, thus hipify-clang should be used instead:

#define KERNEL_NAME_MACRO axpy<float>
#define KERNEL_CALL_MACRO axpy<float><<<1, 2>>>
#define KERNEL_ARG_LIST_MACRO a, x, y

// CUDA:
KERNEL_NAME_MACRO<<<1, 2>>>(KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-perl:
hipLaunchKernelGGL(KERNEL_NAME_MACRO, dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-clang:
hipLaunchKernelGGL((KERNEL_NAME_MACRO), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
hipLaunchKernelGGL((axpy<float>), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
 2019-09-10 15:59:06 +03:00
Aditya Lad 4a53718e10 Replacment of RENAME command in CMakeLists.txt (#1402) 2019-09-10 08:35:16 +00:00
foreman 15d819d61f P4 to Git Change 1995672 by skudchad@skudchad_rocm on 2019/09/09 14:45:42 
SWDEV-199293 - Fix build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#4 edit
 2019-09-09 14:50:37 -04:00
foreman f0f4755aae P4 to Git Change 1995665 by skudchad@skudchad_test2_win_opencl on 2019/09/09 14:36:57 
SWDEV-199293 - Implement hiprtcGetLoweredName

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17960/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#3 edit
 2019-09-09 14:42:47 -04:00
foreman 9a839c46dc P4 to Git Change 1994974 by skudchad@skudchad_test2_win_opencl on 2019/09/06 19:09:36 
SWDEV-199293 - Implement some hipRTC apis.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17953/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/build/Makefile.hip#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#2 edit
 2019-09-06 19:11:43 -04:00
Evgeny Mankov aec10d6ee1 [HIPIFY] Add device functions support 
+ Add a corresponding matcher cudaDeviceFuncCall to match only (__device__ or __global__) and not __host__ functions.
+ Add a corresponding device functions mapping:
  only unsupported are listed, cause supported are exactly the same as of CUDA and do not need transformation;
  make FindAndReplace for device functions separated from host API calls.
+ Add a test to distinguish device functions and user-defined.
 2019-09-06 18:34:12 +03:00
foreman 860615b64d P4 to Git Change 1994498 by skudchad@skudchad_test2_win_opencl on 2019/09/06 04:25:22 
SWDEV-202136 - Fix windows build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#26 edit
 2019-09-06 04:33:24 -04:00
foreman 0322bfd64f P4 to Git Change 1994199 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/09/05 16:35:36 
SWDEV-202136 - Fix typos in `hip_hcc.def.in`.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#25 edit
 2019-09-05 16:45:19 -04:00
foreman 53d56a3843 P4 to Git Change 1994120 by axie@axie-hip-pal on 2019/09/05 14:22:40 
SWDEV-201667 - Linker errors when using hipArrayCreate and hipMemcpyParam2D

	Tests:
	In Windows 10, the linker errors has been fixed with this code change.
	http://ocltc.amd.com:8111/viewModification.html?modId=125600&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17943/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#24 edit
 2019-09-05 14:34:47 -04:00
foreman 599f0b1c93 P4 to Git Change 1994119 by axie@axie-hip-pal on 2019/09/05 14:20:44 
SWDEV-197057 - [hipclang-vdi-rocm][func] 11_texture_driver test in hip samples fails.

	Tests:
	The sample code can be built without linkage error.
	http://ocltc.amd.com:8111/viewModification.html?modId=125598&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17942/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#25 edit
 2019-09-05 14:30:10 -04:00
foreman cd5c37bb4a P4 to Git Change 1994105 by skudchad@skudchad_rocm on 2019/09/05 13:59:26 
SWDEV-202136 - Export symbols for hiprtcVersion and hiprtcGetTypeName

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#24 edit
 2019-09-05 14:12:32 -04:00
Jeff Daily 3d7c146296 fix bug where HIP_DB=1 seg faults at startup (#1388) 2019-09-05 10:04:19 +00:00
mhbliao d511c3e363 [hip] Stop using noduplicate and replace it with convergent. (#1390) 2019-09-05 10:03:43 +00:00
Paul Fultz II d359cd4449 Use hcc when building with hcc compiler (#1225) 
* Use hcc when building with hcc compiler

* Fix misnamed variable

* Dont set HIP_RUNTIME
 2019-09-05 10:03:04 +00:00
Evgeny Mankov a847247d9a [HIPIFY][cmake][#1394] Fix 
[#1394] cmake's VERSION_GREATER_EQUAL introduced in 3.7
 2019-09-05 12:08:56 +03:00
Evgeny Mankov f114a79462 [HIPIFY][perl] Code cleanup (preparation for generating) 2019-09-05 11:52:59 +03:00
foreman 132d10a98a P4 to Git Change 1993529 by skudchad@skudchad_rocm on 2019/09/04 17:08:05 
SWDEV-199293 - Initial API checkin and sym export defines

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#22 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#1 add
 2019-09-04 17:16:03 -04:00
Evgeny Mankov 0ca6525d90 [HIPIFY][perl] Sync hipify-perl with hipify-clang 
Sync by means of semi-automatic generation: hipify-clang -perl
 2019-09-04 17:07:45 +03:00
Evgeny Mankov 7ab9afe513 [HIPIFY][perl] Code cleanup and formatting 2019-09-04 16:37:26 +03:00
Evgeny Mankov e26ec02a99 [HIPIFY][perl][#259] Fix 
empty<<<1, 2>>> ( );     >>  hipLaunchKernelGGL(empty, dim3(1), dim3(2), 0, 0);
empty<<<1, 2, 0>>>();    >>
empty<<<1, 2, 0, 0>>>(); >>

instead of erroneous:    >> hipLaunchKernelGGL((empty), dim3(1), dim3(2), 0, 0, );
 2019-09-03 16:44:20 +03:00
Yaxun (Sam) Liu e72346dc24 Do not include cuda wappers for OMP for hip-clang (#1382) 2019-09-03 05:13:59 +00:00
Rahul Garg d433f6fb58 Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381) 
This reverts commit 9bbd09b04f.
 2019-09-03 05:13:46 +00:00
Nicholas Malaya 796b8aafd7 Fix Broken Link in hip_porting_guide (#1376) 
The math library equivalents between CUDA-HIP are broken. This is a key feature for converting to AMD hardware. This fix corrects the broken link and moves the library equivalents to sit under the "Porting a New Cuda Project" header.
 2019-09-03 05:13:35 +00:00
Sarbojit2019 4d270775c8 Removed hipLaunchKernel macro got missed in Merge (#1374) 2019-09-03 05:13:07 +00:00
Evgeny Mankov d9b5e2f74a [HIPIFY][doc] Update README.md (testing, versions) 2019-09-02 18:18:43 +03:00
Evgeny Mankov 608331250e [HIPIFY][tests] Add occupancy test 2019-09-02 17:54:06 +03:00
Evgeny Mankov 8eb7d53cec [HIPIFY][fix] Fix for upcoming LLVM 10.0 2019-09-01 18:15:03 +03:00
Sameer Sahasrabuddhe 68c133bd78 remove obsolete test for OCKL Asynchronous Streams 
The implementation for OCKL AS was recently removed from the device
library since that feature is now superseded by hostcall.
 2019-08-30 20:41:29 +05:30
foreman 8ea92c83f0 P4 to Git Change 1991227 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/29 17:26:37 
SWDEV-193938 - [HIP] Use fine grained pool for hipHostRegister

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#69 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#40 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#43 edit
 2019-08-29 17:35:38 -04:00
Evgeny Mankov a0a98790f0 [HIPIFY][DNN] cuDNN 7.6.3 support 2019-08-29 19:55:38 +03:00
Evgeny Mankov 451721a821 Merge pull request #1372 from emankov/master 
[HIPIFY][#207][fix] Translate all preprocessor's conditional blocks
 2019-08-29 10:30:05 +03:00
Yaxun (Sam) Liu 793b18c0b1 Fix sample 11_texture_driver for hip-clang (#1370) 2019-08-29 01:03:20 +00:00
Yaxun (Sam) Liu 19a9b15306 Do not change opt level for -g for hip-clang (#1369) 
Currently hipcc uses -O3 for hip-clang by default but uses -O0 if -g is used. This
causes surprise for users since -g should not affect default opt level.
 2019-08-29 01:03:11 +00:00
Sarbojit2019 b5ff9e71ed Updated hipErrorString and CUDAErrorTohipError (#1365) 2019-08-29 01:02:59 +00:00
Sarbojit2019 1ae43cbeba [HIP] Reclaiming hipLaunchKernel API (#1353) 
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path
 2019-08-29 01:02:41 +00:00
satyanveshd d2df21e58c [sample] add new cookbook sample - occupancy (#1352) 
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments
 2019-08-29 01:01:49 +00:00
mshivama f74903851e Device side support for Cooperative Group feature (#1202) 
* first cut of the header implementation of cooperative group feature

* add diclarations for device library functions

* fixed various compile time issues in the CG headers

* enabled copy construction and copy assignment

* fixed a minor bug related to conditional compilation macro

* fixed few more CG constructor issues and added a unit testcase

* fixed typo

* extended unit testcase

* compute size of partitioned CG from mask

* bit of code refactoring

* removed boilerplate code

* fixed few of the review comments by Brian

* Changes to the sigantures of few grid and multi-grid related OCKL functions

* changes to declarations of OCKL functions related to CG feature

* removed all the block level support as it is not planned for 2.9

* Have taken care of review comments by Brian

* Have taken care of review comments by Brian

* removed unused functions which were initially intended to use in block level cg support
 2019-08-29 01:01:25 +00:00
Evgeny Mankov 32f22a0117 [HIPIFY][#207][fix] Translate all preprocessor's conditional blocks 
+ Start to translate preprocessor's false conditional blocks too:
  based on clang's https://reviews.llvm.org/D66597;
  available only starting from LLVM 10.0 or trunk.
+ Option -skip-excluded-preprocessor-conditional-blocks for skipping excluded conditional blocks:
  the default behavior for hipify-clang built with LLVM < 10.0;
  false by default for hipify-clang built with LLVM 10 or trunk.
+ Add 4 preprocessor unit tests, 2 of which are LLVM 10.0 only
+ Update couple of existing tests by setting -skip-excluded-preprocessor-conditional-blocks option:
  update lit testing accordingly
 2019-08-28 21:17:35 +03:00
Evgeny Mankov e3eb62ac4b [HIPIFY][cmake] Minor refactoring 
1. Fix setting std c++ (11|14)
2. Get rid of WIN32, use MSVC instead
3. Use VERSION_GREATER_EQUAL and VERSION_MAJOR instead of logical expressions
 2019-08-28 20:40:10 +03:00
foreman 534727cd01 P4 to Git Change 1990032 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/27 20:20:36 
SWDEV-145570 - [HIP] Add missing HIP_INIT_API macros and more debug printf.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#23 edit
 2019-08-27 20:26:25 -04:00
Maneesh Gupta b92c16f4d9 [packaging] update soft-links that already exist (#1364) 
Change-Id: Ibe9840802b1765094ef998edf2210e95404cb989
 2019-08-26 23:41:14 -04:00
foreman d0edeaf3cf P4 to Git Change 1989149 by kjayapra@0_HIPWS_P2P_ROCM on 2019/08/26 15:30:45 
SWDEV-188177 - Adding ihipTexture APIs to hip_hcc.def.in

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#21 edit
 2019-08-26 15:44:58 -04:00
foreman 441eefa78b P4 to Git Change 1989089 by kjayapra@0_HIPWS_P2P_ROCM on 2019/08/26 14:24:21 
SWDEV-198194 - Delete vars at __hipUnregisterFatBinary.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#38 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#40 edit
 2019-08-26 14:32:48 -04:00