Commit Graph

5361 Commits

Author SHA1 Message Date
Evgeny Mankov df9418c3cd [HIPIFY][fix][#204] Suppress warning message: #pragma once in main file 2019-04-24 20:35:52 +03:00
Evgeny Mankov 1049031d98 [HIPIFY][doc] Update README.md
+ A few words about clang patches to work with CUDA 9.2 - 10.0 on Windows;
+ Fix cuDNN versions with correct values.
2019-04-24 17:40:35 +03:00
Maneesh Gupta 7f81c72f1c Merge pull request #1043 from mhbliao/hliao/master/fp16
[hip] Fix including of hip_fp16.h
2019-04-24 16:50:46 +05:30
Maneesh Gupta 63ab2ea945 Merge pull request #1042 from mhbliao/hliao/master/ldg
[hip] Fix use of `__HIP_CLANG_ONLY__` in `hip_ldg.h`.
2019-04-24 16:50:37 +05:30
Maneesh Gupta 54cdeabe6e Merge pull request #1040 from eshcherb/roctracer-hip-frontend-190422
hip_prof_api.h include under __cplusplus
2019-04-24 16:50:27 +05:30
Maneesh Gupta 7edb43bc83 Merge pull request #1039 from gargrahul/fix_ptrgetattr_nvcc
Fix hipPointerGetAttributes for NVCC
2019-04-24 16:50:18 +05:30
Rahul Garg 94769fc8dd Add hipMallocManaged default functional support (#1036)
* Add hipMallocManaged default functional support

* Fix build error

* Add dtest
2019-04-24 16:50:03 +05:30
Maneesh Gupta 61861faddc Merge pull request #1034 from kpyzhov/master
Minor fixes for 64-bit device functions.
2019-04-24 16:49:36 +05:30
Maneesh Gupta 3ac21336eb Merge pull request #1031 from yxsamliu/fix-init
Fix missing arg in HIP_INIT_API
2019-04-24 16:49:23 +05:30
Maneesh Gupta 3ba7afcfc1 Merge pull request #1028 from gargrahul/fix_d2d_async_test
[dtest] Fix D2DAsync test
2019-04-24 16:49:13 +05:30
Aaron Enye Shi 6b3095f7cb Add COMGR relative path for build machines 2019-04-23 17:16:26 -04:00
Evgeny Mankov 87fa81f7be [HIPIFY][doc] Provide patches for clang's bug 38811
+ Update Readme.md accordingly
2019-04-23 21:13:00 +03:00
Evgeny Mankov 65dd1d4c7d [HIPIFY][hipify-perl] Formatting 2019-04-23 17:55:47 +03:00
Michael LIAO d086dbd0e5 [hip] Fix including of hip_fp16.h
- Separate the definition of `__HCC_OR_HIP_CLANG__`, `__HCC_ONLY__`, and
  `__HIP_CLANG_ONLY__` into hip_common.h so that it could be included in
  hip_fp16.h, which may be included separately in app.
2019-04-23 09:16:00 -04:00
Michael LIAO ca6a5c07eb [hip] Fix use of __HIP_CLANG_ONLY__ in hip_ldg.h.
- Check its value instead of whether it's defined or not.
2019-04-22 23:22:32 -04:00
Evgeny 165c42483b hip_prof_api.h include under __cplusplus 2019-04-22 21:14:18 -05:00
Rahul Garg c0e0f0b7fd Fix hipPointerGetAttributes for NVCC 2019-04-23 03:22:25 +05:30
foreman b07f3f0de7 P4 to Git Change 1772785 by cpaquot@cpaquot-ocl-lc-lnx on 2019/04/22 14:31:18
SWDEV-144570 - [HIP] Lazy build kernels to avoid overfilling dev memory.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#28 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#27 edit
2019-04-22 15:19:24 -04:00
foreman 02b4ec115b P4 to Git Change 1772349 by mshivama@mshivama_tf on 2019/04/20 07:35:24
SWDEV-187020 - Basic "Hello World" Tensorflow program fails to execute on HIP/VDI/PAL/LINUX

	Make sure that the size of `dest` is big enough to hoid `src` including trailing zero byte

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#19 edit
2019-04-21 21:50:04 -04:00
foreman 4538956a99 P4 to Git Change 1772193 by mshivama@mshivama_tf on 2019/04/19 09:39:39
SWDEV-187020 -  Basic "Hello World" Tensorflow program fails to execute on HIP/VDI/PAL/LINUX

	the API hiDeviceGetName() should pass the length of device name as argument to strncpy() instead
	of total (dest) memory size which is being passed to it by its caller. Also, bit of a code clean-up.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#18 edit
2019-04-19 09:49:37 -04:00
Konstantin Pyzhov f6fbf8751d Fix for __popcll() device function implementation. 2019-04-19 08:53:22 -04:00
Yaxun (Sam) Liu 710e633bdd Fix missing arg in HIP_INIT_API 2019-04-18 16:18:31 -04:00
Konstantin Pyzhov 5664ed3206 Fix for __ffsll() device functions. 2019-04-18 13:07:24 -04:00
foreman 8b60833e6e P4 to Git Change 1771752 by cpaquot@cpaquot-ocl-lc-lnx on 2019/04/18 11:54:18
SWDEV-145570 - [HIP] Use isAsync flag for async cases.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#54 edit
2019-04-18 12:15:25 -04:00
David Salinas 1237a0b691 Revert "append the ELF flags for sram-ecc and xnack to the target triple per code object"
This reverts commit 4d0dc45078.
2019-04-18 11:49:40 -04:00
Rahul Garg f1dc017167 Fix D2DAsync test 2019-04-18 07:35:06 +05:30
foreman 9f5001466a P4 to Git Change 1771336 by cpaquot@cpaquot-ocl-lc-lnx on 2019/04/17 18:19:42
SWDEV-145570 - [HIP] Use staging buffer to copy peer to peer.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#27 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#53 edit
2019-04-17 18:38:30 -04:00
Evgeny Mankov 95aca4f9a9 [HIPIFY][SPARSE] cuSPARSE 10.1 support 2019-04-16 14:59:44 +03:00
Evgeny Mankov bbcacd0146 [HIPIFY][BLAS] cuBLAS 10.1 support 2019-04-16 12:52:58 +03:00
Evgeny Mankov f5f1636181 Merge pull request #1023 from emankov/master
[HIPIFY][cuDNN] Add partial cudnnRNNBiasMode_t support
2019-04-16 11:03:22 +03:00
Evgeny Mankov 5fa84735a6 [HIPIFY][cuDNN] Add partial cudnnRNNBiasMode_t support 2019-04-16 11:01:01 +03:00
Maneesh Gupta 715a500b97 Merge pull request #995 from david-salinas/add_sram-ecc_and_xnack_flags_to_triple
Append the ELF flags for sram-ecc and xnack to the target triple per code object
2019-04-16 09:10:04 +05:30
Maneesh Gupta 22660bed74 Merge pull request #1019 from scchan/lazy_binding
minor workaround for lazy binding
2019-04-16 08:36:10 +05:30
Jeff Daily cf8fb43e6b In hipFree, synchronize owner of memory (#1018)
* In hipFree, if memory is associated with a device, synchronize that device's streams.

This changes the behavior from synchronizing the currently set TLS device.

* All devices sync in hipFree for _appId=-1 case.

* Revert "All devices sync in hipFree for _appId=-1 case."

This reverts commit 1efb34d6a8426661e45bc5f763422a1147aeac10.

* add HIP_SYNC_FREE env var
2019-04-16 08:35:55 +05:30
Mr-LiuSw 64bdf82265 add little changes in hip_runtime_api.h to work with c language (#1017)
* Update hip_runtime_api.h

when i try to use mpicc or gcc to compile a c language code which call some hip runtime api , error occured as
> /path/to/hcc_detail/hip_runtime_api.h:2268:33: error: unknown type name ‘hipFuncAttributes’; 
> hipFuncGetAttributes(hipFuncAttributes* attr, const void* func);
 
add ' struct ' for the first parameter of hipFuncGetAttributes will get ride of this problem.
2019-04-16 08:35:36 +05:30
Aaron Enye Shi 2c80975e9c Use COMgr to read Kernel Args Metadata (#1006)
* Add CMAKE dep to amd_comgr

* Use COMGR for read_kernarg_metadata in COV2

* Do not assume kernargs exist

* Add proper metadata destroy cleanup

* Use a process function for easier destroy

* Remove old read_kernarg_metadata

* Clean up HCC, prints, names

* Use COMGR in CMAKE by default

* Move metadata lookup for keyword values into helper

* Remove C string usage for lookup_keyword_value

* Guard COMGR for non-NVCC path

* Add hip_hcc dependency on comgr package

* Add lifetime to metadata nodes

* Find COMGR config file for amd_comgr target

* Move set_active data earlier
2019-04-16 08:34:39 +05:30
Evgeny Mankov 64f0f29111 [HIPIFY] cuDNN 7.5.0.56 support 2019-04-15 15:46:46 +03:00
Maneesh Gupta 72e17e3c92 [ci] Enable tests on ROCm 2.3
Change-Id: Id344ef600b0868f36f2e7ac08d5664234d88835b
2019-04-15 12:38:01 +05:30
Yaxun (Sam) Liu e200ece4da hip-clang: Add __align__
CUDA has __align__. Define eqivalent for hip-clang.
2019-04-10 14:17:18 -04:00
Evgeny Mankov b11bf48270 [HIPIFY] CUDA 10.1 Runtime API support 2019-04-10 18:41:36 +03:00
Evgeny Mankov 9a660c0d48 [HIPIFY] CUDA 10.1 Driver API support 2019-04-10 15:03:34 +03:00
Maneesh Gupta 75691ff3e4 Merge pull request #1013 from yxsamliu/config
Fix hip-config.cmake for hip-clang
2019-04-10 07:53:22 +00:00
Yaxun (Sam) Liu 419eeb4fe0 hip-clang: fix hipcc options
Use -O3 for default optimization level.
Fix --hip-device-lib-path for warnings about unused option.
2019-04-09 22:31:13 -04:00
Yaxun (Sam) Liu a781d2e017 Fix hip-config.cmake for hip-clang
Define HIP_COMPILER and HIP_RUNTIME in hip-config.cmake to
facilitate other packages identify hip-clang and HIP/VDI
runtime.
2019-04-09 16:41:01 -04:00
Yaxun (Sam) Liu 98642129cc hip-clang: add include path for hsa headers 2019-04-09 15:01:50 -04:00
Maneesh Gupta aa8f17193e Merge pull request #1010 from ROCm-Developer-Tools/mangupta-patch-1
[ci] Disable hipLaunchParm.tst for now
2019-04-09 03:19:56 +00:00
foreman 9b36b245c9 P4 to Git Change 1766904 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/04/08 14:42:29
SWDEV-145570 - Check host_context when matching GPU device.

	- In CL#1766264, `host_context` is introduced for mGPU support. Need to
	  match that context specially when trying to match GPU device context.

	The following tests passed:
	$ python test_dataloader.py TestDictDataLoader.test_pin_memory
	.
	----------------------------------------------------------------------
	Ran 1 test in 0.004s

	OK
	$ python test_dataloader.py TestDataLoader.test_sequential_pin_memory
	.
	----------------------------------------------------------------------
	Ran 1 test in 0.063s

	OK
	$ python test_dataloader.py TestDataLoader.test_shuffle_pin_memory
	.
	----------------------------------------------------------------------
	Ran 1 test in 0.174s

	OK
	$ python test_dataloader.py TestStringDataLoader.test_shuffle_pin_memory
	.
	----------------------------------------------------------------------
	Ran 1 test in 0.104s

	OK
	$ python test_torch.py TestTorch.test_pin_memory
	.
	----------------------------------------------------------------------
	Ran 1 test in 0.124s

	OK

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#52 edit
2019-04-08 15:23:35 -04:00
Evgeny Mankov 79e6bd8426 [HIPIFY][cmake][doc] Update CMakeLists and Readme cause CUDA 10.1 and clang 8.0.0 are released
+ Fix the error in cmake: clang 8.0.0 supports CUDA 10.0, not 10.1; only trunk clang 9.0.0 supports CUDA 10.1.
+ Update Readme:
  1. clang's bug 36384 is gone, so latest stable release for Linux is clang 8.0.0, which supports CUDA up to 10.0;
  2. update dependencies, testing and building notes.
2019-04-08 20:05:21 +03:00
Maneesh Gupta 27013c9af6 [ci] Disable hipLaunchParm.tst for now
Due to a HCC bug in rocm-head, the test fails to compile. Disabling the test until the issue is resolved.

Change-Id: Ib4e7baf0b9c2cb5f5dbe38e6dd2bab894d28886a
2019-04-08 16:14:25 +05:30
Yaxun (Sam) Liu 5c67ee11f4 Fix regression on multi-gpu due to PR#997 2019-04-05 22:54:41 -04:00