Commit Graph

16 Commits

Author SHA1 Message Date
Mark Searles aa7ce2ef44 Add keyword 'explicit' to avoid ambiguity
Older gcc, e.g., 5.x, see an ambiguity in some calls. Example error
output as seen with gcc 5.5:

In file included from benchmark_wino.cpp:1:
In file included from ./miopen.hpp:13:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/regex:38:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/algorithm:62:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/stl_algo.h:66:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/random:51:
/usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/random.tcc:1324:27: error: call to 'abs' is ambiguous
                    const double __y = -std::abs(__n) * __param._M_sm - 1;
                                        ^~~~~~~~
/opt/rocm/hip/include/hip/hcc_detail/hip_complex.h:345:31: note: candidate function
__DEFINE_HIP_COMPLEX_REAL_FUN(abs, hipCabs)
2018-08-31 11:10:58 -07:00
Mark Searles f0183dfaac Add keyword 'explicit' to avoid ambiguity
Older gcc, e.g., 5.x, see an ambiguity in some calls. Example error
output as seen with gcc 5.5:

In file included from benchmark_wino.cpp:1:
In file included from ./miopen.hpp:13:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/regex:38:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/algorithm:62:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/stl_algo.h:66:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/random:51:
/usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/random.tcc:1324:27: error: call to 'abs' is ambiguous
                    const double __y = -std::abs(__n) * __param._M_sm - 1;
                                        ^~~~~~~~
/opt/rocm/hip/include/hip/hcc_detail/hip_complex.h:345:31: note: candidate function
__DEFINE_HIP_COMPLEX_REAL_FUN(abs, hipCabs)
2018-08-31 10:36:05 -07:00
Yaxun (Sam) Liu 84da72dae8 Add conj, operator-,==,!= for hipFloatComplex/hipDoubleComplex 2018-06-19 10:49:59 -04:00
Yaxun (Sam) Liu 9181fbb0b7 Add abs/real/imag functions for hipFloatComplex/hipDoubleComplex 2018-06-18 11:57:57 -04:00
Yaxun (Sam) Liu 7a5605d006 Add missing __device__ __host__ to complex constructor
Also add missing typedef value_type
2018-06-17 20:20:32 -04:00
Yaxun (Sam) Liu 2523c39a37 Includes <cmath> or <math.h> by __cplusplus in hip_complex.h 2018-06-17 20:20:32 -04:00
Yaxun (Sam) Liu 325cf3ccf0 Include cmath instead of math.h in hip_complex.h 2018-06-17 20:20:32 -04:00
Yaxun (Sam) Liu 5eeb57b0a6 Add missing macro MAKE_COMPONENT_CONSTRUCTOR_TWO_COMPONENT to hip_complex.h 2018-06-17 20:20:32 -04:00
Maneesh Gupta 1ba06f63c4 Apply .clangformat to all repo source files
Change-Id: I7e79c6058f0303f9a98911e3b7dd2e8596079344
2018-03-12 11:29:03 +05:30
Maneesh Gupta f65574422f Merge branch 'amd-develop' into amd-master
Change-Id: I05572d2b32f1df70b54e2efeb32c8a4d8055912d
(cherry picked from commit 3a56e5c09b)
2017-04-13 03:36:11 -05:00
Maneesh Gupta bb8c51a129 Merge branch 'amd-develop' into amd-master
Change-Id: I53d5a8916d769c4f0fe60d2ee3b240551da80b4f
(cherry picked from commit 01c523f6c9)
2017-04-07 11:10:59 -05:00
Aditya Atluri e0133e627d fixed header names
Change-Id: I21650d6398187d3767b28e8ac81b2642d3b89a0e
2017-03-31 12:18:55 -05:00
pensun 7488d8c7fa add inline to all hip_complex operators
Change-Id: Ifba5966c297cbc9299c39ecfc45c7296003ebb5d
2017-03-08 14:06:13 -06:00
Aditya Atluri 6ca2b289a2 added operator overloading for complex data types
Change-Id: Id96d5d000651914169f04497af6ff78ad96d846a
2017-01-19 15:15:25 -06:00
Aditya Atluri e2318cda74 changed data type used for complex
Change-Id: I0a3bb281af3d5ac1290207821c7c45aea40f513f
2017-01-11 18:23:37 -06:00
Maneesh Gupta 2df7159ad7 Rename hipComplex.h -> hip_complex.h
Change-Id: I86af4ddccc6ebb19606156b459e3065d2c979108
2016-10-16 11:02:36 +05:30