Vladislav Sytchenko
d2be30f0e0
Reduce the amount of free host memory to 40% of what is reported on Windows, otherwise we can run into OOM situations.
...
[ROCm/clr commit: 282367ed6d ]
2019-12-11 20:21:12 -05:00
Rahul Garg
48faf7423a
Revert - Changes related to hipMemcpyWithStream ( #1718 )
...
Reverting #1673 , #1697 and #1707 .
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.
[ROCm/clr commit: a369bd4418 ]
2019-12-06 09:51:53 +05:30
Rahul Garg
6c7a338471
Fix hipMemcpyWithStream ( #1707 )
...
* Fix hipMemcpyWithStream
* Add a dtest for the same.
[ROCm/clr commit: 261a04580f ]
2019-12-04 11:56:23 +05:30
Rahul Garg
9c599a3581
[dtest] Fix hipMemset2D test ( #1579 )
...
Reverts changes made in #1399 . This is a RT api test. For testing hipMemAllocPitch , a new test should be written and that should use correct memset API.
[ROCm/clr commit: 66a3c874c8 ]
2019-10-25 15:44:05 +05:30
Vladislav Sytchenko
54eddfc8f0
_aligned_malloc() on Windows first takes size, then alignment, which is the opposite of how the similar function behaves on Linux. Memory allocated by it also has to be freed using _aligned_free(), unlike Linux where we can use regular free().
...
Edit aligned_alloc() macro and add a aligned_free() one to align with the above behaviour.
[ROCm/clr commit: f4440817cb ]
2019-10-17 18:58:32 -04:00
Vladislav Sytchenko
577bac5de8
hipMemset2D and hipMemset3D tests should be passing by default.
...
[ROCm/clr commit: 86d0c5fa5a ]
2019-10-16 11:02:38 -04:00
Vladislav Sytchenko
2bc49fb55c
In the hipMemset2D and hipMemset3D tests synchronize with the default stream after performing an async memset.
...
[ROCm/clr commit: cc5abec092 ]
2019-10-15 17:15:49 -04:00
Vladislav Sytchenko
91ceb7dd2b
Update indentation in the hipMemset3D test. Replace all tabs with four spaces.
...
[ROCm/clr commit: f402b6d01a ]
2019-10-15 15:29:14 -04:00
Vladislav Sytchenko
d20c5251b1
Add async subtest to hipMemSet3D
...
[ROCm/clr commit: c83b6adb33 ]
2019-10-15 14:24:04 -04:00
Vladislav Sytchenko
e6f426dee3
hipMemset2D test should pass only if both async and sync subtests pass.
...
[ROCm/clr commit: 39e42d4056 ]
2019-10-15 14:20:14 -04:00
ansurya
0abb25a2fe
Fix for directed tests failure ( #1511 )
...
directed_tests/runtimeApi/module/hipLaunchCooperativeKernel.tst - Disabling test temporarily until driver support is available.
directed_tests/runtimeApi/memory/hipArray.tst - Disabling test temporarily to reimplement it correctly.
[ROCm/clr commit: 9bb22c4e0f ]
2019-10-10 19:58:41 +05:30
ansurya
efc64a4f8a
Added new Memory API's ( #1399 )
...
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.
[ROCm/clr commit: 96890792b0 ]
2019-10-04 13:36:31 +05:30
AlexBinXie
cc921b35be
[hip]Skip test when hipHostMallocCoherent is not supported by implementation ( #1380 )
...
[ROCm/clr commit: 313726a457 ]
2019-09-16 08:31:43 +00:00
Rahul Garg
a160d3ee2e
[dtests] refactor windows specific changes ( #1313 )
...
* [dtests] refactor windows specific changes
* Refactor hipMemoryAllocateCoherentDriver - PR- 1309
* Fix missing z in _putenv_s
* Revert "Fix missing z in _putenv_s"
This reverts commit 099a1b20a5c75c5f122d57c0ad2bca01745cdc9c.
* Refactor changes from PR 1299
* Update hipEnvVarDriver.cpp
[ROCm/clr commit: c741ad3c80 ]
2019-08-16 02:13:00 +00:00
amd-lthakur
079ed286ba
[dtests] Fix build issues with hipMemoryAllocateCoherentDriver.cpp on windows ( #1309 )
...
Compilation error being observed due to popen(), pclose() and setenv() linux calls on windows. Replaced with appropriate calls on windows.
[ROCm/clr commit: 19ad365834 ]
2019-08-09 11:53:16 +00:00
amd-lthakur
7879220c48
[dtests] Fix build issue with hipMemcpy_simple.cpp on windows ( #1306 )
...
Compilation error being observed on windows due to aligned_alloc() call. Mapped the call to _aligned_malloc() for windows.
[ROCm/clr commit: 93f5940ef8 ]
2019-08-09 11:52:46 +00:00
Aaron Enye Shi
99ca4c2483
Fix hipMemcpy-size test running out of Host Mem ( #1224 )
...
* Fix hipMemcpy-size test running out of Host Mem
The hipMemcpy-size uses a maxElem calculated from the total GPU mem /8. Then it will allocate 4 times that amount of host memory. This tests begins failing when there is not enough host memory, such as on systems with 32GB GPU mem, and 16GB RAM. This fixes the test if not enough host memory is available on the system.
* Add windows support to hipMemcpy-size fix
* avoid linking extra libs for windows
* HIPMemcpy-size Remove freeCPU including swap
[ROCm/clr commit: c56876cc19 ]
2019-07-24 07:49:20 +00:00
Maneesh Gupta
74110bbd43
[hit] Rename RUN -> TEST & RUN_NAMED -> TEST_NAMED
...
Change-Id: I75e24f15129973cee15fc9dac65d678bd2172074
[ROCm/clr commit: 53dd1df3fa ]
2019-05-09 09:59:18 +05:30
Rahul Garg
d69edbbb7f
Add hipMallocManaged default functional support ( #1036 )
...
* Add hipMallocManaged default functional support
* Fix build error
* Add dtest
[ROCm/clr commit: 94769fc8dd ]
2019-04-24 16:50:03 +05:30
Rahul Garg
c6dd7c9678
Fix D2DAsync test
...
[ROCm/clr commit: f1dc017167 ]
2019-04-18 07:35:06 +05:30
Maneesh Gupta
5c939d7f27
Update hipMemset.cpp
...
Address build issues on nvcc path.
[ROCm/clr commit: 8af4e2b5e4 ]
2019-03-05 12:11:11 +05:30
Wen-Heng (Jack) Chung
21cf5b0ae4
Add direct test for hipMemsetD32 and hipMemsetD32Async
...
[ROCm/clr commit: 365d08535b ]
2019-03-04 17:20:32 +00:00
Rahul Garg
b3ba23ba81
Fix review comments
...
[ROCm/clr commit: 5900416629 ]
2019-03-02 23:38:37 +05:30
Rahul Garg
e6f5850ebb
Fix hipMemset test for HIP/NVCC
...
[ROCm/clr commit: 41afe4d947 ]
2019-03-01 03:46:57 +05:30
Rahul Garg
1a97c0fafc
Update hipMemset test
...
[ROCm/clr commit: 0156388a6b ]
2019-02-28 06:54:49 +05:30
Rahul Garg
489f3ef7ba
Remove redundant arguments from hipMemset3D test
...
[ROCm/clr commit: 10d2a9a269 ]
2018-12-20 06:51:22 +05:30
Maneesh Gupta
50e89b0a30
Replace hipLaunchKernel -> hipLaunchKernelGGL
...
Change-Id: I4d99009e1199811d417becf1e1b934ec4d4e30be
[ROCm/clr commit: e1fe095471 ]
2018-10-17 14:32:25 +05:30
saleelk
bc49031828
Fix hipHostRegister mem leak and copy kind in hipMemcpyAsync ( #587 )
...
[ROCm/clr commit: e8a5ad629f ]
2018-07-23 11:04:14 +05:30
Rahul Garg
f25b05c793
Cleaned up hipMemset3D test
...
[ROCm/clr commit: 7261799835 ]
2018-07-06 14:54:08 +05:30
Rahul Garg
a7be5be448
Added hipMemset3D
...
[ROCm/clr commit: 78568435da ]
2018-05-07 10:24:30 +05:30
Rahul Garg
39a19cc9e8
Added hipMemset2DAsync support
...
[ROCm/clr commit: fcc0866681 ]
2018-04-17 18:27:27 +05:30
Maneesh Gupta
46ddefedee
Apply .clangformat to all repo source files
...
Change-Id: I7e79c6058f0303f9a98911e3b7dd2e8596079344
[ROCm/clr commit: 9e47fccc89 ]
2018-03-12 11:29:03 +05:30
Phaneendr-kumar Lanka
4571ec12ac
[nvccTests] Resubmit hipMemcpyDtoD & inline_asm_vadd
...
[ROCm/clr commit: 89bedb74e7 ]
2017-12-18 14:46:19 +05:30
Phaneendr-kumar Lanka
033e2cde33
[nvccWarnings] Fix warnings seen with dtests on nvcc path
...
[ROCm/clr commit: 0ac125e3db ]
2017-12-14 14:10:37 +05:30
Alex Voicu
a27fa25d76
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit 1cd6416
[ROCm/clr commit: 4966518846 ]
2017-11-29 21:49:10 +00:00
Alex Voicu
a1d5f0ab0c
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit d2fd1f5
[ROCm/clr commit: 2557000b56 ]
2017-11-29 21:36:29 +00:00
Alex Voicu
9cf73ef515
Re-sync with upstream.
...
[ROCm/clr commit: 30d90dab38 ]
2017-11-20 15:34:50 +00:00
Ben Sander
80021d3c68
Merge branch 'feature_natural_indexing' of https://github.com/AlexVlx/HIP
...
[ROCm/clr commit: a43262e699 ]
2017-11-19 15:25:17 -06:00
Ben Sander
6b1fb439f6
Temporarily disable P2P on nvidia (fails on dual GPU)
...
[ROCm/clr commit: fc34fd6f03 ]
2017-11-19 15:21:37 -06:00
Alex Voicu
af0ae5421c
This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
...
[ROCm/clr commit: 0cc921f103 ]
2017-11-19 01:54:12 +00:00
Alex Voicu
d7898eeef0
Update new tests so as to make them work with new variadic based launch mechanisms.
...
[ROCm/clr commit: 8c62d0fbc4 ]
2017-11-10 00:14:34 +00:00
Alex Voicu
12f00d4881
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# tests/src/runtimeApi/stream/hipStreamSync2.cpp
[ROCm/clr commit: f7919a8321 ]
2017-11-08 10:26:30 +00:00
Alex Voicu
142213a52b
Clean up trailing whitespace so as to reduce noise in #246 .
...
[ROCm/clr commit: 0ad1308efd ]
2017-11-08 00:08:55 +00:00
Phaneendr-kumar Lanka
b36eb26ef0
Modified tests as per review
...
[ROCm/clr commit: e18f4239b6 ]
2017-11-06 15:13:36 +05:30
Phaneendr-kumar Lanka
700890e19a
More tests for memory,stream & error APIs
...
[ROCm/clr commit: 7427abba04 ]
2017-11-06 11:31:52 +05:30
Alex Voicu
b738633bcb
This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.
...
[ROCm/clr commit: 28f87f7d2e ]
2017-11-01 15:09:59 +00:00
Ben Sander
4593effbe8
Clean up test to address review feedback.
...
[ROCm/clr commit: cc2bcbcbcf ]
2017-10-25 16:08:16 -05:00
Ben Sander
6dde6de34c
Test cleanup.
...
[ROCm/clr commit: c4612f3dc9 ]
2017-10-07 07:54:10 -07:00
Rahul Garg
b32cf1b3e8
Disable failing test p2p_copy_coherency
...
[ROCm/clr commit: f916a7654e ]
2017-08-02 14:47:13 +05:30
Ben Sander
f1bed37a34
Clean up old USE_* and RELEASE.md notes.
...
[ROCm/clr commit: 42882ddf9c ]
2017-06-23 18:05:30 -05:00