Γράφημα Υποβολών

605 Υποβολές

Συγγραφέας SHA1 Μήνυμα Ημερομηνία
Elwazir, Ammar d2c7312442 Fixing Clang tidy errors (#195)
* Fixing Clang tidy errors

* format-fix

* Update code_object.hpp

* Clang Tidy Fixes on the whole Source folder

* Update source/CMakeLists.txt

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Addressing reviews

* Correcting the logic for parsing att counters

* Format Fix

* Update source/lib/rocprofiler-sdk-att/tests/dummy_decoder.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk-att/tests/standalone_tool_main.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk-tool/config.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Formatting

* Deactivate clang-tidy in source/lib/rocprofiler-sdk-att/tests

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 5410fabd3d]
2025-02-07 22:33:32 -06:00
Elwazir, Ammar 941fd54dfc Temp: Disable Navi3/4 from CI (#196)
Update continuous_integration.yml

[ROCm/rocprofiler-sdk commit: 835e466b65]
2025-02-07 15:21:14 -06:00
Bhardwaj, Gopesh e228ea8485 SWDEV-510794 Adding MPI usage with rocprofv3 (#183)
* swdev-510794 Adding MPI usage with rocprofv3

* update doc

* Fixed build issues

* updating doc

* doc update

* Fixed Typos

* csv format

* change format to shell

[ROCm/rocprofiler-sdk commit: 7821657d65]
2025-02-07 12:01:31 +05:30
Madsen, Jonathan e677801859 Undefined behavior warnings caught by ROCPROFILER_DEFAULT_FAIL_REGEX (#23)
* Add regex for undefined behavior to ROCPROFILER_DEFAULT_FAIL_REGEX

- add UBSAN_OPTIONS to setup-sanitizer-env.sh

* Improve ROCPROFILER_DEFAULT_FAIL_REGEX

* Use -fno-sanitize-recover=undefined flag

- this compiler flag causes all undefined behavior errors to exit

* Revert ROCPROFILER_DEFAULT_FAIL_REGEX

* fix for shift overflow

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
Co-authored-by: Manjunath-Jakaraddi <manjunath.jakaraddi@amd.com>

[ROCm/rocprofiler-sdk commit: e743bf5a93]
2025-02-06 08:55:57 -06:00
Welton, Benjamin 6bd6bb1aec Add example for synchronous reading of device counters (#64)
* Add example for synchronous reading of device counters

We already have test cases for this use case but this a sample
such that our collaborators can have a place to quickly pull
code from for use on their end (and to serve as a working example).

* Formatting fix

* Formatting fix

* Minor change for testing

---------

Co-authored-by: Benjamin Welton <ben@amd.com>

[ROCm/rocprofiler-sdk commit: 6c396adf83]
2025-02-06 08:35:55 -06:00
Madsen, Jonathan b610b5ff56 SDK: No bg thread if no clients use SDK (#123)
* SDK: No bg thread if no clients use SDK

* Update CHANGELOG

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 0fbe6cc7b6]
2025-02-06 08:34:56 -06:00
U, Srihari 908862e45e Initialize extremes to max and min values (#184)
* Initialize extremes to max and min values

* Address review comment

* Adding clang format

[ROCm/rocprofiler-sdk commit: 90ae424c57]
2025-02-06 08:32:37 -06:00
Nagaraj, Sriraksha 4390642c8e remove duplication (#190)
[ROCm/rocprofiler-sdk commit: 03e5a1d9cc]
2025-02-06 08:31:53 -06:00
Elwazir, Ammar 8f99bed27d 6.4 fixes for HSA and HIP (#191)
* Adding support for hsa_amd_signal_wait_all

* Fixes for HIP

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>

[ROCm/rocprofiler-sdk commit: 02a519e84e]
2025-02-06 07:56:08 -06:00
Bhardwaj, Gopesh a8a82d7263 Adding ROCTx usage doc (#159)
* Adding Roctx usage doc

* updated CHANGELOG

* dpc update

* Fixing Related Pages issue

* updating doc

* updating docs

* Adding Resource naming section

* Fixed Formatting

* format fix

* format fix

* Fixing build due to incorrect indentation

[ROCm/rocprofiler-sdk commit: 12508b9521]
2025-02-05 11:04:24 -06:00
Jakaraddi, Manjunath 87fe3387c5 SWDEV-506317: Kernel trace failing due to Code object errors (#170)
SWDEV-506317: Kernel trace failing

[ROCm/rocprofiler-sdk commit: 9c89b475b0]
2025-02-04 18:01:42 -06:00
Elwazir, Ammar 906b8b507a Support new HIP APIs (#179)
* Adding New HIP APIs

* Format Fix

* Format Fix

* Removing changes from ostream and moving it to format

* Addressing Code Review Comments

* Versioning the new hip calls formatting

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>

[ROCm/rocprofiler-sdk commit: dd5c0ea257]
2025-02-04 15:50:18 -06:00
Elwazir, Ammar 08247a9056 Tests: Scratch memory validate bug, summary validate bug (#187)
Scratch memory validate bug, summary validate bug

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>

[ROCm/rocprofiler-sdk commit: b9ad800194]
2025-02-04 12:48:28 -06:00
Welton, Benjamin f615e85f71 [SWDEV-509876] Remove buffer requirement from device counting service (#132)
* [SWDEV-509876] Remove buffer requirement from device counting service

No longer require a buffer to be given when setting up device counting
service. This is to reduce performance overhead in cases where immediate
return of counting samples is being used (synchronous mode).

* Missed file

* Update source/include/rocprofiler-sdk/device_counting_service.h

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk/counters/controller.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk/counters/device_counting.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Fixes for build

---------

Co-authored-by: Benjamin Welton <ben@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
Co-authored-by: Benjamin Welton <bewelton@amd.com>

[ROCm/rocprofiler-sdk commit: 0c4a56c6bb]
2025-02-04 06:06:03 -06:00
Nagaraj, Sriraksha 4282aa31d9 Adding att v3 support (#84)
* Adding att v3 support

* misc fix

* bug fix

* Python linting workflow and rules

* fix regex

* Adding temporary args

* fix temporary args

* fix format

* remove att_perfcounters from test input

* Review comments (#163)

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>

* Revert "Review comments (#163)"

This reverts commit 9ef0f8e5a4489d5581255e1b70ced2aef5c1c1d0.

* Address review comments 2

* review changes

* review comments

* review

* cmake alias

* review

* review

* review

* review

* Enabling percounter in v3 script

* review

* formatting

* formatting

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
Co-authored-by: Baraldi, Giovanni <Giovanni.Baraldi@amd.com>
Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>

[ROCm/rocprofiler-sdk commit: d4a51e4102]
2025-02-04 04:05:38 -06:00
Madsen, Jonathan 6c773a7616 Fix HSA_AMD_MEMORY_POOL_EXECUTABLE_FLAG for ROCm < 6.3 (#178)
Fix HSA_AMD_MEMORY_POOL_EXECUTABLE_FLAG for ROCm < 6.4

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 72a27feb04]
2025-02-04 04:05:19 -06:00
Madsen, Jonathan 6cb0dda8ba Fix async memory copy validation tests (#182)
* Fix async copy validation test

- make the async copy tracing test work regardless of however many HSA memory copies the HIP memory copy decomposes into

* Fix rocprofv3 memory copy tests

* Fix compilation support for hipGraphBatchMemOpNodeGetParams

* Fix rocprofv3-test-summary-*-validate

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 7fcd80f744]
2025-02-04 02:41:19 -06:00
Madsen, Jonathan 8c9185d725 Update HIP string formatting for ROCm 6.4.0 (#144)
Fix HIP data type stringify

- when ROCPROFILER_CI is not defined, provide default for case statements
- Add support for hipGraphNodeTypeBatchMemOp when HIP version is >= 6.4.0

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: f3752faa0a]
2025-01-30 20:51:52 -06:00
Kandula, Venkateshwar reddy aaad37dec1 add gfx12 for counter collection tests (#108)
* add gfx12 for counter def.

* Update continuous_integration.yml

* Update counter_defs.yaml

* commenting logging.

* Update ioctl.cpp

* add gfx12 to tests

* Update ioctl.cpp

* Add description to GFX12 GL2C_EA_RDREQ counter

* Updates from editor

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
Co-authored-by: Kuricheti, Mythreya <Mythreya.Kuricheti@amd.com>

[ROCm/rocprofiler-sdk commit: 121901c321]
2025-01-30 15:16:48 -06:00
Madsen, Jonathan 0a735d1684 Partial fix of legacy rocprofiler project name (#110)
* Partial fix of legacy rocprofiler project name

* Formatting fix

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 1f49d6c57b]
2025-01-30 13:43:35 -06:00
Kuricheti, Mythreya 5dbb3b2f80 Fix navi48 counter event IDs (#158)
* Initial fix for navi48 counters

* Add GL2C navi4x gfx12 counters

[ROCm/rocprofiler-sdk commit: d43070bf08]
2025-01-30 13:40:25 -06:00
Elwazir, Ammar c5b75976c6 SLES Git Safe Directory (#177)
* Update continuous_integration.yml

* Updates from editor

[ROCm/rocprofiler-sdk commit: acab62706b]
2025-01-30 12:32:58 -06:00
Kuricheti, Mythreya 33a480d38e Generate code coverage comment as collapsible summary (#169)
* Generate codecoverage comment as collapsible summary

* Tweak markdown formatting

[ROCm/rocprofiler-sdk commit: 58ecbd83a9]
2025-01-30 12:04:07 -06:00
Baraldi, Giovanni a8f4499f30 Fix for ATT context stop while packets are being processed (#171)
Fix for context stop while packets are being processed

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>

[ROCm/rocprofiler-sdk commit: 39db6d842f]
2025-01-29 11:06:32 -08:00
Mallya, Ameya Keshava daeb310fd9 Added !verify trigger
[ROCm/rocprofiler-sdk commit: 35f8374e35]
2025-01-28 20:07:15 -08:00
Welton, Benjamin 3abb3be245 [SWDEV-482060] Set execute permission for HSA allocated memory (#151)
We need execute permission for HSA memory (req for IB buffers).
Enforcement is upcoming which will break counter collection (see
ticket).

Co-authored-by: Benjamin Welton <bewelton@amd.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>

[ROCm/rocprofiler-sdk commit: 0d701cdaac]
2025-01-28 16:46:22 -08:00
Elwazir, Ammar d0e630cd03 Adding Navi4 excluded tests (#161)
Update continuous_integration.yml

[ROCm/rocprofiler-sdk commit: 689b26143d]
2025-01-28 11:18:02 -06:00
Indic, Vladimir 9f7772d90b Temporarily allow only host-trap sampling (#156)
[ROCm/rocprofiler-sdk commit: e4d736839d]
2025-01-27 13:26:11 -06:00
Elwazir, Ammar b2c71e43cb Fixing collection period rocprofv3 help message (#148)
Update rocprofv3.py

[ROCm/rocprofiler-sdk commit: 19a912d476]
2025-01-24 08:39:40 -06:00
Bhardwaj, Gopesh 7c6afe75dd Fixing corrupted CHANGELOG (#152)
* Fixing corrupted CHANGELOG

* updating changelog

[ROCm/rocprofiler-sdk commit: 2f65f99d2c]
2025-01-23 00:12:12 -06:00
Madsen, Jonathan 3de44de3b5 Upload artifacts only on 'workflow_dispatch' (#147)
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 34145fa762]
2025-01-22 19:44:19 -06:00
Rawat, Swati edb51fc861 update copyright date to 2025 (#102)
* Update LICENSE

* Update conf.py

* Update copyright year

* [fix] Update copyright year

* Update copyright year "ROCm Developer Tools"

* Add license headers to c++ files

* Add license to *.py

* Update licenses in rocdecode sources

---------

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>
Co-authored-by: Mythreya <mythreya.kuricheti@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 97b7a6315d]
2025-01-22 19:11:20 -06:00
Meadows, Lawrence bc76e99c16 Add ELFABIVERSION_AMDGPU_HSA_V6 emitted by recent llvm compilers (#141)
Co-authored-by: Larry Meadows <lmeadows@amd.com>

[ROCm/rocprofiler-sdk commit: 93f19cf5ca]
2025-01-22 13:42:48 -08:00
Kuricheti, Mythreya a4732359ad Upload packages only on 'workflow_dispatch' (#145)
[ROCm/rocprofiler-sdk commit: 9789f76ee6]
2025-01-22 13:50:15 -06:00
Bhardwaj, Gopesh 04ace57589 ROCTx Documentation (#29)
* Add roctx doc

* Add roctx doxyfile input

* Update links and toc

* Build doxysphinx for both doxygen files

* Update scripts

* Generate roctx doxygen files

* Change doxygen path

to allow for 2 doxyfiles

* Make doxygen dir for script

* Call make _doxygen dir with p flag

* Create _doxygen dir in workfllow

* Create doc dirs for doxygen

* Run update docs as sudo

* Fix typo in mkdir command

* Include graphviz for dot

* Install dot for docs CI

* Install dot as sudo due to permission denied

* Install doxygen via sudo

* Install doxysphinx

* Add postcheckout step to RTD to config and gen doxygen docs

* On RTD, update doxygen after creating env

* update docs.yml

* update docs.yml

* fixing build-docs-from-source

* Fixing build docs from source

* update docs.yml

* trying to fix readthedocs

* trying to fix readthedocs

* update docs.yml

* improve mainpage documentation

* update docs

* clang-format fix

---------

Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

[ROCm/rocprofiler-sdk commit: 73e7f8cfb1]
2025-01-22 11:34:21 -06:00
Trowbridge, Ian 0b0a3d473a Documentation Update to reflect that memory allocation trace records null pointers for free operations (#127)
Update documentation to reflect that nullpointers can be recorded in free memory operations

[ROCm/rocprofiler-sdk commit: 73e72bb088]
2025-01-22 11:20:50 -06:00
Cheruvally, Aravindan 66465c3954 Enhance CMAKE install instructions with std install location/destination (#85)
* Enhancement - usage of package name flags commonly across for getting unique folder name

* Enhancements - updating libexec/pkg usage, avoid sbin

* CMAKE Format Update

* Python Format Update

* Revert "Enhancement - usage of package name flags commonly across for getting unique folder name"

This reverts commit 2dcd1ac5f22ab90112d90648e4b5dab5c54bc639.

* REview Comments - Revert PACKAGE_NAME usage

* Review Comments - Update source folders accordingly to new cmake install locations

[ROCm/rocprofiler-sdk commit: 6bb60bf930]
2025-01-22 11:19:47 -06:00
Madsen, Jonathan 9df3eb19ce Update docs jinja requirements (#118)
- Jinja < 3.1.5 has a sandbox breakout through malicious filenames
- Jinja < 3.1.5 has a sandbox breakout through indirect reference to format method

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 89cfb5317d]
2025-01-22 11:18:19 -06:00
Trowbridge, Ian e69ed1475f Changed memory_allocation.csv name to memory_allocation_trace.csv (#111)
[ROCm/rocprofiler-sdk commit: 042c761b64]
2025-01-22 11:14:42 -06:00
Welton, Benjamin 80fbc23f84 Add gfx941/gfx942 to ValuPipeIssueUtil (#139)
[ROCm/rocprofiler-sdk commit: 3076660e60]
2025-01-21 14:39:03 -08:00
Welton, Benjamin b1f44c705d Add gfx940/gfx9 to ValuPipeIssueUtil (#138)
Was dropped, likely by mistake, in the transition to yaml

[ROCm/rocprofiler-sdk commit: c6b52701c7]
2025-01-21 12:12:39 -08:00
Baraldi, Giovanni 3b4b9013ed Fix throw on repeated filename (#124)
Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>

[ROCm/rocprofiler-sdk commit: 081419b745]
2025-01-20 17:24:28 -08:00
Gill, Harkirat 5ed4a1e320 Update clone command in README (#137)
[ROCm/rocprofiler-sdk commit: 95b3fead0e]
2025-01-20 14:20:15 -06:00
Trowbridge, Ian 3e1b8ba4ec rocDecode API Tracing Support (#49)
* rocDecode API Tracing support

* Test bin file added to rocdecode. Need to add validate python methods

* Added option to not make rocDecode tests

* Added rocdecode and rocprofv3 tests

* Added csv test

* Address PR comments. Changed tests to use built-in rocstreambit decoder to remove ffmpeg dependancy. Changed cmake option to disbale tests rather than not build them. Tests work locally, but will fail until rocDecode is built with tracing enabled on CI

* Add option to avoid building rocdecode tests

* Added option to avoid building rocdecode bin file

* Merge conflict error

* CMake files changed in response to review comments. Attempting to implement callbacks.

* Turned off test building for rocdecode

* Minor fixes for review comments

* Review comments

* Updated formatting

* Document changes and format.hpp reversion. Need to remove iterate args support for now for later update.

* Remove iterate args support

* Remove iterate-args

* enforce abi versioning in macro if

* Fix doc error

* removed spaces to fix indentation error

---------

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

[ROCm/rocprofiler-sdk commit: e307b89ca4]
2025-01-17 14:42:25 -08:00
Baraldi, Giovanni 69d94c65a8 SWDEV-478762+FEAT-62196: Fix crash on AQL replay (#104)
* SWDEV-478762: Fix crash on replay

* Fix iteration range

* Format

* Refactor

* Addressing review comments

* Address review comments

* Formatting

* Format

* Refactor

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>

[ROCm/rocprofiler-sdk commit: 1f01526eed]
2025-01-17 12:23:48 -06:00
Mallya, Ameya Keshava eaaeafbfa4 Fixed Workflow for updated KWS structure
[ROCm/rocprofiler-sdk commit: c5140c83a5]
2025-01-17 08:15:36 -08:00
Jakaraddi, Manjunath 324c57ede1 SWDEV-500520: Updated documentation for hang issue (#79)
* SWDEV-500520: Updated documentation for hang issue

* Avoid fatal error when invalid metric is found

* removing invalid metrics

* clang formatting

[ROCm/rocprofiler-sdk commit: dfee6489b1]
2025-01-16 02:14:22 -08:00
Welton, Benjamin ee959cc591 [SWDEV-509659] Skip rocprof device counting tests if lacking permissions (#125)
* [SWDEV-509659] Skip rocprof device counting tests if lacking permissions

Skips non-intercept test if proper permissions are not obtained
(SYS_PERFMON). This should be the only test that fails due to permission
issues (others do not require the IOCTL to pass).

Regex match sample: https://regexr.com/8b29s

* Update source/lib/rocprofiler-sdk/counters/tests/CMakeLists.txt

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* fix

* Update source/lib/rocprofiler-sdk/counters/tests/CMakeLists.txt

---------

Co-authored-by: Benjamin Welton <ben@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

[ROCm/rocprofiler-sdk commit: 536fbba627]
2025-01-16 01:51:06 -06:00
Welton, Benjamin 9a8b8bf905 Small debug print fix in ioctl.cpp (#120)
* Small debug print fix in ioctl.cpp

Fix debug print statement to print agent id.

* formatting

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 71dc203b0c]
2025-01-15 18:00:04 -08:00
Madsen, Jonathan baee324bfc Fix host function logging (#63)
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: fae4ad614c]
2025-01-15 19:54:35 -06:00