Commit Graph

1726 Commits

Author SHA1 Message Date
sdashmiz d2ea4d3dd4 SWDEV-385255 - fixes for graph exec with mem pools
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6f127090904a6c7985992bfaaab928d8b03013f5
2023-04-05 10:52:04 +00:00
Ioannis Assiouras 5ee9e6c8c1 SWDEV-387958 - Fix incorrect slicePitch for ImageGL
Change-Id: I06183deeeed840f345ba988ecdbf4dc442c3c78a
2023-04-05 10:51:48 +00:00
Maneesh Gupta 88b4b6428c SWDEV-361630 - Workaround for rocfft build failure
Change-Id: Ie15e17361f2e6cd5f11e6fc1e6755c98cef7f4ce
2023-04-03 14:52:44 +00:00
Maneesh Gupta 1bc186323f SWDEV-361630 - Enable hip build
Change-Id: Icdeaeff555d46e495c3de954b614168995a82a9f
2023-03-26 15:42:33 +00:00
Ioannis Assiouras e6520ddf8a SWDEV-388278 - Fix return HIP_RETURN(x)
Change-Id: I940ee3660a2427eade8690a9318966fb04a1fbe8
2023-03-13 13:32:55 +00:00
sdashmiz ae631aaa32 SWDEV-377862 - kind does not show on dotprint
- for to/from symbols nodes the correct kind is not showing

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Idf203976b71fcca67b2dd989de0daba4d0554b6d
2023-03-10 16:39:07 -05:00
Sourabh Betigeri ec8ab9b29c SWDEV-385089 - Fixes hipGraphLaunch functionality accounting for the existence of MemFree node or already freed memory when the same graph is launched multiple times
Change-Id: I49beb49ad4e6db4a2dd5b8c8cc8ed11ff0e4e132
2023-03-09 21:10:13 -05:00
Ioannis Assiouras a38296158c SWDEV-373630 - Added input checks in hipOccupancy query functions.
Change-Id: I2b3e47a094acf5968e714bd853c4497995ef386b
2023-03-09 20:45:02 -05:00
Ioannis Assiouras 58e05898d1 SWDEV-386926 - Added check for correct node type in hipGraphMem[Alloc/Free]NodeGetParams
Change-Id: Ic8446210a683d1329391288d0ed99d835c5aa140
2023-03-09 20:05:28 -05:00
Ioannis Assiouras 9e1e3035ec SWDEV-387383 - Changed error message in hipDevice[Get/Set]GraphMemAttribute to match cuda
Change-Id: I34a9f3d8572e004ae3d25ef25a4d404bea6d9597
2023-03-09 11:53:15 -05:00
Saleel Kudchadker dfefc97178 SWDEV-384658 - Optimize D2D memcpy
- Intra device memcpy does not need to perform host side synchronization
- Check alloc flags when determining memory type

Change-Id: Ieff28bd8d62756ffe82905354c4a91e9717e6bd4
2023-03-09 04:47:11 -05:00
Anusha GodavarthySurya 9b84e05427 SWDEV-386102 - Handle code object v5
Change-Id: I47b840f484d90ca7815fb9c8af959ceaac62cf70
2023-03-09 00:19:25 -05:00
Saleel Kudchadker 8028d327e9 SWDEV-345213 - Use the right accessor
- Use correct accessor to fetch memory objects. This checks the svm map
and arena maps

Change-Id: I84515330bb530cfe2b39abf30e1e659938f06806
2023-03-06 19:35:40 -05:00
Ioannis Assiouras 5837d83e46 SWDEV-373630 - Added checks for invalid flags in hipOccupancy query functions
Change-Id: Ice1df4d3722354f40c8b02ba35ed122f9b2e2f2d
2023-03-06 15:10:07 -05:00
Jatin Chaudhary 7715b3b398 SWDEV-386435 - Add checks for memfree graph node
Change-Id: I8eab93046723f0fdc01f95e3bfb9071d84eb2e18
2023-03-03 04:33:49 -05:00
Anusha GodavarthySurya a2785c68b2 SWDEV-366636 - Fix performance drop in TF-RCCL models
Change-Id: Ie04219daacc29654d0f47e1c15ed5cd78d88d8c8
2023-03-03 03:27:00 -05:00
Anusha GodavarthySurya 705c56ed31 SWDEV-368521 - Return hipErrorNotSupported when Mipmap array create support is not available
Change-Id: I47acfa82ff3f58427b1f5fbb0d2f4aabfff0d6ec
2023-03-02 03:05:43 -05:00
Satyanvesh Dittakavi a8c2375fe1 SWDEV-384714 - Add hipRTC support for amd_hip_fp16
Change-Id: Ib6e2b46908d740909dfc15253965590f496a7068
2023-03-01 06:57:57 -05:00
Jatin Chaudhary a7049bf7a0 SWDEV-372153 - Add hipStreamGetDevice Implementation
Change-Id: Ifd1f13e311e8221ca6d94cf27f9131eb97678067
2023-03-01 04:35:49 -05:00
Jaydeep Patel 57fa5938fe SWDEV-383056 - Don't sync with dst device for hipMemcpyAsync.
Change-Id: I28530e6bd870d617507592576295fc9e7eed1475
2023-02-28 23:21:01 -05:00
Sourabh Betigeri 88dc5cd386 SWDEV-378778 - Returns with error logged when compiled for a diffferent gpu arch
Change-Id: I34fb03c4f76d08278246d29028db0eb21a7aa529
2023-02-28 15:59:59 -05:00
Sourabh Betigeri 08c8972d97 SWDEV-326798 - Revert "SWDEV-326798 - Changes in stream sync behavior"
This reverts commit 51adec2730.

Reason for revert: HIP tests on windows fails

Change-Id: I795ed19d76a41e2fd9971414cefa5bd3be45d4bc
2023-02-28 02:28:12 -05:00
Sourabh Betigeri 51adec2730 SWDEV-326798 - Changes in stream sync behavior
Change-Id: If6d0b3876a9bf197c7e49273eaa5ca5bfae46d0b
2023-02-27 16:48:14 -05:00
sdashmiz a69db9b426 SWDEV-382838 - inetrmittent failure
- test fails intermittently because object is not cleared correctly

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I88daf3dc08bb83d6d3f047ff48a63c8f856fb0bf
2023-02-27 16:23:04 -05:00
pghafari 58001ae995 SWDEV-366515 - adding HIP_AD_FORMAT_SIGNED_INT16
Change-Id: I084d7b093049093ea032372593711f6dc0964af8
2023-02-24 12:39:13 -05:00
Ioannis Assiouras 06927fd3c1 SWDEV-381402 - Remove unused getNullStream() from device. Make stream destructor private.
Change-Id: Idde30a8bfe97a525bd9f9fb50698a5cb14b798fc
2023-02-24 10:42:46 +00:00
sdashmiz ea5838320e SWDEV-379388 - remove check for all streams done
- cuda shows  a different behaviour and different error need more
  investigation

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I68771102ba4dff6157bca34a4135cb245f023d08
2023-02-23 22:56:23 -05:00
German Andryeyev 314bdba632 SWDEV-353281 - Add support for MemPool in graphs
Implement hipDeviceGetGraphMemAttribute, hipDeviceSetGraphMemAttribute
and hipDeviceGraphMemTrim

Change-Id: I4f8fc1250ce1e8b7636d43d59ba7343158e45088
2023-02-23 12:49:53 -05:00
Saleel Kudchadker 7fc5ae2226 SWDEV-364604 - Add support for hipEventDisableSystemFence
Change-Id: I1a6451c873fb22729ac61e4e80f8531251e990f0
2023-02-21 23:11:40 -05:00
pghafari c221406681 SWDEV-366520 - DLL_PROCESS_DETACH update
making sure the current thread is not null before calling ihipDestroyDevice

Change-Id: Ib75e3f9ee1c4e0065986e3fed1065907220f4379
2023-02-21 23:02:24 -05:00
Ioannis Assiouras e3633dc8f4 SWDEV-381402 - Derive hip::Stream from amd::HostQueue
Change-Id: I6c1aca5eb350c32d974ae4ffcc725705355956d8
2023-02-21 18:12:03 -05:00
Rakesh Roy 348698ed30 SWDEV-377782 - Fix segmentation fault for hipLaunchKernel
- If fat binary doesn't contain code object for current gfx then inside FatBinaryInfo::ExtractFatBinary(), valid FatBinaryDeviceInfo address isn't stored in vector fatbin_dev_info_
- This raises segmentation fault during hipLaunchKernel

Change-Id: I21017338d91edbd5d9cc2d37277f66558198a129
2023-02-20 09:54:44 -05:00
Konstantin Zhuravlyov caf7551dd7 SWDEV-1 - Add missing gpu cases in getProcName
Change-Id: I16103ab213cc70f388690df85e6a03e7a408384d
2023-02-17 15:55:09 -05:00
victzhan d6a08403d8 SWDEV-376995 - Fixed misplaced checking
Change-Id: Ia3bddabfa7fc76066541fb81723136ae6cffb0a4
2023-02-17 13:34:51 -05:00
Rakesh Roy 287d07ccd4 SWDEV-338733 - Implement hipArrayGet* APIs
- Add implementation for hipArrayGetInfo, hipArrayGetDescriptor &
  hipArray3DGetDescriptor APIs

Change-Id: I181a472066006bc3bd0d987408ea67e218310983
2023-02-16 23:04:29 -05:00
Ioannis Assiouras 8b87ccb8cc SWDEV-381402 - convert host_device to host_context of type amd::Context*
Change-Id: Ic1cb9a3fa64e16699fad7e9ec6679f1d34b14bef
2023-02-16 17:49:12 -05:00
kjayapra-amd 193c5e387e SWDEV-376697 - Pass uncached memory flag when hipDeviceMallocUncached memory is requested.
Change-Id: Idc12948047fdb69876e31edf34a8bcda46c9c303
2023-02-16 14:05:54 -05:00
kjayapra-amd 68139f9ddb SWDEV-381898 - Move the lock after code object loading since COMGR is thread safe now and VDI also have locks.
Change-Id: I15547f3ae3711d12a1ddf5cb7e9abd40a95ded89
2023-02-15 10:23:28 -05:00
victzhan 4e324a9c63 SWDEV-376995 - Added if statement so that when AQL dispatch failed it returns corresponding hip error instead of hipSuccess
Change-Id: I0724fbcf0833c5dd8b2e4d6e443b3e226046dddf
2023-02-14 14:30:50 -05:00
sdashmiz e34be4fbee SWDEV-377862 - wrong format for memcpy1d
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ide6d252083b1812b0ad9cd182b1435e3e59b3aa1
2023-02-14 09:47:04 -05:00
Sourabh Betigeri 191b468d89 SWDEV-375194 - Fixes graph dot file descriptions to include labelId matching CUDA
Change-Id: Ia0e6b77e38678b13457f86755ed8f3b852c9b7a1
2023-02-13 19:43:12 -05:00
Sourabh Betigeri 4cbf9a4a16 SWDEV-375202 - Fixes print formatting for flags in hipGraphDebugPrint() to match CUDA
Change-Id: I2d85fc38d2c65bc12534109883fe00802e77e62d
2023-02-09 13:07:57 -05:00
Satyanvesh Dittakavi 99556449b6 SWDEV-370552 - Correct the HIPRTC behavior to optimize the ISA only once
Change-Id: Idaf0ea8294657db3666e9548deb6a9629e0ee718
2023-02-09 11:55:41 -05:00
sdashmiz 5c5b220561 SWDEV-374378 - correct setparam for memcpy node
- params should be valid when used for default flag since we support
  unified virtual address space

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I75d40e437b12ee58e72e423bb4818b484ce35b66
2023-02-09 09:39:20 -05:00
Saleel Kudchadker 2e4ce59cf4 SWDEV-381633 - Better log
Change-Id: I5c59d42462fe8a233ef10e26ec67314219aeb167
2023-02-08 10:21:57 -08:00
Jaydeep Patel e940beb459 SWDEV-380405 - Check for invalid stream for hipMemcpyPeerAsync.
Change-Id: I6dfccb4d20bb638bd596c071030c68889743d706
2023-02-08 00:47:35 -05:00
pghafari 03f62b90ef SWDEV-377571 - adding scopelock for hipDeviceReset
Change-Id: I3dd95a40d6abff721a4774f26e99d1162bafdfa1
2023-02-07 11:29:20 -05:00
Jaydeep Patel 5f231c55e3 SWDEV-380405 - Make hipMemcpyPeer async w.r.t. host and let dst device wait till copy finishes by src device.
Change-Id: Idbe25404d0c31b93436e190b548f12f327f47a04
2023-02-07 00:34:45 -05:00
German Andryeyev 0fe03b6494 SWDEV-353281 - Switch Graph to operate with stream
MemPool was designed to use hip::Stream, but graph implementation uses
amd::HostQueue. Hence switch graph to hip::Stream management.

Change-Id: Ia319389de45e4c3c6043d17473279a6f27a13140
2023-02-06 10:11:55 -05:00
Jaydeep Patel 01c3299425 SWDEV-379395 - Use getQueue as it handles null stream and flags can be combination.
Change-Id: If37854a9fc0fc57acb30e652953a7f283831cad8
2023-02-01 12:03:42 -05:00