SWDEV-2 - Change OpenCL version number from 2027 to 2028.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1774 edit
[ROCm/clr commit: e5cbfbac36]
SWDEV-86885 - [CQE OCL][2.0][QR][CFX] Few SDK 64 and 32 bit Samples resulting in Soft/hard hangs with faulty cl: 1233743
Unsubmit CL1233743 because of problems with CFX.
I have not been able to figure out how Cl1233743 would cause a problem. It sets a flag, to disable new code... I would expect the new code to be the problem, not the disable.
So, in case this unsubmit does not elminate the problem, CL1233686 is shelved, to use #ifndef CAL_SUPPORT around the new code in CL1226184.
CL1233743 was submitted for:
SWDEV-86253 - [QR] 6 to 7% performance drop is observed in BasemarkCL test
CL1226184 adds serialization to LHIO, because pxproxy accesses global state, without locks, leading to crash, etc.
To fix OpenCL perf regressions, allow unserialized access to pxproxy. It may be that OpenCL design leads away from racy behavior, so it may be safe. This was checked in to gather information. What software gets perf drops? Does any software get fixed?
The dangerous functions are CreateDevice, CreateContext, because the handles from the OS are saved in global caches, and if those global caches are modified in one thread, while other threads are looking-up from the caches - that is a problem.
CL1226184 was submitted for:
SWDEV-80442 - [QR][Adobe Premier Pro CS6] TDR/App Crash observed while resizing the video window within workspace
TC: http://ocltc:8111/viewModification.html?modId=66278&personal=true
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#159 edit
[ROCm/clr commit: 27c1ec4857]
SWDEV-2 - Change OpenCL version number from 2026 to 2027.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1773 edit
[ROCm/clr commit: ecdfb00a01]
SWDEV-2 - Change OpenCL version number from 2025 to 2026.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1772 edit
[ROCm/clr commit: 3251b63346]
SWDEV-2 - Change OpenCL version number from 2024 to 2025.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1771 edit
[ROCm/clr commit: 865b81887a]
SWDEV-86253 - [QR] 6 to 7% performance drop is observed in BasemarkCL test
CL1226184 adds serialization to LHIO, because pxproxy accesses global state, without locks, leading to crash, etc.
To fix OpenCL perf regressions, allow unserialized access to pxproxy. It may be that OpenCL design leads away from racy behavior, so it may be safe. This was checked in to gather information. What software gets perf drops? Does any software get fixed?
The dangerous functions are CreateDevice, CreateContext, because the handles from the OS are saved in global caches, and if those global caches are modified in one thread, while other threads are looking-up from the caches - that is a problem.
TC: http://ocltc:8111/viewModification.html?modId=66278&personal=true
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#158 edit
[ROCm/clr commit: bd54838ca7]
SWDEV-2 - Change OpenCL version number from 2023 to 2024.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1770 edit
[ROCm/clr commit: 99556aca1d]
SWDEV-2 - Change OpenCL version number from 2022 to 2023.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1769 edit
[ROCm/clr commit: 916f8de56e]
changed Cuda to CUDA for consistency
changed NVIDIA to Nvidia for consistency
corrected apostrophes
corrected section "What hardware does HIP support?"
[ROCm/clr commit: 2872d8dfec]
SWDEV-2 - Change OpenCL version number from 2021 to 2022.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1768 edit
[ROCm/clr commit: 57237e521f]
SWDEV-2 - Change OpenCL version number from 2020 to 2021.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1767 edit
[ROCm/clr commit: ed94a0d1af]
SWDEV-2 - Change OpenCL version number from 2019 to 2020.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1766 edit
[ROCm/clr commit: f485a378be]
SWDEV-2 - Change OpenCL version number from 2018 to 2019.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1765 edit
[ROCm/clr commit: 91ed3c45fc]
SWDEV-85649 - The return of owner() needs to be casted to get amd::Image.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpumemory.cpp#125 edit
[ROCm/clr commit: 4ad4539710]
SWDEV-79308 - Use 64-bit to calculate the scratch buffer size for OCL. We observed that the computed scratch buffer size could be > 4G when compilier optimization option is not used.
Cross branch change - requires CL1231547.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#157 edit
[ROCm/clr commit: 80ab916a5b]
SWDEV-2 - Change OpenCL version number from 2017 to 2018.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1764 edit
[ROCm/clr commit: e33c3ccfea]
foreman
Ben Sander
Sam Kolton
Peng Sun
scchan
streamhsa
Jack Chung
Maneesh Gupta
Paul Jähne
sunway513
Aditya Avinash Atluri