Older gcc, e.g., 5.x, see an ambiguity in some calls. Example error
output as seen with gcc 5.5:
In file included from benchmark_wino.cpp:1:
In file included from ./miopen.hpp:13:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/regex:38:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/algorithm:62:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/stl_algo.h:66:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/random:51:
/usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/random.tcc:1324:27: error: call to 'abs' is ambiguous
const double __y = -std::abs(__n) * __param._M_sm - 1;
^~~~~~~~
/opt/rocm/hip/include/hip/hcc_detail/hip_complex.h:345:31: note: candidate function
__DEFINE_HIP_COMPLEX_REAL_FUN(abs, hipCabs)
[ROCm/clr commit: 992c90079b]
Older gcc, e.g., 5.x, see an ambiguity in some calls. Example error
output as seen with gcc 5.5:
In file included from benchmark_wino.cpp:1:
In file included from ./miopen.hpp:13:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/regex:38:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/algorithm:62:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/stl_algo.h:66:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/random:51:
/usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/random.tcc:1324:27: error: call to 'abs' is ambiguous
const double __y = -std::abs(__n) * __param._M_sm - 1;
^~~~~~~~
/opt/rocm/hip/include/hip/hcc_detail/hip_complex.h:345:31: note: candidate function
__DEFINE_HIP_COMPLEX_REAL_FUN(abs, hipCabs)
[ROCm/clr commit: 37cc117bd5]
SWDEV-2 - Change OpenCL version number from 2728 to 2729.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2476 edit
[ROCm/clr commit: 8404016f00]
SWDEV-143465 - HSAIL - Compiler Lib - Stop supporting SPIR binary on CI+ as well
This change plugs a hole when compiling from SPIR precompiled binary is possible on CI+ devices without option "-x spir" specified.
SPIR text has been already deprecated.
[Reviewers] Brian Sumner, Stanislav Mekhanoshin
[Testing] http://ocltc.amd.com:8111/viewModification.html?modId=107222&personal=true&tab=vcsModificationBuilds
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#101 edit
[ROCm/clr commit: da2aa0859e]
SWDEV-2 - Change OpenCL version number from 2727 to 2728.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2475 edit
[ROCm/clr commit: ce5e68844d]
SWDEV-79445 - OCL generic changes and code clean-up
- Use SDMA staging transfers for data upload if pinning fails. Fixes HIP failure in a test that uses the code segment data for uppload.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palblit.cpp#26 edit
[ROCm/clr commit: 45d50bb738]
SWDEV-2 - Change OpenCL version number from 2726 to 2727.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2474 edit
[ROCm/clr commit: 3f02c35aea]
SWDEV-2 - Change OpenCL version number from 2725 to 2726.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2473 edit
[ROCm/clr commit: 0c5f415b5f]
- Removed hcc integration logic for now
- No longer publish docker images to artifactory or docker hub
- Switch to new docker images and new test node
Change-Id: Idb06bf0a52658d1869367cb38bb03ef4f1649103
[ROCm/clr commit: 8c95267bf5]
SWDEV-145570 - [HIP] - Multithreading issues
Add a lock per function so kernel parameters don't get overwritten
Make execStack_ thread local and remove global lock use for it:
The compiler uses the same thread to set it up and launch the function
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#19 edit
[ROCm/clr commit: 556ef9c0d1]
SWDEV-2 - Change OpenCL version number from 2724 to 2725.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2472 edit
[ROCm/clr commit: e2bbfbe758]
SWDEV-2 - Change OpenCL version number from 2723 to 2724.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2471 edit
[ROCm/clr commit: 25a050c22b]
SWDEV-2 - Change OpenCL version number from 2722 to 2723.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2470 edit
[ROCm/clr commit: 0fb56dbba0]
SWDEV-159881 - [OCL][ROCm] Add SVM coarse-grain buffer support with device memory
1. Use the system memory pool for coarse grain allocations on APUs
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15671/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#64 edit
[ROCm/clr commit: 1bf70582f0]
SWDEV-2 - Change OpenCL version number from 2721 to 2722.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2469 edit
[ROCm/clr commit: bd9a437016]
SWDEV-161959 - [ROCm QA][RAVEN] QCDGPU-S test is having ERROR -61: (clCreateKernel failed) on RAVEN
SWDEV-161983 - [ROCm QA][RAVEN] Cachebench test is failing with CL_INVALID_BUFFER_SIZE issue
SWDEV-161978 - [ROCm QA][RAVEN] PCIeBW is failing on -with error : 61, OpenCL error creating buffer !
SWDEV-161962 - [ROCm QA][RAVEN] rodinia->nw test has ERROR: clCreateBuffer input_item_set (size:67125249) => -61
- We make the global memory size at least 1G byte. This is to avoid issue/regression if sysconf API misbehaves.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15660/
Tests:
1. ocltst -m oclruntime.so -A oclruntime.exclude - PASS except SVM test (non regression)
2. TeamCity presubmission test (OpenCL) - PASS
3. Run test qcdgpu-s.sh : PASS
4. Run test cachebench-ocl : PASS
5. Run test PCIeBandwidth -c 0 -g 0 : PASS
6. Run test Rodinia/opencl/nw/run : PASS
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#98 edit
[ROCm/clr commit: d886bbdb2c]
SWDEV-161959 - [ROCm QA][RAVEN] QCDGPU-S test is having ERROR -61: (clCreateKernel failed) on RAVEN
SWDEV-161983 - [ROCm QA][RAVEN] Cachebench test is failing with CL_INVALID_BUFFER_SIZE issue
SWDEV-161978 - [ROCm QA][RAVEN] PCIeBW is failing on -with error : 61, OpenCL error creating buffer !
SWDEV-161962 - [ROCm QA][RAVEN] rodinia->nw test has ERROR: clCreateBuffer input_item_set (size:67125249) => -61
- Adjust Global memory size as half of the system physical memory size in APU for Rocm
- Similar to current DGPU calculation, environment GPU_SINGLE_ALLOC_PERCENT can be used to adjust max memory allocation size.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15659/
Tests:
1. ocltst -m oclruntime.so -A oclruntime.exclude - PASS except SVM test (non regression)
2. TeamCity presubmission test (OpenCL) - PASS
http://ocltc.amd.com:8111/viewModification.html?modId=106628&personal=true&init=1&tab=vcsModificationBuilds
3. Run test qcdgpu-s.sh : PASS
4. Run test cachebench-ocl : PASS
5. Run test PCIeBandwidth -c 0 -g 0 : PASS
6. Run test Rodinia/opencl/nw/run : PASS
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#97 edit
[ROCm/clr commit: f84d1d2d03]
SWDEV-2 - Change OpenCL version number from 2720 to 2721.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2468 edit
[ROCm/clr commit: ebd334d5bf]
Mark Searles
Saleel Kudchadker
foreman
Maneesh Gupta
Aaron Enye Shi
Yaxun Sam Liu
fpadmin
Matthias Werner