Commit Graph

3835 Commits

Author SHA1 Message Date
Aryan Salmanpour d805e98fcb update the hipify-perl 2020-01-31 14:36:37 -05:00
Aryan Salmanpour 75572a4175 code clean up 2020-01-31 13:08:25 -05:00
Aryan Salmanpour 6db9b782be [HIP][HIPIFY] Add some missing flags for cooperative launch and occupancy APIs 2020-01-30 15:05:53 -05:00
Evgeny Mankov f1c70ea6ba Merge pull request #1700 from scchan/object_load_error_check
add error checking for code object loading
2020-01-30 21:31:03 +03:00
satyanveshd 262ad13dd5 Match Occupancy APIs syntax with CUDA (#1625)
* Match Occupancy APIs syntax with CUDA and fix tests using these APIs
2020-01-29 13:05:53 -08:00
vsytch 6da0c82b78 Add missing texturePitchAlignment member to the hipDeviceProp_t struct. (#1802)
* Add missing texturePitchAlignment member to the hipDeviceProp_t struct.

* Add missing hipDeviceAttributeTexturePitchAlignment enumerator to the hipDeviceAttribute_t enum.

* Initialize texturePitchAlignment to 256. This works for gfx9+, but is technically overaligned in most cases for pre-gfx9.

* Add the texturePitchAlignment property to the NVCC path.
2020-01-27 16:37:00 -08:00
Evgeny Mankov 5a788eb048 [HIPIFY] Update Readme.md
Restructure contents in order to have separated same-level information about hipify-clang and hipify-perl.
2020-01-27 17:21:32 +03:00
Evgeny Mankov 5fae88f84b [HIPIFY][#1819] Fix for not found clang's system header files
Use absolute paths instead of relative ones.
2020-01-27 12:37:26 +03:00
Evgeny Mankov e57c2b3147 Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into HIP 2020-01-27 12:08:22 +03:00
vsytch e419a1609f Update the HIP_TRSF_* flags to match their Cuda equivalents. (#1801) 2020-01-24 11:41:15 -08:00
Evgeny Mankov 2b77ca7d2e Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into HIP 2020-01-24 16:14:16 +03:00
aakanksha555 ef3dbc1f91 Fix for a syntax error in deb packages (#1814) 2020-01-24 16:23:47 +05:30
mshivama 0605426049 SWDEV-220503: this_grid().thread_rank() gives incorrect result (#1808)
* fix a minor bug while computing this.grid()::thread_rank()
2020-01-24 16:23:28 +05:30
paulfreddy 5cd5c62f29 Fix install script syntax error (#1805)
Fix hip-nvcc install warning on postinstall and prerm script
2020-01-24 16:22:57 +05:30
Siu Chi Chan 8fc7cad90f Fix associate code object symbols with host allocation bug (#1799)
The current implementation skips this procedure for a given device
object when a global symbol is found in the cache.  This is incorrect:

 - There could be other undefined globals that have not been previously
encountered further down the list
 - If a symbol is found in the cache, it doesn't need to be pinned again
but it still need to be defined for the current executable

Added special case for the printf buffer symbol (already pinned by HCC)

The bug was exposed by running printf on different GPUs.
2020-01-24 16:22:49 +05:30
Alexey Chernov 9f5a4148ce Clear HIP_PATH before version detection (#1786)
Don't allow `HIP_PATH` to be propagated to `hipconfig`,
when run by CMake to detect the package version, as it
leads to the wrong version is detected: when there's
already HIP of some different version installed in the
system and `HIP_PATH` points to its location, `hipconfig`
tends to return the version of the installed HIP, rather
than the value defined for the distribution. The compiled
results report wrong version and spoils the rest of the
stack in this case.
2020-01-24 16:21:49 +05:30
Evgeny Mankov 0a380694c5 [HIP][HIPIFY] Readmes actualization 2020-01-23 20:55:10 +03:00
Evgeny Mankov 85b76bac70 [HIPIFY][doc] Readme - update versions 2020-01-23 18:01:48 +03:00
Evgeny Mankov 584ce03173 [HIPIFY][cmake] Formatting 2020-01-23 17:47:11 +03:00
Evgeny Mankov 9b739bfa15 [HIPIFY][cmake] Send error on CUDA 10.2 and higher as yet unsupported 2020-01-23 16:37:25 +03:00
Rahul Garg 8b8e4a66b4 Simplify hipDispatchLatency sample (#1793)
* Use hipExtLaunchKernelGGL in dispatchlatency sample

* Let it run on NVCC path too

* Refactoring

* Add test_kernel source

* Remove ResultDB

* Remove error checks
2020-01-22 14:37:47 -08:00
paulfreddy c5ed5c71a3 Changes for multiple ROCm installation (#1771)
* FBA-29, FBA-69, multiple rocm support, shared library conflicts
Changes to resolve:
1) Multiple rocm release installation support
2) Multiple rocm shared lib conflicts
3) Add the so versioning also
2020-01-21 14:17:35 +05:30
Evgeny Mankov 30baf8fdf4 Merge pull request #1795 from aakanksha555/master
[HIPIFY][cmake] Packaging for hipify-clang
2020-01-20 19:10:20 +03:00
ansurya 688b6e6af0 Fix texture tests, always pass row pitch to HSA API for linear layout images (#1785)
=> New ROCr calculates pitch as per HSA specification and addrlib is used to check whether HW can support that configuration. Hence few texture tests are failing with HSA_EXT_STATUS_ERROR_IMAGE_PITCH_UNSUPPORTED.

=> Determine pitch for linear images and always pass rowpitch to HSA API's.
2020-01-16 08:54:30 +05:30
kpyzhov 1d6a2fb064 Don't use accelerated vector element access for hip-clang. (#1796) 2020-01-15 18:17:08 -08:00
Aakanksha Patil 545ad0dad3 [HIPIFY][cmake] Packaging for hipify-clang 2020-01-15 11:39:02 -05:00
kpyzhov 0918614615 Add missing constructors for Scalar_accessor class. (#1792) 2020-01-14 11:30:21 -08:00
Evgeny Mankov df563c966c [HIPIFY][fix] Add "--" separator in-place if needed 2020-01-13 18:49:28 +03:00
Evgeny Mankov 41beed4839 [HIPIFY] Sync with hipSPARSE
+ Update hipify-perl and doc accordingly
2020-01-13 18:34:10 +03:00
Jatin Chaudhary 0b211478dd Remove filesystem dependency in hipRTC (#1749)
Removing dependency on filesystem, so libstdc++fs is no longer required to link
2020-01-10 13:47:54 +05:30
Evgeny Mankov 9c2fcff9ce [HIP] Unify hipError_t (Step 3): Sync nvcc path (#1778)
* [HIP] Unify hipError_t (Step 3): Sync nvcc path

* [HIP][fix] Add CUDA 10.x support to nvcc path
2020-01-10 13:47:18 +05:30
Yaxun (Sam) Liu 55525fa466 Fix test hip_bitextract.cpp (#1784)
The randomly generated offset+width may exceeds 32, which causes
a left shift operation with 32-offset-width. As an unsigned number
that is greater than 32 and causes undefined behavior. When the
test is compiled without -mavx it is still OK. However when
the test is compiled with -mavx, the undefined behavior causes
wrong results and test failure.

This patch adjusts width so that offset+width<=32 always.
2020-01-10 13:46:57 +05:30
Maneesh Gupta c091635f5a Revert PRs that break ROCm builds (#1781)
Fixes SWDEV-218626 and SWDEV-218629

Changes:
- Revert "`static inline` in a header, just like excess sugar in a diet, causes bloat (#1692)"
   This reverts commit cf526f5484.
- Revert "Fix rocFFT build failure (#1777)"
   This reverts commit cbd8f604ec.
2020-01-08 15:11:58 +05:30
Siu Chi Chan 26b50e1e1b Detect when an explicit printf buffer flush is required (#1766)
* Detect when an explicit printf buffer flush is required
in a device/stream synchronization function.

* hip_module.cpp: add missing hc_am.hpp header
2020-01-07 09:06:38 -08:00
Evgeny Mankov 8fbbaf3779 [HIPIFY] main source file refactoring 2020-01-07 16:25:18 +03:00
ansurya cbd8f604ec Fix rocFFT build failure (#1777)
Fixes SWDEV-217761
2020-01-07 08:12:37 +05:30
satyanveshd 9b2f22f7aa hipMemcpy[To/From]Symbol(Async) fixes (#1774) 2020-01-07 08:11:53 +05:30
Rick Ho ade47bd848 Fix minor explainations in the kernel guide (#1775) 2020-01-06 12:34:21 +05:30
Rahul Garg 534376cb41 Add hipBindTexture2D on NVCC path (#1773) 2020-01-06 12:33:50 +05:30
Rahul Garg 178d432b90 Fix nested designator warnings (#1768) 2020-01-06 12:33:34 +05:30
Rahul Garg 3fe1695c3a Fix hipcc warning related to hipVersion (#1767)
* Fix hipcc warning related to hipVersion
* Rename hipVersion.h to hip_version.h
* Remove HIP_VERSION splitting
* Update .gitignore
- Ignore generated include/hip/hip_version.h
- Removed some stale entries
- Added executables from samples/1_Utils/*/ for consistency with bin/ entries.
2020-01-06 12:33:23 +05:30
Yaxun (Sam) Liu c80c2bf234 Update HIP-Clang build instruction (#1764) 2020-01-06 12:32:47 +05:30
Yaxun (Sam) Liu 7dcd5f6329 Document FMA settings (#1717) 2020-01-06 12:32:38 +05:30
Evgeny Mankov ed43699a3a Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)
2019-12-30 19:21:09 +03:00
Sarbojit2019 4fd77f8336 Change to generate hipVersion.h (#1726)
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.
2019-12-30 12:44:24 +05:30
Aryan Salmanpour 857052be1e [hip] refactoring cooperative kernel launch APIs (#1737)
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.
2019-12-30 12:42:17 +05:30
ansurya 651c7a8e27 Fix texture 3D & 2D layered with N components (#1746)
SWDEV-151670: Issue with 3D texture with 4 components
SWDEV-151671: Issue with 2D layered texture with 4 components

Fixed memcpy when memory is allocated with driver API's.

Github issues: #1755
Fixed 3D default case when array type is not set during memory allocation.
2019-12-30 12:41:42 +05:30
Evgeny Mankov 2d7e766cc7 [HIPIFY][doc] LLVM 9.0.1 is the latest stable release now
+ Tested on Windows and Linux: no changes are needed
2019-12-23 20:00:33 +03:00
Evgeny Mankov 4aaa2336a8 [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle
2019-12-23 17:01:35 +03:00
Yaxun (Sam) Liu 35988729f3 Add macro __HIP_ENABLE_CUDA_WRAPPER_FOR_OPENMP__ (#1761)
This is to allow force enable cuda wrapper for OpenMP for flexibility
2019-12-23 19:24:54 +05:30