f2a9f8eec3
Merge pull request #367 from gargrahul/fix_tex_drv_offset
...
Fix offset issue in texture driver APIs
2018-03-16 07:43:48 +05:30
1ba06f63c4
Apply .clangformat to all repo source files
...
Change-Id: I7e79c6058f0303f9a98911e3b7dd2e8596079344
2018-03-12 11:29:03 +05:30
b62a8d2ba0
Set offset value to 0
2018-03-11 00:12:22 +05:30
18e70b1e6b
Merge pull request #363 from gargrahul/surface_object_api
...
Added surface object support
2018-03-09 11:50:30 +05:30
0057dbca83
Added hip_surface header file
2018-03-01 12:22:56 +05:30
5c3b91a0a1
Added surface object support
2018-02-26 11:59:03 +05:30
dc7560ef22
Change directory name to match HIP lowercase style.
2018-02-22 13:15:10 +00:00
49ef24c042
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into feature_purge_genco
2018-02-22 12:08:52 +00:00
ebc92e5975
make HIP to load the GPU objects and to setup the function symbol map on startup
2018-02-18 14:26:44 -05:00
baf50a5311
Re-sync with upstream.
2018-02-12 20:20:24 +00:00
4b8ae78891
Merge pull request #321 from gargrahul/hipMemcpyArray_Functions
...
Added support for hipMemcpy Array functions-
2018-02-12 10:36:38 +05:30
2dc315efc8
Merge pull request #350 from gargrahul/fix_module_host_global_symbol
...
Fixed host allocated globals address lookup for host usage
2018-02-12 10:13:49 +05:30
24ab820a11
Fixed host allocated globals address lookup for host usage
...
Fixed texture driver APIs failure
2018-01-30 18:06:31 +05:30
7c2c6e637b
Merge branch 'feature_purge_genco' of https://github.com/AlexVlx/HIP into feature_purge_genco
2018-01-17 14:07:48 +00:00
ed75522ba5
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into feature_purge_genco
2018-01-17 14:02:19 +00:00
487a430b5a
Added support for -
...
- hipMemcpyFromArray
- hipMemcpyAtoH
- hipMemcpyHtoA
2018-01-16 11:44:19 +05:30
8a060d194e
Fixed build error
2017-12-28 16:15:45 +05:30
cebb070d30
Implement hipStreamAddCallback
...
Change-Id: Ib851e4d86ba9c8406ca37b88162ea483ccbc9d36
2017-12-19 16:06:14 +05:30
814d55f046
Merge pull request #282 from gargrahul/texture_driver_3d_support
...
Added support for 3D texture driver apis
2017-12-18 15:39:26 +05:30
e14ac87474
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into feature_purge_genco
2017-12-14 13:50:49 +00:00
7930c03e42
[cmake] Added target static_check for static code analysis
...
- Added static code analysis using cppcheck
- Fixed couple of warnings reported by cppcheck
Change-Id: Ie3b9b06e95ada322e7dc2ce3d6b91831e870198d
2017-12-14 12:16:44 +05:30
6293d3f887
Merge pull request #285 from aaronenyeshi/fix-ilogb-unreachable
...
Fix ilogb/ilogbf functions to return int
2017-12-12 10:47:33 +05:30
b842394957
This introduces LipoProteinLipase (lpl), a simple tool for creating fat binaries. It represents a direct replacement of the creaky hccgenco.sh script, which had various issues. The format it uses is that of a code object bundle, generated by the Clang Offload Bundler. The output is always suffixed with the ".adipose" extension. It is shared with HCC. The hipcc script and associated tests are modified to use lpl. Help can be obtained by invoking lpl --help. A more computer-sciency / corporate friendly name is likely to be beneficial, which is a reason for choosing easily searchable/replaceable names such as lpl or adipose.
2017-12-08 04:22:57 +00:00
707aaef99d
Fix ilogb/ilogbf functions to return int
...
This patch will fix hipDoublePrecisionMathDevice test on ThinLTO, which uncovered that hip math_function's ilogb/ilogbf should return type int instead of double. This will match rocdl.
2017-12-05 23:14:10 +00:00
115c7f2b79
Added support for
...
- 3D texture driver APIs
- hipMalloc3D
- hipMemcpy3D for destination other than array
2017-12-05 14:11:13 +05:30
5ca3176a91
Re-sync with upstream.
2017-12-03 23:14:58 +00:00
5127ce67e8
This is primarily intended as an additional cleanup of the module functionality, in the aftermath of adopting module based dispatch. The main effort was associated with refactoring the questionable ihipModuleGetSymbol. It was quaintly written and misleading, in that it had little to do with getting symbols, and was exactly retrieving a kernel object. Error handling is modified so as to reduce branching depth. Functions which serve as interfaces to the HSA RT are moved in a separate helper header. Code object readers are properly deleted. Some leftover dead functionality pertaining to associating namespace scope variables with their allocated memory is removed. Executable loading is changed to use a string which holds the ELF image of the code object being loaded, thus avoiding some corner cases where using a istream would fail.
2017-12-03 23:09:06 +00:00
6f3ed5e3cf
Merge pull request #271 from bensander/cppcheck
...
Cppcheck
2017-12-02 08:36:17 -06:00
02fc25de4c
Remove stray leftover comment.
2017-12-02 00:03:10 +00:00
6027d3f332
Replace archaic use of homebrew functionality with calls to the HC maths library. This fixes a hang observed when building hipTestDeviceDouble.
2017-12-02 00:01:47 +00:00
9bba97fdcc
Fix some cppcheck style issues.
2017-12-01 20:45:34 +00:00
4313686d6e
Fix warning from default cppchek.
2017-12-01 20:45:33 +00:00
7c0b9a005b
Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter.
2017-11-30 03:29:04 +00:00
32e11e7dc6
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit d2fd1f5
2017-11-29 21:49:10 +00:00
fbaf729f88
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit d2fd1f5
2017-11-29 21:36:29 +00:00
b881cf713c
Fix compiler version check.
2017-11-29 03:05:53 +00:00
3ed8897a5a
Add missing file.
2017-11-29 02:16:44 +00:00
faa546d194
Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component.
2017-11-29 01:37:52 +00:00
89e9399427
Choose whether or not to use functional grid_launch based on the version of HCC used to compile.
2017-11-29 00:17:44 +00:00
5aeb5dcd6f
Remove leftover agent allocated globals.
2017-11-28 19:56:04 +00:00
6e4ca3fbb4
Change memset kernel to use memcpy instead of placement new. Simplify indexers.
2017-11-28 19:45:47 +00:00
02c2bfc7ef
Re-sync with upstream and re-factor platform global management for texture references.
2017-11-28 19:15:29 +00:00
dc67ca3feb
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
2017-11-28 17:29:11 +00:00
265c3b224e
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
2017-11-28 17:23:43 +00:00
a6ccaf3d57
This actually (tries) to do the right thing all the way, by using memcpy for bitcasting, and not rely on undefined behaviour of a different flavour as a substitute for the original undefined behaviour. Note that the compiler will (should) optimise down to the same emitted code, since this is a pattern it understands.
2017-11-28 17:23:06 +00:00
a401ce6e5d
This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution.
2017-11-28 17:23:06 +00:00
0da0426f94
Merge pull request #256 from gargrahul/texture_driver_api_support
...
Texture driver APIs support
2017-11-27 13:52:39 -06:00
4c96882366
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
2017-11-23 09:57:24 +05:30
56862b1c35
Fixed review comments
2017-11-21 21:19:06 +05:30
5e16ee0d1f
This corrects how addresses are formed for symbols which reside in shared objects. For this case, the .value component of an ELF symbol holds the offset from the base VA where the shared object was loaded. Thus, to correctly obtain the VA of the object refered by the symbol, we must add the offset to the VA where the shared object is loaded. We were already doing this correctly for symbols denoting functions, but we were incorrect for those denoting objects.
2017-11-21 13:15:13 +00:00
Maneesh Gupta
Rahul Garg
Alex Voicu
Siu Chi Chan
Aaron En Ye Shi
Ben Sander