Commit Graph

252 Commits

Author SHA1 Message Date
Anusha GodavarthySurya d9debabdc3 SWDEV-278873 - hipStreamCreate handle invalid flag value
Change-Id: I05c0e0b76f7b09947e48d5b9f225af305bade27f
2021-03-31 07:59:41 -04:00
Satyanvesh Dittakavi 68abfb4aff SWDEV-277152 - Add hipMemcpy2DToArrayAsync API in headers
Also, address few scenarios for hipMemcpy2DToArray/Async to return
proper error types

Change-Id: Idbadf666a5e7bebc0f3ea8b7048b79208e04cf6b
2021-03-27 13:50:38 -04:00
Maneesh Gupta dff604f557 SWDEV-187253 - Print warning if launch_params > bounds
Change-Id: I138546bf816887576e797105f97ce37245911045
2021-03-24 22:29:19 -07:00
Anusha GodavarthySurya 23f8c84326 SWDEV-269085 - Fix compilation error with clang
Change-Id: Iab5902c9a2702456fbe433fdefc40541c48acb71
2021-03-22 03:02:50 -07:00
Saleel Kudchadker b1657c4159 SWDEV-277847 - Move event lock_ to the beginning
For addMarker, assume T1 comes in first and enqueues a command C1.
Before T1 grabs the event_::lock_ it gets preempted. At this time,
T2 comes in, enqueues C2 and grabs the lock_ and updates event_. Now T1
wakes up and updates a older command C1 for the event.

Change-Id: Ia423782b23026302c40976385623cfdede32d70b
2021-03-19 15:28:08 -07:00
Tao Sang 08625144b3 SWDEV-273138 - Update canUseStreamWaitValue retrieving
Remove canUseStreamWaitValue from hipDeviceProp_t.
Update canUseStreamWaitValue retrieving in hipDeviceGetAttribute().

Change-Id: I275bd42d8b03e141caaf9f1bc6b714e51ca72dfb
2021-03-18 22:42:35 -04:00
German Andryeyev 5c360446bf SWDEV-277543 - fix destruction of the stream object
Change-Id: If2f532e66099805a7f05181e63f5454893a1a288
2021-03-18 13:24:46 -04:00
Ravi C Akkenapally 397bac37a3 SWDEV-276827 - Stream Operations: match API with CUDA
Change-Id: Ia79a950561e97df3b2229f76f5512dede2babf98
2021-03-18 07:52:29 -07:00
Sarbojit Sarkar 43c371fb7b SWDEV-276319 - Fix for -ve cases
Change-Id: Ie6157e3cdbd1f959c8ea502b48286bdf102b8a0f
2021-03-18 00:21:43 -04:00
Tao Sang 629ea5fe19 SWDEV-273943 - Enable runtimeApi.event dtest
Add device_id_ in hip::event to match cuda behaviour in
hipEventQuery() and hipEventRecord().
Enable hipEventElapsedTime test on AMD platform.
Workarround sporadic crash of hipEventIpc test due to
some bug of event ipc.
Add missing hipEventDestroy() in some event tests.
Fix some logic code errors.
Fix typo in comment.

Change-Id: I9ec74c475161b3e31df48d193449023e921f2924
2021-03-16 17:12:08 -04:00
Vladislav Sytchenko 82e40a6438 SWDEV-275317 - Correctly pass HIP image width to ROCclr APIs in AtoD/DtoA copies
HIP assumes that image width is in bytes, but OCL/ROCclr assumes that
it's in pixels. AtoD/DtoA need to account for this.

Change-Id: I275bd41d8b03e141caaf951bc6b714e51ca72dfc
2021-03-15 21:09:58 -04:00
Payam 2e52ceca29 SWDEV-182753 - Throw error if launch params>bounds
Change-Id: I5f9931efac37e3149894ca116a1b0c2dcc3e5bc5
2021-03-12 19:17:08 -05:00
Rahul Garg cc17122987 SWDEV-270599 - hipExtLaunchKernelGGL Event Timing Incorrect Between Two Launches
Change-Id: I599a51720f297209072c6be8fffe2aa61e1a071e
2021-03-09 12:18:39 -05:00
Satyanvesh Dittakavi daafd303ec SWDEV-275317 - Fix hipMemcpy2DFromArray to return proper error types
Change-Id: Id722865d81460bfd2fa6ad7a198b6e3c2a08265a
2021-03-09 05:22:23 -05:00
German Andryeyev e48111bfce SWDEV-272496 - enqueue a marker for callbacks always
The current implementation in ROCclr for callback is
based on OCL specification. If in HIP the same command
could get multiple callbacks, then ROCclr will process them in
a reverse order. Unique Markers for each callback will make
sure it won't happen.
Add a dependency wait for callbacks, since HSA signal callback
doesn't guarantee the order.

Change-Id: I9d514734e258312fe9a74d48132361eb17c52d67
2021-03-08 14:19:53 -05:00
Sarbojit Sarkar 95b2ad994c SWDEV-254329 - Profiler ON/OFF fix
Change-Id: I996d185d2079ce68234109564a529a187ba4f04b
2021-03-08 01:27:46 -05:00
Arya.Rafii 8cb232ddef SWDEV-269246 - Implementation of hipDrvMemcpy2DUnaligned
Change-Id: I86fdd3b930cbd74c45cd31944f0ea52c0ff65a59
2021-03-04 14:38:06 -05:00
Arya.Rafii 9f142f988d SWDEV-269246 - Added missing exports for hipArrayDestroy
Change-Id: I730814720bb618e895efbe2f412e437110bed8bc
2021-03-04 14:29:16 -05:00
kjayapra-amd 8ef68df3a8 SWDEV-259566 - Adding support to retrieve handle for offsetted pointer.
Change-Id: I5da5ab6a24c6df915950637feb486b8c288e60e0
2021-03-04 12:28:56 -05:00
German Andryeyev b0402a95bf SWDEV-272496 - Delay enqueue until callback setup
With direct dispatch enqueue occurs before callback update and
it can't be tracked in the device backend

Change-Id: Ie8793e3ddb68cc5bb36348f7a8dcdbdc87a2487c
2021-03-03 13:14:28 -05:00
Ravi C Akkenapally fd0f49503f SWDEV-179105 - Stream Operations: Add swqupport for Wait and Write
Change-Id: I9d6d0665d12b62fe705ce1569a0e8264a4f23ab7
2021-03-02 12:15:46 -08:00
Tao Sang 4048db950c SWDEV-270973 - Add missing copyright headers
Change-Id: I6bb27650f74372dae6e29c79fd6bb2022cc062fe
2021-03-01 19:46:24 -05:00
Jatin Chaudhary ec832d42d1 SWDEV-272361 - Dont call memcpy2d if width is 0 or height or depth is 0
Change-Id: I22324a536d2a5e68b9fc3e5ee4ad821b49021a17
2021-03-01 14:34:58 -05:00
cjatin 564417d00f SWDEV-271274 - Changing DevLogPrintf to LogPrintf for cases where error condition is being returned
Change-Id: I153d071f7859e9412ea0c69f53c53d190453d73d
2021-03-01 14:33:46 -05:00
Ashutosh Mishra b9c0065e4f SWDEV-271126 - Memory obtained from getDeviceMEmory can be NULL
which can cause segmentation faults. Hence checking for its sanity

Signed-off-by: Ashutosh Mishra <ashutosh.mishra@amd.com>
Change-Id: I78b4d029f0926a1369a8ebbeb4aef951a8f1f1d7
2021-02-26 23:29:53 -05:00
Payam 5b7dd3a4b9 SWDEV-273405 - updated roctracer path to use env var
Change-Id: I9ec74c475161a3e310f57d193449023e921f2922
2021-02-26 14:51:26 -05:00
cjatin 41d7c688c9 SWDEV-273859 - Add --hip-version to comgr call
Change-Id: Iae6c1a5e958a73f5d9849c13c8b49eede914e25e
2021-02-24 23:41:34 -05:00
Arya.Rafii 5c2eb09624 SWDEV-269246 - Fixed null-case logic for hipCtxPopCurrent
Change-Id: Ic173980caccde8afee85a75c55a5d536f421549e
2021-02-24 13:20:24 -05:00
kjayapra-amd 20dd93a3be SWDEV-274058 - Porting HIP, ROCclr gfx90a changes to mainline.
Change-Id: I02f53d4c7897d26243620cfc961fa9bd984cede4
2021-02-24 09:55:43 -05:00
German Andryeyev fe7501a64b SWDEV-272496 - Add marker if notification was the last command.
If MT is enabled, then a new callback can be received before the previous
command is processed, causing a conflict of 2 callbacks.

Change-Id: I5ff8f231208e8d62824d590d3c8e791e8e36affb
2021-02-23 13:12:06 -05:00
Vladislav Sytchenko be3c5183b2 SWDEV-255979 - Fix Windows build
Change-Id: I1f1375911d90ded9043a4716e7d09a3ca6a33c23
2021-02-19 11:31:52 -05:00
agodavar d5b4762d96 SWDEV-255979 - Added support of __managed__ static variable
Change-Id: I9d5cbbecc8c19ec38a95c94ab4130465ba76c102
2021-02-17 13:01:29 -05:00
Satyanvesh Dittakavi d721c79f36 SWDEV-272543 - Fix hipDeviceGetP2PAttribute when both devices are same
Change-Id: I3db17a962807565ea134e3cbcefa66d373e2d363
2021-02-17 12:41:59 -05:00
Rahul Garg 607795ec9d SWDEV-271182 - Fix HdpMemFlushCntl and HdpMemFlushCntl
Change-Id: I33e5a677c6c6e1d83e6343f8e3690d7b34fe2af5
2021-02-12 14:38:56 -05:00
Sarbojit Sarkar 3f5fb8e9df SWDEV-270630 - Added missing nullcheck
Change-Id: I7caf26c59c4660e26b4159da35731c2ce1600819
2021-02-12 13:29:30 -05:00
Sarbojit Sarkar b7fd0bc902 SWDEV-271496 - Added missing params check
Change-Id: I17bbf5ed445826e7380df22fa5c6ec1675e208d6
2021-02-12 13:28:12 -05:00
Vladislav Sytchenko 9f84ea96be SWDEV-252745 - Guard PCH code behind __HIP_ENABLE_PCH macro
Change-Id: I12425b9d44b3d92f9cacceb797a5d09d99e4156b
2021-02-10 09:23:41 -08:00
Zack Galbreath ddb061cecf SWDEV-264220 - Provide CMake hip language configuration information
This provides the required information for CMake to bootstrap
HIP language and runtime support. In particular this file
is consumed by CMake during HIP compiler detection to
determine the required flags needed for compilation and
linking.

Initial design was discussed in #2158

Add copyright / license header

Change-Id: I10acb860bf6291b2deb6b678e6e916faa7c82c2a
2021-02-10 08:26:35 -05:00
cjatin caf9b2b108 SWDEV-252745 - Adding rtc options transformer
Change-Id: Ib250689906a35f81255398e53da979774361dbfa
2021-02-09 13:35:30 -05:00
agodavar 8f85d89812 SWDEV-271096 - Handle depth zero in hipMalloc3D
Change-Id: I0ef0cc825e20b3480e9e5476e09dde5f73cdd3ea
2021-02-09 08:39:44 -05:00
Jatin Chaudhary 7b6244b641 SWDEV-271274 - Remove hip init call from hipUnregisterBinary, this call ends up initializing rocclr and hsa even when there is no hip call in the entire file
Change-Id: I20c1d3079c6032d79c5b892d5616921f7aeb4fe2
2021-02-09 07:59:32 -05:00
agodavar eb58a0285c SWDEV-269085 - Add support for build with ADDRESS_SANITIZER
Change-Id: I102cbe197727ec059d3dc9fae3a41bb559b0dff1
2021-01-29 01:54:43 -05:00
Vladislav Sytchenko f174d98893 SWDEV-1 - Fix Windows build
Change-Id: I20c727a8718941694da6dc024efdfd1eb6af828b
2021-01-28 10:22:25 -05:00
agodavar 160f0edffa SWDEV-269400 - handle nullptr in hipFuncGetAttributes and blockSizeLimit<0 in hipModuleOccupancyMaxPotentialBlockSize
Change-Id: Ia1c6e5713f40876b4a9c7a1c56b7b3a589c4497a
2021-01-27 23:41:31 -05:00
agodavar 2d2f127b8a SWDEV-268552 - HIP sample segfaults during hipModuleLoad, fix mmap bug
Change-Id: I51c6061e7ac6b2524586d96fdd69b9f084b1906a
2021-01-27 23:39:50 -05:00
Rahul Garg fecaab1179 SWDEV-270166 - Remove Linux specific includes
Change-Id: I929285941f28941cb41718f9fb8f618d11f1a69b
2021-01-27 12:10:37 -05:00
agodavar a16d91a708 SWDEV-267154 - Add checks for grid and block dimensions 0
Change-Id: I54799c0a4a42a91f6226f94a1e3ff7bc79046a98
2021-01-27 00:32:31 -05:00
Vladislav Sytchenko 09c28dcbf4 SWDEV-1 - Fix Windows build
Change-Id: I144142b2b31785fe7b1d319fb7e88eb2b41099ac
2021-01-26 15:51:57 -05:00
Joseph Greathouse 51e53b6b56 SWDEV-269756 - Add missing Cooperative Groups error string
Change-Id: I1833f8bb4b48b19bb3d6cac57dda429231cf3562
2021-01-22 15:48:18 -06:00
Tony Tye 6b641fb368 SWDEV-268864 - Use new isa class to access isa related information (part 2)
Change-Id: If7ed535b3012aec3f2cb4eb7ab93d8f5aed9783f
2021-01-19 03:36:22 +00:00