Commit Graph

6008 Commits

Author SHA1 Message Date
Rahul Garg 8c5e5e435b Fix hipMemcpy3D (#1798)
Fixes #1790 and #1791. hipMemcpy3D still requires further refactoring for different input and output combinations.
2020-02-17 19:35:35 +05:30
Payam Ghafari a719e355d5 Merge "updated hipcc to include HSA path for clang builds as well" into amd-master-next 2020-02-17 02:01:37 -05:00
Maneesh Gupta 854afef281 [dtests] Fix random timeout failures in hipModuleLoadDataMultThreaded (#1877)
Limit the max threads that are launched to 16.
2020-02-17 11:16:20 +05:30
Tao Sang b3f445c0f5 Temporarily comment out Hcc-specific APIs for CLang compiler
Temporarily comment out Hcc-specific template functions
hipExtLaunchKernelGGL and hipOccupancyMaxPotentialBlockSize for CLang
compiler so that all test cases under hip/samples can be built
successfully for Clang + Hip/Hcc runtime.

Change-Id: Iafc761257be4a7b34eafa6759a01f369570cd6ce
2020-02-16 22:26:47 -05:00
Tao Sang 30da92e2af Fix bug of hip/samples/0_Intro/hcc_dialects/vadd_hip
For hipLaunchKernelGGL(), hmod->kernargs is empty, thus we need
insert hmod->kernargs[name_str] which is empty.

Change-Id: I95f818d0525da84452e66c5778f0648a643843c7
2020-02-16 17:58:04 -05:00
Payam 28d8a38c0e updated package generation and removed hiphcc_static as a target for hip-vdi
Change-Id: I0067dd6341f47a212cb02b8d43d3ea01644c2391
2020-02-16 03:00:59 -05:00
Tao Sang 9a005eacf3 Support defaultDriver test with Clang+Hcc Runtime
Fix the following issues:
1.Ignore hidden arguments of kernel functions.
2.Look up both origial function name and function name with .kd postfix
when argments are retrived from module.
3.Addition, fix compiling issue of LaunchKernel test app.

Change-Id: I9400943f2f02433cb4409b19c0cac3626c2bc454
2020-02-15 19:29:13 -05:00
vsytch 56b8b0d80e Add missing __hip_pinned_shadow__ attributes to the texture global vars. (#1866) 2020-02-15 09:52:25 +05:30
Maneesh Gupta e7120dd876 Use deque instead of vector for code readers so that the iterators and references will be stable (#1851)
* Use deque instead of vector for code readers so that the iterators and references will be stable

* Fix compile error

* Assign the iterator

* Add multithreaded test

* Make threads a multiple of hardware concurrency

* Output on failure

* Add setDevice to try and initialize the context on cuda

* Create context for cuda

* Set context on each thread

* Reduce threads on cuda

* Skip test on cuda

* Try to initialize the primary context on cuda

* Push ctx to the stack as current

* Revert "Push ctx to the stack as current"

This reverts commit bff8cbe950.

* Revert "Try to initialize the primary context on cuda"

This reverts commit fd98514113.

* updated test for nvidia path

* Add c++11 option for nvcc

Co-authored-by: satyanveshd <53337087+satyanveshd@users.noreply.github.com>
2020-02-15 09:51:24 +05:30
Nick Curtis 797a929a65 Implement long / long long shuffles (#1829)
Implement additional data-types for shuffles (long and long long).
Based upon the double implementation.
2020-02-15 09:51:09 +05:30
Siu Chi Chan f2ab87d872 Disabling HCC code object v3 generation by default.
Some PyTorch unit tests have regression.  Disabling cov3 to allow more
time to debug and unblock PyTorch

Change-Id: Iba7f425ef3499c20c42ec45d9152b5d27ce97d03
2020-02-14 19:39:27 -05:00
Evgeny Mankov 9a9319c8e7 Merge pull request #1870 from emankov/HIP
[HIPIFY][doc] Update README.md: LLVM 10.0.0-rc2 - the latest supported LLVM Release
2020-02-14 13:25:43 +03:00
Evgeny Mankov 115f45d116 [HIPIFY][doc] Update README.md: LLVM 10.0.0-rc2 - the latest supported LLVM Release 2020-02-14 13:09:31 +03:00
Rahul Garg 9d97f91fbb [sample] Add hipDispatchEnqueueRateMT (#1869)
* [sample] Add hipDispatchEnqueueRateMT
2020-02-13 23:21:40 -08:00
Payam fabe62e31f removing oocupancy tests from hip-vdi for now
Change-Id: I06e966d07021af87fa2c195e4bbaf6bcc336658d
2020-02-13 21:40:06 -05:00
Christophe Paquot f2eb8ec26c Merge "hipLaunchByPtr and hipLaunchKernel deviceId potential issue" into amd-master-next 2020-02-13 18:49:06 -05:00
Payam b95968187b updated hipcc to include HSA path for clang builds as well
Change-Id: Icaaa68fdbe79fb16e4e9fedd420460f1479d7fe0
2020-02-13 16:48:24 -05:00
Christophe Paquot 1d4bb503ae SWDEV-222949 - hipEventRecord
hipEventRecord should always create a new marker so it can track work going on at the time the API is called.

Change-Id: I10ce98044be894fbacab8798441ec3d3f2753b93
2020-02-13 15:01:49 -05:00
Christophe Paquot cc63d2d7b8 hipLaunchByPtr and hipLaunchKernel deviceId potential issue
Those APIs should look at the device associated with the stream first.
If that stream is null then get the current device ID.

Change-Id: Iedde1d1644818ba64f128b988f0bd9674f5b8ad6
2020-02-13 12:00:30 -08:00
Tao Sang f456989339 Merge "Support app(hcc compiled/Hip-Vdi runtime linked)" into amd-master-next 2020-02-13 14:25:30 -05:00
Evgeny Mankov 5f2438a6c6 Merge pull request #1867 from emankov/HIP
[HIPIFY][doc] Update README.md: Windows tested configurations
2020-02-13 18:48:38 +03:00
Evgeny Mankov 084b2fa0f6 [HIPIFY][doc] Update README.md: Windows tested configurations 2020-02-13 18:34:10 +03:00
Aaron Enye Shi 85b6905871 HIP-VDI fix CPACK packaging dependencies
Change-Id: I64d803499dd8b2fc80b1320f71115ebaf019a9e7
2020-02-13 10:02:49 -05:00
Satyanvesh Dittakavi 3fb4135946 Add c++11 option for nvcc 2020-02-13 19:48:26 +05:30
Satyanvesh Dittakavi ead254cdd5 updated test for nvidia path 2020-02-13 16:34:05 +05:30
Jeff Daily 03bb658721 missing break statement in hipDeviceGetAttribute (#1865)
The break is missing for hipDeviceAttributeMaxTexture3DDepth.
2020-02-13 14:22:56 +05:30
Sarbojit2019 1109cbff83 [hip] Fix for bug introduced in #1770 when blockSize is non-power of 2 (#1864)
Fixes SWDEV-222161
2020-02-13 14:22:46 +05:30
Sarbojit2019 fc5256fd28 ihipEnablePeerAccess return error if peer is not accessible (#1858)
hipDeviceEnablePeerAccess returns success and adds peer into the list even if it is not accessible which creates problem in hipMalloc when it tries to share the ptr to peer device.
Proposed change is to check the access status before updating the peer list and update only when it can access the peer.
2020-02-13 14:22:11 +05:30
ansurya 8c6934223b Reduce GPU copying based on arch it runs on (#1751)
Implements SWDEV-213230.
2020-02-13 14:21:51 +05:30
Tao Sang 2699b566cc Support app(hcc compiled/Hip-Vdi runtime linked)
The issues of the following functions have been fixed.
hipModuleLoad: Make Hip-Vdi runtime able to read code object module
generated by Hcc compiler.
hipLaunchKernel: Use introspect method to find function if it cannot
be found from platform state instance.

Change-Id: Id740e5a96614ec6a0b6c704f8f74600bfdc4983e
2020-02-12 16:42:54 -05:00
Laurent Morichetti ba0674f0a6 Remove cl_icd.cpp from the build.
We should be using the temporary fixme.cpp instead.

Change-Id: I7e7a04bb518f56584c41bdb46a9192bde1f70060
2020-02-12 10:46:33 -08:00
Evgeny Mankov 2536a3093d Merge pull request #1830 from asalmanp/coop_flag_define
[HIP][HIPIFY] Add some missing flags for cooperative launch and occup…
2020-02-12 14:07:39 +03:00
Mark Searles f2c1a4d827 Change 2068543 by michliao@hliao-dev-11-hip-workspace on 2020/02/10 10:04:50
SWDEV-125823 - Fix the build issue due to API interface change.

        - PR#1625 is temporarily reverted. Revert CL#2064519 correspondingly.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#61 edit

Change-Id: I519b11532d7e6fe8cbee41804155cc9ca64e596c
2020-02-12 00:22:48 -08:00
Laurent Morichetti 2cf3257795 Merge branch 'master' into amd-master-next
Change-Id: Ibb7775e7acd263d2ece40a241517bbd15976fdd4
2020-02-12 00:14:07 -08:00
Paul 26bb6a97a7 Revert "Try to initialize the primary context on cuda"
This reverts commit fd98514113.
2020-02-11 12:34:11 -06:00
Paul e82e3c2339 Revert "Push ctx to the stack as current"
This reverts commit bff8cbe950.
2020-02-11 12:34:10 -06:00
Paul bff8cbe950 Push ctx to the stack as current 2020-02-11 11:46:29 -06:00
Paul fd98514113 Try to initialize the primary context on cuda 2020-02-11 11:26:24 -06:00
Aryan Salmanpour 959f1b0f0e fix build error in nvcc path 2020-02-11 12:16:51 -05:00
Jatin Chaudhary ab7526f64c Revert "Sync hip-targets*.cmake in package with install changes (#1831)" (#1860)
Fixes SWDEV-222155 & SWDEV-222158
This reverts commit 6891615a15.
2020-02-11 11:56:57 +05:30
Paul b9f97ec3fe Skip test on cuda 2020-02-10 17:23:58 -06:00
Paul 30e8dfdd86 Reduce threads on cuda 2020-02-10 16:37:34 -06:00
Paul 2d9a2d866c Set context on each thread 2020-02-10 16:01:53 -06:00
Christophe Paquot 6462732e49 SWDEV-220533 - HostMapped should use fine grained.
Change-Id: I4ad2064e8e5ea1cd4ed7df143c778ccb685c4f22
2020-02-10 16:53:06 -05:00
Paul e5d077f70e Create context for cuda 2020-02-10 15:52:34 -06:00
Paul 29a257d79b Add setDevice to try and initialize the context on cuda 2020-02-10 13:37:45 -06:00
Payam Ghafari b66451e000 Merge "Excluding vdi platform for now from the following tests so we can build" into amd-master-next 2020-02-10 14:28:44 -05:00
Aryan Salmanpour 5a29f27455 Fix a typo causing a build error 2020-02-10 11:44:40 -05:00
Aryan Salmanpour 874b201ee2 resolve merge conflict 2020-02-10 10:30:55 -05:00
Maneesh Gupta 6614ae33e0 gedit/hip.lang does not need a seperate license 2020-02-10 16:27:20 +05:30