Commit Graph

64643 Commits

Author SHA1 Message Date
Madsen, Jonathan 14c2dc55ff [roctx] Python bindings for rocprofiler-sdk-roctx (#402)
* [roctx] Python bindings for rocprofiler-sdk-roctx

* Update CHANGELOG

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-05-19 20:02:51 -05:00
Kudchadker, Saleel ee7c5554db SWDEV-523279 - Use preferred engine mask for SDMA (#317)
- ROCr now reports preferred engine for copy status. We can leverage
this for max bandwidth for inter-GPU copies
- Cleanup logging

[ROCm/clr commit: 1b0ea080e4]
2025-05-19 16:04:51 -07:00
Kudchadker, Saleel 1b0ea080e4 SWDEV-523279 - Use preferred engine mask for SDMA (#317)
- ROCr now reports preferred engine for copy status. We can leverage
this for max bandwidth for inter-GPU copies
- Cleanup logging
2025-05-19 16:04:51 -07:00
Deshpande, Chinmay Diwakar 1dc47d1a67 SWDEV-532676 - Pass hip-path instead of rocm-path (#182)
* SWDEV-532676 - Pass hip-path instead of rocm-path

Commit 7b7537c1703db0cc53ee1f36089406b555ae9a9e in llvm-project enforces that no hip-device-lib-path is forwarded by hipcc. To ensure that runtime is found, pass hip-path instead.

* SWDEV-532676 - Fix comment

Co-authored-by: Lambert, Jacob <Jacob.Lambert@amd.com>

---------

Co-authored-by: Lambert, Jacob <Jacob.Lambert@amd.com>

[ROCm/hip-tests commit: 65158bc9f1]
2025-05-19 13:26:03 -07:00
Deshpande, Chinmay Diwakar 65158bc9f1 SWDEV-532676 - Pass hip-path instead of rocm-path (#182)
* SWDEV-532676 - Pass hip-path instead of rocm-path

Commit 7b7537c1703db0cc53ee1f36089406b555ae9a9e in llvm-project enforces that no hip-device-lib-path is forwarded by hipcc. To ensure that runtime is found, pass hip-path instead.

* SWDEV-532676 - Fix comment

Co-authored-by: Lambert, Jacob <Jacob.Lambert@amd.com>

---------

Co-authored-by: Lambert, Jacob <Jacob.Lambert@amd.com>
2025-05-19 13:26:03 -07:00
Kudchadker, Saleel 5fd5e846e2 SWDEV-531518 - Fix offset accumulation (#333)
srcAddress/dstAddress accumulation was cumulative, which shouldnt be
done if we increment offset.

[ROCm/clr commit: 5712944c7c]
2025-05-19 18:03:06 +05:30
Kudchadker, Saleel 5712944c7c SWDEV-531518 - Fix offset accumulation (#333)
srcAddress/dstAddress accumulation was cumulative, which shouldnt be
done if we increment offset.
2025-05-19 18:03:06 +05:30
Jayaprakash, Karthik f4c9056cdc Revert "SWDEV-522707 - Set phys_mem_handle type to sizeof(size_t) to avoid blocking address range. (#105)" (#348)
This reverts commit 0071d33754.

[ROCm/clr commit: bb7750a946]
2025-05-19 15:19:16 +05:30
Jayaprakash, Karthik bb7750a946 Revert "SWDEV-522707 - Set phys_mem_handle type to sizeof(size_t) to avoid blocking address range. (#105)" (#348)
This reverts commit 6811fd90b8.
2025-05-19 15:19:16 +05:30
Dittakavi, Satyanvesh fd7786f846 SWDEV-1 - Fix hip on nvidia psdb failures (#185)
[ROCm/hip-tests commit: 1da044b273]
2025-05-19 15:18:27 +05:30
Dittakavi, Satyanvesh 1da044b273 SWDEV-1 - Fix hip on nvidia psdb failures (#185) 2025-05-19 15:18:27 +05:30
Trowbridge, Ian 8721c866a1 Use Internal Correlation ID values for Kernel Rename Feature (#397)
* Updated kernel rename service to use internal correaltion IDs for external correlation IDs and kernel rename values

* Updated for review comments

* Changed if-condition in generateJSON.cpp to check if string view is empty before calling get_entry

[ROCm/rocprofiler-sdk commit: afb27f3f1a]
2025-05-19 01:34:44 -05:00
Trowbridge, Ian afb27f3f1a Use Internal Correlation ID values for Kernel Rename Feature (#397)
* Updated kernel rename service to use internal correaltion IDs for external correlation IDs and kernel rename values

* Updated for review comments

* Changed if-condition in generateJSON.cpp to check if string view is empty before calling get_entry
2025-05-19 01:34:44 -05:00
Madsen, Jonathan b097e276a9 [rocprofv3] Add rocpd output support (part 1: prelude) (#401)
* [rocprofv3] Add rocpd output support (part 1: prelude)

- git submodules for sqlite3, GOTCHA, and pybind11
- HIP stream data
- rocprofiler_query_intercept_table_name(...)
- serialization load
- rocprofiler::sdk::get_perfetto_category(KindT)
- rocprofiler::sdk::parse::strip
- common library updates
  - md5sum
  - hasher
  - simple_timer
  - static_tl_object
  - get_process_start_time_ns(pid_t)
- output library updates
  - node_info
  - file_generator (generator is now virtual base class)
  - stream info updates

* Added submodules

* Code review updates

* Minor unused-but-set-X warning fixes

* Update CI

- install libsqlite3-dev package

* Update CI

- install libsqlite3-dev package

* Fix static thread-local object memory leak

- also fix signal handler chaining

* Remove URL from comment

* Remove page migration exception

* Enable ROCPROFILER_BUILD_SQLITE3 by default

- try find_package(SQLite3) first and then build when ROCPROFILER_BUILD_SQLITE3=ON

* Fix gotcha installation

- make install of target optional

* Validate tracing + counter collection dispatch data

- i.e. correlation ids, thread ids, timestamps

* Make find_package(SQLite3) optional

- ROCm CI does not have SQLite3 dev package installed and cannot build from source (missing tclsh)

* Fixes to tracing + counter collection test

* get_process_start_time_ns update

- original implementation did not work

* Fix pytest-packages test_perfetto_data for counter collection

- erroneous failure when used with same PMC + multiple agents

* cmake policy: option() honors normal variables

- for GOTCHA submodule

* Improve samples/api_buffered_tracing stability

- reduce likelihood of sporadic exception throw

* Update gotcha submodule

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 7166b1ab58]
2025-05-18 20:11:26 -05:00
Madsen, Jonathan 7166b1ab58 [rocprofv3] Add rocpd output support (part 1: prelude) (#401)
* [rocprofv3] Add rocpd output support (part 1: prelude)

- git submodules for sqlite3, GOTCHA, and pybind11
- HIP stream data
- rocprofiler_query_intercept_table_name(...)
- serialization load
- rocprofiler::sdk::get_perfetto_category(KindT)
- rocprofiler::sdk::parse::strip
- common library updates
  - md5sum
  - hasher
  - simple_timer
  - static_tl_object
  - get_process_start_time_ns(pid_t)
- output library updates
  - node_info
  - file_generator (generator is now virtual base class)
  - stream info updates

* Added submodules

* Code review updates

* Minor unused-but-set-X warning fixes

* Update CI

- install libsqlite3-dev package

* Update CI

- install libsqlite3-dev package

* Fix static thread-local object memory leak

- also fix signal handler chaining

* Remove URL from comment

* Remove page migration exception

* Enable ROCPROFILER_BUILD_SQLITE3 by default

- try find_package(SQLite3) first and then build when ROCPROFILER_BUILD_SQLITE3=ON

* Fix gotcha installation

- make install of target optional

* Validate tracing + counter collection dispatch data

- i.e. correlation ids, thread ids, timestamps

* Make find_package(SQLite3) optional

- ROCm CI does not have SQLite3 dev package installed and cannot build from source (missing tclsh)

* Fixes to tracing + counter collection test

* get_process_start_time_ns update

- original implementation did not work

* Fix pytest-packages test_perfetto_data for counter collection

- erroneous failure when used with same PMC + multiple agents

* cmake policy: option() honors normal variables

- for GOTCHA submodule

* Improve samples/api_buffered_tracing stability

- reduce likelihood of sporadic exception throw

* Update gotcha submodule

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-05-18 20:11:26 -05:00
Arif, Maisam a2443a5efe Revert "Correct the dependencies of rocm_smi package."
This reverts commit 93ff9b3547.


[ROCm/rocm_smi_lib commit: 40671be7c9]
2025-05-18 10:34:28 -05:00
Arif, Maisam 40671be7c9 Revert "Correct the dependencies of rocm_smi package."
This reverts commit 6d53d9f9cf.
2025-05-18 10:34:28 -05:00
Arif, Maisam a9ddb0dcea Revert "Use devel in RPM package requires field"
This reverts commit 22777b75b5.


[ROCm/rocm_smi_lib commit: a0ad4a3fcd]
2025-05-18 10:34:28 -05:00
Arif, Maisam a0ad4a3fcd Revert "Use devel in RPM package requires field"
This reverts commit cea68cd940.
2025-05-18 10:34:28 -05:00
Arif, Maisam afc87ee2f8 Revert "Use the alphabetic 'or' in the CPack RPM package Requires field."
This reverts commit edd6134d16.


[ROCm/rocm_smi_lib commit: c7797b19a3]
2025-05-18 10:32:12 -05:00
Arif, Maisam c7797b19a3 Revert "Use the alphabetic 'or' in the CPack RPM package Requires field."
This reverts commit 4d201ad2c2.
2025-05-18 10:32:12 -05:00
Baraldi, Giovanni 682b9967e0 [RSERP-1802] Add trace decoder to API (#398)
* Add trace decoder to API.

* Cleanup and activity

* Rename

* Minor fix

* Replace tt/TT with thread_trace/THREAD_TRACE

- public API types are not abbreviated

* Fix aliases

* Build system updates

- activate clang-tidy for all subfolders in lib
- fix addition of sources for att-tool

* Fix clang-tidy issues with lib/att-tool/counters.{hpp,cpp}

* Delete counters.cpp

* Formatting

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 65786f619d]
2025-05-17 12:08:33 -07:00
Baraldi, Giovanni 65786f619d [RSERP-1802] Add trace decoder to API (#398)
* Add trace decoder to API.

* Cleanup and activity

* Rename

* Minor fix

* Replace tt/TT with thread_trace/THREAD_TRACE

- public API types are not abbreviated

* Fix aliases

* Build system updates

- activate clang-tidy for all subfolders in lib
- fix addition of sources for att-tool

* Fix clang-tidy issues with lib/att-tool/counters.{hpp,cpp}

* Delete counters.cpp

* Formatting

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-05-17 12:08:33 -07:00
Jayaprakash, Karthik 4ea2d9a5ee SWDEV-531711 - Report correct error code based on device failure. (#286)
[ROCm/clr commit: f5b8db33f1]
2025-05-17 06:33:13 -04:00
Jayaprakash, Karthik f5b8db33f1 SWDEV-531711 - Report correct error code based on device failure. (#286) 2025-05-17 06:33:13 -04:00
Ben Richard 4899cfa160 Update illegal character check for profile name (#703)
[ROCm/rocprofiler-compute commit: 41dd4aab90]
2025-05-16 15:45:16 -04:00
Ben Richard 41dd4aab90 Update illegal character check for profile name (#703) 2025-05-16 15:45:16 -04:00
cfallows-amd 72af81c528 Check mode during soc init for roofline (#705)
Check mode before creating roofline object- skip if only printing specs

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 43dbf38b27]
2025-05-16 12:54:53 -04:00
cfallows-amd 43dbf38b27 Check mode during soc init for roofline (#705)
Check mode before creating roofline object- skip if only printing specs

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-05-16 12:54:53 -04:00
Madsen, Jonathan 593fdf6c27 [CI] Disable page-migration tests (#396)
* Disable page-migration tests

* Account for gfx hexadecimal characters

* Update continuous integration action

- remove test exclude for test-page-migration since test is disabled at cmake level

* Fix internal ctest error

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 3eb921a34c]
2025-05-16 09:33:46 -07:00
Madsen, Jonathan 3eb921a34c [CI] Disable page-migration tests (#396)
* Disable page-migration tests

* Account for gfx hexadecimal characters

* Update continuous integration action

- remove test exclude for test-page-migration since test is disabled at cmake level

* Fix internal ctest error

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-05-16 09:33:46 -07:00
Brzak, Branislav dc39d67017 SWDEV-508742 - Make clCreatePipe spec compliant (#80)
[ROCm/clr commit: 7698d799ce]
2025-05-16 15:18:35 +05:30
Brzak, Branislav 7698d799ce SWDEV-508742 - Make clCreatePipe spec compliant (#80) 2025-05-16 15:18:35 +05:30
David Galiffi 909602e1f4 Update Dockerfiles (#207)
Add chrpath to dockerfiles

[ROCm/rocprofiler-systems commit: fc08d56fb4]
2025-05-15 21:06:12 -04:00
David Galiffi fc08d56fb4 Update Dockerfiles (#207)
Add chrpath to dockerfiles
2025-05-15 21:06:12 -04:00
Ranjith Ramakrishnan edd6134d16 Use the alphabetic 'or' in the CPack RPM package Requires field.
Using the OR symbol "|" is causing error in cpack


[ROCm/rocm_smi_lib commit: 4d201ad2c2]
2025-05-15 15:28:26 -07:00
Ranjith Ramakrishnan 4d201ad2c2 Use the alphabetic 'or' in the CPack RPM package Requires field.
Using the OR symbol "|" is causing error in cpack
2025-05-15 15:28:26 -07:00
Castillo, Juan 08062c0577 Fix WARNING: AMD GPUs visible, but data is inaccessible (#58)
* [SWDEV-531834] Fix AMD GPUs visible, but data is inaccessible:
- Scans directories under /sys/bus/pci/drivers/amdgpu
- Verifies each device's runtime_status to determine if it's active
- Returns False if any device is not in active state
- Handles permission errors gracefully with proper debug logging
- Includes comments explaining behavior differences between Instinct / NAVI hardware

The default status is set to True, assuming devices are active unless
proven otherwise, which accommodates hardware like some Instinct ASICS
which do not support runtime power management.

Signed-off-by: Juan Castillo <juan.castillo@amd.com>

[ROCm/rocm_smi_lib commit: 47f80145cb]
2025-05-15 14:30:33 -05:00
Castillo, Juan 47f80145cb Fix WARNING: AMD GPUs visible, but data is inaccessible (#58)
* [SWDEV-531834] Fix AMD GPUs visible, but data is inaccessible:
- Scans directories under /sys/bus/pci/drivers/amdgpu
- Verifies each device's runtime_status to determine if it's active
- Returns False if any device is not in active state
- Handles permission errors gracefully with proper debug logging
- Includes comments explaining behavior differences between Instinct / NAVI hardware

The default status is set to True, assuming devices are active unless
proven otherwise, which accommodates hardware like some Instinct ASICS
which do not support runtime power management.

Signed-off-by: Juan Castillo <juan.castillo@amd.com>
2025-05-15 14:30:33 -05:00
Jayaprakash, Karthik c25250e68b SWDEV-529929 - Adding hipMemRangeHandleType datatype. (#73)
[ROCm/hip commit: d50cd1dcc7]
2025-05-15 14:58:24 -04:00
Jayaprakash, Karthik d50cd1dcc7 SWDEV-529929 - Adding hipMemRangeHandleType datatype. (#73) 2025-05-15 14:58:24 -04:00
vedithal-amd 5d03532296 Fix MI350 tests (#706)
- TCC counter collection tests are still failing due to recent
  rocprofiler-sdk change

[ROCm/rocprofiler-compute commit: 7b755fcd86]
2025-05-15 13:37:55 -04:00
vedithal-amd 7b755fcd86 Fix MI350 tests (#706)
- TCC counter collection tests are still failing due to recent
  rocprofiler-sdk change
2025-05-15 13:37:55 -04:00
Pranjal Swarup 3fa24a0012 ROCPROFSYS_AMD_SMI_METRICS visibility (#208)
* Removed advanced category from ROCPROFSYS_AMD_SMI_METRICS to have this property visible with rocprof-sys-avail.

[ROCm/rocprofiler-systems commit: 4c7560c78c]
2025-05-15 13:31:40 -04:00
Pranjal Swarup 4c7560c78c ROCPROFSYS_AMD_SMI_METRICS visibility (#208)
* Removed advanced category from ROCPROFSYS_AMD_SMI_METRICS to have this property visible with rocprof-sys-avail.
2025-05-15 13:31:40 -04:00
Vignesh Edithal 93e36e5491 Add James Siddley to code reviewers
[ROCm/rocprofiler-compute commit: 6522fe954b]
2025-05-15 12:14:39 -04:00
Vignesh Edithal 6522fe954b Add James Siddley to code reviewers 2025-05-15 12:14:39 -04:00
Belton-Schure, Aidan c04355bbe3 Add __syncwarp operation (#160)
Change-Id: I6a3783beafdbb9f11a3b37333f4ff3f5be27ea54

[ROCm/clr commit: c50610b44d]
2025-05-15 14:20:13 +05:30
Belton-Schure, Aidan c50610b44d Add __syncwarp operation (#160)
Change-Id: I6a3783beafdbb9f11a3b37333f4ff3f5be27ea54
2025-05-15 14:20:13 +05:30
Patel, Jaydeepkumar 7b6e59cbea SWDEV-530803 - User current device id while cloning graph node. (#313)
[ROCm/clr commit: 32eb6a5d89]
2025-05-15 09:06:15 +05:30