Commit Graph

993 Commits

Author SHA1 Message Date
Jeff Daily dcd73a1a87 hipModuleUnload should remove global variables from memtracker (#1464)
[ROCm/hip commit: 56f67e5e36]
2019-09-30 10:41:20 +05:30
Sarbojit2019 7f7a5a3712 [HIP] Add tccDriver info in hipDeviceProp
Fixes #1433.

[ROCm/hip commit: 0fa42af08c]
2019-09-26 13:53:33 +05:30
satyanveshd fe1fae3ec2 Fix checks in hipMemcpy[D/H]to[D/H]() (#1397)
* SWDEV-202043 hipMemcpyDtoD() issue


[ROCm/hip commit: cfbd0e77fe]
2019-09-16 08:32:38 +00:00
ansurya b5549f4397 Added new device attributes (#1377)
* Added new device attributes

* updated comment

* updated with new device attributes supported


[ROCm/hip commit: ceb734b917]
2019-09-16 08:31:30 +00:00
Aryan Salmanpour 9e9a505b39 [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API (#1368)
* [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API

* fix formatting


[ROCm/hip commit: bac52d3729]
2019-09-16 08:31:17 +00:00
Rahul Garg 60adfab243 Fix typo and colon in comment
[ROCm/hip commit: f0a1f95864]
2019-09-13 03:09:01 +05:30
Rahul Garg e79f2d0ff8 [HACK] Temporary fix for hipFree for hipManagedMalloc
[ROCm/hip commit: fe47b2185c]
2019-09-13 02:10:21 +05:30
Jeff Daily 191482e1e4 fix bug where HIP_DB=1 seg faults at startup (#1388)
[ROCm/hip commit: 8384f487ad]
2019-09-05 10:04:19 +00:00
Rahul Garg 83d9c2769b Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381)
This reverts commit 7dca0455e9.

[ROCm/hip commit: 6545521d6c]
2019-09-03 05:13:46 +00:00
Sarbojit2019 73e5c52d0d Updated hipErrorString and CUDAErrorTohipError (#1365)
[ROCm/hip commit: 0722704f35]
2019-08-29 01:02:59 +00:00
Sarbojit2019 74a3171c6b [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/hip commit: 5c4f78bac3]
2019-08-29 01:02:41 +00:00
Aryan Salmanpour 0fc745b3a6 [hip] add initial implementation for hipLaunchCooperativeKernel API (#1339)
* [hip] add initial implementation for hipLaunchCooperativeKernel API

* [hip] use total number of work groups to initialize the GWS resource

* [hip] use only one argument for init_gws kernel

* [hip] use the device associated with the stream for checking the device properties


[ROCm/hip commit: 5066700ace]
2019-08-23 09:19:35 +00:00
Rahul Garg 4aa011eec6 Fix memcpy with IPC slowness (#1321)
* Fix memcpy with IPC slowness

* Make early erroneous returns

* Real Clean up

* Real Clean up++


[ROCm/hip commit: 71559200c0]
2019-08-23 09:19:18 +00:00
Jatin Chaudhary 7dca0455e9 Using HSA API for hipMemsetAsync (#1346)
[ROCm/hip commit: ac62d7a5c0]
2019-08-21 10:00:10 +00:00
Rahul Garg 74443e34ab Fix build issues seen with hip-clang path (#1331)
[ROCm/hip commit: 47b832bba7]
2019-08-16 02:13:45 +00:00
Rahul Garg a984acf245 Add hipMemcpy3DAsync (#1320)
* Add hipMemcpy3DAsync

* Fix CI build error

* Move back stream resolution to internal function

* Remove stream redefinition and check


[ROCm/hip commit: 2405621f62]
2019-08-16 02:13:16 +00:00
Rahul Garg 3c8f84a5c3 Fix undefined identifier issue for hipExtModuleLaunchKernel
[ROCm/hip commit: 3dd0e988b1]
2019-08-14 16:46:32 -04:00
Rahul Garg d42844182c Add hipMemcpyParam2DAsync (#1296)
* Add hipMemcpyParam2DAsync

* Add NVCC path changes

* Clean up

* Fix build issue

* Fix else use in both sync and async apis


[ROCm/hip commit: 45b73e0961]
2019-08-09 11:50:37 +00:00
Siu Chi Chan 83269bea32 Compile HIP runtime with hidden visibility by default (#1303)
* add default visibility to most APIs in program_state

* remove unwanted C++ headers

* Add symbol visibility pragmas and compiler flags

* Add visibility attribute to APIs in channel_descriptor and hip_hcc

* remove unused headers

* simplify build flags with hcc

* add pragma visibility hidden to functional_grid_launch

* [CMake] add gfx908 back


[ROCm/hip commit: 83af327ef2]
2019-08-08 08:33:04 +00:00
Rahul Garg d429ba57e1 Add support for hipFuncGetAttribute (#1279)
* Add support for hipFunGetAttribute

* Support NVCC path

* Test using sample module_api_global

* Try fixing CI build failure due to hip_prof_gen scan

* Fix for CI build issue

* Resolve conflict

* Rebase and resolve conflicts with master

* Fix build error

* Fix NVCC path build error


[ROCm/hip commit: 6ce86f409d]
2019-08-08 08:27:41 +00:00
Alex Voicu 4509df8151 Fix hip_throw. (#1285)
* Fix hip_throw.

* Fix typo

* No, really fix typo


[ROCm/hip commit: fbbed603ff]
2019-08-05 09:52:22 +00:00
Jeff Daily 9b44993343 consolidate thread local storage (#915)
* all thread local access now through single struct

* clean up old commented-out code, more use of GET_TLS()

* fewer calls to GET_TLS by passing tls as a funtion argument

* revert unnecessary change to printf

* fix failing tests due to TLS change

* fix merge conflicts in ihipOccupancyMaxActiveBlocksPerMultiprocessor


[ROCm/hip commit: 1eb3dbf065]
2019-08-05 09:51:02 +00:00
Maneesh Gupta ba14b149d4 Merge pull request #1278 from gargrahul/fix_hipfuncGetAttribute_logstatus
Fix missing logstatus in hipFuncGetAttributes

[ROCm/hip commit: f52245d440]
2019-08-02 10:00:38 +00:00
wkwchau b663dbc5ce Added CooperativeLaunch and CooperativeMultiDeviceLaunch flag and property for hipDeviceGetAttribute() and hipGetDeviceProperties() (#1247)
[ROCm/hip commit: aaec4f73a6]
2019-08-02 10:00:25 +00:00
Rahul Garg 8b597565c4 Fix missing logstatus in hipFuncGetAttributes
[ROCm/hip commit: 474bf0effc]
2019-08-02 11:51:34 +05:30
wkwchau c666fdaa08 Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttribu… (#1238)
* Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttributeHdpRegFlushCntl

* Added NVCC blocker for the hip*FlushCntl test cases


[ROCm/hip commit: e7447d5809]
2019-08-01 16:03:35 +00:00
Maneesh Gupta 6ae756ccfd Merge pull request #1243 from jeffdaily/master-stream-lock-fix
remove stream locks where it is safe to do so

[ROCm/hip commit: 859fb94f3d]
2019-08-01 08:59:13 +00:00
wkwchau 7676b86f12 Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOc… (#1240)
* Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags APIs

* Taking into account of SGPR usage to determine the max active blocks in hipOccupancyMaxActiveBlocksPerMultiprocessor()


[ROCm/hip commit: 4b18b321f7]
2019-08-01 08:58:48 +00:00
Maneesh Gupta ba53d3f04c Merge pull request #1269 from gargrahul/fix_ptr_attr_unkonwn_to_invalid
hipPointerGetAttributes- Change hipErrorUnknown to hipErrorInvalidValue

[ROCm/hip commit: a4407f13db]
2019-07-31 15:43:06 +00:00
Rahul Garg 617a6d43dc Add hip init in hipExtLaunchMultiKernelMultiDevice (#1263)
* Add hip init in hipExtLaunchMultiKernelMultiDevice

* Add more logstatus for multiple return paths

* Fix missing i in function name


[ROCm/hip commit: b9e6d72ee6]
2019-07-31 15:42:29 +00:00
Rahul Garg d7973153ca Add HIP init in hipFuncGetAttributes (#1262)
* Add HIP init in hipFuncGetAttributes

* [dtest]Remove explicit hip init call in hipFuncGetAttributes dtest


[ROCm/hip commit: 0517c30507]
2019-07-31 15:42:08 +00:00
Rahul Garg 0009dc1067 Change hipErrorUnknown to hipErrorInvalidValue
[ROCm/hip commit: 483aab031f]
2019-07-31 00:28:30 +05:30
Jeff Daily 4094b62407 remove stream locks where it is safe to do so
[ROCm/hip commit: f096a3239e]
2019-07-22 17:38:51 +00:00
cdevadas a02f3a3655 Increased the number of implicit-kernarg bytes to 56 (#1217)
[ROCm/hip commit: d5dba47804]
2019-07-19 04:45:34 +00:00
wkwchau e61b8cec28 Fixed bug of determine max block size in hipOccupancyMaxPotentialBlockSize (#1235)
[ROCm/hip commit: 38254caf7a]
2019-07-18 03:19:29 +00:00
ansurya df4dee39f4 Add Max Texture 1D,2D,3D device properties (#1226)
* Add Max Texture 1D,2D,3D device properties

* Corrected testcase to use enums defined in hipDeviceAttribute_t

* Added texture 1D,2D and 3D support for NVIDIA path


[ROCm/hip commit: 8e496c09d9]
2019-07-18 03:18:50 +00:00
Rahul Garg 7629cdd2cf Fix HIP_VISIBLE_DEVICES order (#1184)
* Fix HIP_VISIBLE_DEVICES order

* Fix device IDs mismatch

* Fix review comments- loop order and device range check

* Handle incomplete VISIBLE device env variable

* Revert "Handle incomplete VISIBLE device env variable"


[ROCm/hip commit: 1dcf618d20]
2019-07-18 03:18:04 +00:00
Aryan Salmanpour 774f778352 [hip] fix a bug where we parse kernel's arguments layout for a given kernel multiple times (#1232)
[ROCm/hip commit: 034201f658]
2019-07-17 07:29:07 +00:00
Evgeny Mankov d11063e64c [HIP] Fix segfault on uninitialized struct members in hipArrayCreate and hipArray3DCreate
[ROCm/hip commit: 09162d9a53]
2019-07-12 16:38:26 +03:00
Evgeny Mankov 96801f7b3a [HIP][HIPIFY] Split HIP_ARRAY_DESCRIPTOR struct to HIP_ARRAY_DESCRIPTOR and HIP_ARRAY3D_DESCRIPTOR
[Reason] To be compatible with CUDA [#1133]

Update HIP code, hipify-clang, tests and docs

[TODO] Add support of the corresponding functions on nvcc fallback path


[ROCm/hip commit: c7117df91b]
2019-07-11 14:58:16 +03:00
Jatin Chaudhary c7f8ffe41e Adding bounds check before hipMemset (#1190)
* Adding bounds check in ihipMemset

* Adding ihipMemPtrGetInfo to hipMemPtrGetInfo


[ROCm/hip commit: 5ed16432f8]
2019-07-08 11:00:38 +00:00
Aryan Salmanpour a2655fd90a [hip] Move _criticalData of ihipStream_t class to private section and use criticalData() to access it (#1177)
[ROCm/hip commit: 999f45fc11]
2019-07-04 00:42:19 +00:00
Maneesh Gupta b7fe02394f Added missing NULL checks and corrected API return values (#1188)
* Added missing NULL checks and corrected API return values as per validation

* Added missing NULL checks


[ROCm/hip commit: d57946275b]
2019-07-03 08:51:39 +00:00
Anusha Godavarthy Surya 7eedb4d047 Added missing NULL checks
[ROCm/hip commit: 7a4c3f61c8]
2019-06-27 20:19:30 +05:30
Anusha Godavarthy Surya f1d6b56fc4 Added missing NULL checks and corrected API return values as per validation
[ROCm/hip commit: 3d5f6be1c7]
2019-06-27 00:19:05 +05:30
wkwchau 3c963cc0e1 Fixed bug in hipOccupancyMaxPotentialBlockSize for the SGPRs limitation of gfx8 devices (#1176)
[ROCm/hip commit: 47f16264ed]
2019-06-26 15:18:00 +05:30
Aaron Enye Shi 52614c2729 Fix dlpi_name info empty when using GCC on ub18 (#1181)
This fixes a bug where GCC++ on Ubuntu 18.04 creates failing executables compared to GCC++ on 16.04 and clang++. While creating function names on Ubuntu 18.04, dl_phdr_info seems to provide a non-zero value for dlpi_addr on initial iteration, and an empty string in dlpi_name. This is causing failure when linking with g++, since the empty string prevents the kernel function from being loaded. Clang++ and GCC on UB16 provide a zero value for dlpi_addr. To fix this, we need to verify both addr and name exists, so that /proc/self/exe can be properly loaded.

[ROCm/hip commit: 77bef86949]
2019-06-25 06:32:29 +05:30
Aryan Salmanpour 45fa752888 [hip] implement the hipExtLaunchMultiKernelMultiDevice API (#1165)
* [hip] implement the hipExtLaunchMultiKernelMultiDevice API

* add a guard to check the HCC version for acquire_locked_hsa_queue() API which was introdued in HCC for ROCm 2.5

* modified code based on the requested changes

* changes to lock all streams before launching kernels for each device and unlock them after the dispatches

* check each stream to be valid before starting to lock all the streams


[ROCm/hip commit: 96dc74897d]
2019-06-20 05:59:05 +05:30
wkwchau 40bd111519 Implement the hipOccupancyMaxPotentialBlockSize function (#1162)
* Implement the hipOccupancyMaxPotentialBlockSize function

* Replaced hipGetDeviceProperties() call by ihipGetDeviceProperties() in ihipOccupancyMaxPotentialBlockSize()

* Add test for hipOccupancyMaxPotentialBlockSize in Module API

* Added extern declaration for ihipGetDeviceProperties() to be accessed inside ihipOccupancyMaxPotentialBlockSize()

* fixed hipOccupancyMaxPotentialBlockSize test build issue

* Fix hipOccupancyMaxPotentialBlockSize dtest

* Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest

* Revert "Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest"

This reverts commit 0480ff56f1441fc515d2c26ce33783e303423938.

* Disable hipOccupancyMaxPotentialBlockSize dtest on NVCC

* move extern declaration of ihipGetDeviceProperties to hip_module.cpp

* Update the limiation of 32 wavefronts per CU and 800/512 SGPRs for VI/pre-VI chips to calculate the occupancy


[ROCm/hip commit: d492f1fd6b]
2019-06-20 05:58:29 +05:30
Maneesh Gupta cd72288515 Merge pull request #1167 from eshcherb/hip_prof_refactoring_190611
prof layer includes refactoring

[ROCm/hip commit: fc074d96d0]
2019-06-19 13:36:33 +05:30