AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6,436 Commits 3 Branches 0 Tags
de026633c0e95f67600b206da50f96fb331e2650
Commit Graph

1404 Commits

Author SHA1 Message Date
Ajay de026633c0 SWDEV-327563 - support hipStreamWrite32/64 and hipStreamWait32/64 funcs 
Windows complains about undefined symbol for
hipStreamWrite32/64 and hipStreamWait32/64 -
commit hash 08435a972b

Change-Id: I48b9a6591cab3a05baaedbc26030914dd930fb68
 2022-06-09 20:59:46 -04:00
Ajay c06bfa6bef SWDEV-337331 - graph feature on Windows 
Fixes for hipGraphInstantiate OutofMemory issue and
soft hang of hipStreamSynchronize.
Change-Id: Ic2bb97582c5978ef2e4eb3a1b124483aa412838e
 2022-06-09 12:04:51 -04:00
sdashmiz efd2d55e9d SWDEV-318833 - Get and Set attribute for kernel nodes 
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie51aa4b56661cbb8c5b4eb1dbaad327377084ffb
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
 2022-06-09 09:47:05 -04:00
Aakash Sudhanwa 43c650cf48 Revert "SWDEV-335990 - Use GNUInstallDirs" 
This reverts commit bf4df229c9.

Reason for revert: <Breaking all the staging builds. this is breaking components which are using find_package(HIP)>

Change-Id: Ic7340fb461a5efdd170a0988731e0885538a11d6
 2022-06-07 18:18:06 -04:00
Jeremy Newton bf4df229c9 SWDEV-335990 - Use GNUInstallDirs 
GNUInstallDirs is used to allow the user to customize the install paths
of HIP, rather than using hardcoded locations.

See documentation for more information:
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

Note that libdir must be overriden to "lib" before including
GNUInstallDirs, because by default, cmake tries to detect the libdir
path, but ROCm packaging would like to use lib by default for all
targets. This does not stop the user (or distros) from overriding.

Also note this change does no take into account the changes needed to
non-cmake files, such as perl scripts, so not all paths combinations are
necessarily functional.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: Iae80f47c47ea0a74fc1c221b6eea82b557601394
 2022-06-06 23:43:05 -04:00
Rakesh Roy e2874d5e22 SWDEV-337776 - Fix hipStreamEndCapture API 
- Return hipErrorInvalidValue when pGraph is nullptr

Change-Id: I8846f4448eb15117f98421632885330f132c4fce
 2022-06-01 00:20:23 -04:00
Sourabh Betigeri 5a057af564 SWDEV-320640 - Fixes to return right error codes in hipStreamUpdateCaptureDependencies() for negative scenarios 
Change-Id: I3c4c54f8955fa9bb17eb595544005fe9f0e8a5f0
 2022-05-31 14:09:22 -04:00
pghafari 8e28413a9e SWDEV-337703 - nullptr check for hipMallocArray 
Change-Id: I3b1077e236ccda346d337109014ef7fd2e693ec6
 2022-05-31 11:19:59 -04:00
pghafari 2870b7ddd5 SWDEV-336550 - added nullptr check for svm 
Change-Id: Icfd7dab1c7818958108385261542526d4545721d
 2022-05-30 16:58:45 -04:00
kjayapra-amd 84f94fd134 SWDEV-290384 - Add Linker API support in hiprtc 
Change-Id: I4621a033a22e4da0201c3804e2b357470a681ab0
 2022-05-24 09:16:14 -04:00
Rakesh Roy 01a5ddebe6 SWDEV-337119 - Validate width isn't exceeding either dpitch or spitch in 
ihipMemcpy2D

Change-Id: I8ac68e033762616a42585b26f0b3aa5bbb29ce9c
 2022-05-18 23:25:14 +05:30
Satyanvesh Dittakavi 8dfa7e7f98 SWDEV-334908 - Guard the __noinline__ macro as it is also supported as keyword by clang 
Change-Id: I314b3ac463ea63132a5107f4f24ce769d8112b9b
 2022-05-18 05:51:32 -04:00
pghafari bb9e52ab9f SWDEV-336576 - updated graph check 
hipGraphExecMemcpyNodeSetParamsFromSymbo was not working in functional
case

Change-Id: I2ad04f6f91519efa075c36fe737a695fa1bc127a
 2022-05-17 17:36:10 -04:00
Christophe Paquot 60656d9fc9 SWDEV-322620 - Virtual Memory Management 
Report virtual memory management support.

Change-Id: I448a66c86ab1b2d28f6052e8896ea505e56eb2d2
 2022-05-17 16:24:53 -04:00
Satyanvesh Dittakavi 8a333a989b SWDEV-332606 - SWDEV-333585 - Fix hipMemcpySymbol* and hipGetSymbol* APIs 
This also fixes the QMCPack staging (SWDEV-335826) test failures related
to hipMemcpyToSymbol

Change-Id: Icc3ff04fb1e17999f5bddf12e1a7266e2289032f
 2022-05-16 04:27:02 -04:00
Tao Sang 4561a207dd SWDEV-319818 - Revert change on hipResourceViewDesc 
Revert part of
http://gerrit-git.amd.com/c/compute/ec/hipamd/+/675588

Change-Id: Iee9dac9f8c50aa9b6a12ca9d8fd792a51973b8cd
 2022-05-12 12:14:13 -04:00
Satyanvesh Dittakavi f6e21144ae SWDEV-335780 - Address OOM issue with BERT MLPerf 
Memory free was not happening due to no flush

Change-Id: Iee9d2c9f8c50aa9b6012ca9d8fd792a51973b8c8
 2022-05-11 13:03:32 -04:00
German Andryeyev 8b132beb92 SWDEV-311271 - Enable MGPU support for memory pool 
Change-Id: I36850de282d62139b5cfe342df97bb1204cb7869
 2022-05-11 11:04:24 -04:00
Tao Sang a19b767e8a SWDEV-319818 - Release restriction on hipResourceViewDesc 
Let more types support hipResourceViewDesc.
Add missing symbols to fix cuda build failing.

Change-Id: Ife694cc6491427093863252e257e820b0bb4fa0f
 2022-05-10 15:57:31 -04:00
Jeremy Newton d04938a6ad SWDEV-336248 - Use public icd header 
HIP uses icd_dispatch.h, which is not a public header. Using the public
CL/cl_icd.h removes inclusion of the private header.

This allows compiling HIP without relying on OCL ICD source, which makes
distributing a standalone ROCclr easier.

For WIN32, a few other headers are required.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: I0cab173b9753c5b0ab3be9222aa8bb0545cdeaab
 2022-05-10 13:46:08 -04:00
Sourabh Betigeri 5fa514fea0 SWDEV-329829 - Fixes to return right error codes for respective negative scenarios 
Change-Id: Icb615a336bb846df1cf2811316d88a0e88381da8
 2022-05-10 12:56:20 -04:00
Rakesh Roy 84c46047e5 Revert "SWDEV-332606 - SWDEV-333585 - Fix hipMemcpySymbol* and hipGetSymbol* APIs" 
This reverts commit f1fb612774 due to QMCPack test failure (SWDEV-335826)

Change-Id: I40397b345aa60f43afc17853bc72426daf385cf7
 2022-05-10 11:20:36 +05:30
Rakesh Roy 4e86d538e5 SWDEV-333598 - Use flags field of amd::Memory UserData for hip flags 
Change-Id: I492c7fe54dba4380fcc53eed1df36bf5ac0af852
 2022-05-06 13:42:19 +05:30
Jaydeep Patel 118fad741a SWDEV-333848 - Regression fix 
Change-Id: I328770d5c51418c7f5bcb73696c81311d8dc3aef
 2022-04-29 13:27:46 -04:00
sdashmiz 8ed471f210 200~SWDEV-333583 : hipMallocArray bad channel format 
- channel format should be consistent accross parameters

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I1e7680ab9262a66e7bea4aaa21f061044b0f7956
 2022-04-29 09:15:41 -04:00
Satyanvesh Dittakavi 06203c251e SWDEV-330667 - SWDEV-333599 - Fix hipHostRegister and hipMallocPitch APIs 
- hipHostRegister should return hipErrorInvalidValue when size is 0 or
size doesn't match the actual allocated size
- hipMemAllocPitch should return hipErrorInvalidValue when width or height
is 0 and elementSizeBytes should be 4, 8 or 16

Change-Id: I43c9fe4ac1ef0a6ac2f953908d301508a7bc5aa3
 2022-04-28 13:07:08 +00:00
Christophe Paquot 6d73282f25 SWDEV-322620 - Virtual Memory Management 
Implemented hipMemMap and hipMemUnmap

Change-Id: Idc75e3964d88e375e445733557cfa8e421688f1f
 2022-04-28 02:14:14 -04:00
haoyuan2 59b1ae0a79 SWDEV-333187 - Support IPC in HIP runtime on Windows 
enable shared memory based IPC

Change-Id: I2657ef4713240b6f82a34f416d53f222630263ca
 2022-04-27 11:14:59 -07:00
pghafari 63f23ec2b0 SWDEV-327960, SWDEV-316901 - Adding Graph checks 
hipGraphExecMemcpyNodeSetParamsToSymbol, fix for functional cases
failing as well

Change-Id: I9f263778f6b24e3ec35a78231a17e01c0d44f23a
 2022-04-26 21:04:32 -04:00
Ajay 1abd0d6ecf SWDEV-332522 - ipcEvents Avoid deadlock b/w streamWait & Event 
Using device write to set 0 to signal while streamWaitEvent is checking
the signal.
Use app in SWDEV-314307 to verify this fix
Requires vdi #668012 change to work

Change-Id: Ie329a29cfaeb5d144b92cda36773646f913ca73d
 2022-04-26 11:59:01 -04:00
Satyanvesh Dittakavi f1fb612774 SWDEV-332606 - SWDEV-333585 - Fix hipMemcpySymbol* and hipGetSymbol* APIs 
- hipMemcpy[From/To]Symbol APIs to return hipErrorInvalidMemcpyDirection
if the copy kind is incorrect
- hipGetSymbolSize and hipGetSymbolAddress APIs to return hipErrorInvalidValue
if the pointer is null

Change-Id: I32f428045c804b1e4f648e91b507f749f60c09d0
 2022-04-25 08:25:29 -04:00
Rakesh Roy 8ea74366d7 SWDEV-332603 - Check validity of ihipArrayCreate() first argument 
Change-Id: Ifd0bdb5708c110da45e4baa9426cccd749732822
 2022-04-22 11:08:37 +05:30
Rakesh Roy 2613ebf157 SWDEV-332604 - Add nullptr check for argument pitch 
Change-Id: I6d7aa5356a74b92f21f7a51a7d3e2f8d0b920e07
 2022-04-22 00:13:24 -04:00
Christophe Paquot fd17b53ea4 SWDEV-322620 - Virtual Memory Management 
Implement hipMemAddressFree and hipMemAddressReserve

Change-Id: I1b09e433db5c5c6d6b9fe2a7a15fe2c09f1e1874
 2022-04-21 17:19:10 -04:00
German Andryeyev b4c5a01fbc SWDEV-333607 - Avoid synchronization of all GPU(s) 
Use the original device from creation to sync before host memory
free.

Change-Id: I510e34afa7accf69e3d01338587bbc817b981cec
 2022-04-21 15:36:04 -04:00
Sarbojit Sarkar 71b5235c64 SWDEV-332809 - Fix for OpenMp crash 
Change-Id: I70445edf76261ab8ecf174614f23bd9fb8d60881
 2022-04-19 11:29:19 -04:00
Sarbojit Sarkar fc1f02bbed SWDEV-323441 - support for default stream per thread 
Change-Id: I0032da0357f5cffbf5e4ec4a02435d2a128a262b
 2022-04-18 23:19:55 -04:00
Saleel Kudchadker aace42cfab SWDEV-301667 - Add separate field for event scope 
Change-Id: I0e6b50d1a34b275ea4f1a4c659430c406d9a5a7e
 2022-04-18 15:48:33 -04:00
German Andryeyev 5957ff9f7b SWDEV-311271 - Make sure memory pool can accept default stream 
Add lock protection for access to the pool list.
Remove destroyed stream from the list of the safe streams

Change-Id: I1863b89bd3f5e188c161227cc790c3adaf72cc58
 2022-04-18 10:34:21 -04:00
Satyanvesh Dittakavi b06ee8834d SWDEV-308763 - Remove older hiprtc implementation 
Change-Id: I1f0a1fe9b6590070905348bf71b901ac77b196be
 2022-04-18 05:12:53 -04:00
Satyanvesh Dittakavi 3b525ad298 SWDEV-332371 - Address seg fault with hip event tests on Windows 
Change-Id: I0367f6dbb395b3032c97692c5bde6e99d503c6a9
 2022-04-18 04:19:23 -04:00
Sourabh Betigeri bd851550bd SWDEV-331301 - Fixes error code mismatch 
Change-Id: I8dda98609b16ea5c1ce4d9db9471e61e5fb0c12c
 2022-04-13 18:51:06 -07:00
Saleel Kudchadker f320acb797 SWDEV-276210 - Honor scopes for hipEventRecord 
Honor hipEventReleaseToDevice and hipEventReleaseToSystem flags.
hipEventRecord would flush caches if no release flags are provided. To
change this behavior set ROC_EVENT_NO_FLUSH=1

Change-Id: I03e41b515b1d0cf963b0c2d5b9901b09e71a0e59
 2022-04-13 00:35:19 -04:00
Jaydeep Patel c1503da69b SWDEV-330666 - null(default) stream's priority is 0. 
Change-Id: I115effc2ddaa28dee32967ee28041b9b8da095b9
 2022-04-13 00:28:52 -04:00
Sourabh Betigeri 345e02358c SWDEV-329848 - Fixes error code mismatch between CUDA and HIP 
Change-Id: Ic48de159ca7bdb4b91dadb915972e535518635ae
 2022-04-12 15:00:44 -04:00
haoyuan2 cb4aabd285 SWDEV-328274 - Move DLLMain from VDI layer to HIP/OCL layers 
Change-Id: Ibd3388f0981672cd209d7370f8a28b2883abdea2
 2022-04-12 11:00:20 -04:00
Sarbojit Sarkar 8657c40721 SWDEV-331126 - Fix to Cuda return type 
Change-Id: Iea8e7735ef0c58c1244c92338038d91e61d62c16
 2022-04-11 23:35:04 -04:00
Ajay f301bf3962 SWDEV-331095 - Address hipRTC windows test failures 
Change-Id: I8c1a36ffd362c6f41449092e4dd85f6ec587206a
 2022-04-11 09:40:35 +00:00
Christophe Paquot cd447a5aaa SWDEV-322620 - Virtual Memory Management APIs 
Adding skeletons.
Implemented:
- hipMemGetAllocationGranularity with basic granularity
- hipMemGetAllocationPropertiesFromHandle
- hipMemCreate

Change-Id: I4bd2c75fae45d6a057efcad19d1d3c9715e9ae67
 2022-04-08 11:38:51 -04:00
Jaydeep Patel ff78c439ef SWDEV-330661 - devicePointer null checking. 
Change-Id: I3366031954330143109d0a79e86fd0e0ec996f01
 2022-04-08 00:08:37 -04:00