Commit Graph

1085 Commits

Author SHA1 Message Date
Evgeny Mankov a4b08bcfa3 [HIP] Fix typo in a comment
[ROCm/hip commit: 28c23a7b1a]
2019-10-11 15:20:58 +03:00
Evgeny Mankov 0331004a44 [HIP][fix] Prefix libraryPropertyType to fix build of rocFFT and TensorFlow
[ROCm/hip commit: 337b7ce06a]
2019-10-11 15:18:08 +03:00
Evgeny Mankov 0ac55b1a9d [HIP] Introduce library_types.h as a common header for libs (#1509)
* [HIP] Introduce library_types.h as a common header for libs

[Reason]
Currently, hipFFT, hipBLAS and other HIP libs use their own data types, prefixed with HIPFFT or HIPBLAS, whereas in CUDA those types are common and declared in library_types.h

[TODO]
Switch hipFFT, hipBLAS and other HIP libs to use common library_types.h.

* [HIP] Move include for library_types.h to hip_runtime.h

[Reason]
Repeat CUDA's behaviour, where library_types.h is included in cuda_runtime.h


[ROCm/hip commit: 94eb4155dd]
2019-10-10 19:57:28 +05:30
Philip Salzmann aeba964a7e Fix uninitialized var in hipDeviceGetAttribute (#1497)
This fixes the usage of an uninitialized cdattr variable in hipDeviceGetAttribute for the CUDA backend when taking the switch default, as detailed in #1317.

Note that the directed_tests/runtimeApi/device/hipGetDeviceAttribute.tst test fails for me, but it already did before applying this patch. Let's see what CI says!

[ROCm/hip commit: 9ababa4276]
2019-10-04 13:39:19 +05:30
Rahul Garg 3b9b5fca8d Add texref get APIs support (#1471)
Added support for -
    hipTexRefGetArray
    hipTexRefGetAddressMode
    hipTexRefGetAddress



[ROCm/hip commit: bec725dec2]
2019-10-04 13:38:45 +05:30
Sarbojit2019 d8a79dda8c Removed definition of abs(), real() & imag() from hip_complex.h (#1448)
Addresses SWDEV-201461.

[ROCm/hip commit: 58a476abc2]
2019-10-04 13:38:02 +05:30
ansurya 66e94b1b1f Added new Memory API's (#1399)
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.


[ROCm/hip commit: ba9c6e13e4]
2019-10-04 13:36:31 +05:30
Yaxun (Sam) Liu 21201779c6 Fix cast of __half for HIP-clang (#1475)
[ROCm/hip commit: 56193a7828]
2019-09-30 10:40:42 +05:30
satyanveshd 25699d3b03 Map clock64() to __builtin_readcyclecounter() (#1473)
Fixes SWDEV-203215.

[ROCm/hip commit: 4b413739a9]
2019-09-30 10:40:31 +05:30
eshcherb a0dab5e09c to include hip_prof_str.h under USE_PROF_API macro (#1470)
[ROCm/hip commit: 8234da33b9]
2019-09-30 10:39:41 +05:30
Alex Voicu 4f1cb316c6 Optimise the gridDim.n * blockDim.m idiom (#1468)
[ROCm/hip commit: ab8fe8a3d8]
2019-09-30 10:39:23 +05:30
Yaxun (Sam) Liu 9ef2687f45 Add new kernel launching API for hip-clang
[ROCm/hip commit: 3c80389584]
2019-09-26 20:15:24 -04:00
Sarbojit2019 7f7a5a3712 [HIP] Add tccDriver info in hipDeviceProp
Fixes #1433.

[ROCm/hip commit: 0fa42af08c]
2019-09-26 13:53:33 +05:30
mhbliao 2a58af4380 [HIP] Remove a circular including. (#1418)
[ROCm/hip commit: 1f8c3bbd3b]
2019-09-16 08:32:47 +00:00
ansurya b5549f4397 Added new device attributes (#1377)
* Added new device attributes

* updated comment

* updated with new device attributes supported


[ROCm/hip commit: ceb734b917]
2019-09-16 08:31:30 +00:00
mhbliao 4913aec033 [hip] Stop using noduplicate and replace it with convergent. (#1390)
[ROCm/hip commit: 119ee4b671]
2019-09-05 10:03:43 +00:00
Yaxun (Sam) Liu 73b6fe599c Do not include cuda wappers for OMP for hip-clang (#1382)
[ROCm/hip commit: 8fe8fc18c0]
2019-09-03 05:13:59 +00:00
Sarbojit2019 fed6843ecf Removed hipLaunchKernel macro got missed in Merge (#1374)
[ROCm/hip commit: e1f9e08ea7]
2019-09-03 05:13:07 +00:00
Sarbojit2019 73e5c52d0d Updated hipErrorString and CUDAErrorTohipError (#1365)
[ROCm/hip commit: 0722704f35]
2019-08-29 01:02:59 +00:00
Sarbojit2019 74a3171c6b [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/hip commit: 5c4f78bac3]
2019-08-29 01:02:41 +00:00
satyanveshd f378b67565 [sample] add new cookbook sample - occupancy (#1352)
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments


[ROCm/hip commit: f807cc1a7b]
2019-08-29 01:01:49 +00:00
mshivama 37779f5bef Device side support for Cooperative Group feature (#1202)
* first cut of the header implementation of cooperative group feature

* add diclarations for device library functions

* fixed various compile time issues in the CG headers

* enabled copy construction and copy assignment

* fixed a minor bug related to conditional compilation macro

* fixed few more CG constructor issues and added a unit testcase

* fixed typo

* extended unit testcase

* compute size of partitioned CG from mask

* bit of code refactoring

* removed boilerplate code

* fixed few of the review comments by Brian

* Changes to the sigantures of few grid and multi-grid related OCKL functions

* changes to declarations of OCKL functions related to CG feature

* removed all the block level support as it is not planned for 2.9

* Have taken care of review comments by Brian

* Have taken care of review comments by Brian

* removed unused functions which were initially intended to use in block level cg support


[ROCm/hip commit: d75dc4eb29]
2019-08-29 01:01:25 +00:00
Michael LIAO e3d7baceff [hcc] Fix previous replacement of result_of_t.
- `result_of_t` is defined as the shortcut of
  ```
  template< class T >
  using result_of_t = typename result_of<T>::type;
  ```


[ROCm/hip commit: 63e47e525b]
2019-08-26 10:58:38 -04:00
ramcherukuri 8b5587cebd moving result_of_t to result_of
[ROCm/hip commit: 3a6ca29815]
2019-08-24 08:59:58 -04:00
Rahul Garg bd916675eb Make Bundled_code_header visible for hipRTC usage (#1359)
[ROCm/hip commit: 0fd14a3e13]
2019-08-23 09:20:02 +00:00
Aryan Salmanpour 0fc745b3a6 [hip] add initial implementation for hipLaunchCooperativeKernel API (#1339)
* [hip] add initial implementation for hipLaunchCooperativeKernel API

* [hip] use total number of work groups to initialize the GWS resource

* [hip] use only one argument for init_gws kernel

* [hip] use the device associated with the stream for checking the device properties


[ROCm/hip commit: 5066700ace]
2019-08-23 09:19:35 +00:00
Sarbojit2019 edb699bd32 Compilation failure on nvcc path when using hipChannelFormatKind (#1345)
Fix for github #1183 issue reported

[ROCm/hip commit: 84de192c9b]
2019-08-21 10:01:03 +00:00
kpyzhov 612833bcfe Corrected declaration of __ockl_clz_u64() (#1340)
[ROCm/hip commit: 0e3198be25]
2019-08-20 12:06:36 +00:00
Yaxun (Sam) Liu aae6ad3ab4 Fix missing decl for hip-clang
Add back decl for hipHccModuleLaunchKernel and hipExtModuleLaunchKernel for HIP/VDI only


[ROCm/hip commit: 51f0b3f3a6]
2019-08-19 18:27:13 -04:00
mhbliao 1ddc06c042 [hip] Allow from/to half conversion on host side. (#1334)
[ROCm/hip commit: e919a8246e]
2019-08-16 02:13:59 +00:00
Yaxun (Sam) Liu 4f0fb9236e Fix assert for windows. (#1329)
MSVC assert.h has no guard for include once. The macro assert overrides
device assert definition. Do not include it for device compilation.

[ROCm/hip commit: 7aa7a4ce22]
2019-08-16 02:13:33 +00:00
Rahul Garg a984acf245 Add hipMemcpy3DAsync (#1320)
* Add hipMemcpy3DAsync

* Fix CI build error

* Move back stream resolution to internal function

* Remove stream redefinition and check


[ROCm/hip commit: 2405621f62]
2019-08-16 02:13:16 +00:00
Rahul Garg 3c8f84a5c3 Fix undefined identifier issue for hipExtModuleLaunchKernel
[ROCm/hip commit: 3dd0e988b1]
2019-08-14 16:46:32 -04:00
Sarbojit2019 157856f40e [HIP] Fix for hipArray_t failure on nvcc path
Fixes SWDEV-148407

[ROCm/hip commit: b2fc64cc39]
2019-08-14 11:30:06 +00:00
Rahul Garg d42844182c Add hipMemcpyParam2DAsync (#1296)
* Add hipMemcpyParam2DAsync

* Add NVCC path changes

* Clean up

* Fix build issue

* Fix else use in both sync and async apis


[ROCm/hip commit: 45b73e0961]
2019-08-09 11:50:37 +00:00
Siu Chi Chan 83269bea32 Compile HIP runtime with hidden visibility by default (#1303)
* add default visibility to most APIs in program_state

* remove unwanted C++ headers

* Add symbol visibility pragmas and compiler flags

* Add visibility attribute to APIs in channel_descriptor and hip_hcc

* remove unused headers

* simplify build flags with hcc

* add pragma visibility hidden to functional_grid_launch

* [CMake] add gfx908 back


[ROCm/hip commit: 83af327ef2]
2019-08-08 08:33:04 +00:00
Rahul Garg d429ba57e1 Add support for hipFuncGetAttribute (#1279)
* Add support for hipFunGetAttribute

* Support NVCC path

* Test using sample module_api_global

* Try fixing CI build failure due to hip_prof_gen scan

* Fix for CI build issue

* Resolve conflict

* Rebase and resolve conflicts with master

* Fix build error

* Fix NVCC path build error


[ROCm/hip commit: 6ce86f409d]
2019-08-08 08:27:41 +00:00
Rahul Garg fe9cfbdd3c Enable temporarily disabled device properties on HIP/VDI
[ROCm/hip commit: 59bda14979]
2019-08-06 22:03:19 -04:00
Maneesh Gupta 3a04541b9d Merge pull request #1280 from ROCm-Developer-Tools/fix_dont_break_hcc_just_because
This difference makes absolutely no sense.

[ROCm/hip commit: 4ee600ed5e]
2019-08-05 09:51:53 +00:00
Sarbojit2019 b72170d037 Enabled gcc for hip host code (#1214)
* Enabled gcc for hip host code

* Adding tests for hip code + (gcc & g++), without kernels

* Excluding nvcc platforms for gcc and g++ tests + Addressing review comments

* minor code clean-up

* Add rocm include path

* Added relative path for library

* Hiding non supported functions for gcc

* Incorporating review comments


[ROCm/hip commit: 3bfff0a23d]
2019-08-05 09:51:36 +00:00
Jeff Daily 9b44993343 consolidate thread local storage (#915)
* all thread local access now through single struct

* clean up old commented-out code, more use of GET_TLS()

* fewer calls to GET_TLS by passing tls as a funtion argument

* revert unnecessary change to printf

* fix failing tests due to TLS change

* fix merge conflicts in ihipOccupancyMaxActiveBlocksPerMultiprocessor


[ROCm/hip commit: 1eb3dbf065]
2019-08-05 09:51:02 +00:00
Alex Voicu b859635575 This difference makes absolutely no sense.
[ROCm/hip commit: a85b0fe68e]
2019-08-02 12:30:03 +03:00
wkwchau c666fdaa08 Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttribu… (#1238)
* Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttributeHdpRegFlushCntl

* Added NVCC blocker for the hip*FlushCntl test cases


[ROCm/hip commit: e7447d5809]
2019-08-01 16:03:35 +00:00
Maneesh Gupta 87bc7183bf Merge pull request #1277 from mangupta/nvcc_devprop
[nvcc] Populate missing fields in hipGetDeviceProperties

[ROCm/hip commit: adc95002c6]
2019-08-01 08:59:58 +00:00
wkwchau 7676b86f12 Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOc… (#1240)
* Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags APIs

* Taking into account of SGPR usage to determine the max active blocks in hipOccupancyMaxActiveBlocksPerMultiprocessor()


[ROCm/hip commit: 4b18b321f7]
2019-08-01 08:58:48 +00:00
Maneesh Gupta 1e92f785bc [nvcc] Populate missing fields in hipGetDeviceProperties
Change-Id: Ie90e02674d503e385f144f1ead3d53ff7b49cecc


[ROCm/hip commit: 3ec381d729]
2019-08-01 13:16:39 +05:30
Yaxun (Sam) Liu 6c438e311f Temporarily disable maxTexture1D in hipDeviceProp_t for VDI (#1237)
[ROCm/hip commit: d7aea38d74]
2019-07-19 15:38:32 +00:00
ansurya df4dee39f4 Add Max Texture 1D,2D,3D device properties (#1226)
* Add Max Texture 1D,2D,3D device properties

* Corrected testcase to use enums defined in hipDeviceAttribute_t

* Added texture 1D,2D and 3D support for NVIDIA path


[ROCm/hip commit: 8e496c09d9]
2019-07-18 03:18:50 +00:00
ansurya 358d9d311f UChar and UShort textures as Normalized Float (#1213)
* UChar and UShort textures as Normalized Float

* UChar and UShort textures as Normalized Float for all float variants

* Handled uninitilaized texture format value


[ROCm/hip commit: 6b6258b84f]
2019-07-18 03:18:28 +00:00
Evgeny Mankov 96801f7b3a [HIP][HIPIFY] Split HIP_ARRAY_DESCRIPTOR struct to HIP_ARRAY_DESCRIPTOR and HIP_ARRAY3D_DESCRIPTOR
[Reason] To be compatible with CUDA [#1133]

Update HIP code, hipify-clang, tests and docs

[TODO] Add support of the corresponding functions on nvcc fallback path


[ROCm/hip commit: c7117df91b]
2019-07-11 14:58:16 +03:00