Commit Graph

5568 Commits

Author SHA1 Message Date
Evgeny Mankov a01e2c7d03 [HIP][SPARSE] sync with HIPIFY's #95 and #96
Based on:
  https://github.com/ROCm-Developer-Tools/HIPIFY/pull/95
  https://github.com/ROCm-Developer-Tools/HIPIFY/pull/96
Update hipify-perl and CUSPARSE_API_supported_by_HIP.md accordingly
2020-04-10 19:36:43 +03:00
Maneesh Gupta 21f1e6d5b8 Merge "Merge branch 'amd-master' into amd-master-next" into amd-master-next 2020-04-10 01:11:03 -04:00
Evgeny b8b5bdf44b fxing C compatibility (amd-master-next)
Change-Id: Ib95b953bb49e0edbe044789b6ff81aaccb87f85f
2020-04-10 00:08:09 -05:00
Vladislav Sytchenko a81e7d63c6 Correctly check max 1D image buffer size
VDI reports the limits in pixels, but user provides the size in bytes.

Make sure both values are in pixels before doing comparisons.

Change-Id: I082c7175c9fa4383e0b0ee38ff8c047c26ff20b4
2020-04-09 21:37:43 -04:00
Vladislav Sytchenko 7592fd18d7 Fix Windows build
Change-Id: I8e219f8200875e3c46c1f54348317ba7ad8ae8ba
2020-04-09 20:00:29 -04:00
Christophe Paquot 6584470377 Merge "Remove a map lookup whenever we were getting the default stream" into amd-master-next 2020-04-09 18:35:46 -04:00
Vladislav Sytchenko 2613b22e8a Fix warnings when compiling with clang
The following warnings are addressed:

comparison of different enumeration types in switch statement

Change-Id: I6cb3948aeab7287851c57ecc1d4b3a439ab14ec6
2020-04-09 17:07:48 -04:00
Christophe Paquot 4d9c540f4f Remove a map lookup whenever we were getting the default stream
Change-Id: I64b6d1deea41d81e94a58a83de287e78923656b3
2020-04-09 12:44:21 -07:00
Aakash Sudhanwa f03a1ef371 Merge "enabling hipPrintString (to master-next)" into amd-master-next 2020-04-09 15:08:35 -04:00
Vladislav Sytchenko de67236a27 Disable all texture tests for VDI
Latest llvm already includes the texture/surface rework, but appropriate runtime changes have not been submitted.

Disable all texture related tests until http://gerrit-git.amd.com/c/compute/ec/hip/+/342147 is submitted.

Change-Id: I359c2eac6becdd3ca5110f2140679bd29d8ae54b
2020-04-09 14:02:40 -04:00
Evgeny 1e4e4cb229 enabling hipPrintString (to master-next)
Change-Id: I28859f3dbe5b867a858ca1d76c93e6fab6a68d1f
2020-04-09 09:57:27 -05:00
Maneesh Gupta 2af31479e2 Merge branch 'amd-master' into amd-master-next
Change-Id: I3094c15008093f2072bcd38aca4ea90aeae2d97b
2020-04-09 06:31:00 -04:00
Sameer Sahasrabuddhe 1d464f391e printf test: loop with divergent exit condition
Change-Id: I1071e4a240a280332bde669701c72228b9dea2df
2020-04-09 10:20:11 +05:30
Michael LIAO a48b312aa9 [hip] Fix volatile-qualified member function declartion.
- It should be a volatile-qualified member function instead of returning
  volatile type.

Change-Id: Id7aaa1953d56151b59e469ef22b9f4280f63bebb
2020-04-07 12:49:26 -04:00
Evgeny Mankov 5f1420a229 [HIP][HIPIFY] Remove HIPIFY related stuff due to moving of HIPIFY to a separate repo (#2002)
HIPIFY tools now are here: https://github.com/ROCm-Developer-Tools/HIPIFY
2020-04-07 14:03:30 +05:30
Evgeny Mankov ff8d193b7f [HIP][doc] Update docs due to moving of HIPIFY to a separate repo (#2001) 2020-04-07 14:03:19 +05:30
Rahul Garg ba8a556ea9 Rename hipDrvOccupancy to hipModuleOccupancy and match CUDA syntax (#1943) 2020-04-07 14:02:52 +05:30
Saleel Kudchadker f99db12c82 Merge "Revert "Wake up commandQueue before returning"" into amd-master-next 2020-04-06 18:52:29 -04:00
Saleel Kudchadker 71f850f9ec Revert "Wake up commandQueue before returning"
This reverts commit bc8d6ac97c.

Reason for revert: German advised againt this change.

Change-Id: Ia1b1b9db60c965b2d9c006bd7d20012a9d7697e1
2020-04-06 16:46:50 -05:00
Payam 8c26e0b3b6 updated LOG_LEVEL prints to print pid and tid
Change-Id: I8a9212b26bb7e312408a222823efcfd00344094b
2020-04-06 16:58:25 -04:00
German Andryeyev 5fe91ccb1b SWDEV-184710
Support hipLaunchCooperativeKernelMultiDevice()

- Add validation logic for MGPU launches to pass a cuda test

Change-Id: Iccca7fde43493fc3bc6685512d39202271ae3e92
2020-04-06 16:38:27 -04:00
German Andryeyev 382d5ce77f Merge "(SWDEV-228488)" into amd-master-next 2020-04-06 16:30:37 -04:00
German Andryeyev da1444bfc8 SWDEV-184710
Support hipLaunchCooperativeKernelMultiDevice()

- Add hipCooperativeLaunchMultiDeviceNoPreSync and
hipCooperativeLaunchMultiDeviceNoPostSync support to pass a cuda test

Change-Id: If518f11ef2636a2235e5df9e77f879d8ced68102
2020-04-06 15:29:03 -04:00
Vladislav Sytchenko 1bd640b659 (SWDEV-228488)
These fixes address regressions caused by http://gerrit-git.amd.com/c/compute/ec/hip/+/337601

Currently we're converting a 1D offset into a 3D offset, which doesn't make much sense once you consider the fact that this offset is relative to a different origin than our current 3D offset.

I traced through our blit kernels in VDI - the copy buffer rect path is able to handle immediate offsets in the 3D buffer via the amd::BufferRect::start_ parameter.

Instead of adjusting the offset, simply adjust the start of the region.

Change-Id: Ic8797a2c8ac0ad106f246f61ff06ca1ca03d3058
2020-04-06 14:17:11 -04:00
Michael LIAO 7e051d8a96 [vdi] Fix -Wsign-compare warning. NFC.
- TeamCity build failed as `-Werror` is turned on.

Change-Id: Icd2cbd45f60e3c296894e8e73685e1d177f125a8
2020-04-06 12:16:07 -04:00
German Andryeyev b72ec19c0e Merge "SWDEV-184709 - support hipLaunchCooperativeKernel()" into amd-master-next 2020-04-06 11:45:34 -04:00
satyanveshd 17862812b4 fix hipIpcOpenMemHandle (#1998) 2020-04-06 15:39:49 +05:30
Rahul Garg a12cc8b031 use hsa_executable_get_symbol_by_name in find_kernel_by_name (#1994) 2020-04-06 15:39:30 +05:30
Rahul Garg 59afcb1091 Bump version to 3.5 (#1993)
* Switch CI testing from rocm-3.1.x to rocm-3.3.x
* Update hcc workweek for cooperative view
* bump version to 3.5
2020-04-06 15:39:10 +05:30
Sarbojit2019 b80a2c3966 hipEventElapsedTime should respect device (#1992)
Fixes SWDEV-228636.
Also added a unit test to verify this.
2020-04-06 15:38:25 +05:30
lmoriche 9de5e90ab5 Don't duplicate embedded code objects (#1991)
If the code object is embedded in an already mapped file, and the
lifetime of the mapped file exceeds the lifetime of the executable,
we do not need to make a copy of the binary.

This allows the ROCR to present the code object URI as
file:///path/to/file#offset=X&size=Y.
2020-04-06 15:37:35 +05:30
Jatin Chaudhary 6358e40a76 Removing header size from formula (#1988)
Fixed a bug in the elf file size computation.
2020-04-06 15:37:07 +05:30
Rahul Garg 6c65fc04d1 Fix 2D and 3D memset (#1987) 2020-04-06 15:35:59 +05:30
ansurya 770e76e752 Initial support for bfloat16 (#1980) 2020-04-06 15:35:43 +05:30
Yaxun (Sam) Liu 4af2106d10 Fix ambiguity of fma for _Float16 for libc++ (#1976)
libc++ defines fma as template function for auto promotion of mixed-type
arguments. libc++ does not handle _Float16 as _Float16 is not a supported
type by C++ standard. As such, it is unlikely we can commit our fix for
_Float16 to libc++ trunk.

Therefore we handle _Float16 with a template specialization of
__numeric_type in HIP headers.

Change-Id: If01960a657ebf1a7a67463cdcf66fab7458dff3c
2020-04-06 15:35:18 +05:30
Sameer Sahasrabuddhe db3e17d552 SWDEV-227201: Introduce tests for printf on hostcall
Tests that check POSIX specifiers with a single thread:
 - hipPrintfSpecifiers.cpp     : all conversion specifiers
 - hipPrintfFlags.cpp          : common flags that modify conversions
 - hipPrintfAltForms.cpp       : alternate forms ('#')
 - hipPrintfStar.cpp           : additional arguments ('*')
 - hipPrintfWidthPrecision.cpp : floating point details

Tests that check functionality on top of hostcall
 - hipPrintfBasic.cpp       : divergent calls, series of calls, return value, etc
 - hipPrintfManyWaves.cpp   : many waves printing together
 - hipPrintfManyDevices.cpp : many waves on many devices

Change-Id: I35e069f4c542f896999239996dc89eda0faad7b8
2020-04-06 00:49:34 -04:00
eshcherb e4a1c49e72 adding HIP_PROF version macro (#2000) 2020-04-04 13:10:28 -07:00
Christophe Paquot fa5a9b3810 Default HostMalloc to uncached memory
Change-Id: I72e19c7f7820a77fd5afc09f09cfea9acd0b8e84
2020-04-03 19:19:33 -04:00
Saleel Kudchadker f1a9a4f22a Merge "Wake up commandQueue before returning" into amd-master-next 2020-04-03 18:27:03 -04:00
Michael LIAO 9e619430f4 [vdi] Add hipFreeHost
Change-Id: I8a5b7ff3f0ab4f5674efd6723c18808ad6ef33f5
2020-04-03 16:34:28 -04:00
German Andryeyev 6f19e77f69 Merge "SWDEV-184709 - support hipLaunchCooperativeKernel()" into amd-master-next 2020-04-03 16:23:05 -04:00
Vladislav Sytchenko 5f14ae1161 Take into an account the number of channels...
when querying the element size of an array.

Change-Id: Id57d3374b14d80a59230ec8286704f2fbabb0fae
2020-04-03 15:43:18 -04:00
German Andryeyev 7820018037 SWDEV-184709 - support hipLaunchCooperativeKernel()
- Add validation checks for cooperative launch to pass Cuda test

Change-Id: Ie296f0c3f113909d9a357879db3b2a833ab314c5
2020-04-03 15:18:21 -04:00
Michael Hong Bin Liao fad9e39597 Merge "Fix size type in __hipRegisterVar" into amd-master-next 2020-04-03 15:12:21 -04:00
Saleel Kudchadker bc8d6ac97c Wake up commandQueue before returning
Change-Id: I87eb5a22c81a9cb807474a960b5987d5fb6c2b86
2020-04-03 10:23:36 -07:00
Aaron En Ye Shi a2104f6c94 Merge "Fix path for hip-clang when using hipcc (#1961)" into amd-master-next 2020-04-03 12:28:50 -04:00
Michael LIAO 00bb2ce04a Fix size type in __hipRegisterVar
Change-Id: I6b667600ae8f133583b768ab963318882b84179f
2020-04-03 10:51:58 -04:00
Michael Hong Bin Liao dbedce9e54 Merge "[hip] Clean up unnecessary casting." into amd-master-next 2020-04-03 10:50:40 -04:00
German Andryeyev 0d69b79622 SWDEV-184709 - support hipLaunchCooperativeKernel()
- Enable cooperative tests for single and multiple devices

Change-Id: I54b6713f578b6b5e670f117b17469c0091028c99
2020-04-02 12:55:05 -04:00
Michael LIAO 79d8f7e47e [hip] Clean up unnecessary casting.
Change-Id: I64b08aaef5c67ffb49330c9c605611f1fbd3f5a2
2020-04-02 12:46:15 -04:00