Commit Graph

64 Commits

Author SHA1 Message Date
Satyanvesh Dittakavi 954d7872f2 SWDEV-279486 - Fix hipMemcpyPeer/hipMemcpy APIs
Addresses the scenarios when the size passed is more than
the allocated size and when the deviceid is invalid
Change-Id: I6c9b62639096f655ffb61976905b1ce8c5f51ee7

Change-Id: I8a0d660924a8e2300c517aba6f9088626b8f6ef5


[ROCm/clr commit: 191ce1dd05]
2021-04-09 02:53:15 -04:00
Sarbojit Sarkar ce41fd9824 SWDEV-276319 - Added null checks
Change-Id: Ib22a333f0f599c8f0efca34f2a287bc4b118d743


[ROCm/clr commit: 4af7a74482]
2021-04-01 05:11:16 -04:00
Sarbojit Sarkar 993f52cd8b SWDEV-254441 - Fixed review comments
Change-Id: Ica13f23638be04216d152821127b2b7316f96af0


[ROCm/clr commit: 35c8493237]
2021-04-01 00:21:19 -04:00
pghafari 4578277e13 SWDEV-245532 - HIP - Vulkan interop
Change-Id: Iba1ef8112e318b4f099da5a4a4602e0dae7de9e3


[ROCm/clr commit: a9304f6111]
2021-03-31 10:23:31 -04:00
Satyanvesh Dittakavi 85ca63f256 SWDEV-277152 - Add hipMemcpy2DToArrayAsync API in headers
Also, address few scenarios for hipMemcpy2DToArray/Async to return
proper error types

Change-Id: Idbadf666a5e7bebc0f3ea8b7048b79208e04cf6b


[ROCm/clr commit: 68abfb4aff]
2021-03-27 13:50:38 -04:00
Sarbojit Sarkar 80bb284b12 SWDEV-276319 - Fix for -ve cases
Change-Id: Ie6157e3cdbd1f959c8ea502b48286bdf102b8a0f


[ROCm/clr commit: 43c371fb7b]
2021-03-18 00:21:43 -04:00
Vladislav Sytchenko d09885f10d SWDEV-275317 - Correctly pass HIP image width to ROCclr APIs in AtoD/DtoA copies
HIP assumes that image width is in bytes, but OCL/ROCclr assumes that
it's in pixels. AtoD/DtoA need to account for this.

Change-Id: I275bd41d8b03e141caaf951bc6b714e51ca72dfc


[ROCm/clr commit: 82e40a6438]
2021-03-15 21:09:58 -04:00
Satyanvesh Dittakavi c8e84cbf02 SWDEV-275317 - Fix hipMemcpy2DFromArray to return proper error types
Change-Id: Id722865d81460bfd2fa6ad7a198b6e3c2a08265a


[ROCm/clr commit: daafd303ec]
2021-03-09 05:22:23 -05:00
Arya.Rafii 3d6667ccb7 SWDEV-269246 - Implementation of hipDrvMemcpy2DUnaligned
Change-Id: I86fdd3b930cbd74c45cd31944f0ea52c0ff65a59


[ROCm/clr commit: 8cb232ddef]
2021-03-04 14:38:06 -05:00
kjayapra-amd 2b715e4826 SWDEV-259566 - Adding support to retrieve handle for offsetted pointer.
Change-Id: I5da5ab6a24c6df915950637feb486b8c288e60e0


[ROCm/clr commit: 8ef68df3a8]
2021-03-04 12:28:56 -05:00
Ravi C Akkenapally 4cf7a5799a SWDEV-179105 - Stream Operations: Add swqupport for Wait and Write
Change-Id: I9d6d0665d12b62fe705ce1569a0e8264a4f23ab7


[ROCm/clr commit: fd0f49503f]
2021-03-02 12:15:46 -08:00
Jatin Chaudhary 59204ceea9 SWDEV-272361 - Dont call memcpy2d if width is 0 or height or depth is 0
Change-Id: I22324a536d2a5e68b9fc3e5ee4ad821b49021a17


[ROCm/clr commit: ec832d42d1]
2021-03-01 14:34:58 -05:00
cjatin 3152413001 SWDEV-271274 - Changing DevLogPrintf to LogPrintf for cases where error condition is being returned
Change-Id: I153d071f7859e9412ea0c69f53c53d190453d73d


[ROCm/clr commit: 564417d00f]
2021-03-01 14:33:46 -05:00
Ashutosh Mishra cd0b146be0 SWDEV-271126 - Memory obtained from getDeviceMEmory can be NULL
which can cause segmentation faults. Hence checking for its sanity

Signed-off-by: Ashutosh Mishra <ashutosh.mishra@amd.com>
Change-Id: I78b4d029f0926a1369a8ebbeb4aef951a8f1f1d7


[ROCm/clr commit: b9c0065e4f]
2021-02-26 23:29:53 -05:00
agodavar 390565d4b7 SWDEV-271096 - Handle depth zero in hipMalloc3D
Change-Id: I0ef0cc825e20b3480e9e5476e09dde5f73cdd3ea


[ROCm/clr commit: 8f85d89812]
2021-02-09 08:39:44 -05:00
Satyanvesh Dittakavi 7fec171e78 SWDEV-263678 - fix rocHPCG mgpu perf drop
Change-Id: I33269fe4f6165d1ed172b19033ab9fcb92f338c3


[ROCm/clr commit: 15baf7ef6d]
2021-01-05 00:22:12 -05:00
Sarbojit Sarkar fae1bcd07c Revert "Fix hipmemset to match CUDA behavior"
This reverts commit 76a2999f22.

Change-Id: I53052b25bac4956f3efd124eadc936197f2e466a


[ROCm/clr commit: f64af513a2]
2021-01-01 00:11:58 -05:00
agodavar ceb68b8d4f hipmemcpy2D handle height 0
Change-Id: I46bf89e81559c3bfccac0dd0ccd78eee9058c7e3


[ROCm/clr commit: 7dcf2769ae]
2020-12-31 01:41:56 -05:00
agodavar e85f1404e8 SWDEV-263180 : Fix null ptr dereference
Change-Id: Iefc9fa3f195af45a5c5ebe075056246c930a6d84


[ROCm/clr commit: d74777d2a7]
2020-12-19 02:02:54 -05:00
Rahul Garg 76a2999f22 Fix hipmemset to match CUDA behavior
Make hipMemset asynchronous with respect to the host unless
destination pointer refers to pinned host memory.

Change-Id: I5ba230e0cc622aa076dc94692a4c43a57dd2df7b


[ROCm/clr commit: 9ba5902be4]
2020-12-17 19:13:31 +00:00
Satyanvesh Dittakavi c832ef9e7c SWDEV-258754 Fix seg fault hipMemset with device pointer mapped from hipHostRegister
Change-Id: Ifab66b67df172812ebb6eb25c2bac71821f4d614


[ROCm/clr commit: f06393c75f]
2020-12-15 07:44:34 -05:00
Satyanvesh Dittakavi 1f654026d7 Fix hipPointerGetAttributes
Modified hipPointerGetAttributes to support hipHostRegister ptrs and mapped device ptrs from hipHostRegister
Change-Id: I2f4cf12e09578768308f644123d6d4bdccbd77a8


[ROCm/clr commit: 40733e1fff]
2020-12-15 01:40:24 -05:00
Sarbojit Sarkar 80075304f1 Updated review comment
Change-Id: Ic7f9f33dd23c975f2a7a0f0d485a3d2a457c62bb


[ROCm/clr commit: 1ef88375c2]
2020-12-13 11:30:28 -05:00
agodavar 9ae4798aa7 SWDEV-256810 : hipMemcpy2D API handle width, src/dst pitch 0
Change-Id: I4f60b220624f4235c0c3daf68adcd5a496e93696


[ROCm/clr commit: 273e83ff6c]
2020-12-03 10:34:12 -05:00
Sarbojit Sarkar 83e94d189c SWDEV-258579: hipMemcpy2D better error handling
Change-Id: I09378d6e31da99451e22cbe9276a5ff1ad4a1840


[ROCm/clr commit: a08ddb4b53]
2020-12-03 05:50:42 -05:00
Satyanvesh Dittakavi 8d4b0ecb0c SWDEV-255614: Fix Caffe2 Test Failure
Change-Id: I043caa89b2a43dace7f18c739f30d2a7bfa644ca
Fixes the issue when memcpy DtoH is performed on device 0 where the device buffer 
is allocated on device1 and the destination pinned buffer is allocated from device 0.


[ROCm/clr commit: 60ec2a3e46]
2020-11-20 10:24:50 -05:00
Rahul Garg 5a56ff9cfa Fix async flag in hipMemset3DAsync
Change-Id: I3dc717c14bdd1d46873e03c687bdf57f9202663e


[ROCm/clr commit: 236352a64d]
2020-11-18 20:32:18 -05:00
Sarbojit Sarkar a5f78cf686 SWDEV-256325 : Fix for hipMemset2D crash
Change-Id: I1f434602fecd4fb935d2bc72f2c72d6a2d4c45fe


[ROCm/clr commit: a73d1a1fe0]
2020-10-20 02:54:29 -04:00
German Andryeyev e343bc4b00 Report managed memory capabilities
Change-Id: I241a42e26ee49fb47dcb3ba87c4bd8fb691dffdf


[ROCm/clr commit: 15ba5611ba]
2020-10-13 16:09:43 -04:00
Aryan Salmanpour 0a6ac3c020 Fix a seg fault when unallocated mem handle passed to hipIpcOpenMemHandle API
also validate the flag argument passed to hipIpcOpenMemHandle API and return
error if it is not equal to "hipIpcMemLazyEnablePeerAccess" (defined to 0)
and it is the only supported flag currenlty for this API.

SWDEV-253462

Change-Id: Ie1c8b79c680a29dc72bf262cf53ae5e011fb1247


[ROCm/clr commit: 89964dbbd4]
2020-10-13 11:14:41 -04:00
Vladislav Sytchenko 7b635ae18c Revert "Revert "Merge branch 'amd-master-next' into amd-npi-next""
This reverts commit 0627e8783b.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I92ceb171e31026ed1864704cef2fc1497b883ef9


[ROCm/clr commit: d5aa0f607d]
2020-10-05 13:20:58 -04:00
Vladislav Sytchenko 0627e8783b Revert "Merge branch 'amd-master-next' into amd-npi-next"
This reverts commit 6c6299acb2.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I53322718dadde2c98f96140b8e260ec7ee9ef721


[ROCm/clr commit: 9142674ef0]
2020-10-05 13:02:39 -04:00
Julia Jiang 8976ef0471 SWDEV-247518-fix HPC multi gpu test performance drop
Change-Id: I2f07d9ba183cf88b3845d8d61607a8a0462d015f


[ROCm/clr commit: 3d59e050db]
2020-09-29 12:04:40 -04:00
Aryan Salmanpour 58a6e2f0f2 fix a pagefault when wrong argument (extent) passed in hipMemset3D API
Change-Id: I779fc14ccd7c942d1ae0a938ebfd3c2e728ff761


[ROCm/clr commit: a680b514b3]
2020-09-25 10:57:37 -04:00
Rahul Garg b1851cdc96 Return hipMemoryTypeHost as memory type for hipHostRegistered pointer
Fixes SWDEV-253741
Change-Id: I42c2c9df00862157314d5767b6f175a0d2f28b47


[ROCm/clr commit: 2f3d60fc4a]
2020-09-24 12:27:32 -04:00
Satyanvesh Dittakavi 84634b6903 Print size_t variables with %zu
Change-Id: I02bb073b07e9efd03dea2b76b6ba1bd2f552bcaa
Total Memory is not being printed correctly with %u.
%zu represents size_t variables appropriately.


[ROCm/clr commit: 00c0118910]
2020-09-18 11:55:41 -04:00
Sarbojit Sarkar 2e95688d9d Fix for hipPointerGetAttributes [github#2137]
Change-Id: I5295575638ecc4d3b7129552a9c26c6f6a7195fc


[ROCm/clr commit: 74cdf8f9e3]
2020-09-10 10:51:30 -04:00
Rahul Garg 920a7d4002 Return error when mismatch in copy kind and ptrs
Change-Id: I70e4d06e850843697035b42c5d1d56287c874ac8


[ROCm/clr commit: c8a32c932d]
2020-08-27 20:53:48 -04:00
Payam 1cdf2afd5e adding duration to print log for hip api calls
Change-Id: Icffa8fcacfb8ba24861d980b9553faeee4efec8c


[ROCm/clr commit: c24f884c76]
2020-08-06 06:42:21 -04:00
Sarbojit Sarkar ee526f9212 Added free device memory info
Recently there were few OOM(out of Memory) issues poped. Adding trace will help know genuine OOM issue. 
Change-Id: Ie2a56bba95cead24caf1af5c807e73c383c2f5d9


[ROCm/clr commit: bc76760452]
2020-08-06 01:16:36 -04:00
Jason Tang aa179b01a3 SWDEV-243576 - Fix hipMemcpy regression.
If the queue device doesn't match the device on any memory object, use the queue device from the memory object.

Change-Id: I5fdcf00494f8391574f4443332c01788b8da44ef


[ROCm/clr commit: e430506f70]
2020-07-28 03:04:00 -04:00
jujiang e5b39e4056 SWDEV-242344-hipMemcpyAll failed on MGPU
Change-Id: I01671e322c84213964d3d48bd6b5dc704dba731a


[ROCm/clr commit: c1d65e57a1]
2020-07-27 13:30:30 -04:00
Vlad Sytchenko bddfc6a790 2D/3D copy optimizations
SWDEV-244798

If {src/dst} ptr is marked as hipMemoryTypeHost, check if the memory was
prepinned. If it was, upgrade the copy type to hipMemoryTypeDevice to
avoid extra pinning.

Change-Id: Id287ef5b14ae67dfbcf80c4caa1b08a311191948


[ROCm/clr commit: fe6b645f3b]
2020-07-23 11:24:16 -04:00
jujiang 362faab3f5 SWDEV-242337-Fix hipHostRegister test failure for MGPU
Change-Id: I748dac0c5a47fa00184f065d9ef716573aa70b12


[ROCm/clr commit: 797d2761d4]
2020-07-20 11:40:49 -04:00
Sarbojit Sarkar a4c135ec8a host pointer check [SWDEV-243104, SWDEV-243206]
Change-Id: Id58dabfe5c35e5f8e42d224e700a431a4a97d003


[ROCm/clr commit: 9ba3732180]
2020-07-14 07:16:12 -04:00
kjayapra-amd 28b5e13757 SWDEV-240165 - Move all amd::MemObjMap_ reference to ROCclr and only allow base ptr to get ipc handle.
Change-Id: I4f11e56ba455a7ce5a066c0e9e49657c5220a211


[ROCm/clr commit: ff36244b9c]
2020-07-09 21:19:50 -04:00
German Andryeyev f2464edb74 Remove hipMemcpyDeviceToDevice check.
There is hipMemcpyDefault that requires validation also.

Change-Id: I5ae0ffa1c023b7774547acbdc049b84a0c2cb4c5


[ROCm/clr commit: 11b7842f71]
2020-06-30 12:59:54 -04:00
agodavar 4644558c2b SWDEV-239297:hipMemset fix, getMemoryObject with unaligned ptr
Change-Id: I37b8139c5099d37b42f34d728a3d694fdf9cb55d


[ROCm/clr commit: 6a47458764]
2020-06-23 08:56:09 -04:00
Tao Sang b702f41277 Support numa policy set by user
Add hipHostMallocNumaUser flag to hipHostMalloc() in order to support
numa policy set by user.

Change-Id: I6d70ed539a5f97f27187f2242b68849c0e27e4d6


[ROCm/clr commit: 71c64e98a0]
2020-06-19 21:23:58 -04:00
Vlad Sytchenko 0a3e99aa14 Support creating textures from user ptr with offset
Change-Id: Ied0af9a842fc6ef067e068a9d89dde63ff5dfce1


[ROCm/clr commit: ba2d3fbbb3]
2020-06-17 14:10:14 -04:00