foreman
e4eb8e6a1b
P4 to Git Change 1997981 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/13 11:17:32
...
SWDEV-203438 - [HIP] AllGather RCCL test issue
The test tries to launch a kernel on two devices at once and they need to communicate with each other.
For that, it uses a custom stream for each devices.
Problem is in getNullStream we used to call syncStreams all the time
and it was syncing all the streams even the ones on different devices.
So that made the second kernel launch (on 2n dev) to wait for the first kernel to finish which
would never occur since the first one was waiting for the second one.
The fix is to not call syncStreams from getNullStream because we sync already anyway prior in general.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#40 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#70 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#24 edit
[ROCm/clr commit: 0aa24f6d4d ]
2019-09-13 11:28:33 -04:00
foreman
649d08488c
P4 to Git Change 1990032 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/27 20:20:36
...
SWDEV-145570 - [HIP] Add missing HIP_INIT_API macros and more debug printf.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#23 edit
[ROCm/clr commit: 534727cd01 ]
2019-08-27 20:26:25 -04:00
foreman
11bc45adbd
P4 to Git Change 1982034 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/12 19:08:13
...
SWDEV-199606 - [HIP] hipStreamQuery issue
Don't test against CL_COMMAND_MARKER but 0 instead (user visible=false)
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.hpp#6 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#22 edit
[ROCm/clr commit: 1ce84c8b6e ]
2019-08-12 19:16:30 -04:00
foreman
b31e671b32
P4 to Git Change 1981152 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/09 20:33:32
...
SWDEV-193430 - [HIP] Delay creating HostQueue till commands are enqueued.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.hpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#34 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#68 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#31 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#21 edit
[ROCm/clr commit: 3494344c4d ]
2019-08-09 20:41:13 -04:00
foreman
38cfac4dcd
P4 to Git Change 1972922 by cpaquot@cpaquot-ocl-lc-lnx on 2019/07/24 11:59:16
...
SWDEV-196881 - [HIP] Fix hipStreamQuery implementation. Using isEmpty isn't correct.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#32 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#20 edit
[ROCm/clr commit: 47ac573d70 ]
2019-07-24 12:05:47 -04:00
foreman
9f00fda30e
P4 to Git Change 1788615 by cpaquot@cpaquot-ocl-lc-lnx on 2019/05/28 18:54:55
...
SWDEV-190565 - [HIP] Allow null stream as argument to hipStreamWaitEvent.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#19 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#19 edit
[ROCm/clr commit: 397ad08fae ]
2019-05-28 19:06:58 -04:00
foreman
4f37e552ad
P4 to Git Change 1778971 by cpaquot@cpaquot-ocl-lc-lnx on 2019/05/06 17:03:12
...
SWDEV-187125 - [HIP] Protect hip::Event with lock and add threadId to logs.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.hpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#30 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#18 edit
[ROCm/clr commit: 84d257cf3b ]
2019-05-06 17:43:06 -04:00
foreman
2d2e37205f
P4 to Git Change 1777158 by cpaquot@cpaquot-ocl-lc-lnx on 2019/05/01 17:12:01
...
SWDEV-188219 - [HIP] Add hipStreamCreateWithPriority. NOP right now.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#14 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/commandqueue.hpp#21 edit
[ROCm/clr commit: ef45e9ab42 ]
2019-05-01 18:43:47 -04:00
foreman
a9820e7b72
P4 to Git Change 1758971 by yaxunl@yaxunl-lc10 on 2019/03/20 12:00:49
...
SWDEV-145570 - Fix build failure due to type mismatch of amd::Event::CallBackFunction
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#16 edit
[ROCm/clr commit: 7d3439719d ]
2019-03-20 12:24:45 -04:00
foreman
4842e57b41
P4 to Git Change 1623601 by skudchad@skudchad_test2_win_opencl on 2018/10/24 17:52:57
...
SWDEV-145570 - [HIP] Refactor hipStreamAddCallback
ReviewBoardURL = http://ocltc.amd.com/reviews/r/16045/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#15 edit
[ROCm/clr commit: 5a126bf678 ]
2018-10-24 18:00:42 -04:00
foreman
b3b400f681
P4 to Git Change 1620765 by skudchad@skudchad_test2_win_opencl on 2018/10/17 16:58:04
...
SWDEV-145570 - [HIP] Track last used event and use last enqueued command in a stream rather than creating a new event
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15996/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#90 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/commandqueue.cpp#28 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/commandqueue.hpp#20 edit
[ROCm/clr commit: 8526ed9b96 ]
2018-10-18 13:41:32 -04:00
foreman
d6357be515
P4 to Git Change 1602601 by skudchad@skudchad_test2_win_opencl on 2018/09/06 15:01:00
...
SWDEV-145570 - [HIP] Implement hipStreamAddCallback and hipStreamQuery
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15749/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#13 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/commandqueue.cpp#27 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/commandqueue.hpp#19 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/concurrent.hpp#9 edit
[ROCm/clr commit: e075998b2b ]
2018-09-06 15:21:28 -04:00
foreman
c1bb44fa73
P4 to Git Change 1593706 by skudchad@skudchad_test2_win_opencl on 2018/08/14 18:44:29
...
SWDEV-145570 - [HIP] Implement hipError*
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15619/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#11 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_profile.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#9 edit
[ROCm/clr commit: 2ec2cfd3c1 ]
2018-08-14 18:54:13 -04:00
foreman
0f8c914c5f
P4 to Git Change 1562507 by skudchad@skudchad_test2_win_opencl on 2018/05/31 18:10:39
...
SWDEV-145570 - [HIP] - Fix HIP build
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#11 edit
[ROCm/clr commit: 28247da814 ]
2018-05-31 18:18:00 -04:00
foreman
f877ce4f42
P4 to Git Change 1555197 by cpaquot@cpaquot-ocl-lc-lnx on 2018/05/15 16:26:41
...
SWDEV-145570 - [HIP] Fixed a typo, hipStreamGetFlags test passes now
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#10 edit
[ROCm/clr commit: 408acaf35e ]
2018-05-15 16:36:25 -04:00
foreman
6453962807
P4 to Git Change 1555193 by cpaquot@cpaquot-ocl-lc-lnx on 2018/05/15 16:19:50
...
SWDEV-145570 - [HIP] Implemented events
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.hpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#25 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#9 edit
[ROCm/clr commit: a896cb9af0 ]
2018-05-15 16:26:16 -04:00
foreman
d44b3dc620
P4 to Git Change 1553709 by cpaquot@cpaquot-ocl-lc-lnx on 2018/05/11 11:24:30
...
SWDEV-145570 - [HIP] Make streamSet global and protect it
By default from the spec, streamSet should be global and not per thread.
There is a flag to make it per thread but we don't handle this yet. We
would just add another variable that will be thread local and use it instead.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#10 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#11 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#8 edit
[ROCm/clr commit: c6b9701abb ]
2018-05-11 11:34:01 -04:00
foreman
39ea36a458
P4 to Git Change 1552807 by skudchad@skudchad_test2_win_opencl on 2018/05/09 18:08:07
...
SWDEV-145570 - [HIP] - Release a stream first before taking it off from the set.
- Queue::create() needs to be called before returning a valid queue.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/14830/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#7 edit
[ROCm/clr commit: 1426982a65 ]
2018-05-09 18:15:41 -04:00
foreman
970febab07
P4 to Git Change 1552209 by cpaquot@cpaquot-ocl-lc-lnx on 2018/05/08 20:24:32
...
SWDEV-145570 - [HIP] Use the as_amd()->asHostQueue with streamSet
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#6 edit
[ROCm/clr commit: d4bb6a0a11 ]
2018-05-08 20:30:17 -04:00
foreman
24e9cf40cc
P4 to Git Change 1552198 by skudchad@skudchad_rocm on 2018/05/08 18:57:32
...
SWDEV-145570 - [HIP] - Synchronize the legacy default stream with other blocking streams as per the spec.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/14796/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#11 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#10 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#5 edit
[ROCm/clr commit: 813c770d73 ]
2018-05-08 19:04:35 -04:00
foreman
eea99696ec
P4 to Git Change 1548476 by cpaquot@cpaquot-ocl-lc-lnx on 2018/05/01 15:50:51
...
SWDEV-145570 - [HIP]
Added support for null stream avoiding creating/destroying dummy streams.
Added basic event class for hipEvent* support.
Refactored some common functionality: No more direct access to g_context.
Support hipStreamSynchronize(0).
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.hpp#1 add
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#8 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#7 edit
[ROCm/clr commit: c874bb2b90 ]
2018-05-01 18:10:09 -04:00
foreman
2bf865a669
P4 to Git Change 1537228 by skudchad@skudchad_test2_win_opencl on 2018/04/05 14:53:31
...
SWDEV-145570 - [HIP] - Add HIP Memory, texture, surface, context api skeletons
ReviewBoardURL = http://ocltc.amd.com/reviews/r/14565/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#1 add
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#1 add
[ROCm/clr commit: 6fc37f7147 ]
2018-04-05 15:02:43 -04:00
foreman
466cb9634d
P4 to Git Change 1534798 by cpaquot@cpaquot-ocl-lc-lnx on 2018/03/30 00:56:35
...
SWDEV-145570 - [HIP] Implemented hipStream create/destroy
Use the provided stream in hipModuleLaunchKernel
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#2 edit
[ROCm/clr commit: 9504ce2bc4 ]
2018-03-30 01:06:00 -04:00
foreman
d8f628753c
P4 to Git Change 1522211 by lmoriche@lmoriche_opencl_dev2 on 2018/03/02 17:41:47
...
SWDEV-145570 - [HIP] - Hip Rearchitecture
- Rename cuda* launch functions -> hip*
- Add more function prototypes to compile the HIP tests
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#1 add
[ROCm/clr commit: f27e6709eb ]
2018-03-02 17:55:48 -05:00