Jatin Chaudhary
24f12bbd85
SWDEV-271274 - Remove hip init call from hipUnregisterBinary, this call ends up initializing rocclr and hsa even when there is no hip call in the entire file
...
Change-Id: I20c1d3079c6032d79c5b892d5616921f7aeb4fe2
[ROCm/hip commit: 1770e8a160 ]
2021-02-09 07:59:32 -05:00
agodavar
83957f599e
SWDEV-269400 - handle nullptr in hipFuncGetAttributes and blockSizeLimit<0 in hipModuleOccupancyMaxPotentialBlockSize
...
Change-Id: Ia1c6e5713f40876b4a9c7a1c56b7b3a589c4497a
[ROCm/hip commit: 464cad2751 ]
2021-01-27 23:41:31 -05:00
Tony Tye
8da2326f6f
SWDEV-268864 - Use new isa class to access isa related information (part 2)
...
Change-Id: If7ed535b3012aec3f2cb4eb7ab93d8f5aed9783f
[ROCm/hip commit: 040bc455d4 ]
2021-01-19 03:36:22 +00:00
agodavar
add7f87881
SWDEV-245381: Updated guarantee error messages to print based on BUILD_TYPE
...
Change-Id: Ifafbc075d6b9860da040c72859127c4e638a786f
[ROCm/hip commit: 387d0aa829 ]
2021-01-05 23:29:50 -05:00
Tao Sang
c618b6aeff
Remove hip-hcc codes: Part three
...
1.Rename include/hip/hcc_detail/ as include/hip/amd_detail/
2.Rename include/hip/nvcc_detail/ as include/hip/nvidia_detail/
3.Create __HIP_PLATFORM_AMD__ to replace __HIP_PLATFORM_HCC__
4.Create __HIP_PLATFORM_NVIDIA__ to replace __HIP_PLATFORM_NVCC__
After hcc_detail, nvcc_detail, __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__
have been removed from upstream, they will be removed from hip runtime.
Change-Id: I1ae457effd739d6c25bca203c1724b026be21fce
[ROCm/hip commit: c2adc70d4d ]
2021-01-05 10:39:31 -05:00
Rahul Garg
a2539f0342
Handle overflow
...
Fixes SWDEV-261712
Change-Id: I730fcdca8c2640fde9cfdfe2f4b4cf4894807fed
[ROCm/hip commit: 15ecdcf084 ]
2020-12-09 19:09:43 -05:00
Sourabh Betigeri
f02cf67087
SWDEV-251091: Added null checks and empty file check in hip_module and hip_platform
...
Change-Id: Iad99f996dcf90ffb86f62e79bf4cbd53b35b7e3b
[ROCm/hip commit: 3c4208aa7d ]
2020-10-20 19:55:01 -04:00
kjayapra-amd
644e635e64
SWDEV-254363 - Checks to make sure kernel is launched on the same device as it was launched.
...
Change-Id: I2f273a70b1a5fc0e9fc9c6144eabd32466ff4e59
[ROCm/hip commit: c4505bede3 ]
2020-10-06 08:38:09 -04:00
Vladislav Sytchenko
e4caaa2a77
Revert "Revert "Merge branch 'amd-master-next' into amd-npi-next""
...
This reverts commit 28b17d3dbd .
Reason for revert: <INSERT REASONING HERE>
Change-Id: I92ceb171e31026ed1864704cef2fc1497b883ef9
[ROCm/hip commit: ad2d55c144 ]
2020-10-05 13:20:58 -04:00
Vladislav Sytchenko
28b17d3dbd
Revert "Merge branch 'amd-master-next' into amd-npi-next"
...
This reverts commit 258d79bca7 .
Reason for revert: <INSERT REASONING HERE>
Change-Id: I53322718dadde2c98f96140b8e260ec7ee9ef721
[ROCm/hip commit: 374ead1d19 ]
2020-10-05 13:02:39 -04:00
kjayapra-amd
84b764eacc
SWDEV-241896 - Remove extern support in ROCclr/HIP since compiler added Texture reference support.
...
Change-Id: I1b0a7377b803b4e2b94ffef6ffd91e376fdb2b2f
[ROCm/hip commit: dcaec76d41 ]
2020-09-24 14:28:16 -04:00
Jatin Chaudhary
42636e83e5
Adding checks for return type compatibility with CUDA
...
Change-Id: I09b6bd9a7299f0a97ac9011ea0903a1f81e28251
[ROCm/hip commit: a779350181 ]
2020-09-21 00:36:02 -04:00
Vladislav Sytchenko
bc1f8180ee
Fix Windows build
...
Change-Id: I8769bafba199b9258c610e51b58e454fe10a75e6
[ROCm/hip commit: 36ecdf9c3a ]
2020-09-18 18:51:25 -04:00
kjayapra-amd
ec47e5a7d4
SWDEV-241902 - Changes to pass file descriptor and offset to load code object.
...
Change-Id: I96add27f4fde1b5ee5501e206b7e85ab77e87dfc
[ROCm/hip commit: 89e5e8b90c ]
2020-09-15 07:54:28 -04:00
Rahul Garg
2bdb08bbe7
Reinsert __gnu_h2f_ieee and __gnu_f2h_ieee.
...
Fixes SWDEV-251676
Reverts Ide24d245d851e20961020323e52f33322a33fff9 and adds
__attribute__((weak)) to __gnu_h2f_ieee and __gnu_f2h_ieee.
Change-Id: If4f9e2f867b56a3f0121a907a49ae4032220d9af
[ROCm/hip commit: 5241c76a9d ]
2020-09-15 01:39:14 -04:00
Tao Sang
f985a8d247
Replace private libelf with elfio
...
Change-Id: I59ae33f7cc55e73f6519af14be91dd9863b03af3
[ROCm/hip commit: 4e1344de0f ]
2020-09-01 10:29:11 -04:00
kjayapra-amd
16b52c4a62
SWDEV-249499 - Add message to Guarantee assert code in hip runtime.
...
Change-Id: I1850463675bbc3e6ff5e3cef8211b1fd40e55f96
[ROCm/hip commit: 9c75797d9f ]
2020-08-24 17:35:39 -04:00
Jason Tang
cba6c9a60f
SWDEV-232197 - Remove refering to gfxipVersion_
...
Change-Id: I91b6b972e26b18dabf6deda5a142bff491c8bb45
[ROCm/hip commit: e2169ce6d0 ]
2020-08-12 16:34:18 -04:00
Anusha Godavarthy Surya
2cd41daf44
SWDEV-243961 Added overflow check for globalWorkSize
...
Change-Id: I153d99398eb4619baad8c0a52466e0d5d5f898ca
[ROCm/hip commit: 9ea54f7797 ]
2020-08-05 11:18:07 -04:00
Tao Sang
cbc01d5488
Remove __gnu_h2f_ieee and __gnu_f2h_ieee
...
Change-Id: Ide24d245d851e20961020323e52f33322a33fff9
[ROCm/hip commit: ef9176db03 ]
2020-07-23 14:50:24 -04:00
kjayapra-amd
9d8d1ad889
SWDEV-236178 - Remove use of old routines functions()/modules().
...
Change-Id: I3a1ed967227c91b0d8cdf39e1360ade685e0bc73
[ROCm/hip commit: dab399f22c ]
2020-07-22 14:55:02 -04:00
Saleel Kudchadker
eef8d8ea1f
Print devPtr and size for hip*Symbol* api
...
Change-Id: I07be6949cca005700ee1d1708d86220c793c9728
[ROCm/hip commit: f897f003cf ]
2020-07-21 13:49:10 -04:00
Tao Sang
05300c8fe3
Implement HIP_ENABLE_DEFERRED_LOADING in right way
...
Change-Id: Ia28dbdea5cde93b3ca69f44c6a3c18ec8a730d42
[ROCm/hip commit: 66fca8be23 ]
2020-07-11 18:14:03 -04:00
kjayapra-amd
b823a939b0
SWDEV-236178 - Fixing func_attributes that was over written on redesign.
...
Change-Id: I157913ae4fa4a3a149817e901f10475b7750188b
[ROCm/hip commit: 6f15d8ca6b ]
2020-07-01 11:52:45 -04:00
Tao Sang
9c6dbda74b
Fix static lib crashing issue
...
Initialize HIP_ENABLE_DEFERRED_LOADING = 1
Change-Id: I432ccf1926b953c4391fdd086cde7da2380962bb
[ROCm/hip commit: 0eebbb4f87 ]
2020-06-22 13:24:40 -04:00
kjayapra-amd
10919eb6a9
SWDEV-236178 - Store texture reference metadata for dynamically loaded modules.
...
Change-Id: I99ecc80da7e29c691341a01a09e4532972f1e3e5
[ROCm/hip commit: 173bb2af6e ]
2020-06-11 22:34:50 -04:00
kjayapra-amd
37508980de
SWDEV-236178 - Reorganizing Platform/Modules code for easy access.
...
Change-Id: Ie8920260ffc4ff01e44b48af8cec9ea5aed1aa9b
[ROCm/hip commit: 20f05c4228 ]
2020-06-11 10:11:20 -04:00
kjayapra-amd
81e6261ff8
SWDEV-239327 - Remove amd_mem_obj during unregistervar
...
Change-Id: I2130eaa21369b9634a9459680061138c61eaaaa4
[ROCm/hip commit: 421bc7dfcb ]
2020-06-05 23:24:38 -04:00
kjayapra-amd
a3f6bf1161
SWDEV-235295 - Move addDeviceProgram() to lazy loading
...
Change-Id: I8fe07e370e58844496e18c858bb528393556854f
[ROCm/hip commit: 348066d21f ]
2020-06-05 18:03:32 -04:00
kjayapra-amd
0bdff1ff07
SWDEV-234295 - Pass flag to ROCclr to not clear device programs during program::build()
...
Change-Id: I50b9fa1a96da6895f73fdf4a7c0d3f096b1188da
[ROCm/hip commit: 8941d19fe8 ]
2020-06-05 09:53:11 -04:00
Jatin
7b52f0a1ea
Adding changes for hipExtLaunchKernel for rocCLR
...
Change-Id: Iba52bc3bde7c37f3fb375a55ba0947e87b3cdc9b
[ROCm/hip commit: 2d517fdcc6 ]
2020-06-02 14:16:41 -04:00
kjayapra-amd
6d2ec4c700
SWDEV-229840 - fixing return HIP_RETURN instances in hip.
...
Change-Id: I48763d7268bf5649bf2242c962c185f5f4af159c
[ROCm/hip commit: aae3e13296 ]
2020-05-29 09:43:58 -04:00
kjayapra-amd
cdd32d1fd0
SWDEV-233927 - Crash if binary for current device is not found.
...
Change-Id: I57281ae6c09110f39155664fca5a83ea57bb62b4
[ROCm/hip commit: 0599855f0d ]
2020-05-28 16:18:27 -04:00
Joseph Greathouse
6690e7a9e0
Fix a build error on signed/unsigned comparison
...
Change-Id: Ic79eb4c3ec5c6fd36cea7c4810d990619f08b9e1
[ROCm/hip commit: 1f25e4956c ]
2020-05-28 14:27:16 -05:00
kjayapra-amd
7002be9c95
SWDEV-236465 - Return error code as soon as global creation fails.
...
Change-Id: I790b8b4fdd6ab8818bc5b6b9a79e6900b840372d
[ROCm/hip commit: db972c4f2a ]
2020-05-28 13:28:23 -04:00
Joseph Greathouse
72de06128e
Fix occupancy calculation functions in ROCclr path
...
The hipOccupancyMaxPotentialBlockSize API is meant to return the
number of threads for the highest-occupancy workgroup, and the number
of those workgroups. It was previously calculating the number of
maximum-sized workgroups that would fit on a single CU. This is
a mixture of the API we wanted (to calculate max potential block size)
and the MaxBlocksPerMultiprocessor function.
This patch fixes it up so that the internal occupancy calculation
function works for two uses: the traditional function that calculates
the maximum blocks per multiprocessor when a user passes in a fixed
block size (used for hipMaxBlocksPerMultiprocessor style functions)
and a function that calculates the size of a block that would lead
to maximum occupancy, and how many blocks of that size would be
needed to fill the whole GPU (for hipOccupancyMaxPotentialBlockSize
style functions).
This also updates the occupancy calculation function to prepare for
gfx10, which does not have SGPR-based occupancy limits.
Change-Id: Ie007b3f9d5ebc4e166b50a3a051498af35650f35
[ROCm/hip commit: ebe5054e04 ]
2020-05-28 10:22:10 -05:00
Laurent Morichetti
02d5a7c4b9
load functions when registered if lazy load is disabled
...
Change-Id: I08c9684ca4ab86a6294ed9e670f3125c1a0cc6c4
[ROCm/hip commit: 22edde84d5 ]
2020-05-21 09:19:20 -04:00
Payam
bfea574271
load functions when registered if lazy load is disabled
...
Change-Id: I6f10a72f7643e476407af03b04ef52e59741be45
[ROCm/hip commit: a5b4f5f02d ]
2020-05-15 12:15:32 -04:00
Evgeny
73eb4c6330
API tracing instrumentation
...
Change-Id: I257409b9fe299b009ded3e3a43287322d5f93a70
[ROCm/hip commit: 5abb8e1a68 ]
2020-05-14 11:03:09 -05:00
Payam
514b242275
adding support to disable lazy loading, HIP_ENABLE_LAZY_KERNEL_LOADING
...
Change-Id: Iafe0f396570ee2bccf642b537cbf9aad967e1370
[ROCm/hip commit: 56509b0ffd ]
2020-05-13 17:18:48 -04:00
Christophe Paquot
56a91401a4
Make sure to remove the global var from amd::MemObjMap
...
We need this otherwise ROCr can give us a matching address
for another allocation and doing "insert" in ROCclr will not
update the map with the newest object. We would then end up
using stale objects (yikes)
SWDEV-234992
Change-Id: I3475adf9781a9309d64a024fae45181d7e5afb04
[ROCm/hip commit: a03fee04fe ]
2020-05-13 00:26:19 -07:00
Christophe Paquot
2588c88679
Add lock to addFatBinary and removeFatBinary
...
In case hipModule(Un)Load is called from different thread as hipInit we need to grab the lock
as both are going to modify modules_
Also add some logging for __hipExtractCodeObjectFromFatBinary in case binary isn't found for GPU
SWDEV-236032
Change-Id: Icbd72b412502df80d5066cea42a4fbcd5b0b8a98
[ROCm/hip commit: f100ae3679 ]
2020-05-12 16:04:08 -07:00
kjayapra-amd
38587ea539
SWDEV-227602 - Fixing hipFuncGetAttribute parameters
...
Change-Id: I46bd079372f453cabfaa2c709e2b30c69400dd33
[ROCm/hip commit: 78e27488be ]
2020-05-12 09:15:43 -04:00
Vlad Sytchenko
802b60054d
Correct HIP_FUNC_ATTRIBUTE_MAX_THREADS_PER_BLOCK query
...
We should be returning the max workgroup size calculated by the compiler.
Change-Id: If86590efbb9b291f470bdbe87e5df992e661c539
[ROCm/hip commit: 1b1c032e9f ]
2020-05-08 14:36:47 -04:00
Vlad Sytchenko
2e98030e46
Fix confusion in hipFuncGetAttribute()
...
Cuda shared == OpenCL local
Cuda local == OpenCL private
Change-Id: I5a204945ecde35919b9e9def20bbb2662fffea2b
[ROCm/hip commit: a373538d72 ]
2020-05-08 14:36:36 -04:00
Payam
0c8b343931
name change vdi to rocclr
...
Change-Id: I06d198bbb4a499e153b290b73a92afed3553b252
[ROCm/hip commit: c5f76c3de3 ]
2020-05-06 09:14:30 -04:00