Commit Graph

243 Commits

Author SHA1 Message Date
Tao Sang e212e1a947 SWDEV-273943 - Enable runtimeApi.event dtest
Add device_id_ in hip::event to match cuda behaviour in
hipEventQuery() and hipEventRecord().
Enable hipEventElapsedTime test on AMD platform.
Workarround sporadic crash of hipEventIpc test due to
some bug of event ipc.
Add missing hipEventDestroy() in some event tests.
Fix some logic code errors.
Fix typo in comment.

Change-Id: I9ec74c475161b3e31df48d193449023e921f2924


[ROCm/clr commit: 629ea5fe19]
2021-03-16 17:12:08 -04:00
Vladislav Sytchenko d09885f10d SWDEV-275317 - Correctly pass HIP image width to ROCclr APIs in AtoD/DtoA copies
HIP assumes that image width is in bytes, but OCL/ROCclr assumes that
it's in pixels. AtoD/DtoA need to account for this.

Change-Id: I275bd41d8b03e141caaf951bc6b714e51ca72dfc


[ROCm/clr commit: 82e40a6438]
2021-03-15 21:09:58 -04:00
Payam 67fd63192a SWDEV-182753 - Throw error if launch params>bounds
Change-Id: I5f9931efac37e3149894ca116a1b0c2dcc3e5bc5


[ROCm/clr commit: 2e52ceca29]
2021-03-12 19:17:08 -05:00
Rahul Garg 513c951343 SWDEV-270599 - hipExtLaunchKernelGGL Event Timing Incorrect Between Two Launches
Change-Id: I599a51720f297209072c6be8fffe2aa61e1a071e


[ROCm/clr commit: cc17122987]
2021-03-09 12:18:39 -05:00
Satyanvesh Dittakavi c8e84cbf02 SWDEV-275317 - Fix hipMemcpy2DFromArray to return proper error types
Change-Id: Id722865d81460bfd2fa6ad7a198b6e3c2a08265a


[ROCm/clr commit: daafd303ec]
2021-03-09 05:22:23 -05:00
German Andryeyev 03ee6e58b0 SWDEV-272496 - enqueue a marker for callbacks always
The current implementation in ROCclr for callback is
based on OCL specification. If in HIP the same command
could get multiple callbacks, then ROCclr will process them in
a reverse order. Unique Markers for each callback will make
sure it won't happen.
Add a dependency wait for callbacks, since HSA signal callback
doesn't guarantee the order.

Change-Id: I9d514734e258312fe9a74d48132361eb17c52d67


[ROCm/clr commit: e48111bfce]
2021-03-08 14:19:53 -05:00
Sarbojit Sarkar 27e4e966f7 SWDEV-254329 - Profiler ON/OFF fix
Change-Id: I996d185d2079ce68234109564a529a187ba4f04b


[ROCm/clr commit: 95b2ad994c]
2021-03-08 01:27:46 -05:00
Arya.Rafii 3d6667ccb7 SWDEV-269246 - Implementation of hipDrvMemcpy2DUnaligned
Change-Id: I86fdd3b930cbd74c45cd31944f0ea52c0ff65a59


[ROCm/clr commit: 8cb232ddef]
2021-03-04 14:38:06 -05:00
Arya.Rafii cd4aec747f SWDEV-269246 - Added missing exports for hipArrayDestroy
Change-Id: I730814720bb618e895efbe2f412e437110bed8bc


[ROCm/clr commit: 9f142f988d]
2021-03-04 14:29:16 -05:00
kjayapra-amd 2b715e4826 SWDEV-259566 - Adding support to retrieve handle for offsetted pointer.
Change-Id: I5da5ab6a24c6df915950637feb486b8c288e60e0


[ROCm/clr commit: 8ef68df3a8]
2021-03-04 12:28:56 -05:00
German Andryeyev 23c0d39315 SWDEV-272496 - Delay enqueue until callback setup
With direct dispatch enqueue occurs before callback update and
it can't be tracked in the device backend

Change-Id: Ie8793e3ddb68cc5bb36348f7a8dcdbdc87a2487c


[ROCm/clr commit: b0402a95bf]
2021-03-03 13:14:28 -05:00
Ravi C Akkenapally 4cf7a5799a SWDEV-179105 - Stream Operations: Add swqupport for Wait and Write
Change-Id: I9d6d0665d12b62fe705ce1569a0e8264a4f23ab7


[ROCm/clr commit: fd0f49503f]
2021-03-02 12:15:46 -08:00
Tao Sang 2a6f45533d SWDEV-270973 - Add missing copyright headers
Change-Id: I6bb27650f74372dae6e29c79fd6bb2022cc062fe


[ROCm/clr commit: 4048db950c]
2021-03-01 19:46:24 -05:00
Jatin Chaudhary 59204ceea9 SWDEV-272361 - Dont call memcpy2d if width is 0 or height or depth is 0
Change-Id: I22324a536d2a5e68b9fc3e5ee4ad821b49021a17


[ROCm/clr commit: ec832d42d1]
2021-03-01 14:34:58 -05:00
cjatin 3152413001 SWDEV-271274 - Changing DevLogPrintf to LogPrintf for cases where error condition is being returned
Change-Id: I153d071f7859e9412ea0c69f53c53d190453d73d


[ROCm/clr commit: 564417d00f]
2021-03-01 14:33:46 -05:00
Ashutosh Mishra cd0b146be0 SWDEV-271126 - Memory obtained from getDeviceMEmory can be NULL
which can cause segmentation faults. Hence checking for its sanity

Signed-off-by: Ashutosh Mishra <ashutosh.mishra@amd.com>
Change-Id: I78b4d029f0926a1369a8ebbeb4aef951a8f1f1d7


[ROCm/clr commit: b9c0065e4f]
2021-02-26 23:29:53 -05:00
Payam a8df01574a SWDEV-273405 - updated roctracer path to use env var
Change-Id: I9ec74c475161a3e310f57d193449023e921f2922


[ROCm/clr commit: 5b7dd3a4b9]
2021-02-26 14:51:26 -05:00
cjatin 3d0abe6803 SWDEV-273859 - Add --hip-version to comgr call
Change-Id: Iae6c1a5e958a73f5d9849c13c8b49eede914e25e


[ROCm/clr commit: 41d7c688c9]
2021-02-24 23:41:34 -05:00
Arya.Rafii 64f7d5b430 SWDEV-269246 - Fixed null-case logic for hipCtxPopCurrent
Change-Id: Ic173980caccde8afee85a75c55a5d536f421549e


[ROCm/clr commit: 5c2eb09624]
2021-02-24 13:20:24 -05:00
kjayapra-amd 9374c2bb93 SWDEV-274058 - Porting HIP, ROCclr gfx90a changes to mainline.
Change-Id: I02f53d4c7897d26243620cfc961fa9bd984cede4


[ROCm/clr commit: 20dd93a3be]
2021-02-24 09:55:43 -05:00
German Andryeyev ad0fb5721d SWDEV-272496 - Add marker if notification was the last command.
If MT is enabled, then a new callback can be received before the previous
command is processed, causing a conflict of 2 callbacks.

Change-Id: I5ff8f231208e8d62824d590d3c8e791e8e36affb


[ROCm/clr commit: fe7501a64b]
2021-02-23 13:12:06 -05:00
Vladislav Sytchenko c920024cde SWDEV-255979 - Fix Windows build
Change-Id: I1f1375911d90ded9043a4716e7d09a3ca6a33c23


[ROCm/clr commit: be3c5183b2]
2021-02-19 11:31:52 -05:00
agodavar 601d2453be SWDEV-255979 - Added support of __managed__ static variable
Change-Id: I9d5cbbecc8c19ec38a95c94ab4130465ba76c102


[ROCm/clr commit: d5b4762d96]
2021-02-17 13:01:29 -05:00
Satyanvesh Dittakavi 82a333b3ba SWDEV-272543 - Fix hipDeviceGetP2PAttribute when both devices are same
Change-Id: I3db17a962807565ea134e3cbcefa66d373e2d363


[ROCm/clr commit: d721c79f36]
2021-02-17 12:41:59 -05:00
Rahul Garg e78e7b8abc SWDEV-271182 - Fix HdpMemFlushCntl and HdpMemFlushCntl
Change-Id: I33e5a677c6c6e1d83e6343f8e3690d7b34fe2af5


[ROCm/clr commit: 607795ec9d]
2021-02-12 14:38:56 -05:00
Sarbojit Sarkar 8a48c8a0e0 SWDEV-270630 - Added missing nullcheck
Change-Id: I7caf26c59c4660e26b4159da35731c2ce1600819


[ROCm/clr commit: 3f5fb8e9df]
2021-02-12 13:29:30 -05:00
Sarbojit Sarkar 3c1920f76c SWDEV-271496 - Added missing params check
Change-Id: I17bbf5ed445826e7380df22fa5c6ec1675e208d6


[ROCm/clr commit: b7fd0bc902]
2021-02-12 13:28:12 -05:00
Vladislav Sytchenko 69e9b5c0ee SWDEV-252745 - Guard PCH code behind __HIP_ENABLE_PCH macro
Change-Id: I12425b9d44b3d92f9cacceb797a5d09d99e4156b


[ROCm/clr commit: 9f84ea96be]
2021-02-10 09:23:41 -08:00
Zack Galbreath f3369ee1d8 SWDEV-264220 - Provide CMake hip language configuration information
This provides the required information for CMake to bootstrap
HIP language and runtime support. In particular this file
is consumed by CMake during HIP compiler detection to
determine the required flags needed for compilation and
linking.

Initial design was discussed in #2158

Add copyright / license header

Change-Id: I10acb860bf6291b2deb6b678e6e916faa7c82c2a


[ROCm/clr commit: ddb061cecf]
2021-02-10 08:26:35 -05:00
cjatin c31897edcf SWDEV-252745 - Adding rtc options transformer
Change-Id: Ib250689906a35f81255398e53da979774361dbfa


[ROCm/clr commit: caf9b2b108]
2021-02-09 13:35:30 -05:00
agodavar 390565d4b7 SWDEV-271096 - Handle depth zero in hipMalloc3D
Change-Id: I0ef0cc825e20b3480e9e5476e09dde5f73cdd3ea


[ROCm/clr commit: 8f85d89812]
2021-02-09 08:39:44 -05:00
Jatin Chaudhary 3de1a22c48 SWDEV-271274 - Remove hip init call from hipUnregisterBinary, this call ends up initializing rocclr and hsa even when there is no hip call in the entire file
Change-Id: I20c1d3079c6032d79c5b892d5616921f7aeb4fe2


[ROCm/clr commit: 7b6244b641]
2021-02-09 07:59:32 -05:00
agodavar f379ff60bd SWDEV-269085 - Add support for build with ADDRESS_SANITIZER
Change-Id: I102cbe197727ec059d3dc9fae3a41bb559b0dff1


[ROCm/clr commit: eb58a0285c]
2021-01-29 01:54:43 -05:00
Vladislav Sytchenko 4987cc7052 SWDEV-1 - Fix Windows build
Change-Id: I20c727a8718941694da6dc024efdfd1eb6af828b


[ROCm/clr commit: f174d98893]
2021-01-28 10:22:25 -05:00
agodavar 4017a88253 SWDEV-269400 - handle nullptr in hipFuncGetAttributes and blockSizeLimit<0 in hipModuleOccupancyMaxPotentialBlockSize
Change-Id: Ia1c6e5713f40876b4a9c7a1c56b7b3a589c4497a


[ROCm/clr commit: 160f0edffa]
2021-01-27 23:41:31 -05:00
agodavar 53a0b62f82 SWDEV-268552 - HIP sample segfaults during hipModuleLoad, fix mmap bug
Change-Id: I51c6061e7ac6b2524586d96fdd69b9f084b1906a


[ROCm/clr commit: 2d2f127b8a]
2021-01-27 23:39:50 -05:00
Rahul Garg 447657f32d SWDEV-270166 - Remove Linux specific includes
Change-Id: I929285941f28941cb41718f9fb8f618d11f1a69b


[ROCm/clr commit: fecaab1179]
2021-01-27 12:10:37 -05:00
agodavar 0cf97308ae SWDEV-267154 - Add checks for grid and block dimensions 0
Change-Id: I54799c0a4a42a91f6226f94a1e3ff7bc79046a98


[ROCm/clr commit: a16d91a708]
2021-01-27 00:32:31 -05:00
Vladislav Sytchenko 29dd5f95ad SWDEV-1 - Fix Windows build
Change-Id: I144142b2b31785fe7b1d319fb7e88eb2b41099ac


[ROCm/clr commit: 09c28dcbf4]
2021-01-26 15:51:57 -05:00
Joseph Greathouse de014d4042 SWDEV-269756 - Add missing Cooperative Groups error string
Change-Id: I1833f8bb4b48b19bb3d6cac57dda429231cf3562


[ROCm/clr commit: 51e53b6b56]
2021-01-22 15:48:18 -06:00
Tony Tye cfc4640981 SWDEV-268864 - Use new isa class to access isa related information (part 2)
Change-Id: If7ed535b3012aec3f2cb4eb7ab93d8f5aed9783f


[ROCm/clr commit: 6b641fb368]
2021-01-19 03:36:22 +00:00
Tony Tye c9c78bca63 SWDEV-268864 - Use new isa class to access isa related information
Change-Id: I2122bf85155997d802ca54e456c2dae66b801825


[ROCm/clr commit: cd1117d627]
2021-01-18 22:31:01 +00:00
Tony Tye 7d42f2535d Use ROCclr Info.targetId_
Use Info.targetId_ instead of Info.name_ so it will work on Windows
PAL driver and ROCm.

Change-Id: I20537899c36c0ee330a4c09136a52e53d9f35e0d


[ROCm/clr commit: 7d35a43165]
2021-01-14 05:17:20 +00:00
Rahul Garg f169546403 Add IPC Events support
Change-Id: Iac2bf3d5e1d9a993bebbb066c20d300d6f05558b


[ROCm/clr commit: 3829645039]
2021-01-08 20:09:26 +00:00
Tao Sang eeb275d643 Remove hip-hcc codes: Part four
Remove __HCC__, __HCC_ONLY__, __HCC_CPP__, __HCC_C__,
__HCC_OR_HIP_CLANG__, __HIP_ROCclr__ and their guarded codes.

Remove Hcc codes from directed_tests and samples.

Remove __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__ from
some files where they are not necessary.

Add deprecation notice.

Change-Id: I1ae467eafd749d6c25bca204c1724b026be21fce


[ROCm/clr commit: d504a761ad]
2021-01-08 10:53:34 -05:00
agodavar efe86a0f88 SWDEV-245381: Updated guarantee error messages to print based on BUILD_TYPE
Change-Id: Ifafbc075d6b9860da040c72859127c4e638a786f


[ROCm/clr commit: 6838df46eb]
2021-01-05 23:29:50 -05:00
Tao Sang 2c1c9f78d6 Remove hip-hcc codes: Part three
1.Rename include/hip/hcc_detail/ as include/hip/amd_detail/

2.Rename include/hip/nvcc_detail/ as include/hip/nvidia_detail/

3.Create __HIP_PLATFORM_AMD__ to replace __HIP_PLATFORM_HCC__

4.Create __HIP_PLATFORM_NVIDIA__ to replace __HIP_PLATFORM_NVCC__

After hcc_detail, nvcc_detail, __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__
have been removed from upstream, they will be removed from hip runtime.

Change-Id: I1ae457effd739d6c25bca203c1724b026be21fce


[ROCm/clr commit: 8a2b0b7424]
2021-01-05 10:39:31 -05:00
Satyanvesh Dittakavi 7fec171e78 SWDEV-263678 - fix rocHPCG mgpu perf drop
Change-Id: I33269fe4f6165d1ed172b19033ab9fcb92f338c3


[ROCm/clr commit: 15baf7ef6d]
2021-01-05 00:22:12 -05:00
cjatin 42dfa8e5c4 Add ELF Flags moved from rocclr
Change-Id: I5febe7bdca80517e9f9492d7930def72db83c14e


[ROCm/clr commit: 6faffdffd2]
2021-01-04 13:43:16 -05:00
Sarbojit Sarkar fae1bcd07c Revert "Fix hipmemset to match CUDA behavior"
This reverts commit 76a2999f22.

Change-Id: I53052b25bac4956f3efd124eadc936197f2e466a


[ROCm/clr commit: f64af513a2]
2021-01-01 00:11:58 -05:00