- correct condition for flags
- remove check for num of dependency
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6efd918e203b57c840d74ee0243f24b0c2c80e21
[ROCm/clr commit: a10df01f81]
HIP_FORCE_QUEUE_PROFILING has been replaced by GPU_FORCE_QUEUE_PROFILING.
Change-Id: Ic8dec4407ef79c27094cb3954e48869075b4732f
[ROCm/clr commit: 97741fe5d4]
Hiprtc related libraries are duplicated when installed from build directory
This happens when cmake install libdir is set with lib64 as default and using hard code path "lib" for LIBRARY_DESTINATION
Replaced "lib" with cmake install libdir
Removed the default setting of libdir in source code and its should be controlled via build argument
Change-Id: Icac55eac9427a5088903d01942e6bfd5263a6fc0
[ROCm/clr commit: ba04f95771]
Fixed an error in the CMakeLists.txt USE_PERF_API option declaration
that was making it always disabled. Fixing this exposed an issue with
the hip_prof_gen.py script's handling of function variants (for example,
_spt functions) and new HIP_INIT_API_* macros.
Also switched the python interpreter to python3 as python2 may not be
available by default on the build system.
Change-Id: I971fc9edcc746ca63a2bdf4f540e755f9a80fe69
[ROCm/clr commit: 8ac20e5e38]
Replace the custom reader/writer lock with the standard implementation
available in C++17.
Change-Id: I46013b821f13a023a16094830b7f45c4bacf11cb
[ROCm/clr commit: 008aa1c2e1]
- add user obj APIs for creating release and retain of user onbjects
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I0bf2999c77e44269565b27c31c7c1461f8a160a2
[ROCm/clr commit: 2c010dec17]
- if flags are not supported
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id7570d2c5f3d1169da33561f05c278dcd1834db6
[ROCm/clr commit: 58c5e17c5f]
- hiprtcCompileProgram should create isa with temp name when
program name is not provided along with --save-temps option
Change-Id: I47974e2ac56336c851531622ff7d2a3ffb53455e
[ROCm/clr commit: 958b97b433]
- Don't pass uint32_t arguments by reference.
- Use nullptr instead of NULL.
- Don't add frivolous typedefs.
- Use correct types when available instead of generic integral types.
- Make all roctracer callbacks extern "C" to prepare for a future change
that will be removing their declaration from hip_runtime_api.h.
- Rename cb/sem sync and release functions -> reader_lock/writer_lock
acquire and release.
Change-Id: If203fee077d421a9782fcd34607a413b8c3dcfc8
[ROCm/clr commit: 9f09ca929e]
When acquiring the reader's lock (sem_sync()...sem_release()), it is
possible for a writer to squeeze by if the reader goes into sync_wait().
The writer could re-acquire the entry.sync between entry.sem > 0 and
entry.sync = 0.
void sync_wait(uint32_t id) {
sem_decrement(id);
while (entry(id).sync.load()) {}
// <--- HERE
sem_increment(id);
}
This could result in both the reader and the writer accessing
{ callback, arg } at the same time, and the reader could read
inconsistent data, for example: { new callback, old arg }.
The solution is to re-test entry.sync when returning from sync_wait():
void sem_sync(uint32_t id) {
sem_increment(id);
- if (entry(id).sync.load() == true) sync_wait(id);
+ while (entry(id).sync.load() == true) sync_wait(id);
}
Change-Id: I22f74f4cb9a5f027aac8aa4ed3e633acc19df4b8
[ROCm/clr commit: 6f78083f2a]
This reverts commit d12900e000.
Reason for revert: Moved out to future release
Change-Id: I36b046c8681371baa9e0ccb69d46dad633ee5706
[ROCm/clr commit: d328d72fab]
- test should allow first calling get function
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I365cd6210a01fd5ae3620711694bdc52e0f90b19
[ROCm/clr commit: 66bde8f336]
- hiprtcAddLinkData should accept 0 or null as input name
- hiprtcLinkCreate should accept 0 or null as options ptr
- hiprtcCompile should send -fgpu-rdc option to comgr if its present in the options
Change-Id: I84f6e36df5c99b719ee9c67dfc1b4dbcfd8e3172
[ROCm/clr commit: ee27685ac4]
sdashmiz
Satyanvesh Dittakavi
Jiabao Xie
Jaydeep Patel
Jason Tang
Anusha Godavarthy Surya
Ranjith Ramakrishnan
kjayapra-amd
pghafari
Laurent Morichetti
Sarbojit Sarkar
Ajay
Tao Sang
Maneesh Gupta