Wykres commitów

331 Commity

Autor SHA1 Wiadomość Data
Rahul Garg 83b9cc743c Fix nested designator warnings (#1768)
[ROCm/clr commit: 178d432b90]
2020-01-06 12:33:34 +05:30
Evgeny Mankov 8c58286a9b Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/clr commit: ed43699a3a]
2019-12-30 19:21:09 +03:00
ansurya 56d51a3dc7 Fix texture 3D & 2D layered with N components (#1746)
SWDEV-151670: Issue with 3D texture with 4 components
SWDEV-151671: Issue with 2D layered texture with 4 components

Fixed memcpy when memory is allocated with driver API's.

Github issues: #1755
Fixed 3D default case when array type is not set during memory allocation.

[ROCm/clr commit: 651c7a8e27]
2019-12-30 12:41:42 +05:30
Evgeny Mankov d191980c6a [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/clr commit: 4aaa2336a8]
2019-12-23 17:01:35 +03:00
Alex Voicu 1f762e3970 Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/clr commit: 150e690a3a]
2019-12-23 19:11:24 +05:30
Rahul Garg 48faf7423a Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.

[ROCm/clr commit: a369bd4418]
2019-12-06 09:51:53 +05:30
Rahul Garg 6c7a338471 Fix hipMemcpyWithStream (#1707)
* Fix hipMemcpyWithStream
* Add a dtest for the same.


[ROCm/clr commit: 261a04580f]
2019-12-04 11:56:23 +05:30
Jeff Daily 22c07e2331 fix hipMempcy precondition, test for zero size first (#1697)
[ROCm/clr commit: 6df73e1f12]
2019-11-25 19:03:03 -08:00
Alex Voicu 553a7c2ce3 General sync memcpy improvements. Add hipMemcpyWithStream (#1673)
* General sync memcpy improvements. Add `hipMemcpyWithStream`

* Update hip_memory.cpp


[ROCm/clr commit: 022ac3cb0a]
2019-11-20 21:36:37 +05:30
Jeff Daily bc5596cc74 General hipMemset improvements (#1495)
* hipMemset et al can use HSA API directly for synchronous cases

* lock and flush stream in hipMemset, hold lock until complete

* move hipMemset async check to front of conditional

* use hsa_amd_memory_fill for additional sync memset cases

code cleanup/review for all memset calls

* Fix inversion of execution mutating value.

* ihipMemsetSync fall back to kernel if HSA memset fails

* Never fallback, never surrender.

* Allow NULL stream.

* Optimise memset kernel. Remove deadwood.

* Update hip_memory.cpp

* Clean up stream logic in sync memset

* Revert "Clean up stream logic in sync memset"

This reverts commit 6117dedf673367f44cc704192573a117a3d92477.


[ROCm/clr commit: 854147e911]
2019-11-07 13:19:54 +05:30
ansurya f5a92e5cb6 Fixed texture 2D mapping for pitched arrays & 3D Texture read (#1415)
Texture 2D image mapping for pitched arrays:
github issue: Texture Object's Buffer seems to be Misaligned #886
JIRA ticket: SWDEV-199313

SWDEV-151670 : Fixed issue with 3D texture with 4 components
SWDEV-151671 : Issue with 2D layered texture with 4 components

[ROCm/clr commit: dc8f556460]
2019-11-07 13:17:46 +05:30
Rahul Garg 138b0327da Add stream
[ROCm/clr commit: f556e15361]
2019-10-31 12:15:56 -04:00
Rahul Garg 440a172f0e Fix HIP init calls in hipMemcpy2DFromArray
[ROCm/clr commit: 0718ba0f00]
2019-10-31 12:15:56 -04:00
Rahul Garg 7ea7a9c3b7 Add hipMemcpy2DfromArray (#1510)
Adds hipMemcpy2DFromArray and hipMemcpy2DFromArrayAsync equivalent to cudaMemcpy2DFromArray and cudaMemcpy2DFromArrayAsync.

[ROCm/clr commit: 14b870d1ce]
2019-10-25 15:43:33 +05:30
Aryan Salmanpour 9e0eaef846 [hip] add support for implicit kernel argument for multi-grid sync (#1456)
* [hip] add support for implicit kernel argument for multi-grid sync

* modified code for calculating the prev_sum

* change the impCoopArg type to size_t

* add memory clean up

* launch init_gws and main kernels into two separate loops


[ROCm/clr commit: 93c688a0c9]
2019-10-24 17:43:30 +05:30
Vladislav Sytchenko e2c2025e3e Update the declarations of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async. These functions are type aware and take in as their third argument the number of elements in the buffer, not the buffer size. Change the name of this argument from sizeBytes to count to align with the above description.
[ROCm/clr commit: 0200aa3a21]
2019-10-15 14:18:42 -04:00
ansurya efc64a4f8a Added new Memory API's (#1399)
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.


[ROCm/clr commit: 96890792b0]
2019-10-04 13:36:31 +05:30
satyanveshd 1c9dc1331e Reimplement hipMemGetInfo (#1447)
Addresses SWDEV-136570. hipMemGetInfo changed to compute free memory based on information from kfd instead of relying on hc::am_tracker.


[ROCm/clr commit: 1ae4cbed4d]
2019-10-01 12:40:36 +05:30
satyanveshd ca6b4bbc0d Fix checks in hipMemcpy[D/H]to[D/H]() (#1397)
* SWDEV-202043 hipMemcpyDtoD() issue


[ROCm/clr commit: 842e304a9c]
2019-09-16 08:32:38 +00:00
Rahul Garg f79ffd587e Fix typo and colon in comment
[ROCm/clr commit: d9179cbe70]
2019-09-13 03:09:01 +05:30
Rahul Garg b7a06efb6c [HACK] Temporary fix for hipFree for hipManagedMalloc
[ROCm/clr commit: 2e9b8e9d0d]
2019-09-13 02:10:21 +05:30
Rahul Garg 33af62d66e Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381)
This reverts commit 4313f00563.

[ROCm/clr commit: d433f6fb58]
2019-09-03 05:13:46 +00:00
Rahul Garg 14a510ee74 Fix memcpy with IPC slowness (#1321)
* Fix memcpy with IPC slowness

* Make early erroneous returns

* Real Clean up

* Real Clean up++


[ROCm/clr commit: a786728939]
2019-08-23 09:19:18 +00:00
Jatin Chaudhary 4313f00563 Using HSA API for hipMemsetAsync (#1346)
[ROCm/clr commit: 9bbd09b04f]
2019-08-21 10:00:10 +00:00
Rahul Garg 8966072920 Add hipMemcpy3DAsync (#1320)
* Add hipMemcpy3DAsync

* Fix CI build error

* Move back stream resolution to internal function

* Remove stream redefinition and check


[ROCm/clr commit: fbc9f7e20a]
2019-08-16 02:13:16 +00:00
Rahul Garg 6630b0caa6 Add hipMemcpyParam2DAsync (#1296)
* Add hipMemcpyParam2DAsync

* Add NVCC path changes

* Clean up

* Fix build issue

* Fix else use in both sync and async apis


[ROCm/clr commit: 569f35a258]
2019-08-09 11:50:37 +00:00
Jeff Daily 68f674205e consolidate thread local storage (#915)
* all thread local access now through single struct

* clean up old commented-out code, more use of GET_TLS()

* fewer calls to GET_TLS by passing tls as a funtion argument

* revert unnecessary change to printf

* fix failing tests due to TLS change

* fix merge conflicts in ihipOccupancyMaxActiveBlocksPerMultiprocessor


[ROCm/clr commit: f337ae1edb]
2019-08-05 09:51:02 +00:00
Rahul Garg 7a21d085ad Change hipErrorUnknown to hipErrorInvalidValue
[ROCm/clr commit: 1c49943ac3]
2019-07-31 00:28:30 +05:30
Evgeny Mankov 24af494e97 [HIP] Fix segfault on uninitialized struct members in hipArrayCreate and hipArray3DCreate
[ROCm/clr commit: 299fbd4842]
2019-07-12 16:38:26 +03:00
Evgeny Mankov b5f0cdaa7b [HIP][HIPIFY] Split HIP_ARRAY_DESCRIPTOR struct to HIP_ARRAY_DESCRIPTOR and HIP_ARRAY3D_DESCRIPTOR
[Reason] To be compatible with CUDA [#1133]

Update HIP code, hipify-clang, tests and docs

[TODO] Add support of the corresponding functions on nvcc fallback path


[ROCm/clr commit: f0832fd968]
2019-07-11 14:58:16 +03:00
Jatin Chaudhary 6e8edf8890 Adding bounds check before hipMemset (#1190)
* Adding bounds check in ihipMemset

* Adding ihipMemPtrGetInfo to hipMemPtrGetInfo


[ROCm/clr commit: fcb0a3d4e2]
2019-07-08 11:00:38 +00:00
Anusha Godavarthy Surya e643bae27d Added missing NULL checks and corrected API return values as per validation
[ROCm/clr commit: 4989452413]
2019-06-27 00:19:05 +05:30
Evgeny Mankov 204043c6e0 [HIP][HIPIFY] Make hipMemcpyParam2D coherent with cuMemcpy2D
+ Makes hip_Memcpy2D struct compatible with CUDA_MEMCPY2D struct
+ Add hipMemcpyParam2D support in nvcc fallback path
+ Update hipify-clang, tests and docs accordingly


[ROCm/clr commit: 9cb3e9aa5e]
2019-05-22 18:31:39 +03:00
Rahul Garg d44e800a17 Add fine grained host memory lock support (#1095)
* Add fine grained host memory lock support

* Fix default flag check


[ROCm/clr commit: e1f3dc0c80]
2019-05-13 11:48:26 +05:30
Rahul Garg d69edbbb7f Add hipMallocManaged default functional support (#1036)
* Add hipMallocManaged default functional support

* Fix build error

* Add dtest


[ROCm/clr commit: 94769fc8dd]
2019-04-24 16:50:03 +05:30
Jeff Daily cf4e198a91 In hipFree, synchronize owner of memory (#1018)
* In hipFree, if memory is associated with a device, synchronize that device's streams.

This changes the behavior from synchronizing the currently set TLS device.

* All devices sync in hipFree for _appId=-1 case.

* Revert "All devices sync in hipFree for _appId=-1 case."

This reverts commit 1efb34d6a8426661e45bc5f763422a1147aeac10.

* add HIP_SYNC_FREE env var


[ROCm/clr commit: cf8fb43e6b]
2019-04-16 08:35:55 +05:30
Rahul Garg 73bb9a74bb Handle D2D in memcpy2D
[ROCm/clr commit: 50d623981e]
2019-03-28 02:21:45 +05:30
Rahul Garg 0d47ae4203 Let hipHostMalloc always share/map pinned host ptr
[ROCm/clr commit: 9b38380c03]
2019-03-26 10:19:13 +05:30
Rahul Garg 21d7bbab11 Avoid double mapping of devices to hostMalloc buffer
[ROCm/clr commit: ad11972f47]
2019-03-25 23:07:05 +05:30
Maneesh Gupta 817e064745 Merge pull request #970 from mangupta/swdev-172995
hipExtMallocWithFlags implementation

[ROCm/clr commit: c20d233585]
2019-03-25 07:46:53 +00:00
Maneesh Gupta 505fc1e98c hipExtMallocWithFlags needs hcc workweek 19115 or higher
[ROCm/clr commit: 45255ab492]
2019-03-25 11:41:20 +05:30
Maneesh Gupta f1d064562d hipExtMallocWithFlags implementation
Change-Id: Iee9e119796472200b2933d5e23be60813f33bc75


[ROCm/clr commit: e44de376f7]
2019-03-19 11:59:22 +05:30
Rahul Garg da6653482d Add 2D fallback to use copy kernel
[ROCm/clr commit: af72cde0a1]
2019-03-14 13:03:06 +05:30
Alex Voicu 45f4ac5023 dlopen() fixes (#929)
* Initial attempt to switch over to internally linked state.

* Add missing CMake update.

* hipLaunchKernelGGLImpl must be inline as well. Ensure internal linkage.

* Ensure global retrieval uses internally linked state.

* Hide HC in the implementation. Minimise ADL woes.

* Strange software exists, and must be catered to.

* Use a less spammy mechanism for ensuring internal linkage / non-export.

* Remove leftover internal detail.


[ROCm/clr commit: ed48847237]
2019-03-06 17:31:44 +05:30
Wen-Heng (Jack) Chung e34b0ccd48 Address code review comments to use hipDeviceptr_t
[ROCm/clr commit: 8b7baa0bd9]
2019-03-05 05:51:05 +00:00
Wen-Heng (Jack) Chung 2706bf46f2 Add hipMemsetD32 and hipMemsetD32Async
Add 2 extra memset functions which fills memory with integer-typed data

Also change the parameters of ihipMemset to better explain the semantic


[ROCm/clr commit: 392271f4db]
2019-03-04 17:00:33 +00:00
Wilkin Chau 19b361281a Fix hipMemset3D test
Calculate the allocated size based on the width, height and depth.


[ROCm/clr commit: 99540373cf]
2019-02-28 22:42:46 +00:00
Evgeny a4df59d819 fixing HSA_INIT_API cid args
[ROCm/clr commit: 47625cb8fd]
2019-01-16 23:45:44 -06:00
Maneesh Gupta f096437107 Merge pull request #797 from gargrahul/fixhipPointerGetAttributes
Fixed hipPointerGetAttributes for hostmalloced ptr

[ROCm/clr commit: a778f7cdf7]
2018-12-12 10:16:07 +05:30
Maneesh Gupta 30ce297635 Merge pull request #608 from gargrahul/add_pinned_2d_sdma_copy
Added support for pinned 2D SDMA copy

[ROCm/clr commit: 6ce99b066c]
2018-12-12 07:44:16 +05:30