Commit Graph

13501 Commits

Author SHA1 Message Date
David Galiffi fb177c8352 Update pull_request_template.md (#258)
Rewording the "related issues" comments

[ROCm/rocprofiler-systems commit: 20efb9641f]
2025-06-19 11:06:13 -04:00
David Galiffi 20efb9641f Update pull_request_template.md (#258)
Rewording the "related issues" comments
2025-06-19 11:06:13 -04:00
Yat Sin, David 16ae2e90c6 Remove unnecessary dependency on hsakmt (#57) 2025-06-18 21:01:23 -05:00
Yat Sin, David 1360fbfd64 Remove unnecessary dependency on hsakmt (#57)
[ROCm/rocprofiler commit: 16ae2e90c6]
2025-06-18 21:01:23 -05:00
ajanicijamd ad2e95de05 Modified nic-performance test to download a smaller file (#253)
[ROCm/rocprofiler-systems commit: 4346c1c217]
2025-06-18 19:39:48 -04:00
ajanicijamd 4346c1c217 Modified nic-performance test to download a smaller file (#253) 2025-06-18 19:39:48 -04:00
David Yat Sin b3c48cc68c rocr: support reserving non-registered VA
Extend hsa_amd_vmem_address_reserve/hsa_amd_vmem_address_reserve_align
to support HSA_AMD_VMEM_ADDRESS_NO_REGISTER flag. This allocation can be
used to reserve virtual address ranges that can later be used by
hsa_amd_svm_attributes_set for SVM based memory allocations.
2025-06-18 18:21:11 -04:00
jamessiddeley-amd 979c59fadc added progress printout in rocprof-compute profile (#727)
* added progress printout for profiler

* added comments and fixed readability

* removed redundant newlines

* moved format_time helper function to utils

* removed tqdm and redundant time calc

[ROCm/rocprofiler-compute commit: 036866fc12]
2025-06-18 14:09:09 -04:00
jamessiddeley-amd 036866fc12 added progress printout in rocprof-compute profile (#727)
* added progress printout for profiler

* added comments and fixed readability

* removed redundant newlines

* moved format_time helper function to utils

* removed tqdm and redundant time calc
2025-06-18 14:09:09 -04:00
xuchen-amd 9d50115bd7 Integrate roofline in tui (#762)
* Update changelog, remove unused code.

* enable roofline in TUI.

* Remove roofline section when data not available.

* Fix workload dir path.

[ROCm/rocprofiler-compute commit: 5d8fd55e36]
2025-06-18 13:58:42 -04:00
xuchen-amd 5d8fd55e36 Integrate roofline in tui (#762)
* Update changelog, remove unused code.

* enable roofline in TUI.

* Remove roofline section when data not available.

* Fix workload dir path.
2025-06-18 13:58:42 -04:00
Luu, Jonathan 337cbeba6f SWDEV-531400 - Remove File reorganization backward computability (roctracer) (#40)
* SWDEV-531400 - Remove File reorganization backward computability (roctracer)

* removing no longer needed files

---------

Co-authored-by: Jonathan Luu <jonatluu@amd.com>

[ROCm/roctracer commit: 9a620d64d9]
2025-06-18 13:33:41 -04:00
Luu, Jonathan 9a620d64d9 SWDEV-531400 - Remove File reorganization backward computability (roctracer) (#40)
* SWDEV-531400 - Remove File reorganization backward computability (roctracer)

* removing no longer needed files

---------

Co-authored-by: Jonathan Luu <jonatluu@amd.com>
2025-06-18 13:33:41 -04:00
xuchen-amd 0b6e03adb0 CLI: enable roofline plot (#760)
* enable roofline plot in cli.

* Add roofline to analysis config.

* Unify global variables.

* Disable roofline for baseline comparison and gfx908.

* Add check for roofline.csv

[ROCm/rocprofiler-compute commit: 80159ee117]
2025-06-18 13:19:58 -04:00
xuchen-amd 80159ee117 CLI: enable roofline plot (#760)
* enable roofline plot in cli.

* Add roofline to analysis config.

* Unify global variables.

* Disable roofline for baseline comparison and gfx908.

* Add check for roofline.csv
2025-06-18 13:19:58 -04:00
Pratik Basyal 0f7ae37ca6 Broken link to ROCprofiler-SDK updated (#254)
[ROCm/rocprofiler-systems commit: 66e71574ba]
2025-06-18 13:15:18 -04:00
Pratik Basyal 66e71574ba Broken link to ROCprofiler-SDK updated (#254) 2025-06-18 13:15:18 -04:00
Daniel Su f155355b33 Add thread header to videodecode example (#252)
[ROCm/rocprofiler-systems commit: 475d6c0f1f]
2025-06-18 12:40:24 -04:00
Daniel Su 475d6c0f1f Add thread header to videodecode example (#252) 2025-06-18 12:40:24 -04:00
Baraldi, Giovanni 0ea9dbf7a8 Adding doc links for trace decoder, aqlprofile and viewer (#464)
Adding interlinks for trace decoder, aqlprofile and viewer

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>

[ROCm/rocprofiler-sdk commit: 9dadbbace5]
2025-06-18 14:10:18 +02:00
Baraldi, Giovanni 9dadbbace5 Adding doc links for trace decoder, aqlprofile and viewer (#464)
Adding interlinks for trace decoder, aqlprofile and viewer

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>
2025-06-18 14:10:18 +02:00
Chris Freehill 24f36de037 rocr: Add missing close of dmabuf after import 2025-06-17 20:22:34 -04:00
vedithal-amd ab985464ef Add docker files for testing (#761)
[ROCm/rocprofiler-compute commit: b16256fd07]
2025-06-17 16:18:35 -04:00
vedithal-amd b16256fd07 Add docker files for testing (#761) 2025-06-17 16:18:35 -04:00
Elwazir, Ammar b9b44070c9 Create external PR Workflow (#118)
Create external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Separating Internal and External Workflows (#119)

* Separating Internal and External Workflows

* Update continuous_integration.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Create external-pr-sync.yml (#121)

* Create external-pr-sync.yml

* Update external-pr.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Create external-pr-close.yml

 Fixing External PR Workflows

 Fixing External PR Workflows

 Fixing External PR Workflows


[ROCm/aqlprofile commit: 2f771e6107]
2025-06-17 14:55:35 -05:00
Elwazir, Ammar 2f771e6107 Create external PR Workflow (#118)
Create external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Separating Internal and External Workflows (#119)

* Separating Internal and External Workflows

* Update continuous_integration.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Create external-pr-sync.yml (#121)

* Create external-pr-sync.yml

* Update external-pr.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Create external-pr-close.yml

 Fixing External PR Workflows

 Fixing External PR Workflows

 Fixing External PR Workflows
2025-06-17 14:55:35 -05:00
Trowbridge, Ian 8de9854a62 [SDK] [CI] Update HSA EXT Step Version (#460)
Update HSA EXT step version

[ROCm/rocprofiler-sdk commit: 883a57ece7]
2025-06-17 08:55:58 -07:00
Trowbridge, Ian 883a57ece7 [SDK] [CI] Update HSA EXT Step Version (#460)
Update HSA EXT step version
2025-06-17 08:55:58 -07:00
Trowbridge, Ian 191778f071 Add copyright disclaimer for new files (#16)
[ROCm/rocprofiler-register commit: 19fe192e8f]
2025-06-17 10:34:21 -05:00
Trowbridge, Ian 19fe192e8f Add copyright disclaimer for new files (#16) 2025-06-17 10:34:21 -05:00
Elwazir, Ammar ca571e5d13 Add test target to the default build target (#117)
Signed-off-by: zichguan-amd <zichuan.guan@amd.com>
Co-authored-by: zichguan-amd <zichuan.guan@amd.com>

[ROCm/aqlprofile commit: 8dad9518dc]
2025-06-17 10:13:37 -05:00
Elwazir, Ammar 8dad9518dc Add test target to the default build target (#117)
Signed-off-by: zichguan-amd <zichuan.guan@amd.com>
Co-authored-by: zichguan-amd <zichuan.guan@amd.com>
2025-06-17 10:13:37 -05:00
David Galiffi 133834335d Unhandled enum in switch statement (#247)
Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 244c193a57]
2025-06-17 09:57:27 -04:00
David Galiffi 244c193a57 Unhandled enum in switch statement (#247)
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-17 09:57:27 -04:00
Elwazir, Ammar 4d79e1df30 [SDK] Support CMake option for using internal RCCL tracing + (temporary) enable in CI (#457)
* Temp: disable RCCL tracing

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Adding option to disable rccl tracing from CMake

* Update codeql.yml

* Misc updates

- ROCPROFILER_BUILD_RCCL -> ROCPROFILER_INTERNAL_RCCL_API_TRACE
- env.EXTRA_TEMP_CMAKE_OPTIONS -> env.GLOBAL_CMAKE_OPTIONS
- add (advanced) option ROCPROFILER_INTERNAL_RCCL_API_TRACE

* Fix rocprofiler::sdk::get_enum_label

- missing enum labels for HIP_RUNTIME_API_TABLE_STEP_VERSION > 8

* Update tests/rocprofv3/advanced-thread-trace/CMakeLists.txt

- improve various aspect of cmake -- particularly echoing where attdecoder_LIBRARY was found

* Use CMAKE_MESSAGE_INDENT

- add prefix to cmake messages to help indicate where messages are coming from
- make find_package(Python3 ...) QUIET for bindings

* Fix rocprofiler::sdk::get_enum_label

- handle HSA_AMD_EXT_API_TABLE_MAJOR_VERSION

* Fix rocprofv3 message for att library path

* Fix tests/rocprofv3/advanced-thread-trace/att_input.yml config

* Fix rocprofv3 check_att_capability + soversion/version library resolution

- Account for ROCPROF_ATT_LIBRARY_PATH in env in check_att_capability
- Add resolve_library_path
  - supports resolution of library names to SOVERSION and VERSION paths

* Fix python linting error (unused import)

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: aeb1621c2b]
2025-06-17 08:32:54 -05:00
Elwazir, Ammar aeb1621c2b [SDK] Support CMake option for using internal RCCL tracing + (temporary) enable in CI (#457)
* Temp: disable RCCL tracing

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Adding option to disable rccl tracing from CMake

* Update codeql.yml

* Misc updates

- ROCPROFILER_BUILD_RCCL -> ROCPROFILER_INTERNAL_RCCL_API_TRACE
- env.EXTRA_TEMP_CMAKE_OPTIONS -> env.GLOBAL_CMAKE_OPTIONS
- add (advanced) option ROCPROFILER_INTERNAL_RCCL_API_TRACE

* Fix rocprofiler::sdk::get_enum_label

- missing enum labels for HIP_RUNTIME_API_TABLE_STEP_VERSION > 8

* Update tests/rocprofv3/advanced-thread-trace/CMakeLists.txt

- improve various aspect of cmake -- particularly echoing where attdecoder_LIBRARY was found

* Use CMAKE_MESSAGE_INDENT

- add prefix to cmake messages to help indicate where messages are coming from
- make find_package(Python3 ...) QUIET for bindings

* Fix rocprofiler::sdk::get_enum_label

- handle HSA_AMD_EXT_API_TABLE_MAJOR_VERSION

* Fix rocprofv3 message for att library path

* Fix tests/rocprofv3/advanced-thread-trace/att_input.yml config

* Fix rocprofv3 check_att_capability + soversion/version library resolution

- Account for ROCPROF_ATT_LIBRARY_PATH in env in check_att_capability
- Add resolve_library_path
  - supports resolution of library names to SOVERSION and VERSION paths

* Fix python linting error (unused import)

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-06-17 08:32:54 -05:00
Bhardwaj, Gopesh 1f4084c7b5 Adding rocpd documenation (#449)
* Adding rocpd docuemenation

* rocpd format

* CHANGELOG update and indexing

* Fixing links

* format fixes

* fixing table

* major edits

* fixed logical error

* fixing rocprofv3 avail

[ROCm/rocprofiler-sdk commit: 3e43b1f019]
2025-06-17 15:41:53 +05:30
Bhardwaj, Gopesh 3e43b1f019 Adding rocpd documenation (#449)
* Adding rocpd docuemenation

* rocpd format

* CHANGELOG update and indexing

* Fixing links

* format fixes

* fixing table

* major edits

* fixed logical error

* fixing rocprofv3 avail
2025-06-17 15:41:53 +05:30
David Yat Sin 649ec63a4f rocrtst: Reduce host memory limit to 90%
Further reduce upper bound for rocrtstFunc.Memory_Max_Mem
as previous limit of 95% can still trigger OOM killer.
2025-06-16 21:02:20 -04:00
David Yat Sin 488cfd467c rocr: Always send free scratch notifications
Always send notification to profiler tools when scratch memory is freed.
2025-06-16 17:39:33 -04:00
Vladimir Indic f49b70142f [PC Sampling] Separate counts for issued and stalled samples (#756)
[ROCm/rocprofiler-compute commit: 451be8a600]
2025-06-16 15:09:21 -06:00
Vladimir Indic 451be8a600 [PC Sampling] Separate counts for issued and stalled samples (#756) 2025-06-16 15:09:21 -06:00
Kandula, Venkateshwar reddy 50d3edb569 [BUG FIX] [Counter Collection] SWDEV-523582- Use a map to differenciate xcc_sample_count wrt event id. (#99)
* use a map to differenciate xcc_sample_count wrt event id.

Change-Id: Ie1f2e8466edb244574686d49008125dc9f4e7efd

* Format.

Change-Id: I668c6ed448d8610d9d66f9cf77d0d27d7cf4e8b6

* use blockinfo to get xcc_sample_count.

Change-Id: I066a10e3185df4c8767d4f8eae59aca1f78f5284

* use EventAttribDim for xcc_sample_count.

Change-Id: Ide3707934b5b42c0462ea332b27f6e2e4fc0449f

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>

[ROCm/aqlprofile commit: 41cd5d6531]
2025-06-16 16:09:13 -05:00
Kandula, Venkateshwar reddy 41cd5d6531 [BUG FIX] [Counter Collection] SWDEV-523582- Use a map to differenciate xcc_sample_count wrt event id. (#99)
* use a map to differenciate xcc_sample_count wrt event id.

Change-Id: Ie1f2e8466edb244574686d49008125dc9f4e7efd

* Format.

Change-Id: I668c6ed448d8610d9d66f9cf77d0d27d7cf4e8b6

* use blockinfo to get xcc_sample_count.

Change-Id: I066a10e3185df4c8767d4f8eae59aca1f78f5284

* use EventAttribDim for xcc_sample_count.

Change-Id: Ide3707934b5b42c0462ea332b27f6e2e4fc0449f

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
2025-06-16 16:09:13 -05:00
vedithal-amd fccb9195ff Print counter list in DEBUG level (#758)
[ROCm/rocprofiler-compute commit: 7c0ffd14a9]
2025-06-16 16:53:00 -04:00
vedithal-amd 7c0ffd14a9 Print counter list in DEBUG level (#758) 2025-06-16 16:53:00 -04:00
Alysa Liu 3b450397d6 rocr: Fix wrong sizeof argument
Update size calculation from 2 * sizeof(void*) to 2 * sizeof(uint64_t)

Signed-off-by: Alysa Liu <Alysa.Liu@amd.com>
2025-06-16 13:11:07 -04:00
David Galiffi 21374bc8bc Cleanup of Dyninst build dependencies (#238)
- Refactor elfutils build folders. Move build artifacts to the "external" subfolders
- Remove reference to unused DYNINST configuration
- Declare Dyninst interfaces with other external declarations
- Updated cmake warning message
- Update the deprecation warning for "DYNINST_BUILD_${dep}" to make it clearer that the option is being translated to the new option, "ROCPROFSYS_BUILD_${dep}"

[ROCm/rocprofiler-systems commit: eaaec2cc3b]
2025-06-13 17:19:46 -04:00
David Galiffi eaaec2cc3b Cleanup of Dyninst build dependencies (#238)
- Refactor elfutils build folders. Move build artifacts to the "external" subfolders
- Remove reference to unused DYNINST configuration
- Declare Dyninst interfaces with other external declarations
- Updated cmake warning message
- Update the deprecation warning for "DYNINST_BUILD_${dep}" to make it clearer that the option is being translated to the new option, "ROCPROFSYS_BUILD_${dep}"
2025-06-13 17:19:46 -04:00
David Galiffi 76cde58f56 Removing dyninst builds from CI docker files (#249)
Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 8535da17c8]
2025-06-13 17:16:01 -04:00