Commit Graph

13501 Commits

Author SHA1 Message Date
David Galiffi 6a960a1edb Added copyright information to requested files (#167)
For SWDEV-526556

[ROCm/rocprofiler-systems commit: b25b6cec92]
2025-04-15 18:39:53 -04:00
David Galiffi b25b6cec92 Added copyright information to requested files (#167)
For SWDEV-526556
2025-04-15 18:39:53 -04:00
Galantsev, Dmitrii a5cb334f8b Add RDC_FI_GPU_BUSY_PERCENT
AMDSMI needs to merge first and bump the version to at least 24.4.2

Change-Id: I30149bb78c79ebc3de0dabdc8e63fcef12b2f406
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-04-15 17:00:56 -05:00
Kandula, Venkateshwar reddy a15f26f7ef [SDK] remove HIP_MEMSET_NODE_PARAMS for HIP step version >= 12. (#334)
* remove HIP_MEMSET_NODE_PARAMS for HIP step version >= 12.

* remove extra ifdef

* format.

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>

[ROCm/rocprofiler-sdk commit: 6cea857c6a]
2025-04-15 14:05:15 -07:00
Kandula, Venkateshwar reddy 6cea857c6a [SDK] remove HIP_MEMSET_NODE_PARAMS for HIP step version >= 12. (#334)
* remove HIP_MEMSET_NODE_PARAMS for HIP step version >= 12.

* remove extra ifdef

* format.

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
2025-04-15 14:05:15 -07:00
Indic, Vladimir 3dc4148c46 MI300 Stochastic PC Sampling Documentation and Changelog (#336)
* MI300 Stochastic PC Sampling Documentation

* Stochastic PC sampling title renaming

---------

Co-authored-by: Welton, Benjamin <Benjamin.Welton@amd.com>

[ROCm/rocprofiler-sdk commit: 96a0ef244f]
2025-04-15 14:04:19 -07:00
Indic, Vladimir 96a0ef244f MI300 Stochastic PC Sampling Documentation and Changelog (#336)
* MI300 Stochastic PC Sampling Documentation

* Stochastic PC sampling title renaming

---------

Co-authored-by: Welton, Benjamin <Benjamin.Welton@amd.com>
2025-04-15 14:04:19 -07:00
Madsen, Jonathan 50bc3ed803 [Misc] Rework header includes (#311)
* Update header file includes

* Fix includes for lib/rocprofiler-sdk/hip/hip.hpp

* Minor touch ups

* Minor include improvements

* Doxygen tweak

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: c5a3edc3fa]
2025-04-15 14:02:12 -07:00
Madsen, Jonathan c5a3edc3fa [Misc] Rework header includes (#311)
* Update header file includes

* Fix includes for lib/rocprofiler-sdk/hip/hip.hpp

* Minor touch ups

* Minor include improvements

* Doxygen tweak

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-04-15 14:02:12 -07:00
Kandula, Venkateshwar reddy 94cbb26b35 SWDEV-524130: add reduced sum counters for new mi355 counters (#328)
add derived counter for td, tcc, ta.

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>

[ROCm/rocprofiler-sdk commit: bc85151a51]
2025-04-15 13:37:28 -07:00
Kandula, Venkateshwar reddy bc85151a51 SWDEV-524130: add reduced sum counters for new mi355 counters (#328)
add derived counter for td, tcc, ta.

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
2025-04-15 13:37:28 -07:00
Welton, Benjamin bc4160833b Add SerializedAtomicRatio counter (#327)
Co-authored-by: Benjamin Welton <bewelton@amd.com>

[ROCm/rocprofiler-sdk commit: f143333df0]
2025-04-15 13:36:34 -07:00
Welton, Benjamin f143333df0 Add SerializedAtomicRatio counter (#327)
Co-authored-by: Benjamin Welton <bewelton@amd.com>
2025-04-15 13:36:34 -07:00
Bhardwaj, Gopesh 8778237298 doc improvements for 1.0.0 part 2 (#330)
* update installation steps

* Github Issue #50 Adding README's for samples

* Making name change to ROCprofiler-SDK for consistency

* Fix HIP trace documentation

* Fix HSA trace in docs

* Fix kernel trace in docs

* Fixing memory copy and memory allocation traces

* runtime trace and sys trace doc update

* Fix scratch memory doc

* kernel naming and filtering options

* Adding collection period in docs

* Perfetto configs update

* summary output file

* kernel trace format fix

* update CHANGELOG

* Agent index doc update

* rocm-smi output

* group by queue option

* Updated --group-by-queue description

* perfetto visualization

---------

Co-authored-by: Ian Trowbridge <Ian.Trowbridge@amd.com>

[ROCm/rocprofiler-sdk commit: ca7cce9e81]
2025-04-15 13:30:07 -07:00
Bhardwaj, Gopesh ca7cce9e81 doc improvements for 1.0.0 part 2 (#330)
* update installation steps

* Github Issue #50 Adding README's for samples

* Making name change to ROCprofiler-SDK for consistency

* Fix HIP trace documentation

* Fix HSA trace in docs

* Fix kernel trace in docs

* Fixing memory copy and memory allocation traces

* runtime trace and sys trace doc update

* Fix scratch memory doc

* kernel naming and filtering options

* Adding collection period in docs

* Perfetto configs update

* summary output file

* kernel trace format fix

* update CHANGELOG

* Agent index doc update

* rocm-smi output

* group by queue option

* Updated --group-by-queue description

* perfetto visualization

---------

Co-authored-by: Ian Trowbridge <Ian.Trowbridge@amd.com>
2025-04-15 13:30:07 -07:00
Charis Poag a0df877fdf [SWDEV-518325/SWDEV-518320/SWDEV-443309] Fix Partition Enumeration
* Changes:
  - Updates to DRM renderD* / card* pathing for partition devices
  - Now use KFD to discover AMD devices and populate accordingly
    Device MUST have an accessible KFD node (via cgroups)
  - Updated several ROCm SMI CLI outputs to handle SYSFS files
    which are not accessible on partition nodes
  - Added a new method to help get card/drm info
    (rsmi_dev_device_identifiers_get) from ROCm SMI

Change-Id: If844f27ffc595942272abe9c8167ed90a0b0e225
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2025-04-14 16:03:24 -05:00
Trowbridge, Ian 5a5fe7f4bf Copyright Compliance (#333)
* Added copyright information to requested files

* Formatting

* Fix bad function name error

[ROCm/rocprofiler-sdk commit: 4fbcfd142c]
2025-04-14 13:07:32 -05:00
Trowbridge, Ian 4fbcfd142c Copyright Compliance (#333)
* Added copyright information to requested files

* Formatting

* Fix bad function name error
2025-04-14 13:07:32 -05:00
Castillo, Juan 2630bf0a8c [SWDEV-516013]-rocm-smi runtime status check fix (#28)
rocm-smi is not working in mGPU, Blocking DLM tests
Updates include:
 - Creating check_runtime_status function to check for device status of active.
 - Added warning to users that No AMD GPUs are available, check power status/control.
 - Added check for empty string coming from HWMON, if emtpy returns unexpected data.

---------

Signed-off-by: Juan Castillo <juan.castillo@amd.com>
2025-04-14 13:05:22 -05:00
David Galiffi d629a890a1 Fix RPM generation on RHEL 10 (#162)
* Set version for RPM_PACKAGE_OBSOLETES

* Not setting a version of omnitrace which rocprofiler-systems obsoletes will result in a warning

* Patch RPATH in libunwind files

* Update Timemory pointer

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 75916f8876]
2025-04-14 11:34:53 -04:00
David Galiffi 75916f8876 Fix RPM generation on RHEL 10 (#162)
* Set version for RPM_PACKAGE_OBSOLETES

* Not setting a version of omnitrace which rocprofiler-systems obsoletes will result in a warning

* Patch RPATH in libunwind files

* Update Timemory pointer

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-04-14 11:34:53 -04:00
Elwazir, Ammar f23fe43c29 SWDEV-526393: HSA_TOOLS_LIB is not respected for some pytorch APPs (#24)
HSA_TOOLS_LIB is not respected for some pytorch APPs

Instead of depending on HSA_TOOLS_LIB, move to depending on LD_PRELOAD for loading the rocprofiler library.
2025-04-14 08:41:00 -05:00
Elwazir, Ammar 0270964ce6 SWDEV-526393: HSA_TOOLS_LIB is not respected for some pytorch APPs (#24)
HSA_TOOLS_LIB is not respected for some pytorch APPs

Instead of depending on HSA_TOOLS_LIB, move to depending on LD_PRELOAD for loading the rocprofiler library.

[ROCm/rocprofiler commit: f23fe43c29]
2025-04-14 08:41:00 -05:00
ywang103-amd 46bf2453cc configure rocprofv3 as default for unit test (#668)
[ROCm/rocprofiler-compute commit: fe2035d166]
2025-04-11 19:30:18 -04:00
ywang103-amd fe2035d166 configure rocprofv3 as default for unit test (#668) 2025-04-11 19:30:18 -04:00
Galantsev, Dmitrii ac50573e67 CMAKE - Bump version to 1.1.0
Change-Id: I0fbc0f6d842c034ad858f30fa6418afd01e11a4f
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-04-11 17:27:27 -05:00
Galantsev, Dmitrii dfae9cd37f Profiler - Remove buffer to fix memory leaks
Change-Id: Ia3717ccfc147221557f5469965c2abb76b3f451c
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-04-11 17:27:27 -05:00
Trowbridge, Ian 5467c83188 rocDecode Buffer Tracing Support (#315)
* Added buffer tracing support for rocdecode and updated tests to work with buffer tracing

* Updated perfetto to output args individually rather than as a string list

* Updated docstrings and operation type, changed OTF2 code to remove warning due to change in operation type

* Updated tests for review comments

* Test args exist and return value

* Updated to use string entry

* Change function name

* Updated PR to reflect review comments

* Updated for PR review comments

* Change function name

[ROCm/rocprofiler-sdk commit: 077723337a]
2025-04-11 21:56:36 +00:00
Trowbridge, Ian 077723337a rocDecode Buffer Tracing Support (#315)
* Added buffer tracing support for rocdecode and updated tests to work with buffer tracing

* Updated perfetto to output args individually rather than as a string list

* Updated docstrings and operation type, changed OTF2 code to remove warning due to change in operation type

* Updated tests for review comments

* Test args exist and return value

* Updated to use string entry

* Change function name

* Updated PR to reflect review comments

* Updated for PR review comments

* Change function name
2025-04-11 21:56:36 +00:00
cfallows-amd 10d304f365 Add roofline support for rhel10 (#667)
-add check for rhel10 (platform:el10), force use rhel roof binary
-update changelog in 'unreleased- added' section

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: c056a39db4]
2025-04-11 17:45:53 -04:00
cfallows-amd c056a39db4 Add roofline support for rhel10 (#667)
-add check for rhel10 (platform:el10), force use rhel roof binary
-update changelog in 'unreleased- added' section

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-04-11 17:45:53 -04:00
cfallows-amd ffa47d197e Fix rpath checks during RPM generation on RHEL10 (#669)
Invalid rpath on roofline binaries reported during build testing for new RHEL10 addition, removed rpaths to prevent rpath check failures.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 03732d3719]
2025-04-11 17:40:59 -04:00
cfallows-amd 03732d3719 Fix rpath checks during RPM generation on RHEL10 (#669)
Invalid rpath on roofline binaries reported during build testing for new RHEL10 addition, removed rpaths to prevent rpath check failures.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-04-11 17:40:59 -04:00
anujshuk-amd 36f7de25a2 Change the default value of ROCPROFSYS_SAMPLING_CPUS to "none" (#164)
[ROCm/rocprofiler-systems commit: 807a622b04]
2025-04-11 17:09:26 -04:00
anujshuk-amd 807a622b04 Change the default value of ROCPROFSYS_SAMPLING_CPUS to "none" (#164) 2025-04-11 17:09:26 -04:00
Daniel Su 413c564cdd External CI: add parallel mainline checks for develop and staging branches (#666)
[ROCm/rocprofiler-compute commit: 36aa7fb7a9]
2025-04-11 15:34:18 -04:00
Daniel Su 36aa7fb7a9 External CI: add parallel mainline checks for develop and staging branches (#666) 2025-04-11 15:34:18 -04:00
Shane Xiao 6a63170b38 rocr: Add rec sdma engines with limited XGMI SDMA engine
This patch will adds recommended sdma supports with
limited XGMI SDMA engine. It will use one PCIe SDMA
to do gpu <-> gpu copies which will help improve all
to all copy performance.

Signed-off-by: Shane Xiao <shane.xiao@amd.com>
2025-04-11 23:54:15 +08:00
Pryor, Adam 58811fecbb [SWDEV-515192] Fix rdc topo (#146)
Change-Id: I64a8077a56e2eaf99735fafb1010d869a1fdb0c3

Signed-off-by: adapryor <Adam.pryor@amd.com>
2025-04-10 17:46:08 -05:00
Jonathan Kim 4c3a0698f8 kfdtest: fix trap on start for gfx 9 and 11
Similar to GFX 12, GFX 9 and 11 need to exit without forwarding
the PC.
2025-04-10 14:48:19 -04:00
Galantsev, Dmitrii 91be467cad Profiler - Fix eval fields
The 'value' pointer was being written to a lot and then used for reading
within the same function. This likely caused issues all over RDC when
reading the metrics.

This commit changes it so *value is written to only once.

Change-Id: I83c158c1e46c6ce46ff87d8a2e769f26ffa8c0da
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-04-09 20:06:21 -05:00
ajanicijamd afec56b7ff Added ctest for NIC performance profiling (#143)
Added two new tests: nic-performance and validate-nic-performance-perfetto
- For ticket: SWDEV-516739

[ROCm/rocprofiler-systems commit: 11fe6a8ebb]
2025-04-09 17:38:46 -04:00
ajanicijamd 11fe6a8ebb Added ctest for NIC performance profiling (#143)
Added two new tests: nic-performance and validate-nic-performance-perfetto
- For ticket: SWDEV-516739
2025-04-09 17:38:46 -04:00
David Galiffi 07d2e46bf3 Disable AUTOREQ and manually add requirements. (#160)
- The amd-smi-lib package is not providing libamd_smi.so in its specs. We need to add a package dependency instead.
  - For ticket: SWDEV-525268
- Add support for `ROCM_DEP_ROCMCORE` in CMake

[ROCm/rocprofiler-systems commit: eaad295cfc]
2025-04-09 17:15:24 -04:00
David Galiffi eaad295cfc Disable AUTOREQ and manually add requirements. (#160)
- The amd-smi-lib package is not providing libamd_smi.so in its specs. We need to add a package dependency instead.
  - For ticket: SWDEV-525268
- Add support for `ROCM_DEP_ROCMCORE` in CMake
2025-04-09 17:15:24 -04:00
Sajina PK 04fb7e4fe7 RocJpeg cmake and document fixes (#157)
- Fix for rocjpeg sample cmake due to changes in the rocJPEG project
- Fix for rocprofiler-sdk version check - change the format
- Edits to docs for jpeg and vcn activity support - mention that these values may not be supported on all ASICs.

[ROCm/rocprofiler-systems commit: fad3a0d341]
2025-04-09 16:20:02 -04:00
Sajina PK fad3a0d341 RocJpeg cmake and document fixes (#157)
- Fix for rocjpeg sample cmake due to changes in the rocJPEG project
- Fix for rocprofiler-sdk version check - change the format
- Edits to docs for jpeg and vcn activity support - mention that these values may not be supported on all ASICs.
2025-04-09 16:20:02 -04:00
ajanicijamd 01c1cbe57f "How-To" document describing network performance profiling (#145)
---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: Peter Park <peter.park@amd.com>
Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

[ROCm/rocprofiler-systems commit: de84a277f2]
2025-04-09 16:11:52 -04:00
ajanicijamd de84a277f2 "How-To" document describing network performance profiling (#145)
---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: Peter Park <peter.park@amd.com>
Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>
2025-04-09 16:11:52 -04:00
dependabot[bot] b2217a4957 Bump rocm-docs-core from 1.18.1 to 1.18.2 in /docs/sphinx (#657)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.18.1 to 1.18.2.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.1...v1.18.2)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 550212a886]
2025-04-08 17:09:01 -06:00