Commit Graph

13501 Commits

Author SHA1 Message Date
David Galiffi 42d64232af Merge pull request #466 from ROCm/dgaliffi/sync-main-with-stg
Omniperf v3.0.0 in prep for ROCm 6.3.0

[ROCm/rocprofiler-compute commit: 71bc463921]
2024-11-05 13:53:20 -05:00
David Galiffi 71bc463921 Merge pull request #466 from ROCm/dgaliffi/sync-main-with-stg
Omniperf v3.0.0 in prep for ROCm 6.3.0
2024-11-05 13:53:20 -05:00
meserve-amd 4467e50453 SWDEV-470692: Fix parsing of unknown API records
- A valid trace is now given even if an individual entry in an API trace
  does not contain a parameter list
- Previously an "unknown" record in an API trace would cause the entire
  output to be discarded

Change-Id: I29bf6df2cf58a231d836aafb37fbde9c5d85512f
2024-11-05 12:48:35 -05:00
meserve-amd f3aaad1687 SWDEV-470692: Fix parsing of unknown API records
- A valid trace is now given even if an individual entry in an API trace
  does not contain a parameter list
- Previously an "unknown" record in an API trace would cause the entire
  output to be discarded

Change-Id: I29bf6df2cf58a231d836aafb37fbde9c5d85512f


[ROCm/rocprofiler commit: 4467e50453]
2024-11-05 12:48:35 -05:00
David Galiffi 38da6b266a Merge branch 'amd-staging' into dgaliffi/sync-main-with-stg
Signed-off-by: David Galiffi <David.Galiffi@amd.com>


[ROCm/rocprofiler-compute commit: f0ccace29b]
2024-11-05 11:21:47 -05:00
David Galiffi f0ccace29b Merge branch 'amd-staging' into dgaliffi/sync-main-with-stg
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-11-05 11:21:47 -05:00
Fei Zheng 03ffa7a756 Merge pull request #460 from feizheng10/doc_warp_efficency
Fix PoP of VALU Active Threads with wave_size

[ROCm/rocprofiler-compute commit: b4f9b38e99]
2024-11-05 09:00:59 -07:00
Fei Zheng b4f9b38e99 Merge pull request #460 from feizheng10/doc_warp_efficency
Fix PoP of VALU Active Threads with wave_size
2024-11-05 09:00:59 -07:00
David Galiffi 7eaaa83024 Fix for proto files not being viewable in Perfetto UI (#16)
- Fix for proto files not being viewable in Perfetto UI
  - Ported from https://github.com/ROCm/omnitrace/pull/411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 21d9ab79fd]
2024-11-05 10:14:25 -05:00
David Galiffi 21d9ab79fd Fix for proto files not being viewable in Perfetto UI (#16)
- Fix for proto files not being viewable in Perfetto UI
  - Ported from https://github.com/ROCm/omnitrace/pull/411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-11-05 10:14:25 -05:00
Benjamin Welton 0568f772ab Kernel Serialization Documentation (#1167)
* Kernel Serialization Documentation

Added docs for kernel serialization.

* Update counter_collection_services.md

* correcting counter collection mode names

* correcting counter collection modes naming

---------

Co-authored-by: Gopesh Bhardwaj <gopesh.bhardwaj@amd.com>

[ROCm/rocprofiler-sdk commit: dc6a568ec5]
2024-11-05 09:00:11 -06:00
Benjamin Welton dc6a568ec5 Kernel Serialization Documentation (#1167)
* Kernel Serialization Documentation

Added docs for kernel serialization.

* Update counter_collection_services.md

* correcting counter collection mode names

* correcting counter collection modes naming

---------

Co-authored-by: Gopesh Bhardwaj <gopesh.bhardwaj@amd.com>
2024-11-05 09:00:11 -06:00
Peter Park 5a30a05800 Fix changelog heading
Signed-off-by: Peter Park <peter.park@amd.com>


[ROCm/rocprofiler-compute commit: 6a381d8966]
2024-11-05 09:07:57 -05:00
Peter Park 6a381d8966 Fix changelog heading
Signed-off-by: Peter Park <peter.park@amd.com>
2024-11-05 09:07:57 -05:00
srawat 162fb23187 Update CHANGELOG.md (#1181)
[ROCm/rocprofiler-sdk commit: 216f724e9a]
2024-11-05 18:11:57 +05:30
srawat 216f724e9a Update CHANGELOG.md (#1181) 2024-11-05 18:11:57 +05:30
fei.zheng f1c9c686ff fix PoP of VALU Active Threads with wave_size
Signed-off-by: fei.zheng <fei.zheng@amd.com>


[ROCm/rocprofiler-compute commit: 1b37572b4a]
2024-11-04 14:31:52 -07:00
fei.zheng 1b37572b4a fix PoP of VALU Active Threads with wave_size
Signed-off-by: fei.zheng <fei.zheng@amd.com>
2024-11-04 14:31:52 -07:00
Jonathan R. Madsen 3e64cedc0c SDK: create CMake option for strict checks on CPU vs. GPU timestamps (#1159)
* SDK: create CMake option for strict checks on CPU vs. GPU timestamps

- Configurating CMake with `ROCPROFILER_BUILD_CI_STRICT_TIMESTAMPS=ON` will enable fatal errors if dispatch/memcpy timestamps on GPU are outside of the start/end time from the CPU
- `ROCPROFIELR_BUILD_CI_STRICT_TIMESTAMPS` defaults to the value of `ROCPROFILER_BUILD_CI`

* Formatting

* Disable async_copy frequency scaling

* Disable profiling dispatch time frequency scaling

* Support runtime configuration via env variables

- ROCPROFILER_CI_FREQ_SCALE_TIMESTAMPS env variable will enable scaling the timestamps based on the hsa timestamp period
- ROCPROFILER_CI_STRICT_TIMESTAMPS env variable will enable strict timestamp checks
  - when cmake is configured with ROCPROFILER_BUILD_CI_STRICT_TIMESTAMPS=ON, this env variable defaults to true

* ROCPROFILER_BUILD_CI_STRICT_TIMESTAMPS defaults to OFF

* Update cmake-target

* Common tracing::adjust_profiling_time

---------

Co-authored-by: Gopesh Bhardwaj <gopesh.bhardwaj@amd.com>

[ROCm/rocprofiler-sdk commit: ad48201912]
2024-11-01 23:12:51 -05:00
Jonathan R. Madsen ad48201912 SDK: create CMake option for strict checks on CPU vs. GPU timestamps (#1159)
* SDK: create CMake option for strict checks on CPU vs. GPU timestamps

- Configurating CMake with `ROCPROFILER_BUILD_CI_STRICT_TIMESTAMPS=ON` will enable fatal errors if dispatch/memcpy timestamps on GPU are outside of the start/end time from the CPU
- `ROCPROFIELR_BUILD_CI_STRICT_TIMESTAMPS` defaults to the value of `ROCPROFILER_BUILD_CI`

* Formatting

* Disable async_copy frequency scaling

* Disable profiling dispatch time frequency scaling

* Support runtime configuration via env variables

- ROCPROFILER_CI_FREQ_SCALE_TIMESTAMPS env variable will enable scaling the timestamps based on the hsa timestamp period
- ROCPROFILER_CI_STRICT_TIMESTAMPS env variable will enable strict timestamp checks
  - when cmake is configured with ROCPROFILER_BUILD_CI_STRICT_TIMESTAMPS=ON, this env variable defaults to true

* ROCPROFILER_BUILD_CI_STRICT_TIMESTAMPS defaults to OFF

* Update cmake-target

* Common tracing::adjust_profiling_time

---------

Co-authored-by: Gopesh Bhardwaj <gopesh.bhardwaj@amd.com>
2024-11-01 23:12:51 -05:00
David Galiffi 4e78cf9b8c Install LICENCE to ${CMAKE_INSTALL_DOCDIR} (#458)
* Install LICENSE to ${CMAKE_INSTALL_DOCDIR}
* Update tarball.yml to test for LICENSE file after the install

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: 50755de867]
2024-11-01 17:51:00 -04:00
David Galiffi 50755de867 Install LICENCE to ${CMAKE_INSTALL_DOCDIR} (#458)
* Install LICENSE to ${CMAKE_INSTALL_DOCDIR}
* Update tarball.yml to test for LICENSE file after the install

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-11-01 17:51:00 -04:00
David Galiffi e43db734fa Update VERSION to 3.0.0 (#457)
* Update VERSION  and README to 3.0.0
* Update version mismatch of profiling data to a warning.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: 152eff0df1]
2024-11-01 15:26:34 -04:00
David Galiffi 152eff0df1 Update VERSION to 3.0.0 (#457)
* Update VERSION  and README to 3.0.0
* Update version mismatch of profiling data to a warning.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-11-01 15:26:34 -04:00
Cole Ramos 14d90939da Give executable permission to rocprof-compute (#456)
Signed-off-by: coleramos425 <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 8a88e8bd90]
2024-11-01 14:16:49 -04:00
Cole Ramos 8a88e8bd90 Give executable permission to rocprof-compute (#456)
Signed-off-by: coleramos425 <colramos@amd.com>
2024-11-01 14:16:49 -04:00
xuchen-amd 825440e7ba Rename Omniperf to ROCm Compute Profiler (#428)
- Update filenames.
- Update executable to `rocprof-compute` 
- Update update package to `rocprofiler-compute`
- Update name in application output and logs
- Update name in README files
- Update testing and workflows

---------

Signed-off-by: Xuan Chen <xuchen@amd.com>

[ROCm/rocprofiler-compute commit: 31b4de1a38]
2024-11-01 12:20:21 -04:00
xuchen-amd 31b4de1a38 Rename Omniperf to ROCm Compute Profiler (#428)
- Update filenames.
- Update executable to `rocprof-compute` 
- Update update package to `rocprofiler-compute`
- Update name in application output and logs
- Update name in README files
- Update testing and workflows

---------

Signed-off-by: Xuan Chen <xuchen@amd.com>
2024-11-01 12:20:21 -04:00
adapryor 61ed9e13f4 [SWDEV-412505] Handle mclk permission errors as not supported
Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: I25c9af42ed62697f87c70ecaeb153abe53401091
2024-10-31 15:18:03 -04:00
Yiannis Papadopoulos 2837825b14 rocr: Adding pointer to the owner driver in Agent class
Change-Id: If913d7c7e4caf6d6e6eee3a858a27c6027c2923f
2024-10-31 12:29:10 -04:00
Chris Freehill c7521a5f2a rocr: Fix supported_isas transient memory issue
An ASAN run of the release build revealed some elements of
the supported_isas static map were still using stack data. This
change makes it use heap data so it will persist.

Change-Id: Ie51887e88b9e2dec27acfc97ea45a6219fea971c
2024-10-31 11:59:29 -04:00
Chris Freehill 4256630fd0 rocr: Fix several rocrtst memory errors
Change-Id: I9049a3905fb26cf9b8ad0839684a70771a49f616
2024-10-30 20:36:25 -04:00
srawat d8cfdd2887 Refactor API reference docs (#1125)
* Refactor API reference docs

* refactor API ref docs

* corrections

* consistent naming

* updates

* Update CHANGELOG.md

* improving SEO

* improving SEO

* Update using-rocprofv3.rst

* Update counter_collection_services.md

* Update using-rocprofv3.rst

* Fixing doc build errors

* changelogs and some formatting issues

---------

Co-authored-by: Gopesh Bhardwaj <gopesh.bhardwaj@amd.com>

[ROCm/rocprofiler-sdk commit: 4204042ac6]
2024-10-30 19:39:08 +05:30
srawat 4204042ac6 Refactor API reference docs (#1125)
* Refactor API reference docs

* refactor API ref docs

* corrections

* consistent naming

* updates

* Update CHANGELOG.md

* improving SEO

* improving SEO

* Update using-rocprofv3.rst

* Update counter_collection_services.md

* Update using-rocprofv3.rst

* Fixing doc build errors

* changelogs and some formatting issues

---------

Co-authored-by: Gopesh Bhardwaj <gopesh.bhardwaj@amd.com>
2024-10-30 19:39:08 +05:30
Gopesh Bhardwaj b69bf8d939 changelog update for release notes (#1171)
[ROCm/rocprofiler-sdk commit: 762ca819cf]
2024-10-30 15:48:43 +05:30
Gopesh Bhardwaj 762ca819cf changelog update for release notes (#1171) 2024-10-30 15:48:43 +05:30
Jonathan R. Madsen 22f8106311 Remove serializing Reserved field of HSA_CAPABILITY (#1170)
- reserved fields have no meaning

[ROCm/rocprofiler-sdk commit: 7f416a2f82]
2024-10-30 00:12:48 -05:00
Jonathan R. Madsen 7f416a2f82 Remove serializing Reserved field of HSA_CAPABILITY (#1170)
- reserved fields have no meaning
2024-10-30 00:12:48 -05:00
Giovanni Lenzi Baraldi f6b0641a2a Update fetch_size metric (#1165)
Co-authored-by: Gopesh Bhardwaj <gopesh.bhardwaj@amd.com>

[ROCm/rocprofiler-sdk commit: 4acca76edb]
2024-10-29 21:44:27 -03:00
Giovanni Lenzi Baraldi 4acca76edb Update fetch_size metric (#1165)
Co-authored-by: Gopesh Bhardwaj <gopesh.bhardwaj@amd.com>
2024-10-29 21:44:27 -03:00
Jonathan Kim 7f8676e177 rocr: revert back to old copy behaviour with no xgmi sdma engines
SDMA queue resources are limited when all SDMA copies are bottle necked
into 2 engines.  Callers will not be able to make the best decisions
to allocate queue resources fairly so have ROCr fallback to old round
robin behaviour dictated by KFD.

Change-Id: I93d52297976d74e20129c5eb1dcfbfa5aa5067a7
2024-10-29 16:01:01 -04:00
Gopesh Bhardwaj 2800fb526f CODEOWNERS Update (#1164)
* Assigining code owners

* Assigining code owners

* reducing default list further for ease

* Update CODEOWNERS

* Update CODEOWNERS

* Update CODEOWNERS

---------

Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: 980b97cc51]
2024-10-29 11:47:14 +05:30
Gopesh Bhardwaj 980b97cc51 CODEOWNERS Update (#1164)
* Assigining code owners

* Assigining code owners

* reducing default list further for ease

* Update CODEOWNERS

* Update CODEOWNERS

* Update CODEOWNERS

---------

Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
2024-10-29 11:47:14 +05:30
Manjunath P Jakaraddi fa35b62708 SWDEV-493402: Changing the header format for counter collection (#1148)
* SWDEV-493402: Changing the header format for counter collection

* Adding column widths

[ROCm/rocprofiler-sdk commit: f087debe84]
2024-10-29 10:11:29 +05:30
Manjunath P Jakaraddi f087debe84 SWDEV-493402: Changing the header format for counter collection (#1148)
* SWDEV-493402: Changing the header format for counter collection

* Adding column widths
2024-10-29 10:11:29 +05:30
Chris Freehill 0c18ff22e1 rocr: Generic ISA targets support
Change-Id: I6a0341ec9c1ec1e710143676b80a8a3c1a78f725
2024-10-28 08:54:06 -05:00
Chris Freehill 08699069d6 rocr: Quiet some ROCr compile warnings
These are mostly AIE related, but there are a couple of others.

Change-Id: I549e004772160ca282d4c94dc9d94dd2ccae8b1c
2024-10-28 09:08:14 -04:00
Gopesh b9bc6d7bd5 Revert " SWDEV-477849: Remove dependency of libatomic from roctracer"
This reverts commit 3c4467274f.

Change-Id: I63a0166f629fa6f3b71f03b4e540e4d8ee160910


[ROCm/roctracer commit: 82ebb1c3ec]
2024-10-28 01:20:02 -05:00
Gopesh 82ebb1c3ec Revert " SWDEV-477849: Remove dependency of libatomic from roctracer"
This reverts commit 4ca1a68fd9.

Change-Id: I63a0166f629fa6f3b71f03b4e540e4d8ee160910
2024-10-28 01:20:02 -05:00
Giovanni LB 71dcc432da Output GPU index for kernel.txt files
Change-Id: Ib32e051bd035c0ecd30ba79b347fd65fe289c3fb
2024-10-25 19:41:19 -04:00