David Yat Sin
e539c8dce2
Remove assert for physical vs virtual memory size
...
On systems with more than 1 TB of memory per NUMA region, this triggers
unnecessary errors.
Change-Id: I1bc7f209b9c1739b516c9f6b0acf434488ac7b8d
2024-04-24 08:43:23 -04:00
Jonathan R. Madsen
312461ebe5
Fix LICENSE install location + CPACK_RPM_PACKAGE_LICENSE ( #820 )
...
- LICENSE needs to be installed in share/doc/rocprofiler-sdk not share/doc/rocprofiler
- CPACK_RPM_PACKAGE_LICENSE should be set to license type not the license location
[ROCm/rocprofiler-sdk commit: 5d365bb8b8 ]
2024-04-24 01:19:32 -05:00
Jonathan R. Madsen
5d365bb8b8
Fix LICENSE install location + CPACK_RPM_PACKAGE_LICENSE ( #820 )
...
- LICENSE needs to be installed in share/doc/rocprofiler-sdk not share/doc/rocprofiler
- CPACK_RPM_PACKAGE_LICENSE should be set to license type not the license location
2024-04-24 01:19:32 -05:00
amd-jmacaran
8a893ea0b8
Add support for external CI builds using Azure Pipelines
...
Change-Id: I8f4de331f00317a959b86f7e5b7a1025ba03564b
2024-04-23 21:10:49 -04:00
Ammar ELWazir
e165856721
Update rocprofiler_config_packaging.cmake ( #817 )
...
[ROCm/rocprofiler-sdk commit: 777add01d1 ]
2024-04-23 18:43:41 -05:00
Ammar ELWazir
777add01d1
Update rocprofiler_config_packaging.cmake ( #817 )
2024-04-23 18:43:41 -05:00
Ammar ELWazir
28f39abfa4
Barrier Packets are being displayed with kernel dispatches
...
Workaround to seperate barrier packets in a separate category named GPU Barriers in JSON to easily navigate dispatches in perfetto and chrome tracing UI
Change-Id: I714975f50a186622612e605b98d0b45426d53aa4
2024-04-23 19:36:46 -04:00
Ammar ELWazir
4bf23fccb8
Barrier Packets are being displayed with kernel dispatches
...
Workaround to seperate barrier packets in a separate category named GPU Barriers in JSON to easily navigate dispatches in perfetto and chrome tracing UI
Change-Id: I714975f50a186622612e605b98d0b45426d53aa4
[ROCm/rocprofiler commit: 28f39abfa4 ]
2024-04-23 19:36:46 -04:00
David Galiffi
a8bd453243
Fixed MD linting issue regarding code blocks.
...
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
Change-Id: Id0467b332bf033642a2d403090ffe598e41689f5
2024-04-23 16:48:15 -04:00
David Galiffi
975c5dd24a
Fixed broken link to ROCm documentation
...
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
Change-Id: I9a6bc0ad08a060d83fdc3a0589dfc81c68ce2b0e
2024-04-23 16:47:50 -04:00
David Galiffi
f94c1794bb
Fixed MD linting issue regarding headers
...
They should start at H1
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
Change-Id: Id11a2599c4609255a1a9916f70b58adc41cdddb4
2024-04-23 16:47:19 -04:00
David Galiffi
c9103a00ef
Update GitHub links to point to the new organization.
...
ie., RadeonOpenCompute --> ROCm
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
Change-Id: I6724cbcbbb525f767af297e3986cd61fa69cd49f
2024-04-23 16:46:42 -04:00
Philip Yang
97497c7efc
libhsakmt: Support contiguous VRAM allocation flag
...
Add HsaMemFlags Contiguous bit for hsaKmtAllocMemory to allocate
contiguous VRAM, to support RDMA device with limited scatter-gather
ability.
Check KFD ioctl minor version >= 17.
Change-Id: I0db00dad125b2b7be523f343082641f59b850423
Signed-off-by: Philip Yang <Philip.Yang@amd.com >
2024-04-23 14:27:12 -04:00
Your Name
e2d742ac6f
libhsakmt: Remove HsaMemFlag reserved bit init
...
HsaMemFlag new flags added and the number of the reserved bits is
reduced, and generate value overflow compilanation error.
The reserved bits is not used, remove the init.
Change-Id: I603596977dfd558ce31ead03711d7c5ce5ee5b71
Signed-off-by: Philip Yang <Philip.Yang@amd.com >
2024-04-23 14:27:12 -04:00
Ammar ELWazir
c91487d483
Adding License to core package
...
[ROCm/rocprofiler-register commit: 64a0e626e4 ]
2024-04-23 11:50:41 -05:00
Ammar ELWazir
64a0e626e4
Adding License to core package
2024-04-23 11:50:41 -05:00
Ammar ELWazir
e875ffed24
Update rocprofiler_register_config_packaging.cmake
...
[ROCm/rocprofiler-register commit: f18651d9f1 ]
2024-04-23 11:50:41 -05:00
Ammar ELWazir
f18651d9f1
Update rocprofiler_register_config_packaging.cmake
2024-04-23 11:50:41 -05:00
Galantsev, Dmitrii
913d6fd173
Merge amd-staging into amd-master 20240423
...
Change-Id: I55800aeb88b62f85aae2715a9d314aa4530d8576
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2024-04-23 10:53:41 -05:00
Bill(Shuzhou) Liu
6ff95e55da
Support thread only mutex
...
The environment variable RSMI_MUTEX_THREAD_ONLY=1 to enable thread only mutex.
The RSMI_INIT_FLAG_THRAD_ONLY_MUTEX can also be pass to rsmi_init()
to enable thread only mutex.
Change-Id: I2d9844039b774e386f03bb9bb130d8c342504ea6
2024-04-23 10:49:17 -05:00
Jonathan R. Madsen
ab551e7eb7
Remove Critical Trace Support ( #327 )
...
* Delete core critical-trace files
* Update docs and README
* Update workflows
* Update testing
* Update cmake
* Remove critical trace usage in source code
* Update source/docs/critical_trace.md
- fix spelling
* Formatting
* Update bin/omnitrace-avail/avail.cpp
- statically allocate shared pointers for timemory manager and hash id/aliases to prevent use-after-free errors
[ROCm/rocprofiler-systems commit: 9499e2f521 ]
2024-04-23 09:35:44 -05:00
Jonathan R. Madsen
9499e2f521
Remove Critical Trace Support ( #327 )
...
* Delete core critical-trace files
* Update docs and README
* Update workflows
* Update testing
* Update cmake
* Remove critical trace usage in source code
* Update source/docs/critical_trace.md
- fix spelling
* Formatting
* Update bin/omnitrace-avail/avail.cpp
- statically allocate shared pointers for timemory manager and hash id/aliases to prevent use-after-free errors
2024-04-23 09:35:44 -05:00
David Galiffi
2a42e3abf0
Updated links to point to the ROCm organization. ( #337 )
...
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
[ROCm/rocprofiler-systems commit: b81db80926 ]
2024-04-23 01:44:02 -05:00
David Galiffi
b81db80926
Updated links to point to the ROCm organization. ( #337 )
...
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
2024-04-23 01:44:02 -05:00
Oliveira, Daniel
e95d80f7ef
fix: [SWDEV-458101] [rocm/rocm_smi_lib]
...
Drops checks that are invalid with the new pp_od_clk_voltage format
Code changes related to the following:
* get_od_clk_volt_info()
* get_od_clk_volt_curve_regions()
Change-Id: I5ebe23aa0ed4ea77d5ab5a94ce34ad9b1b51281f
Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com >
2024-04-23 00:16:53 -05:00
gobhardw
dc09052d82
SWDEV-452226-dispatch ids to start from 0 for v1 parity
...
Change-Id: Ib60a6c108131f67395ab1f9d35ad605859d39987
2024-04-23 00:41:55 -04:00
gobhardw
1f797ac1d1
SWDEV-452226-dispatch ids to start from 0 for v1 parity
...
Change-Id: Ib60a6c108131f67395ab1f9d35ad605859d39987
[ROCm/rocprofiler commit: dc09052d82 ]
2024-04-23 00:41:55 -04:00
David Galiffi
3a9db4dc7f
Create CODEOWNERS ( #338 )
...
[ROCm/rocprofiler-systems commit: c29f8e8244 ]
2024-04-22 23:22:01 -05:00
David Galiffi
c29f8e8244
Create CODEOWNERS ( #338 )
2024-04-22 23:22:01 -05:00
Ammar ELWazir
da744e88e5
Update docs.yml ( #815 )
...
[ROCm/rocprofiler-sdk commit: c93a55b070 ]
2024-04-22 22:50:34 -05:00
Ammar ELWazir
c93a55b070
Update docs.yml ( #815 )
2024-04-22 22:50:34 -05:00
Jonathan R. Madsen
399f2cc660
Remove -Wno-missing-field-initializers from build flags ( #810 )
...
* Remove -Wno-missing-field-initializers
- Compiler errors if missing field initializers
* Update lib/rocprofiler-sdk/counters/evaluate_ast.cpp
- copy over dispatch ID in perform_reduction/evaluate
[ROCm/rocprofiler-sdk commit: 48273d6a65 ]
2024-04-22 22:26:01 -05:00
Jonathan R. Madsen
48273d6a65
Remove -Wno-missing-field-initializers from build flags ( #810 )
...
* Remove -Wno-missing-field-initializers
- Compiler errors if missing field initializers
* Update lib/rocprofiler-sdk/counters/evaluate_ast.cpp
- copy over dispatch ID in perform_reduction/evaluate
2024-04-22 22:26:01 -05:00
Vladimir Indic
843398eb3c
Introducing PcSamplingExtTable ( #735 )
...
* pcs: updating the PCS table
* Fixing Clang Tidy errors
* pcs: reverting old table version
* testint wrong table size
* new size
* testing step
* reverting old steps
* hsa_amd_queue_get_info introduced
* pcs: testing table version
* formatting
* removing redundand declarations
* removing unnecessary files
* Apply suggestions from code review
* Apply suggestions from code review
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update source/lib/rocprofiler-sdk/hsa/pc_sampling.cpp
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Enable function pointer offset check in hsa::pc_sampling::copy_table
- add offset() to HSA_API_META_DEFINITION
- check if offset() >= size of struct
* Support build without PC sampling API table
* ids for ROCr's PC sampling public functions
---------
Co-authored-by: Ammar ELWazir <aelwazir@hpe6u-21.amd.com >
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com >
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com >
[ROCm/rocprofiler-sdk commit: deabd869b5 ]
2024-04-22 20:07:28 -05:00
Vladimir Indic
deabd869b5
Introducing PcSamplingExtTable ( #735 )
...
* pcs: updating the PCS table
* Fixing Clang Tidy errors
* pcs: reverting old table version
* testint wrong table size
* new size
* testing step
* reverting old steps
* hsa_amd_queue_get_info introduced
* pcs: testing table version
* formatting
* removing redundand declarations
* removing unnecessary files
* Apply suggestions from code review
* Apply suggestions from code review
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update source/lib/rocprofiler-sdk/hsa/pc_sampling.cpp
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Enable function pointer offset check in hsa::pc_sampling::copy_table
- add offset() to HSA_API_META_DEFINITION
- check if offset() >= size of struct
* Support build without PC sampling API table
* ids for ROCr's PC sampling public functions
---------
Co-authored-by: Ammar ELWazir <aelwazir@hpe6u-21.amd.com >
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com >
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com >
2024-04-22 20:07:28 -05:00
Ammar ELWazir
1be381d18c
Fixing issue related to python support in CentOS 7
...
Change-Id: I296fda319ab82505e836a4179c95c3a1e444ae00
2024-04-22 17:39:36 -05:00
Ammar ELWazir
c81c5cd89b
Fixing issue related to python support in CentOS 7
...
Change-Id: I296fda319ab82505e836a4179c95c3a1e444ae00
[ROCm/rocprofiler commit: 1be381d18c ]
2024-04-22 17:39:36 -05:00
David Yat Sin
f2751b7030
Fix queue creation for PC Sampling
...
Fix lazy pointer initialization for dedicated PC Sampling queue.
Previous implementation would always create a queue on GPU agent
creation instead of creating the queue on first use.
Change-Id: Icf300f2b162e59143ba61ba182d9bee6e1308fc1
2024-04-22 19:00:48 +00:00
Ammar ELWazir
7c42a4eaf1
GPUs not needed for doc action ( #804 )
...
[ROCm/rocprofiler-sdk commit: 7589084197 ]
2024-04-22 11:00:43 -05:00
Ammar ELWazir
7589084197
GPUs not needed for doc action ( #804 )
2024-04-22 11:00:43 -05:00
Karl W Schulz
2653dc850b
additional mod needed to support roofline binaries potentially
...
executing from two different locations
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: b5011ff0ae ]
2024-04-22 09:00:18 -05:00
Karl W Schulz
b5011ff0ae
additional mod needed to support roofline binaries potentially
...
executing from two different locations
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-22 09:00:18 -05:00
Karl W Schulz
6d277e5443
allow override of CPACK_GENERATOR
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 144843f710 ]
2024-04-21 14:53:14 -05:00
Karl W Schulz
144843f710
allow override of CPACK_GENERATOR
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-21 14:53:14 -05:00
Karl W Schulz
4dd0801633
use concurrency instead of cancel-workflow-action
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: c5cb6ba44f ]
2024-04-21 14:53:14 -05:00
Karl W Schulz
c5cb6ba44f
use concurrency instead of cancel-workflow-action
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-21 14:53:14 -05:00
Karl W Schulz
6591b6e2d3
fix module load path
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: f0ec149497 ]
2024-04-21 14:53:14 -05:00
Karl W Schulz
f0ec149497
fix module load path
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-21 14:53:14 -05:00
Karl W Schulz
8033e4f20f
include additional omniperf in modulefile install path
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 7d24465ee6 ]
2024-04-21 14:53:14 -05:00
Karl W Schulz
7d24465ee6
include additional omniperf in modulefile install path
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
2024-04-21 14:53:14 -05:00