AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
4,174 Commits 3 Branches 0 Tags
e6de34770a4a171a576099a84ce2137bf3479717
Commit Graph

1025 Commits

Author SHA1 Message Date
Jeff Daily bc5596cc74 General hipMemset improvements (#1495) 
* hipMemset et al can use HSA API directly for synchronous cases

* lock and flush stream in hipMemset, hold lock until complete

* move hipMemset async check to front of conditional

* use hsa_amd_memory_fill for additional sync memset cases

code cleanup/review for all memset calls

* Fix inversion of execution mutating value.

* ihipMemsetSync fall back to kernel if HSA memset fails

* Never fallback, never surrender.

* Allow NULL stream.

* Optimise memset kernel. Remove deadwood.

* Update hip_memory.cpp

* Clean up stream logic in sync memset

* Revert "Clean up stream logic in sync memset"

This reverts commit 6117dedf673367f44cc704192573a117a3d92477.


[ROCm/clr commit: 854147e911]
 2019-11-07 13:19:54 +05:30
Sarbojit2019 4d0b7e65bb [HIP] Fixed hipStreamAddCallback [SWDEV#165185] (#1425) 
Fixed hipStreamAddCallback() as requested in SWDEV#165185
Added unit test to test the behavior


[ROCm/clr commit: 97fca3439d]
 2019-11-07 13:18:12 +05:30
ansurya f5a92e5cb6 Fixed texture 2D mapping for pitched arrays & 3D Texture read (#1415) 
Texture 2D image mapping for pitched arrays:
github issue: Texture Object's Buffer seems to be Misaligned #886
JIRA ticket: SWDEV-199313

SWDEV-151670 : Fixed issue with 3D texture with 4 components
SWDEV-151671 : Issue with 2D layered texture with 4 components

[ROCm/clr commit: dc8f556460]
 2019-11-07 13:17:46 +05:30
Rahul Garg cf648f7dbe Rename hip/hip_hcc.h to hip/hip_ext.h (#1341) 
* Rename hip/hip_hcc.h to hip/hip_ext.h

* Deprecate hip_hcc.h


[ROCm/clr commit: dfee3ae279]
 2019-11-07 13:17:10 +05:30
Jeff Daily 39a98df790 hipEventRecord only needs one lock; remove locked_eventIsReady 
[ROCm/clr commit: b2af1820f5]
 2019-11-06 15:56:32 +00:00
Jeff Daily 539d0c2ae3 remove ihipEvent_t::refreshEventStatus(), new hipEventElapsedTime 
This fixes possible races in hipEventElapsedTime.


[ROCm/clr commit: 444122dfb9]
 2019-11-06 15:46:46 +00:00
Jeff Daily f7e255c3c4 fix race condition in hipEventRecord 
[ROCm/clr commit: 6c3479a155]
 2019-11-04 17:45:11 +00:00
Rahul Garg e61ff0408c Merge pull request #1598 from lmoriche/master 
Fix a code object memory corruption

[ROCm/clr commit: 2199f8a6c6]
 2019-10-31 17:12:24 -07:00
Rahul Garg 138b0327da Add stream 
[ROCm/clr commit: f556e15361]
 2019-10-31 12:15:56 -04:00
Rahul Garg 440a172f0e Fix HIP init calls in hipMemcpy2DFromArray 
[ROCm/clr commit: 0718ba0f00]
 2019-10-31 12:15:56 -04:00
Rahul Garg 04785f2d54 Merge pull request #1515 from ansurya/tex_unbind_issue_fix 
Fix undefined ref to hipUnbindTexture for texture types

[ROCm/clr commit: aeb7cebbad]
 2019-10-30 17:54:15 -07:00
Laurent Morichetti f1f649e57c Addressed review comments 
Change comment "must exceed" to "must be no shorter than"
move the std::string instead of creating a copy


[ROCm/clr commit: 3243f06eef]
 2019-10-30 13:14:41 -07:00
Rahul Garg 72c686ed67 Revert "Fix occupany APIs (#1560)" 
This reverts commit ad1e409a24.


[ROCm/clr commit: 27221bc823]
 2019-10-29 11:41:08 -07:00
Laurent Morichetti 0113961674 Fix a code object memory corruption 
The lifetime of the buffer given to
hsa_code_object_reader_create_from_memory must exceed that of the
code object reader. We need to create a copy of the code object
binary memory (file) that is kept allocated until the code object
reader is destroyed.


[ROCm/clr commit: 66c91b42e6]
 2019-10-29 08:23:57 -07:00
Anusha Godavarthy Surya dfa019bdf6 Merge branch 'master' into tex_unbind_issue_fix 
[ROCm/clr commit: 9332a39838]
 2019-10-25 15:54:25 +05:30
Anusha Godavarthy Surya 0140ea8e1a merge from master 
[ROCm/clr commit: ae838f8cee]
 2019-10-25 15:52:09 +05:30
Rahul Garg 7ea7a9c3b7 Add hipMemcpy2DfromArray (#1510) 
Adds hipMemcpy2DFromArray and hipMemcpy2DFromArrayAsync equivalent to cudaMemcpy2DFromArray and cudaMemcpy2DFromArrayAsync.

[ROCm/clr commit: 14b870d1ce]
 2019-10-25 15:43:33 +05:30
Anusha Godavarthy Surya 2d538b702d Merge branch 'master' into tex_unbind_issue_fix 
[ROCm/clr commit: c0fc5e718c]
 2019-10-25 15:36:55 +05:30
satyanveshd ad1e409a24 Fix occupany APIs (#1560) 
Addresses SWDEV-205006 

[ROCm/clr commit: 6c5fbf9b4a]
 2019-10-24 17:44:47 +05:30
searlmc1 510be4b5dc Improve performance of v2 arg handling (#1539) 
* Improve performance of v2 arg handling

* Missing change to `std::string`


[ROCm/clr commit: 15a699688e]
 2019-10-24 17:44:05 +05:30
Aryan Salmanpour 9e0eaef846 [hip] add support for implicit kernel argument for multi-grid sync (#1456) 
* [hip] add support for implicit kernel argument for multi-grid sync

* modified code for calculating the prev_sum

* change the impCoopArg type to size_t

* add memory clean up

* launch init_gws and main kernels into two separate loops


[ROCm/clr commit: 93c688a0c9]
 2019-10-24 17:43:30 +05:30
Rahul Garg 685a4cd182 Merge pull request #1544 from vsytch/master 
QoL changes to the hipMemset family

[ROCm/clr commit: a21fe1443b]
 2019-10-16 18:54:20 -07:00
Nick Curtis a7d6c03e17 Guard against division by zero for no VGPR usage (e.g., in an empty kernel) (#1528) 
* guard against division by zero for no VGPR usage (e.g., in an empty kernel)

* fix bracket format

* clean up parenthesis


[ROCm/clr commit: d16963c9d5]
 2019-10-16 10:49:56 +05:30
Vladislav Sytchenko e2c2025e3e Update the declarations of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async. These functions are type aware and take in as their third argument the number of elements in the buffer, not the buffer size. Change the name of this argument from sizeBytes to count to align with the above description. 
[ROCm/clr commit: 0200aa3a21]
 2019-10-15 14:18:42 -04:00
Anusha Godavarthy Surya c5fc879606 Fix undefine ref to hipUbindTexture for texture types 
[ROCm/clr commit: a5d9f56bef]
 2019-10-09 16:26:06 +05:30
Evgeny 266d2fd9c8 tracing layer unifying with hcc: removing API_ID_ANY 
[ROCm/clr commit: ed29c10394]
 2019-10-08 19:09:43 -05:00
Rahul Garg 09bb83cf2c Fix PCI Domain ID query (#1424) 
* Fix PCI Domain ID query

* Update BDF comment


[ROCm/clr commit: e2260d82a6]
 2019-10-07 14:11:52 +05:30
mhbliao 85640091d5 [hip] Add the missing header <sstream>. (#1498) 
[ROCm/clr commit: 5fbb09fb39]
 2019-10-04 13:39:29 +05:30
Rahul Garg 8d500c1b59 Add texref get APIs support (#1471) 
Added support for -
    hipTexRefGetArray
    hipTexRefGetAddressMode
    hipTexRefGetAddress



[ROCm/clr commit: d5a61736d8]
 2019-10-04 13:38:45 +05:30
ansurya efc64a4f8a Added new Memory API's (#1399) 
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.


[ROCm/clr commit: 96890792b0]
 2019-10-04 13:36:31 +05:30
Siu Chi Chan 1a7fc4e5c1 fix kernel descriptor bug with code object v3 
Change-Id: I9306b2baf36d338e36c5ab1226f74373a61a5ae0


[ROCm/clr commit: d8e09c4b70]
 2019-10-03 10:56:35 -04:00
satyanveshd 1c9dc1331e Reimplement hipMemGetInfo (#1447) 
Addresses SWDEV-136570. hipMemGetInfo changed to compute free memory based on information from kfd instead of relying on hc::am_tracker.


[ROCm/clr commit: 1ae4cbed4d]
 2019-10-01 12:40:36 +05:30
Jeff Daily 280212353c hipModuleUnload should remove global variables from memtracker (#1464) 
[ROCm/clr commit: 2a53299f07]
 2019-09-30 10:41:20 +05:30
Sarbojit2019 3ef2e123bb [HIP] Add tccDriver info in hipDeviceProp 
Fixes #1433.

[ROCm/clr commit: db4c0c0811]
 2019-09-26 13:53:33 +05:30
satyanveshd ca6b4bbc0d Fix checks in hipMemcpy[D/H]to[D/H]() (#1397) 
* SWDEV-202043 hipMemcpyDtoD() issue


[ROCm/clr commit: 842e304a9c]
 2019-09-16 08:32:38 +00:00
ansurya 4436a38e65 Added new device attributes (#1377) 
* Added new device attributes

* updated comment

* updated with new device attributes supported


[ROCm/clr commit: e2a934f377]
 2019-09-16 08:31:30 +00:00
Aryan Salmanpour f68652cc5f [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API (#1368) 
* [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API

* fix formatting


[ROCm/clr commit: 6c7da60e28]
 2019-09-16 08:31:17 +00:00
Rahul Garg f79ffd587e Fix typo and colon in comment 
[ROCm/clr commit: d9179cbe70]
 2019-09-13 03:09:01 +05:30
Rahul Garg b7a06efb6c [HACK] Temporary fix for hipFree for hipManagedMalloc 
[ROCm/clr commit: 2e9b8e9d0d]
 2019-09-13 02:10:21 +05:30
Jeff Daily 42c49b6ba9 fix bug where HIP_DB=1 seg faults at startup (#1388) 
[ROCm/clr commit: 3d7c146296]
 2019-09-05 10:04:19 +00:00
Rahul Garg 33af62d66e Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381) 
This reverts commit 4313f00563.

[ROCm/clr commit: d433f6fb58]
 2019-09-03 05:13:46 +00:00
Sarbojit2019 15b80a759d Updated hipErrorString and CUDAErrorTohipError (#1365) 
[ROCm/clr commit: b5ff9e71ed]
 2019-08-29 01:02:59 +00:00
Sarbojit2019 4d23e35532 [HIP] Reclaiming hipLaunchKernel API (#1353) 
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/clr commit: 1ae43cbeba]
 2019-08-29 01:02:41 +00:00
Aryan Salmanpour e8f69a8c36 [hip] add initial implementation for hipLaunchCooperativeKernel API (#1339) 
* [hip] add initial implementation for hipLaunchCooperativeKernel API

* [hip] use total number of work groups to initialize the GWS resource

* [hip] use only one argument for init_gws kernel

* [hip] use the device associated with the stream for checking the device properties


[ROCm/clr commit: 32ce882d6e]
 2019-08-23 09:19:35 +00:00
Rahul Garg 14a510ee74 Fix memcpy with IPC slowness (#1321) 
* Fix memcpy with IPC slowness

* Make early erroneous returns

* Real Clean up

* Real Clean up++


[ROCm/clr commit: a786728939]
 2019-08-23 09:19:18 +00:00
Jatin Chaudhary 4313f00563 Using HSA API for hipMemsetAsync (#1346) 
[ROCm/clr commit: 9bbd09b04f]
 2019-08-21 10:00:10 +00:00
Rahul Garg 147e516d1f Fix build issues seen with hip-clang path (#1331) 
[ROCm/clr commit: a0cc627c42]
 2019-08-16 02:13:45 +00:00
Rahul Garg 8966072920 Add hipMemcpy3DAsync (#1320) 
* Add hipMemcpy3DAsync

* Fix CI build error

* Move back stream resolution to internal function

* Remove stream redefinition and check


[ROCm/clr commit: fbc9f7e20a]
 2019-08-16 02:13:16 +00:00
Rahul Garg 1ca562e14c Fix undefined identifier issue for hipExtModuleLaunchKernel 
[ROCm/clr commit: 7f9de881cb]
 2019-08-14 16:46:32 -04:00
Rahul Garg 6630b0caa6 Add hipMemcpyParam2DAsync (#1296) 
* Add hipMemcpyParam2DAsync

* Add NVCC path changes

* Clean up

* Fix build issue

* Fix else use in both sync and async apis


[ROCm/clr commit: 569f35a258]
 2019-08-09 11:50:37 +00:00