Commit Graph

1086 Commits

Author SHA1 Message Date
Vladislav Sytchenko e2c2025e3e Update the declarations of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async. These functions are type aware and take in as their third argument the number of elements in the buffer, not the buffer size. Change the name of this argument from sizeBytes to count to align with the above description.
[ROCm/clr commit: 0200aa3a21]
2019-10-15 14:18:42 -04:00
Evgeny Mankov caba615304 [HIP] Fix typo in a comment
[ROCm/clr commit: 7a1301eab9]
2019-10-11 15:20:58 +03:00
Evgeny Mankov 1881f7fe8a [HIP][fix] Prefix libraryPropertyType to fix build of rocFFT and TensorFlow
[ROCm/clr commit: 3a83b3a62c]
2019-10-11 15:18:08 +03:00
Evgeny Mankov 949e778f66 [HIP] Introduce library_types.h as a common header for libs (#1509)
* [HIP] Introduce library_types.h as a common header for libs

[Reason]
Currently, hipFFT, hipBLAS and other HIP libs use their own data types, prefixed with HIPFFT or HIPBLAS, whereas in CUDA those types are common and declared in library_types.h

[TODO]
Switch hipFFT, hipBLAS and other HIP libs to use common library_types.h.

* [HIP] Move include for library_types.h to hip_runtime.h

[Reason]
Repeat CUDA's behaviour, where library_types.h is included in cuda_runtime.h


[ROCm/clr commit: d8d9f16f17]
2019-10-10 19:57:28 +05:30
Philip Salzmann 2dee09bd5b Fix uninitialized var in hipDeviceGetAttribute (#1497)
This fixes the usage of an uninitialized cdattr variable in hipDeviceGetAttribute for the CUDA backend when taking the switch default, as detailed in #1317.

Note that the directed_tests/runtimeApi/device/hipGetDeviceAttribute.tst test fails for me, but it already did before applying this patch. Let's see what CI says!

[ROCm/clr commit: 11f23bba39]
2019-10-04 13:39:19 +05:30
Rahul Garg 8d500c1b59 Add texref get APIs support (#1471)
Added support for -
    hipTexRefGetArray
    hipTexRefGetAddressMode
    hipTexRefGetAddress



[ROCm/clr commit: d5a61736d8]
2019-10-04 13:38:45 +05:30
Sarbojit2019 60373919d4 Removed definition of abs(), real() & imag() from hip_complex.h (#1448)
Addresses SWDEV-201461.

[ROCm/clr commit: a7f52f8ea1]
2019-10-04 13:38:02 +05:30
ansurya efc64a4f8a Added new Memory API's (#1399)
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.


[ROCm/clr commit: 96890792b0]
2019-10-04 13:36:31 +05:30
Yaxun (Sam) Liu 2ed78f20a2 Fix cast of __half for HIP-clang (#1475)
[ROCm/clr commit: 7b3b82bd0d]
2019-09-30 10:40:42 +05:30
satyanveshd 491270de07 Map clock64() to __builtin_readcyclecounter() (#1473)
Fixes SWDEV-203215.

[ROCm/clr commit: ff1b23b558]
2019-09-30 10:40:31 +05:30
eshcherb ce4c08dc1f to include hip_prof_str.h under USE_PROF_API macro (#1470)
[ROCm/clr commit: b8139f7da4]
2019-09-30 10:39:41 +05:30
Alex Voicu dfbb6d555c Optimise the gridDim.n * blockDim.m idiom (#1468)
[ROCm/clr commit: 33c40ee510]
2019-09-30 10:39:23 +05:30
Yaxun (Sam) Liu 33b6f971fa Add new kernel launching API for hip-clang
[ROCm/clr commit: f12b060a3b]
2019-09-26 20:15:24 -04:00
Sarbojit2019 3ef2e123bb [HIP] Add tccDriver info in hipDeviceProp
Fixes #1433.

[ROCm/clr commit: db4c0c0811]
2019-09-26 13:53:33 +05:30
mhbliao 3a8a65c46a [HIP] Remove a circular including. (#1418)
[ROCm/clr commit: 4691c1ef8c]
2019-09-16 08:32:47 +00:00
ansurya 4436a38e65 Added new device attributes (#1377)
* Added new device attributes

* updated comment

* updated with new device attributes supported


[ROCm/clr commit: e2a934f377]
2019-09-16 08:31:30 +00:00
mhbliao b55c3dba08 [hip] Stop using noduplicate and replace it with convergent. (#1390)
[ROCm/clr commit: d511c3e363]
2019-09-05 10:03:43 +00:00
Yaxun (Sam) Liu 732c9829c1 Do not include cuda wappers for OMP for hip-clang (#1382)
[ROCm/clr commit: e72346dc24]
2019-09-03 05:13:59 +00:00
Sarbojit2019 e0f1719c1b Removed hipLaunchKernel macro got missed in Merge (#1374)
[ROCm/clr commit: 4d270775c8]
2019-09-03 05:13:07 +00:00
Sarbojit2019 15b80a759d Updated hipErrorString and CUDAErrorTohipError (#1365)
[ROCm/clr commit: b5ff9e71ed]
2019-08-29 01:02:59 +00:00
Sarbojit2019 4d23e35532 [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/clr commit: 1ae43cbeba]
2019-08-29 01:02:41 +00:00
satyanveshd 0e4701d59f [sample] add new cookbook sample - occupancy (#1352)
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments


[ROCm/clr commit: d2df21e58c]
2019-08-29 01:01:49 +00:00
mshivama 757aa67a43 Device side support for Cooperative Group feature (#1202)
* first cut of the header implementation of cooperative group feature

* add diclarations for device library functions

* fixed various compile time issues in the CG headers

* enabled copy construction and copy assignment

* fixed a minor bug related to conditional compilation macro

* fixed few more CG constructor issues and added a unit testcase

* fixed typo

* extended unit testcase

* compute size of partitioned CG from mask

* bit of code refactoring

* removed boilerplate code

* fixed few of the review comments by Brian

* Changes to the sigantures of few grid and multi-grid related OCKL functions

* changes to declarations of OCKL functions related to CG feature

* removed all the block level support as it is not planned for 2.9

* Have taken care of review comments by Brian

* Have taken care of review comments by Brian

* removed unused functions which were initially intended to use in block level cg support


[ROCm/clr commit: f74903851e]
2019-08-29 01:01:25 +00:00
Michael LIAO eb1039a1e8 [hcc] Fix previous replacement of result_of_t.
- `result_of_t` is defined as the shortcut of
  ```
  template< class T >
  using result_of_t = typename result_of<T>::type;
  ```


[ROCm/clr commit: c84628f420]
2019-08-26 10:58:38 -04:00
ramcherukuri 4e3b65f10c moving result_of_t to result_of
[ROCm/clr commit: 6ea9e2b249]
2019-08-24 08:59:58 -04:00
Rahul Garg 7f71fe3af9 Make Bundled_code_header visible for hipRTC usage (#1359)
[ROCm/clr commit: d367fdf28c]
2019-08-23 09:20:02 +00:00
Aryan Salmanpour e8f69a8c36 [hip] add initial implementation for hipLaunchCooperativeKernel API (#1339)
* [hip] add initial implementation for hipLaunchCooperativeKernel API

* [hip] use total number of work groups to initialize the GWS resource

* [hip] use only one argument for init_gws kernel

* [hip] use the device associated with the stream for checking the device properties


[ROCm/clr commit: 32ce882d6e]
2019-08-23 09:19:35 +00:00
Sarbojit2019 40c0bc5588 Compilation failure on nvcc path when using hipChannelFormatKind (#1345)
Fix for github #1183 issue reported

[ROCm/clr commit: 684801fc1d]
2019-08-21 10:01:03 +00:00
kpyzhov b783820b90 Corrected declaration of __ockl_clz_u64() (#1340)
[ROCm/clr commit: d81267ae15]
2019-08-20 12:06:36 +00:00
Yaxun (Sam) Liu 035568f6b5 Fix missing decl for hip-clang
Add back decl for hipHccModuleLaunchKernel and hipExtModuleLaunchKernel for HIP/VDI only


[ROCm/clr commit: 68a59ddbe8]
2019-08-19 18:27:13 -04:00
mhbliao a6e8fa0ca0 [hip] Allow from/to half conversion on host side. (#1334)
[ROCm/clr commit: 282f06014e]
2019-08-16 02:13:59 +00:00
Yaxun (Sam) Liu 5cb8a914c2 Fix assert for windows. (#1329)
MSVC assert.h has no guard for include once. The macro assert overrides
device assert definition. Do not include it for device compilation.

[ROCm/clr commit: c4655d167e]
2019-08-16 02:13:33 +00:00
Rahul Garg 8966072920 Add hipMemcpy3DAsync (#1320)
* Add hipMemcpy3DAsync

* Fix CI build error

* Move back stream resolution to internal function

* Remove stream redefinition and check


[ROCm/clr commit: fbc9f7e20a]
2019-08-16 02:13:16 +00:00
Rahul Garg 1ca562e14c Fix undefined identifier issue for hipExtModuleLaunchKernel
[ROCm/clr commit: 7f9de881cb]
2019-08-14 16:46:32 -04:00
Sarbojit2019 2c441ad3b6 [HIP] Fix for hipArray_t failure on nvcc path
Fixes SWDEV-148407

[ROCm/clr commit: c4618f2c3b]
2019-08-14 11:30:06 +00:00
Rahul Garg 6630b0caa6 Add hipMemcpyParam2DAsync (#1296)
* Add hipMemcpyParam2DAsync

* Add NVCC path changes

* Clean up

* Fix build issue

* Fix else use in both sync and async apis


[ROCm/clr commit: 569f35a258]
2019-08-09 11:50:37 +00:00
Siu Chi Chan 1436897785 Compile HIP runtime with hidden visibility by default (#1303)
* add default visibility to most APIs in program_state

* remove unwanted C++ headers

* Add symbol visibility pragmas and compiler flags

* Add visibility attribute to APIs in channel_descriptor and hip_hcc

* remove unused headers

* simplify build flags with hcc

* add pragma visibility hidden to functional_grid_launch

* [CMake] add gfx908 back


[ROCm/clr commit: 3cf2d7d385]
2019-08-08 08:33:04 +00:00
Rahul Garg 6641c0dc94 Add support for hipFuncGetAttribute (#1279)
* Add support for hipFunGetAttribute

* Support NVCC path

* Test using sample module_api_global

* Try fixing CI build failure due to hip_prof_gen scan

* Fix for CI build issue

* Resolve conflict

* Rebase and resolve conflicts with master

* Fix build error

* Fix NVCC path build error


[ROCm/clr commit: 8b6317d041]
2019-08-08 08:27:41 +00:00
Rahul Garg b75cd71dd4 Enable temporarily disabled device properties on HIP/VDI
[ROCm/clr commit: 971a64c6b9]
2019-08-06 22:03:19 -04:00
Maneesh Gupta 21e5fc4e33 Merge pull request #1280 from ROCm-Developer-Tools/fix_dont_break_hcc_just_because
This difference makes absolutely no sense.

[ROCm/clr commit: 48a775373c]
2019-08-05 09:51:53 +00:00
Sarbojit2019 55fa6a83c6 Enabled gcc for hip host code (#1214)
* Enabled gcc for hip host code

* Adding tests for hip code + (gcc & g++), without kernels

* Excluding nvcc platforms for gcc and g++ tests + Addressing review comments

* minor code clean-up

* Add rocm include path

* Added relative path for library

* Hiding non supported functions for gcc

* Incorporating review comments


[ROCm/clr commit: f23c1a1499]
2019-08-05 09:51:36 +00:00
Jeff Daily 68f674205e consolidate thread local storage (#915)
* all thread local access now through single struct

* clean up old commented-out code, more use of GET_TLS()

* fewer calls to GET_TLS by passing tls as a funtion argument

* revert unnecessary change to printf

* fix failing tests due to TLS change

* fix merge conflicts in ihipOccupancyMaxActiveBlocksPerMultiprocessor


[ROCm/clr commit: f337ae1edb]
2019-08-05 09:51:02 +00:00
Alex Voicu 6547d7f57c This difference makes absolutely no sense.
[ROCm/clr commit: 0e3d967656]
2019-08-02 12:30:03 +03:00
wkwchau 75f1bb21b3 Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttribu… (#1238)
* Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttributeHdpRegFlushCntl

* Added NVCC blocker for the hip*FlushCntl test cases


[ROCm/clr commit: abe6776677]
2019-08-01 16:03:35 +00:00
Maneesh Gupta 98669d1867 Merge pull request #1277 from mangupta/nvcc_devprop
[nvcc] Populate missing fields in hipGetDeviceProperties

[ROCm/clr commit: d5a3202a47]
2019-08-01 08:59:58 +00:00
wkwchau a19b4fbd8b Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOc… (#1240)
* Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags APIs

* Taking into account of SGPR usage to determine the max active blocks in hipOccupancyMaxActiveBlocksPerMultiprocessor()


[ROCm/clr commit: 7b9801fe9a]
2019-08-01 08:58:48 +00:00
Maneesh Gupta d5f73d22aa [nvcc] Populate missing fields in hipGetDeviceProperties
Change-Id: Ie90e02674d503e385f144f1ead3d53ff7b49cecc


[ROCm/clr commit: b24a4000f8]
2019-08-01 13:16:39 +05:30
Yaxun (Sam) Liu 16632b627c Temporarily disable maxTexture1D in hipDeviceProp_t for VDI (#1237)
[ROCm/clr commit: 13301398d8]
2019-07-19 15:38:32 +00:00
ansurya 8b8946f78b Add Max Texture 1D,2D,3D device properties (#1226)
* Add Max Texture 1D,2D,3D device properties

* Corrected testcase to use enums defined in hipDeviceAttribute_t

* Added texture 1D,2D and 3D support for NVIDIA path


[ROCm/clr commit: 00aa42e05f]
2019-07-18 03:18:50 +00:00
ansurya 264df316ba UChar and UShort textures as Normalized Float (#1213)
* UChar and UShort textures as Normalized Float

* UChar and UShort textures as Normalized Float for all float variants

* Handled uninitilaized texture format value


[ROCm/clr commit: 849b5ef6af]
2019-07-18 03:18:28 +00:00