Commit Graph

1787 Commits

Author SHA1 Message Date
Pranjal Swarup 4e5029221b Update RCCL-tests in examples folder (#261)
- Create a local copy for ROCm/rccl-tests for our examples.
- Update argument parsing to no longer use getopt_long.
- Workaround for Dyninst instrumentation.

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-06-27 11:44:13 -04:00
Fei Zheng f5bc717fe1 Documentation update for FP8 on MI300 (#766) 2025-06-26 13:35:36 -06:00
vedithal-amd a95a45d69a Add support for MI 100 with rocprofiler-sdk (#768)
* Add custom rocprofiler-sdk counter definitions file for MI 100

* Update CHANGELOG to mention that accumulation counters will not be
  collected when profiling on MI 100 using rocprofiler-sdk/rocprofv3

* Migrate accum_counters.yaml to code
2025-06-26 09:03:18 -04:00
anujshuk-amd 3631362903 Add ctests to verify roctx api (#260)
---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-06-25 14:01:04 -04:00
David Galiffi 1903e8e748 Provide a version for RPM Obsoletes attribute (#670)
Fix RPM generation warning
2025-06-25 12:36:47 -04:00
dependabot[bot] 4b741a0148 Bump rocm-docs-core[api_reference] from 1.21.0 to 1.21.1 in /docs/sphinx (#263)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.21.0 to 1.21.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.21.0...v1.21.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.21.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-25 09:51:55 -04:00
Kian Cossettini 4c524235db Fixed docker run cmd (#264) 2025-06-25 09:51:30 -04:00
Kunal Malviya 661de1d483 Adding verbose and changing threads (#771)
Co-authored-by: rocm <rocm@rocm-System-Kunal.amd.com>
2025-06-25 18:49:46 +05:30
cfallows-amd 630bc149ff Add roofline PDF output to general profiling runs (#774)
Change when Roofline PDFs are generated- during general profiling and --roof-only profiling (skip only when --no-roof option is present)

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-06-25 01:19:28 -04:00
dependabot[bot] 181e4f44c7 Bump rocm-docs-core from 1.18.2 to 1.21.1 in /docs/sphinx (#775)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.18.2 to 1.21.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.2...v1.21.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-version: 1.21.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-24 21:04:16 -04:00
xuchen-amd 74e9853f8e Fix system sol units, remove units if None value. (#773)
* Fix system sol units.
2025-06-24 16:37:55 -04:00
xuchen-amd 92ce4732bc GUI: prevent big number overflow (#772)
* Prevent number overflow by formatting values.

* Improve value formatting logic based on comments.
2025-06-24 16:27:06 -04:00
dependabot[bot] 3a0985c68a Bump rocm-docs-core[api_reference] from 1.20.1 to 1.21.0 in /docs/sphinx (#262)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.20.1 to 1.21.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.20.1...v1.21.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.21.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-24 12:33:13 -04:00
David Galiffi 3668e603cc Update CHANGELOGS (#248)
* Update CHANGELOGS

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update CHANGELOG.md

Clarify Fortran support on CHANGELOGS

* Update CHANGELOG.md

Fixed typo

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>
2025-06-24 11:10:26 -04:00
Kian Cossettini 8457cb11be Added docker usage steps for rocprofiler systems (#251)
---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>
2025-06-23 15:19:47 -04:00
David Galiffi 122623a929 Use gersemi for CMake formatting (#257)
* Replace `cmake-format` with `gersemi`

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Remove .cmake-format.yaml

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update workflow to use gersemi

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update CONTRIBUTING.md

* Update helper scripts

* Don't include `*/external/*` in workflows

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-22 10:44:33 -04:00
David Galiffi 1e13b590e7 Use clang-format-18 for source formatting (#256)
* Updating clang-format to v18

- Updates the pre-commit-config
- Formats source files according to the utility

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update format source workflow

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update CONTRIBUTING

* Update comment in .clang-format

* Update CONTRIBUTING.md

* Update helper script

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-22 08:48:08 -04:00
vedithal-amd 5950a02ff6 Fix counter collection for MI 350 (#764)
* Fix TCC counter collection bug
* Fix accumulate counter collection
* Fix formatting
2025-06-21 08:48:25 -04:00
Jason Bonnell 44c3516b8b Ignore certain workflows when changes are only for .md, docs, and docker (#754)
* add paths-ignore for both push and PR to rhel-8.yml and ubuntu-jammy.yml

* add paths-ignore for PR only in tarball.yml

* add rocm-docs-core linting.yml workflow to formatting.yml

* fix small mistake in github directory path

* remove rocm-docs-core linting
2025-06-20 09:26:28 -04:00
Sajina PK e3741f678b Show VCN and JPEG busy values where VCN/JPEG activity is not supported. (#232)
On AMD-SMI, in rocm 7.0, vcn_activity and jpeg_activity will not be reported when XCP (partition) stats, vcn_busy and jpeg_busy, are available. This causes the activity tracking to fail. The fix is to read the busy values when activity values are not supported.

For issue: SWDEV-536439

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-06-19 16:23:30 -04:00
David Galiffi 20efb9641f Update pull_request_template.md (#258)
Rewording the "related issues" comments
2025-06-19 11:06:13 -04:00
ajanicijamd 4346c1c217 Modified nic-performance test to download a smaller file (#253) 2025-06-18 19:39:48 -04:00
jamessiddeley-amd 036866fc12 added progress printout in rocprof-compute profile (#727)
* added progress printout for profiler

* added comments and fixed readability

* removed redundant newlines

* moved format_time helper function to utils

* removed tqdm and redundant time calc
2025-06-18 14:09:09 -04:00
xuchen-amd 5d8fd55e36 Integrate roofline in tui (#762)
* Update changelog, remove unused code.

* enable roofline in TUI.

* Remove roofline section when data not available.

* Fix workload dir path.
2025-06-18 13:58:42 -04:00
xuchen-amd 80159ee117 CLI: enable roofline plot (#760)
* enable roofline plot in cli.

* Add roofline to analysis config.

* Unify global variables.

* Disable roofline for baseline comparison and gfx908.

* Add check for roofline.csv
2025-06-18 13:19:58 -04:00
Pratik Basyal 66e71574ba Broken link to ROCprofiler-SDK updated (#254) 2025-06-18 13:15:18 -04:00
Daniel Su 475d6c0f1f Add thread header to videodecode example (#252) 2025-06-18 12:40:24 -04:00
vedithal-amd b16256fd07 Add docker files for testing (#761) 2025-06-17 16:18:35 -04:00
David Galiffi 244c193a57 Unhandled enum in switch statement (#247)
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-17 09:57:27 -04:00
Vladimir Indic 451be8a600 [PC Sampling] Separate counts for issued and stalled samples (#756) 2025-06-16 15:09:21 -06:00
vedithal-amd 7c0ffd14a9 Print counter list in DEBUG level (#758) 2025-06-16 16:53:00 -04:00
David Galiffi eaaec2cc3b Cleanup of Dyninst build dependencies (#238)
- Refactor elfutils build folders. Move build artifacts to the "external" subfolders
- Remove reference to unused DYNINST configuration
- Declare Dyninst interfaces with other external declarations
- Updated cmake warning message
- Update the deprecation warning for "DYNINST_BUILD_${dep}" to make it clearer that the option is being translated to the new option, "ROCPROFSYS_BUILD_${dep}"
2025-06-13 17:19:46 -04:00
David Galiffi 8535da17c8 Removing dyninst builds from CI docker files (#249)
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-13 17:16:01 -04:00
David Galiffi 6dd1ee78bf Add perfetto validation to rccl ctests (#246)
Check for the "RCCL Communication Send / Receive" data counters

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-13 17:09:49 -04:00
ywang103-amd b8dd6d049d format the code after mem chart's fix of test (#753) 2025-06-13 12:03:42 -04:00
Jason Bonnell da6bf4b5c9 Move pr template file (#746)
* updated documentation wording, added cherry pick option for PR type

* moved pull_request_template to base .github directory
2025-06-13 11:37:56 -04:00
vedithal-amd fa1e9965f8 fix test_gpu_specs.py (#752) 2025-06-13 10:01:59 -04:00
ywang103-amd bb0c417871 fix broken test with --cols options (#750) 2025-06-12 19:45:24 -04:00
jamessiddeley-amd 667128e3c7 Fix: Add explicit includes for assert.h and thread in sample files (#751)
* Fix: Add explicit includes for assert.h and thread in sample/vcopy.cpp

The HIP/CLR change e3cb5399c removed transitive inclusion  
of standard headers like assert.h from hip_runtime.h.  
This caused build failures in rocprof-compute samples.  

This commit explicitly includes <assert.h> and <thread>  
in vcopy.cpp to resolve potential missing definitions.  


Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vsequential_access.cpp

Added assert and thread imports

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vrandom_access.cpp

Added assert import

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vsequential_access.cpp

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
2025-06-12 17:03:48 -04:00
Jason Bonnell da326048b9 add pull_request_template.md (#237)
* add pull_request_template.md

* Update .github/PULL_REQUEST_TEMPLATE/pull_request_template.md

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

* fix markdown linting errors

* Update .github/PULL_REQUEST_TEMPLATE/pull_request_template.md

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

* moved pull_request_template.md to base /.github/ directory

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-06-12 16:13:48 -04:00
Vignesh Edithal 6054b3b7fd Bugfix for PR #744 2025-06-12 16:09:15 -04:00
vedithal-amd d27ee69b52 Change default rocprof to rocprofv3 (#748)
* Revert of https://github.com/ROCm/rocprofiler-compute/pull/738

* Change default rocprof backend interface to rocprofv3

* Add MI 350 support in documentation

* Added known issue that MI 100 profiling will not work unless rocprofv1
  is explicitly opted in

* Remove MI 50 soc gfx python class since MI 50 is not supported
2025-06-12 15:45:11 -04:00
vedithal-amd cdd41dee40 Remove rocscope related code and add deprecation warning for mongo db usecase (#744)
* Remove rocscope related code

* Add deprecation warning for database update mode which is used for grafana and mongodb functionality
2025-06-12 14:21:24 -04:00
David Galiffi 1cd989a110 Copyright Header Compliance (#745)
- for SWDEV-537492
2025-06-12 12:02:58 -04:00
jamessiddeley-amd f004aeebe9 fixed long kernel names cut off in --kernel-names option (#728)
* reformatted kernel roofline PDF to use table

* restored kernel symbol icons

* enhance code readability

* restored cell text wrap

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
2025-06-12 10:23:40 -04:00
jamessiddeley-amd 97dad3f7f1 increased utils.py code coverage to ~84% (#742)
* code coverage file cover: utils.py

* added code coverage 82% for utils.py

* reverted unused_code rebase
2025-06-12 10:21:40 -04:00
David Galiffi 877fa671cc Updated Dockerfile.ubuntu (#245)
Using miniforge instead of miniconda

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-12 10:19:01 -04:00
David Galiffi d9381c3e0a SWDEV-525474 - Fixed CMake 4 configuration error (#244)
Update Timemory / GOTCHA modules

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-12 10:14:55 -04:00
Pranjal Swarup c00070ddbf Change docker scripts to use miniforge instead of miniconda (#242) 2025-06-11 23:43:34 -04:00
David Galiffi 28bee27253 Fix OpenMP-Target ctest (#241)
Test is missing from rocm-7.0 stack because of a HIP version check.
In these builds, hip_version.h is still reporting 6.5.0.
This check was originally put in to skip the test on older versions
of ROCm, which should no longer be required

- For SWDEV-537718

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-11 16:00:48 -04:00