Commit Graph

198 Commits

Author SHA1 Message Date
agodavar efe86a0f88 SWDEV-245381: Updated guarantee error messages to print based on BUILD_TYPE
Change-Id: Ifafbc075d6b9860da040c72859127c4e638a786f


[ROCm/clr commit: 6838df46eb]
2021-01-05 23:29:50 -05:00
Tao Sang 2c1c9f78d6 Remove hip-hcc codes: Part three
1.Rename include/hip/hcc_detail/ as include/hip/amd_detail/

2.Rename include/hip/nvcc_detail/ as include/hip/nvidia_detail/

3.Create __HIP_PLATFORM_AMD__ to replace __HIP_PLATFORM_HCC__

4.Create __HIP_PLATFORM_NVIDIA__ to replace __HIP_PLATFORM_NVCC__

After hcc_detail, nvcc_detail, __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__
have been removed from upstream, they will be removed from hip runtime.

Change-Id: I1ae457effd739d6c25bca203c1724b026be21fce


[ROCm/clr commit: 8a2b0b7424]
2021-01-05 10:39:31 -05:00
Satyanvesh Dittakavi 7fec171e78 SWDEV-263678 - fix rocHPCG mgpu perf drop
Change-Id: I33269fe4f6165d1ed172b19033ab9fcb92f338c3


[ROCm/clr commit: 15baf7ef6d]
2021-01-05 00:22:12 -05:00
cjatin 42dfa8e5c4 Add ELF Flags moved from rocclr
Change-Id: I5febe7bdca80517e9f9492d7930def72db83c14e


[ROCm/clr commit: 6faffdffd2]
2021-01-04 13:43:16 -05:00
Sarbojit Sarkar fae1bcd07c Revert "Fix hipmemset to match CUDA behavior"
This reverts commit 76a2999f22.

Change-Id: I53052b25bac4956f3efd124eadc936197f2e466a


[ROCm/clr commit: f64af513a2]
2021-01-01 00:11:58 -05:00
agodavar ceb68b8d4f hipmemcpy2D handle height 0
Change-Id: I46bf89e81559c3bfccac0dd0ccd78eee9058c7e3


[ROCm/clr commit: 7dcf2769ae]
2020-12-31 01:41:56 -05:00
agodavar 47604611de SWDEV-266089: hipStreamAddCallback argument validation
Change-Id: I3e61006796e88b4e2ba029118c95f3499959257b


[ROCm/clr commit: c5e3f955bf]
2020-12-29 05:42:54 -05:00
agodavar e85f1404e8 SWDEV-263180 : Fix null ptr dereference
Change-Id: Iefc9fa3f195af45a5c5ebe075056246c930a6d84


[ROCm/clr commit: d74777d2a7]
2020-12-19 02:02:54 -05:00
Rahul Garg 76a2999f22 Fix hipmemset to match CUDA behavior
Make hipMemset asynchronous with respect to the host unless
destination pointer refers to pinned host memory.

Change-Id: I5ba230e0cc622aa076dc94692a4c43a57dd2df7b


[ROCm/clr commit: 9ba5902be4]
2020-12-17 19:13:31 +00:00
Evgeny 024774c58a SWDEV-259683 : hipprof: adding hipApiIdByName() method
Change-Id: I1ad2be76efc9fb690ed7c9c2b1091f7eb0c04a31


[ROCm/clr commit: e54f2a1af1]
2020-12-15 15:42:10 -05:00
Satyanvesh Dittakavi c832ef9e7c SWDEV-258754 Fix seg fault hipMemset with device pointer mapped from hipHostRegister
Change-Id: Ifab66b67df172812ebb6eb25c2bac71821f4d614


[ROCm/clr commit: f06393c75f]
2020-12-15 07:44:34 -05:00
Satyanvesh Dittakavi 1f654026d7 Fix hipPointerGetAttributes
Modified hipPointerGetAttributes to support hipHostRegister ptrs and mapped device ptrs from hipHostRegister
Change-Id: I2f4cf12e09578768308f644123d6d4bdccbd77a8


[ROCm/clr commit: 40733e1fff]
2020-12-15 01:40:24 -05:00
Sarbojit Sarkar 80075304f1 Updated review comment
Change-Id: Ic7f9f33dd23c975f2a7a0f0d485a3d2a457c62bb


[ROCm/clr commit: 1ef88375c2]
2020-12-13 11:30:28 -05:00
Tao Sang 68554aa473 Some improvements on hip cmake file
1.Fix unexpected repeated hip runtime lib building
2.Seperate test cmake from top cmake.

Change-Id: I1ae457effd639d6c25bca293c1724b026be21ecd


[ROCm/clr commit: a7aa84f73a]
2020-12-11 13:32:15 -05:00
Rahul Garg 7ef0e83499 Handle overflow
Fixes SWDEV-261712

Change-Id: I730fcdca8c2640fde9cfdfe2f4b4cf4894807fed


[ROCm/clr commit: 584771e7a2]
2020-12-09 19:09:43 -05:00
Saleel Kudchadker 662d3c2964 Honor hipEventDisableTiming event flag
Change-Id: Ia949db96e81b9af467f04ab40d143e8d6faa9394


[ROCm/clr commit: 08a65054ea]
2020-12-09 15:10:18 -05:00
Jatin Chaudhary c5feb4d862 Updating the gcnArchName to now have target id
Change-Id: Ibd5576e0fb5b46e8f212de4ec57cd96eb1d3c157


[ROCm/clr commit: 24b997119f]
2020-12-09 01:22:08 -05:00
Jatin Chaudhary 8aa2ebb4de Adding checks for function, size and params in ihipModuleLaunchKernel to have common message for hipModuleLaunch and hipExtModuleLaunch
Change-Id: I11921ad753930872572571dbfd1c12daba83a725


[ROCm/clr commit: dfe6f1ef27]
2020-12-07 03:17:14 -05:00
Saleel Kudchadker c43e5d83dd Add a new flag for profilingInfo to record gpu TS
Add a flag to record gpu TS in a marker, also disable marker flush
if there was already a marker submitted before.

Change-Id: I9cdf8e49137690c0050fe9370764dd059855a2f8


[ROCm/clr commit: db7ed1a78c]
2020-12-03 13:45:39 -05:00
agodavar 9ae4798aa7 SWDEV-256810 : hipMemcpy2D API handle width, src/dst pitch 0
Change-Id: I4f60b220624f4235c0c3daf68adcd5a496e93696


[ROCm/clr commit: 273e83ff6c]
2020-12-03 10:34:12 -05:00
Sarbojit Sarkar 83e94d189c SWDEV-258579: hipMemcpy2D better error handling
Change-Id: I09378d6e31da99451e22cbe9276a5ff1ad4a1840


[ROCm/clr commit: a08ddb4b53]
2020-12-03 05:50:42 -05:00
agodavar 2e6334e080 SWDEV-259210 : Handle invalid inputs for hipDeviceGetByPCIBusId and hipDeviceGetPCIBusId APIs
Change-Id: Iab48604941c4c715ee3357ace2e2d26dbc8cad33


[ROCm/clr commit: ef415ec610]
2020-12-02 00:01:54 -05:00
Tony 0d2004544b Add additional targets
Add support for loading the following targets:

- gfx705
- gfx805
- gfx90c
- gfx1031
- gfx1032
- gfx1033

Change-Id: Ib7f61c33662619757409e95fb0b50068f9e11065


[ROCm/clr commit: 8493142a22]
2020-11-23 20:31:45 +00:00
Aryan Salmanpour 4376b55b25 Add support for hipExtStreamGetCUMask API
Change-Id: I0fa67ad581dd75556f17c7410af2c1d5cb6ae99a


[ROCm/clr commit: 00268eaeed]
2020-11-20 13:41:38 -05:00
Satyanvesh Dittakavi 8d4b0ecb0c SWDEV-255614: Fix Caffe2 Test Failure
Change-Id: I043caa89b2a43dace7f18c739f30d2a7bfa644ca
Fixes the issue when memcpy DtoH is performed on device 0 where the device buffer 
is allocated on device1 and the destination pinned buffer is allocated from device 0.


[ROCm/clr commit: 60ec2a3e46]
2020-11-20 10:24:50 -05:00
Vladislav Sytchenko 07f463ab3f Report maxTexture1DLinear property
Change-Id: If562bbee80d8b98712806cb8258b5a7482d33bf6


[ROCm/clr commit: 63167e4b70]
2020-11-20 10:18:20 -05:00
Rahul Garg 5a56ff9cfa Fix async flag in hipMemset3DAsync
Change-Id: I3dc717c14bdd1d46873e03c687bdf57f9202663e


[ROCm/clr commit: 236352a64d]
2020-11-18 20:32:18 -05:00
Yaxun (Sam) Liu 24d1c8c229 Fix embedding PCH
Change-Id: Ibaf043c9e331f15965185cd4195da98d9441cba3


[ROCm/clr commit: cdc7f3f49e]
2020-11-18 00:56:42 -05:00
Rahul Garg 908decb338 Fix hipDeviceGetByPCIBusId
SWDEV-260845

Change-Id: I2d6db15906d794c9ebfa85b745a2c1bbb6f3e731


[ROCm/clr commit: d11027c522]
2020-11-16 23:28:52 +00:00
Tao Sang f3b3c0ba9c Remove unnecessary stuff from hip cmakefile
Remove the following from hip cmakefile,
1.find_package cmds of hsa-runtime64 and amd_comgr;
2.macros of USE_COMGR_LIBRARY and COMGR_DYN_DLL
because they have already been used in Rocclr cmakefile.
cmake mechanism will make hip cmakefile inherite them.

Change-Id: I03b527fc4135c79bb35cbbfe419211ec363cb067


[ROCm/clr commit: 10f4918d97]
2020-11-13 15:01:32 -05:00
agodavar 4bb6e01ea3 SWDEV-249870: Generate Pre-Compiled Headers from includes in source repo for Online Compilation
Change-Id: I663f510603e983927f80f7944df4d039ba7bc0b0


[ROCm/clr commit: 9ef681a618]
2020-11-12 10:50:33 -05:00
German Andryeyev 0cdff99dd0 Add an early exit if it's a null stream wait
Change-Id: I577f5da2f928bff172d64d511a60e08eda28c81d


[ROCm/clr commit: d4e642203c]
2020-11-11 13:20:04 -05:00
Konstantin Zhuravlyov 1b1b2998ad SWDEV-198415 - Implement Target ID Proposal
Changes from Jatin Chaudhary, Tony Tye

Change-Id: I14904920ad2356ae2098cf827b83613089d33962


[ROCm/clr commit: 73fb01cb3a]
2020-11-10 13:31:43 -05:00
Tao Sang d8e8f2c833 Make directed_test support static libs
1.Make directed_test apps linked against static libs
    of hip, rocclr, rocr, roct and amd_comgr.
    2.Remove custom_target amdhip64_static_combiner.
    3.Support EXCLUDE_HIP_LIB_TYPE <static|shared>.
    4.Simplify argument list parsing.
    5.Install rocclr when rocm is installed.
    6.Fix some original small bugs.

Revert "Revert "Make directed_test support static libs""
This reverts commit f1cc6bef64.

Change-Id: I918eeae94487e5e2ff5bfde083667ac65fb6e702


[ROCm/clr commit: 6db4976759]
2020-10-26 12:39:58 -04:00
Sourabh Betigeri 19f45f83f3 SWDEV-251091: Added null checks and empty file check in hip_module and hip_platform
Change-Id: Iad99f996dcf90ffb86f62e79bf4cbd53b35b7e3b


[ROCm/clr commit: b65314d168]
2020-10-20 19:55:01 -04:00
kjayapra-amd 16b7ecf4ec SWDEV-250005 - Fixing error code propagation to HIP outer layer.
Change-Id: I0c0e87dbace0b1182f24411200abdfd9cab3f865


[ROCm/clr commit: c18a791c80]
2020-10-20 09:43:57 -04:00
Sarbojit Sarkar a5f78cf686 SWDEV-256325 : Fix for hipMemset2D crash
Change-Id: I1f434602fecd4fb935d2bc72f2c72d6a2d4c45fe


[ROCm/clr commit: a73d1a1fe0]
2020-10-20 02:54:29 -04:00
Rahul Garg e7e9d74c79 Fix PCI bus domain ID query
SWDEV-256338

Change-Id: I5db361bd2899a5bf761ecf05ecd4635f9e3dce1d


[ROCm/clr commit: 4b7c8f5fc1]
2020-10-19 12:02:50 -04:00
Rahul Garg b5abdead82 Fix maxTexture1D query
Needed by SWDEV-254068

Change-Id: Ib43a3e5e96d3882af354208063e5502673c0f35a


[ROCm/clr commit: cc1101f97a]
2020-10-14 17:32:04 -04:00
agodavar bf65eead59 SWDEV-249870: Short-Term solution for Pre-Compiled Headers for Online Compilation - Fix static build
Change-Id: Ib608e73dbffa2d803599cba5ba842cd5a2a2ba9d


[ROCm/clr commit: 4018464960]
2020-10-14 00:37:46 -04:00
German Andryeyev e343bc4b00 Report managed memory capabilities
Change-Id: I241a42e26ee49fb47dcb3ba87c4bd8fb691dffdf


[ROCm/clr commit: 15ba5611ba]
2020-10-13 16:09:43 -04:00
Aryan Salmanpour 0a6ac3c020 Fix a seg fault when unallocated mem handle passed to hipIpcOpenMemHandle API
also validate the flag argument passed to hipIpcOpenMemHandle API and return
error if it is not equal to "hipIpcMemLazyEnablePeerAccess" (defined to 0)
and it is the only supported flag currenlty for this API.

SWDEV-253462

Change-Id: Ie1c8b79c680a29dc72bf262cf53ae5e011fb1247


[ROCm/clr commit: 89964dbbd4]
2020-10-13 11:14:41 -04:00
Julia Jiang 427cb5bf4c SWDEV-249487-remove two HCC related APIs
Change-Id: Icf90ece0808643e0c5f0cc00b6644d5171b553d8


[ROCm/clr commit: c144b57d54]
2020-10-13 11:08:37 -04:00
agodavar de8da71c9a SWDEV-254185 - Added support to pass include headers to hipRTC
Change-Id: Ia19e6806a476d3c6ecd3e9a89c3ed72953a4900c


[ROCm/clr commit: 7d67573a4f]
2020-10-12 06:04:14 -04:00
Tao Sang f1cc6bef64 Revert "Make directed_test support static libs"
This reverts commit a47392be9b.

Reason for revert: <INSERT REASONING HERE>

Change-Id: Ib2d1084ea21461f70f96f95c6025a08f88288357


[ROCm/clr commit: 0d1cf31eb1]
2020-10-12 00:01:13 -04:00
Tao Sang a47392be9b Make directed_test support static libs
1.Make directed_test apps linked against static libs
of hip, rocclr, rocr, roct and amd_comgr.
2.Remove custom_target amdhip64_static_combiner.
3.Support EXCLUDE_HIP_LIB_TYPE <static|shared>.
4.Simplify argument list parsing.
5.Fix hip_pch.o missing issue in samples' build.
6.Fix some original small bugs.

Change-Id: I30f5e65367613152ce86b80b13e1c9f2a28da803


[ROCm/clr commit: 36c5679efc]
2020-10-08 22:46:58 -04:00
Sarbojit Sarkar 1dee6f664b [perf]hipMalloc perf optimization
Change-Id: I9cd1d29205cb0c9938d26bb8e336fc9fe8a262ed


[ROCm/clr commit: a3b44b5f75]
2020-10-06 12:22:57 -04:00
Vladislav Sytchenko 4a6f033fd2 Change __HIP_ENABLE_PCH to be an option
Currently all the logic checks if __HIP_ENABLE_PCH is set, so setting it
to OFF will still enable PCH.

Switching __HIP_ENABLE_PCH to be a CMake option will enable correct
build behaviour.

Change-Id: I77a663589ffb5f2595c6ad3d144eb9466adcf250


[ROCm/clr commit: 8034467ec3]
2020-10-06 11:17:47 -04:00
kjayapra-amd 78fd06679b SWDEV-254363 - Checks to make sure kernel is launched on the same device as it was launched.
Change-Id: I2f273a70b1a5fc0e9fc9c6144eabd32466ff4e59


[ROCm/clr commit: 40322a9f1c]
2020-10-06 08:38:09 -04:00
Rahul Garg 8e268b9170 Remove libhip_hcc references
These were added in commit b2e0df3845.

Change-Id: I5815c90bb83ac74730f6bce114eb353f54b86670


[ROCm/clr commit: 2a5d39cd3b]
2020-10-06 04:29:35 -04:00