ECR #304775 - Fix for a memory "leak" in one GEHC sample
- The app builds a dependency graph when the new command waits for the previous one. Our runtime couldn't release wait commands in this situation, because release is done in the command destructor. Release the events from the wait list when the command is done.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#71 edit
EPR #396242 - Update to HCtoDCmapping: Adding guards for HCtoDCmapping in mapping parameters from LLVM to MVSC. New struct packing rule for doubles in Windows added. Use dc_alignment and hc_alignment to track parameter alignment on device and host compilers respectively.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpumapping.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpumapping.hpp#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpuprogram.cpp#66 edit
[ROCm/clr commit: 51d7e63f11]
EPR #396242 - Update to HCtoDCmapping: Adding guards for HCtoDCmapping in mapping parameters from LLVM to MVSC. New struct packing rule for doubles in Windows added. Use dc_alignment and hc_alignment to track parameter alignment on device and host compilers respectively.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpumapping.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpumapping.hpp#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpuprogram.cpp#66 edit
EPR #420344 - Forum [180211]: enqueueNDRangeKernel crashes to execute device binary if it contains printf statements
This is a temporary workaround to avoid app crash when a kernel has pritntf but the program object is built from a binary (i.e., the printf info is not propagated if the program object is built from a binary).
ReviewBoardURL = http://ocltc.amd.com/reviews/r/7676/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprintf.cpp#36 edit
[ROCm/clr commit: a53e6a74a4]
EPR #420344 - Forum [180211]: enqueueNDRangeKernel crashes to execute device binary if it contains printf statements
This is a temporary workaround to avoid app crash when a kernel has pritntf but the program object is built from a binary (i.e., the printf info is not propagated if the program object is built from a binary).
ReviewBoardURL = http://ocltc.amd.com/reviews/r/7676/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprintf.cpp#36 edit
EPR #010002 - Change OpenCL version number from 1815 to 1816.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1562 edit
[ROCm/clr commit: 59acc67b52]
EPR #010002 - Change OpenCL version number from 1815 to 1816.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1562 edit
EPR #010002 - Change OpenCL version number from 1814 to 1815.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1561 edit
[ROCm/clr commit: 6cffb032b1]
EPR #010002 - Change OpenCL version number from 1814 to 1815.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1561 edit
EPR #010002 - Change OpenCL version number from 1813 to 1814.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1560 edit
[ROCm/clr commit: 4b6532c7d0]
EPR #010002 - Change OpenCL version number from 1813 to 1814.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1560 edit
EPR #420584 - [CQE OCL][ISV][QR][SI] FAHBenchmark application is crashing on all SI cards.
Wave limiter causes FAH crash on SI. Disable wave limiter for SI as a workaround.
Opened bug #10817 to track this issue.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#6 edit
[ROCm/clr commit: 79b758537c]
EPR #420584 - [CQE OCL][ISV][QR][SI] FAHBenchmark application is crashing on all SI cards.
Wave limiter causes FAH crash on SI. Disable wave limiter for SI as a workaround.
Opened bug #10817 to track this issue.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#6 edit
EPR #010002 - Change OpenCL version number from 1812 to 1813.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1559 edit
[ROCm/clr commit: 51b3851007]
EPR #010002 - Change OpenCL version number from 1812 to 1813.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1559 edit
EPR #010002 - Change OpenCL version number from 1811 to 1812.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1558 edit
[ROCm/clr commit: 9795320da5]
EPR #010002 - Change OpenCL version number from 1811 to 1812.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1558 edit
EPR #010002 - Change OpenCL version number from 1810 to 1811.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1557 edit
[ROCm/clr commit: 2b7be4d803]
EPR #010002 - Change OpenCL version number from 1810 to 1811.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1557 edit
EPR #419347 - Fix a d3d9 memory leak.
According to https://msdn.microsoft.com/en-us/library/windows/desktop/bb174386(v=vs.85).aspx: Calling IDirect3DDevice9::GetDirect3D will increase the internal reference count on the IDirect3D9 interface. Failure to call IUnknown::Release when finished using this IDirect3D9 interface results in a memory leak..
Although p3d9devEx->Release() has the same effect as p3d9dev->Release(), for clarification we better use p3d9dev->Release() instead.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDeviceD3D9.cpp#13 edit
[ROCm/clr commit: 6d913bfc23]
EPR #419347 - Fix a d3d9 memory leak.
According to https://msdn.microsoft.com/en-us/library/windows/desktop/bb174386(v=vs.85).aspx: Calling IDirect3DDevice9::GetDirect3D will increase the internal reference count on the IDirect3D9 interface. Failure to call IUnknown::Release when finished using this IDirect3D9 interface results in a memory leak..
Although p3d9devEx->Release() has the same effect as p3d9dev->Release(), for clarification we better use p3d9dev->Release() instead.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDeviceD3D9.cpp#13 edit
EPR #010002 - Change OpenCL version number from 1809 to 1810.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1556 edit
[ROCm/clr commit: f329e3fc66]
EPR #010002 - Change OpenCL version number from 1809 to 1810.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1556 edit
ECR #304775 - Mipmaps support in OpenCL
- Enable PAD2 bit for miplevel views
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#218 edit
EPR #010002 - Change OpenCL version number from 1808 to 1809.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1555 edit
[ROCm/clr commit: 60c0f95fa6]
EPR #010002 - Change OpenCL version number from 1808 to 1809.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1555 edit
EPR #010002 - Change OpenCL version number from 1807 to 1808.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1554 edit
[ROCm/clr commit: d9a4d01b17]
EPR #010002 - Change OpenCL version number from 1807 to 1808.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1554 edit
EPR #010002 - Change OpenCL version number from 1806 to 1807.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1553 edit
[ROCm/clr commit: 6a1476d1ce]
EPR #010002 - Change OpenCL version number from 1806 to 1807.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1553 edit
EPR #010002 - Change OpenCL version number from 1805 to 1806.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1552 edit
[ROCm/clr commit: 6852d41216]
EPR #010002 - Change OpenCL version number from 1805 to 1806.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1552 edit
EPR #403782 - IOMMU2/SVM
- Update the caching and hit logic for resource cache to reflect allocation attributes for SVM. Else it can give wrong hits leading to hangs if a regular surface is used for shader upload etc. IOMMUv2 strictly needs shader and command buffers to have EXECUTE attribute.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/7572/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#217 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.hpp#80 edit
[ROCm/clr commit: 4f338e5578]
EPR #403782 - IOMMU2/SVM
- Update the caching and hit logic for resource cache to reflect allocation attributes for SVM. Else it can give wrong hits leading to hangs if a regular surface is used for shader upload etc. IOMMUv2 strictly needs shader and command buffers to have EXECUTE attribute.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/7572/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#217 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.hpp#80 edit
EPR #397491 - Disabling generic address space on 32 bit windows too for now.
Back out revision 116 from //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#117 edit
[ROCm/clr commit: 24ac37876f]
EPR #397491 - Disabling generic address space on 32 bit windows too for now.
Back out revision 116 from //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#117 edit
EPR #397491 - According to HSA-Finalizer-ADD, for GPUVM32 private_segment_aperture_base_hi and group_segment_aperture_base_hi should be equal to the 32 bits of the 32 bit private and group segment flat address aperture.
Reviewed by: German
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#362 edit
[ROCm/clr commit: 9d37ac1fc8]
EPR #397491 - According to HSA-Finalizer-ADD, for GPUVM32 private_segment_aperture_base_hi and group_segment_aperture_base_hi should be equal to the 32 bits of the 32 bit private and group segment flat address aperture.
Reviewed by: German
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#362 edit
EPR #010002 - Change OpenCL version number from 1804 to 1805.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1551 edit
[ROCm/clr commit: a24f070742]