Graf commitů

101 Commity

Autor SHA1 Zpráva Datum
Kiriti Gowda eb5f2da4ae Support GFX12 (#423) 2024-09-17 10:47:17 -04:00
jeffqjiangNew 14f4c6973a Simplified MD5 string compare code and fixed potential incorrect conversion of MD5 string to integers. (#414)
* * rocDecode: Fixed potential incorrect conversion of MD5 string to integers.

* * rocDecode: Changed a string name.

* * rocDecode: Simplified the MD5 string compare code.

* * rocDecode: Added minor changed based on review comments.

* * rocDecode: Minor changes.

* * rocDecode/Sample script: Added units to Bit rate field in csv output.
2024-09-16 15:27:10 -04:00
jeffqjiangNew 6253248188 Added real decode speed report to set it apart from the current output speed report in sample apps (#409)
* * rocDecode: Added real decode speed report.
 - The current decode speed report is actually output/display speed report.
 - Due to AV1's extensive use of alternate reference frames that are not display, AV1 decoded frame count and output/displayed frame count can be quite different, making the current speed report not an accurate decode speed measurement.
 - We now added the actual decode speed report, besides the existing speed report, now called output/display FPS.

* * rocDecode: Added real decode speed report.
 - The current decode speed report is actually output/display speed report.
 - Due to AV1's extensive use of alternate reference frames that are not display, AV1 decoded frame count and output/displayed frame count can be quite different, making the current speed report not an accurate decode speed measurement.
 - We now added the actual decode speed report, besides the existing speed report, now called output/display FPS.

* * rocDecode/Sample script: Added missing changes for sample_mode 0 case.
2024-08-20 17:43:33 -04:00
Kiriti Gowda 1ac853e441 CTest Updates - Fix duplicates (#408)
* Test - Fix CTest

* CMakeLists - Clang Set

* Ctest - support

* Readme - Fix and updates

* Readme - minor fix

* Readme - MS template

* Install - Minor instructiion fix

* Clang - Added as default CXX compiler

* Update CHANGELOG.md

Remove unreleased
2024-08-14 17:28:52 -04:00
jeffqjiangNew c486a7f6b4 Perf sample: Added decoded frame number and display delay options to video decode performance sample. (#405)
* * rocDecode/Perf sample: Added decoded frame number and display delay options to video decode performance sample. Also changed default thread number from 4 to 1.

* * rocDecode: Added max number of decoded frames option to decode sample script. This is useful to do partial decoding test on long streams.

* * rocDecode: Updated README.md.

* * rocDecode: Minor correction.
2024-08-12 09:39:43 -04:00
Kiriti Gowda 27d3d74f1d Samples: Video batch decode - FFMPEG Multiversion support (#402) 2024-07-30 14:31:51 -07:00
Lakshmi Kumar e3b3fe9e8e Test Upgrades (#395)
* adds av1 to ctest

* add av1 support for batch sample

* add test to make test also

* path update for make test

* add function for codec support check

* add changes to batch sample

* addressign review comment

* modify all apps to check codec support
2024-07-26 17:09:58 -04:00
Rajy Rawther 84c1dc9d03 Rr/video dec mem sample update (#390)
* remove hardcoded buffer size requirement

* minor change
2024-07-22 08:48:29 -04:00
Rajy Rawther fe5f63428c VideoToSequence sample (#373)
* videoToSequence sample initial commit

* add frame_num calculation when seeking

* update README

* addressed review comments

* added FlushAndReconfigure() to flush out frames with seek
2024-07-22 08:42:58 -04:00
Kiriti Gowda 2014c55f11 CMakeLists - Use -D AMDGPU_TARGETS (#379)
* Sample - Updates

* CMakeList - Accept -D AMDGPU_TARGET
2024-07-09 11:03:24 -04:00
Pavel Tcherniaev 1b9dd60837 Fixed bug with videoDecodeBatch (#375)
* fixed bug with videoDecodeBatch

* changed if statement to check n_frame_returned
2024-07-09 10:59:41 -04:00
Lakshmi Kumar 48b56de77a Add session overhead functions & modify perf app (#366)
* add session overhead funcitons & modify perf app

* remove class:: for function calls

* add session overhead funcitons & modify perf app

* remove class:: for function calls

* review comments

* fix comments

* duration to double

* update perf sample for thread_id for overhead

* remove debug statements

* revoew comments

* return value chnage to double

* remove session ID functions

* check session id validity
2024-06-11 10:38:19 -04:00
jeffqjiangNew 61c8661b9c rocDecode: Added decode buffer pool implementation for AVC and HEVC. (#355)
* * rocDecode: Initial check in for decode buffer pool.

* * rocDecode: All 135 streams pass.

* * rocDecode: Fixed a build error in debug mode.

* * rocDecode/HEVC: Removed two workaround in HEVC DPB management, after decode buffer pool implementa
tion.
 - WR 1: Conditional bumping (when max_num_reorder_pics > 0) to avoid synchronous job submission in
C.5.2.3.
 - WR 2: Add two more buffers in DPB to avoid buffer over-writing.

* * rocDecode/HEVC: Added display delay feature.

* * rocDecode/HEVC: Fixed the -z option issue within the context of the new decode buffer pool implementation.

* * rocDecode/HEVC: Removed redundent code.

* * rocDecode/AVC: Added decode buffer pool implementation for AVC.

* * rocDecode: Added a few changes.
 - Added display delay feature to AVC.
 - Removed a workaround for AVC: AVC_MAX_DPB_FRAMES was increased to 18. Now it is back to 16.
 - Removed a workaround for AVC: increased DPB buffer size by 2. Now it is back to normal.
 - Code format changes for HEVC.

* * rocDecode/AVC: Fixed the -z option issue within the context of the new decode buffer pool implementation.

* * rocDecode: Merged OutputDecodedPictures() method to upper class RocVideoParser.

* * rocDecode: Code cleanup. No functional changes.

* * rocDecode: Made decode buffer pool size adaptive.
 - Removed the hard coded decode buffer pool size set in the decoder.
 - Exposed the display delay parameter from RocVideoDecoder class to the user.
 - Now the decoder buffer pool size is determined from the DPB buffer size and display delay parameter.

* * rocDecode: Several changes based on code review.
 - Merged decode and display use status into one parameter.
 - Removed the surface index from DecodeFrameBuffer, which is now implicitly referred by the array index.
 - Changed a function name for better clarity.

* * rocDecode: Added a comment.
2024-05-31 13:14:02 -04:00
Pavel Tcherniaev 746877ef56 added MD5 checksum for videodecodemem sample (#349) 2024-05-16 11:36:40 -04:00
Rajy Rawther dd30db9f51 Added a new function to get RgbStride (#352)
* re-org videodecodeRGB sample

* minor fix

* removed un-necessary include

* minor fix

* added GetRgbStride utility function for RGB stride

* fix for review comments

---------

Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com>
2024-05-13 12:39:38 -04:00
Aryan Salmanpour bdb08ab644 Fix compilation issues on distro without std::filesystem (#348) 2024-05-08 14:45:32 -04:00
Rajy Rawther 95f90982eb videodecodeRGB sample re-org for rocPyDecode (#343)
* re-org videodecodeRGB sample

* minor fix

* removed un-necessary include

* minor fix
2024-05-07 17:11:57 -04:00
Aryan Salmanpour 1943aad663 Fix compilation issues on RHEL8 and SLES15.5 related to using std::filesystem (#342) 2024-05-06 21:12:23 -04:00
Kiriti Gowda e2b9e7197a Sample - Added missing header (#336) 2024-05-02 17:26:11 -04:00
Pavel Tcherniaev 12fa766973 added md5 checksum with changes that Aryan and Rajy requested (#333)
Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com>
2024-05-02 08:49:46 -04:00
Lakshmi Kumar 2d50d685f7 Seek - Bug Fixes + Sample Update (#327)
* adds seek to videodecode and seek bug fixes

* fixes both frames & timestamp with prev_key_frame option

* switch to exact key frame and bug fix

* fix decoded_frame_number from seek

* fix out_frame_duration

* clean up + exact fram fix
2024-05-01 17:03:27 -04:00
Lakshmi Kumar d5b5a31881 move getEnvVar function to common (#299) 2024-03-26 19:07:13 -04:00
Aryan Salmanpour 592195b652 Organizing the install location of the rocdecode utils headers (#296) 2024-03-26 12:47:37 -04:00
Lakshmi Kumar e4316f009c Sample Bug Fix - Batch sync issue (#289)
* bug fix for new dec creation

* move bit depth change after creating new dec

* codec update for every new dec

* bug fix for new dec creation

* move bit depth change after creating new dec

* codec update for every new dec

* fixes sync issue on MI250X for batch sample

* remove unused variable
2024-03-20 08:25:00 -04:00
Rajy Rawther 39e274d02d rocDecode resize sample implementation (#285)
* WIP: resize kernels

* hipified kernels for scaling from cuda

* updated videodecodeRGB sample for scaling

* added stream parameter to kernels

* add scale kernels using tex2d and NN

* enable tex2D kernels

* add NN resize kernels

* fixed scaling kernels

* fixed tex2D scaling kernel for UV scaling

* minor formatting

* address review comments

---------

Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com>
2024-03-18 08:32:19 -04:00
Lakshmi Kumar cca5f22a9a Bug Fix - Batch sample (#283)
* bug fix for new dec creation

* move bit depth change after creating new dec

* codec update for every new dec
2024-03-12 13:27:34 -04:00
jeffqjiangNew e4614de461 Fixed several issues with cropping. (#275)
* * rocDecode: Fixed several issues with cropping.
  - Fixed the pixel start offset error on streams with non-zero top/left cropping in MD5 calculation.
  - Fixed the pixel start offset error on streams with non-zero top/left cropping, and/or with user specified cropping in YUV frame output.
  - Sorted out code which deals with cropping area specifiied by the bitstream, and cropping area specified by the user.

* * rocDecode: Additional changes after discussion.
 - Set display rect for decoder create/reconfig to displayable area or user specified ROI area.
 - Do not set target rect for decoder create/reconfig. Leave it for future use.
 - Unified naming of display rect in decoder create/reconfig structs.

* * rocDecode: Put back the extra rounding to target width/height specifiied by the coded stream, for peace of mind, based on code review.

* * rocDecode: Added the missing stream specified cropping offset to the starting pixel pointer for none-internal memory modes.

---------

Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com>
2024-03-11 22:35:11 -04:00
Lakshmi Kumar 264e847c5a README Updates (#282)
* adding new sample for decoding mulitple files on multiple threads

* threads work ; no decoding yet

* working version

* code clean up

* review comments

* removing spaces

* review comments

* fps cal + name changes for files

* code clean up

* update readme

* update readme

* remove spaces

* change to lambda functions

* changes for using reconfig

* adding dumping of yuv frames + review comments

* review comments

* remove extra lines/spaces

* adding struct for decoder info

* make separate decoders for 8 & 10bit

* code clean up

* addign reset for Saving frames

* review comments

* fixes dump issue for new file

* cmake update for threads

* support for avc

* name change for sample

* cmake soource name change

* readme update

* fixing typo in readme

* update REAME

* update readme

---------

Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com>
2024-03-08 10:56:51 -05:00
Lakshmi Kumar ce3ebadaab Samples - Multi Threaded Multi FIles (#255)
* adding new sample for decoding mulitple files on multiple threads

* threads work ; no decoding yet

* working version

* code clean up

* review comments

* removing spaces

* review comments

* fps cal + name changes for files

* code clean up

* update readme

* update readme

* remove spaces

* change to lambda functions

* changes for using reconfig

* adding dumping of yuv frames + review comments

* review comments

* remove extra lines/spaces

* adding struct for decoder info

* make separate decoders for 8 & 10bit

* code clean up

* addign reset for Saving frames

* review comments

* fixes dump issue for new file

* cmake update for threads

* support for avc

* name change for sample

* cmake soource name change

* readme update

* fixing typo in readme

---------

Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com>
2024-03-07 20:29:14 -05:00
Kiriti Gowda ca067ae6ec FFMPEG - Multi-version support (#270)
* FFMPEG 5.X - Support

* FFMPEG 5.X - Support

* FFMPEG - Multiversion support

* FFMPEG - Support FFMPEG AVCODEC > 58.134.X
2024-03-05 08:34:05 -05:00
Aryan Salmanpour 6317b9f22b Revert "FFMPEG 5.X - Support (#268)" (#269)
This reverts commit 4f2bf945a9.
2024-02-28 14:31:07 -05:00
Kiriti Gowda 4f2bf945a9 FFMPEG 5.X - Support (#268) 2024-02-28 12:37:33 -05:00
jeffqjiangNew 320c0954a3 * rocDecode: Take care of the case where DecodeFrame() does not return 1 (decoded frame number) so the accumulated decoded frame number does not match the user targeted frame number and the decoding will not stop. (#257) 2024-02-23 22:54:29 -05:00
jeffqjiangNew ad31866ee0 * rocDecode: Added a command option to limit the number of decoded frames to a user set value to the video decoder app. (#252) 2024-02-16 08:44:03 -05:00
Kiriti Gowda e95129ece2 VideoDecodeRGB - Failure Fix (#248)
* Sample - ROCM PATH Fix

* Sample - Add missing lib
2024-02-14 13:03:34 -05:00
Aryan Salmanpour ee3829388d Fix a bug in VideoDecodeRGB for syncing between main and worker threads (#245) 2024-02-14 12:30:03 -05:00
Aryan Salmanpour 31c7c7c104 Fix a segmentation fault on some samples when the memory type is 3 (OUT_SURFACE_MEM_NOT_MAPPED) and attempting to save the output (which is not supported) (#239)
* Fix a segmentation fault on some samples when the memory type is 3 (OUT_SURFACE_MEM_NOT_MAPPED) and attempting to save the output (which is not supported)

* update the videoDecodeMultiFiles sample

* update the readme for videoDecodeMultiFiles

* add comments

* use OUT_SURFACE_MEM_NOT_MAPPED instead of integer number 3
2024-02-12 16:50:17 -05:00
Kiriti Gowda 1881a5a61e Sample - fix path & build types (#237) 2024-02-12 12:13:37 -05:00
Aryan Salmanpour de5841d249 Enable gfx941/gfx942 by default for videoDecodeRGB sample (#236) 2024-02-12 08:35:23 -05:00
Lakshmi Kumar 072d6fe0e2 remove fork example (#232) 2024-02-09 15:46:48 -05:00
Kiriti Gowda 5e5c92abb5 Doc - Updates (#231) 2024-02-09 13:31:44 -05:00
Kiriti Gowda adaa5f76a4 rocDecode Docs - Updates (#225)
* rocDecode Docs - Updates

* Copy Fix

* Fix create dir

* Online - docs Updates

* Fix indents

* Fix indent

* Create symlink to overview

* Docs - Cleanup

---------

Co-authored-by: Sam Wu <sam.wu2@amd.com>
2024-02-07 18:37:58 -08:00
Pavel Tcherniaev fa3f21a7df fixed syntax error in videodecodefork.cpp, was missing a semicolon at the end of a line (#217)
Co-authored-by: kjayapra-amd <karthik.jayaprakash@amd.com>
2024-02-02 16:46:07 -05:00
Lakshmi Kumar 43481ce36b Samples - Clean up and bug fixes (#203)
* clean up samples

* fixes error seen in videoDecodeMem app with big files
2024-01-29 12:58:00 -05:00
Kiriti Gowda 6658070d1c Samples - Updates (#206)
* Samples - Updates

* Readme - samples
2024-01-26 10:38:20 -08:00
Kiriti Gowda 2298d93990 Samples - Docs Updated (#204) 2024-01-26 05:19:24 -08:00
Rajy Rawther 51ecd8fccf fix for hipOutOfMem bug when decoding large videos (#189)
* fix for issue 441908
2024-01-19 09:46:02 -08:00
Lakshmi Kumar 8ec38d2d24 Adding support for reading Environmental variable for samples (#186)
* check if env var set and choose device

* clean up for env var

* app modification

* move getEnvVar function to header

* fork example

* spacing adjust

* review comments

* use hipGetErrorName to throw errors
2024-01-17 22:57:31 -05:00
Aryan Salmanpour 3d28911453 Remove unsupported GPUs (#175) 2024-01-15 10:50:34 -08:00
Lakshmi Kumar e7be5f2bbf fixes bug with device id provided by user (#171)
* fixes bug when setting env variable

* fix for device id
2024-01-12 14:54:44 -05:00