Commit Graph

35 Commits

Author SHA1 Message Date
Marko Arandjelovic 850511cc28 SWDEV-465196 - Fix coalesced_group tests
Change-Id: I4537e2351273d0c71ff62d34b5002fcb2ecd15e6
2024-09-13 04:29:02 -04:00
Sourabh Betigeri aaec37314f SWDEV-462007 - Fixes and strenghtens multi grid sync on mgpus
- Replaces logic relying on clock64() instead to
  use an atomic counter that the last wg in grid
  and multi-grid groups wait on while the the
  non-last work groups increment the counter
  to "done"
- Implements a new logic to verify the multi-grid
  sync()

Change-Id: I7780d8124e5f144b124e5d191d0f412483a3b565
2024-09-06 11:58:20 -07:00
Vladana Stojiljkovic 5b67a2a4a0 SWDEV-450735 - Add compiler option for using clock64
Change-Id: I9efed88d691ee1b2b4465286b3340b820f7bf627
2024-08-29 10:26:11 +02:00
Sourabh Betigeri 787f7f8df1 SWDEV-435054 - Improves robustness of HIP test
Makes the test stronger by hiding
dispatch scheduling latency on MI300

Change-Id: Ic9724f4f1b16f1e707060129327248bbb353df45
2024-08-08 14:23:24 -04:00
Jatin Chaudhary 5293b1a3a5 SWDEV-450109 - add sanity tests for cg functions
Change-Id: If54be97c07502beaaf068fdc249758931dfa5abf
2024-07-30 11:23:56 -04:00
Rahul Manocha 6df445fef6 [SWDEV-438556][SWDEV-450826][SWDEV-449018] - Fix cooperative group catch tests
Change-Id: I553afe9c684b9ae60ce84231d7a5fbd6532a20e6
2024-06-17 17:22:26 -04:00
Alex Xie 26223a792b SWDEV-452538 - Cast functions directly to void *
This fix build errors in some builds

Change-Id: I1b8c9fa7186b60a20e8dfb86599c348455620c32
2024-05-06 09:21:17 -04:00
Sebastian Luzynski 109ffa0590 SWDEV-452538 - Cast functions directly to void* instead of casting to function pointer
This change fixes build warning when compiled with -Wcast-function-type flag

Signed-off-by: Sebastian Luzynski <Sebastian.Luzynski@amd.com>
Change-Id: If60abf5c6855879a07375c166d7cb9ff6cd6fe5d
2024-05-06 07:38:07 -04:00
Jaydeep Patel 7def265d94 SWDEV-449111 - Lesser CU size tends to have block & thread dim = 0. OOM as PAL uses half of CPU memory once GPU memory exhausts.
Change-Id: I2399f7247f5172fdc7980a4652ff68df4b5598c5
2024-04-17 07:58:37 -04:00
Rahul Manocha bcff12dedc [SWDEV-438556][SWDEV-449685] - Fix for CG MultiGrid Group Tests
Change-Id: Iaf3d422e57465fefe9adb1fc7c01a480ada37db3
2024-04-16 08:20:33 -04:00
Jaydeep Patel ad602b0011 SWDEV-444257 - Less # of CUs i.e. 2 tends to ..
- make blockdim to become 0 and hence need validation.
- run cooperative kernel with param lesser # of threads
  than actual # of elements and hence need correction in
  validation part.

Change-Id: Ie48a038fe6f8cf25d7f6460703648a360f511f35
2024-04-03 13:37:34 -04:00
Branislav Brzak 6c23e25c86 SWDEV-448163 - Fix Doxygen warnings
Change-Id: If72e312461a72920b6a482009c9aef4cf92f2e1b
2024-03-25 05:18:34 -04:00
Jaydeep Patel bffc913f8c SWDEV-448989 - Check image support.
Change-Id: Id245c3f348c6c7b4146224f93534443f93a01a9d
2024-03-19 11:59:52 -04:00
Mirza Halilcevic dc78fafa49 EXSWHTEC-384 - Coverage Tool and Test Plan update #455
Change-Id: Idf52308186a73ae1c4d815eb59f20ea7da99c964
2024-02-27 22:26:25 +05:30
Nives Vukovic c6a6475743 EXSWHTEC-266 - Implement new and extend existing tests for coalesced group partitioning #155
Change-Id: Ia971913ef7550e9ce4c886c044c30dc46578beb3
2024-02-23 20:44:45 +05:30
Nives Vukovic 4fa177dd2b EXSWHTEC-259 - Implement new and extend existing tests for thread_block #151
Change-Id: I4d85af8e5f805a1c8ff7b7efd3b3400f38343ea9
2024-02-19 23:36:30 +05:30
Nives Vukovic 9ab359fa17 EXSWHTEC-260 - Implement new and extend existing tests for thread_block_tile #152
Change-Id: I797d895f582d01efa9a2657b0fbd3dc69049f80b
2024-02-19 23:28:51 +05:30
Rakesh Roy 978e165d33 SWDEV-1 - Merge github PRs to amd-staging
- https://github.com/ROCm/hip-tests/pull/154
- https://github.com/ROCm/hip-tests/pull/438
- https://github.com/ROCm/hip-tests/pull/425
- https://github.com/ROCm/hip-tests/pull/424
- https://github.com/ROCm/hip-tests/pull/423
- https://github.com/ROCm/hip-tests/pull/365
- https://github.com/ROCm/hip-tests/pull/356
- https://github.com/ROCm/hip-tests/pull/279
- https://github.com/ROCm/hip-tests/pull/274
- https://github.com/ROCm/hip-tests/pull/190
- https://github.com/ROCm/hip-tests/pull/189
- https://github.com/ROCm/hip-tests/pull/188
- https://github.com/ROCm/hip-tests/pull/156
- https://github.com/ROCm/hip-tests/pull/49
- https://github.com/ROCm/hip-tests/pull/439
- https://github.com/ROCm/hip-tests/pull/437
- https://github.com/ROCm/hip-tests/pull/436
- https://github.com/ROCm/hip-tests/pull/435
- https://github.com/ROCm/hip-tests/pull/193

Change-Id: I2529d0baf0f8d47d6215863321720cde2b1a846c
2024-02-19 15:33:25 +05:30
Nives Vukovic 09fc34b982 EXSWHTEC-253 - Implement tests for coalesced_group basic APIs (#154)
Change-Id: I81854598d8e1ae0b5cff24012e8f381258e0818f
2024-02-15 19:41:25 +05:30
Nives Vukovic 9b96b707ee EXSWHTEC-267 - Implement tests for multi_grid_group APIs (#156)
Change-Id: I2820ec19831f0dad3b8ce60172c86791f274107e
2024-02-15 19:41:22 +05:30
Jaydeep Patel 3da249e472 SWDEV-439298 - Correct odd/even logic.
Change-Id: Iafe1b3915b513207a5ef24cf145ac1e8e39a1672
2024-02-14 10:12:10 -05:00
Jatin Chaudhary 5e766685c8 SWDEV-440095 - remove the test Unit_hipLaunchCooperativeKernel_Streams
The test checks the pattern of thing "A" should be always faster than
thing "B". Which might not be the case for several reasons and will result
in unreliable, randomly failing test.

Change-Id: I6fa9e2c110f9ef48ef63a720e7a64c54e7f2a72f
2024-01-24 04:28:58 -05:00
Maneesh Gupta 6429ef1b60 SWDEV-1 - Merge github PRs to amd-staging
- https://github.com/ROCm/hip-tests/pull/194
- https://github.com/ROCm/hip-tests/pull/36
- https://github.com/ROCm/hip-tests/pull/44
- https://github.com/ROCm/hip-tests/pull/47
- https://github.com/ROCm/hip-tests/pull/62
- https://github.com/ROCm/hip-tests/pull/63
- https://github.com/ROCm/hip-tests/pull/64
- https://github.com/ROCm/hip-tests/pull/65
- https://github.com/ROCm/hip-tests/pull/66
- https://github.com/ROCm/hip-tests/pull/67
- https://github.com/ROCm/hip-tests/pull/68
- https://github.com/ROCm/hip-tests/pull/69
- https://github.com/ROCm/hip-tests/pull/142
- https://github.com/ROCm/hip-tests/pull/196
- https://github.com/ROCm/hip-tests/pull/238

Change-Id: I74f7fef76d7d536b1cf89dad3e527c92d1cd21b5
2023-12-20 10:39:37 +00:00
Nives Vukovic e0612f9346 EXSWHTEC-308 - Migrate and refactor cooperative groups tests from HIP repository (#238)
Change-Id: Ib46b7c038a5bda9d05f5d55a7269a7c645b0d049
2023-12-20 10:22:01 +00:00
Sourabh Betigeri 559b335208 SWDEV-427356 - Workaround to fix a bug that causes soft hang of cooperative group tests
Change-Id: I57e2b51acc9443c1bd036f3d0d5c047989ceef82
2023-11-17 05:52:00 -05:00
Rupam Chetia ae8090bde8 SWDEV-421132 - [catch2][dtest] Adding basic tests for Cooperative Groups methods meta_group_size() and meta_group_rank()
Change-Id: I7b9df6a3d656e0303e357e2610da9303e93f5600
2023-11-06 09:17:03 -05:00
Sourabh Betigeri 9cef1f0ac5 SWDEV-417765 - Modifies test to verify dimensions returned by group_dim()
Change-Id: Ie92b9f74f4cc37b55f175cb828a88266c5167e0c
2023-10-12 11:51:50 -04:00
Rakesh Roy 632802aef8 SWDEV-1 - Fix build errors occurred due to -Wunused-variable, -Wunused-but-set-variable, -Wunused-result
- Remove unused variables
- Validate return value of HIP APIs
- Disable failed tests in PSDB
- Use HIP_CHECK_ERROR instead of ASSERT_EQUAL

Change-Id: I9dd0792ecd8c79760b6c948388a953ac8c97b5c2
2023-09-22 21:41:16 +05:30
Sourabh Betigeri 850a18bf2f SWDEV-396656 - Adds CG tiled_partition and coalesced_groups tests
- Tests meta_group_rank/size() in static tile
               partitioning

Change-Id: I1a0d83224145a2356aa12b5e83b094834b53d5a4
2023-09-22 04:49:19 +00:00
ROCm CI Service Account 34976df246 SWDEV-385161 - Deprecate usage of env vars in HIP samples and tests (#363)
* SWDEV-385161 - Deprecate usage of env vars in HIP samples and tests env vars such as HIP_PATH, ROCM_PATH, HIP_COMPILER, HIP_RUNTIME, HSA_PATH etc are removed.

Change-Id: I280e20b291cfb14675846aae72d97fa5b3ad567d
2023-08-14 12:06:14 +05:30
nives-vukovic 22f3d9034b EXSWHTEC-256 - Implement tests for grid_group APIs (#153)
- Migrate basic Cooperative Groups tests and integrate to catch
- Refactor basic Cooperative Groups tests
- Rename tiled partition related files and fix minor bug
- Add LaunchCooperativeKernal and LaunchCooperativeKernelMultiDevice tests
- Refactor hipCGThreadBlockTileType to use common function
- Fix updated file not added during merge
- Add coalesced_group type tests
- Add coalesced_group shuffle_up and shuffle_down tests
- Add coalesced_group shuffle tests - test fails
- Implement common code for cooperative group tests
- Fixed compilation errror in cooperative_groups_common.hh
- Implement busy wait device function
- Reimplement tests for grid_group APIs
- Add tests for grid_group member and non-member APIs
- Refactor existing test for grid_group sync testing
- Add thread and block dimensions generators
- Add check of grid and block dimensions
- Modify doxygen comments
- Move cpu_grid.h and supporting functions to catch/include
- Use warp_size from properties in grid/block dims generators
- Fix condition for warp size 32 on AMD
- Fix cpu_grid.h for warp function tests
- Add missing include into cpu_grid.h
- Code cleanup
- Fix doxygen comments
- Add missing include in utils header
2023-07-18 12:55:00 +05:30
ROCm CI Service Account 6e4bfd4bce SWDEV-358553 - Fixed all compiling bugs (#214)
Change-Id: I6f5316d76b2fad534f670b18138fc100c313be0d
2023-06-21 15:57:11 +05:30
ROCm CI Service Account 74a6e407e7 SWDEV-348282 - fixed intermittent failure fo hipCGMultiGrid* and hipCGThread* tests, porting over to catch2 in the process (#3067)
Change-Id: Id22dfb4ab2ee8171242fbf6a10886ff3e4abc926
2022-11-18 12:14:12 -08:00
Paulius Velesko da453211ed Catch2 Test Fixes (#2961)
* test fixes

* address PR comment

* PR comment fixing Nvidia pass

* add additional kernel launch checks

* pr comments
2022-09-30 15:07:25 -07:00
ROCm CI Service Account 10c84389cd SWDEV-325480 - Adds unit and functional tests for coalesced_groups (#2538)
Change-Id: I147b4099e6793df5df3a6e252894d281fc338adb
2022-03-11 16:54:08 +05:30