Commit Graph

11513 Commits

Author SHA1 Message Date
Sourabh Betigeri 325aca33ad SWDEV-342067 - Fixes a minor coding error to loop through all the entries in the map
Change-Id: I837cb4868de2acd3e71ca9a745a62ed0bb2d1400


[ROCm/clr commit: 5ad38a32bf]
2022-06-20 19:20:38 -04:00
Alex Xie 4faa8f8b4a SWDEV-328157 - Palamida scan header remediation
Change-Id: Iee7798d368cc3c1c47c4b8ff483d42aec595d900


[ROCm/clr commit: 1d24125cf3]
2022-06-20 17:23:15 -04:00
Ajay 1402d33098 SWDEV-334340 - clang_rt.lib not to search in default path
Change-Id: Idf493477bbf8ddde4b7754f64f44c9c5aea008a2


[ROCm/clr commit: 7b38ee1574]
2022-06-19 22:54:03 -04:00
Chauncey Hui 8517632ad8 SWDEV-2 - Change OpenCL version number from 3474 to 3475
[ROCm/clr commit: 4fe8038b7c]
2022-06-18 03:00:06 -04:00
Jaydeep 147485a9aa SWDEV-336548 - Check for valid hipArray pointer in hipFreeArray
Change-Id: Icf0d47eeca7b5dd390a6a9c53b622b3680688ca4


[ROCm/clr commit: 1032581ded]
2022-06-18 00:56:33 -04:00
Sourabh Betigeri 4501fb58b5 SWDEV-341994 - Fixes to returns the right error code to match CUDA spec for hipHostUnregister()
Change-Id: Ied9b5a15e841d4c201042d116b0ed535f07c17fc


[ROCm/clr commit: 3ca4c7edf7]
2022-06-17 12:16:52 -04:00
Jaydeep e146b7812e SWDEV-332607 - If pitch returned from hipMallocPitch is equal to pitch passed to hipMemset2D then height passed to hipMemset2D must be less than or equal to height passed to hipMallocPitch.
Change-Id: I8d9b0938fb592170008aaec9cedd519bf40c6201


[ROCm/clr commit: ea0590d1fe]
2022-06-17 10:35:22 -04:00
Rakesh Roy 813128436d SWDEV-330455 - Avoid creating different HSA signals for ROCr
- In ROCr, there is supposed to be exactly one HSA signal ever whose pointer is stored in every hostcall buffer so that device code can find it
- But, hostcallListener->initDevice creates a new HSA signal everytime enableHostcalls() gets called

Change-Id: I100595ec37442bcdb73da5991062f0a474de2935


[ROCm/clr commit: 42da508815]
2022-06-17 05:30:57 -04:00
Chauncey Hui 784539891c SWDEV-2 - Change OpenCL version number from 3473 to 3474
[ROCm/clr commit: 3223c1b56a]
2022-06-17 03:00:08 -04:00
Jaydeep 4185c568da SWDEV-336542 - Return InvalidValue error for hipArrayCubemap flag.
Change-Id: I4ca996d7643158d5ccf8cb48ceaead3ceaf9aedf


[ROCm/clr commit: 0ad84364e0]
2022-06-17 00:25:18 -04:00
Sarbojit Sarkar 8f863abe02 SWDEV-325379 - Fix for remote copy crash
Change-Id: I22152c0b3538cf7cfc80f82505bc255c01d98f7b


[ROCm/clr commit: 356e22f910]
2022-06-16 23:59:11 -04:00
jaypatel 8b4d8bdee4 SWDEV-322688 - Added hip math constants header.
Change-Id: I9363f82159a53c6822e943c4950fc7f6c350b326


[ROCm/clr commit: 8d464a2e83]
2022-06-16 23:56:45 -04:00
German Andryeyev 14f03b4571 SWDEV-341316 - Copy image SRD only if it's valid
Change-Id: I971a21fe99fd07b21cfd3dbe4e7ed33c0ea322f4


[ROCm/clr commit: 73ec7bada6]
2022-06-16 09:18:04 -04:00
kjayapra-amd 86cc032d73 SWDEV-340226 - Fixing minor issues related to hiprtc Link API changes.
Change-Id: I18e7ca2a467ccf14d95ffb37b5516dda74f98cf7


[ROCm/clr commit: 5e61b9e762]
2022-06-16 06:06:38 -07:00
kjayapra-amd 8e43fcc5df SWDEV-339913 - Move SingleFPDenorm under ASIC Revision from GFXIP switch case.
Change-Id: I7826f81bdf7cf1479882f261d495c2c287725b3c


[ROCm/clr commit: 3a78a1edcd]
2022-06-16 08:31:37 -04:00
Chauncey Hui 07a15d664e SWDEV-2 - Change OpenCL version number from 3472 to 3473
[ROCm/clr commit: 0cd8e18cb3]
2022-06-16 03:00:06 -04:00
Satyanvesh Dittakavi 04ace898e0 SWDEV-327563 - Fix the hip runtime library name to load in hiprtc on Windows
Change-Id: Ib4988dd8677da907bec8e59b1b4ce3e57aad2bb7


[ROCm/clr commit: bf4cf3c369]
2022-06-16 00:45:43 -04:00
Satyanvesh Dittakavi 920ceab2db SWDEV-336532 - Convert Managed Memory in hipPointerGetAttributes on Nvidia platform
Change-Id: I3bc6180040b6ad48f06ffdc7d01ca6fd9fe32c0e


[ROCm/clr commit: f7d0850eb8]
2022-06-16 00:43:15 -04:00
Jaydeep Patel 770171bde8 SWDEV-338376 - Added hipMemGetAllocationGranularity, hipMemCreate and hipMemRelease for CUDA
Change-Id: If8c6a00958bb39752eb202c30a7960d13de225ae


[ROCm/clr commit: ab8583b4d5]
2022-06-15 23:59:56 -04:00
Ranjith Ramakrishnan 488b937709 SWDEV-335990 - Use GNUInstallDirs
GNUInstallDirs is used to allow the user to customize the install paths
of HIP, rather than using hardcoded locations.
Minimum cmake version updated to 3.16.8

Depends-On: I521c44dc34404b136141682c2777257b23ffa6e8
Change-Id: I2cff642c469d6d1e8bb3f1a3c151e6a03fb5d55b


[ROCm/clr commit: 8f8367fd49]
2022-06-15 23:49:54 -04:00
Jaydeep Patel 33a50636e9 SWDEV-333581 - Pass free and/or total size_t as nullptr.
Change-Id: Ib83467a351b6df22ef641c0e82284c7e0fac32e3


[ROCm/clr commit: a527c241a2]
2022-06-15 23:46:34 -04:00
sdashmiz 57a0d997d3 SWDEV-325711 - add Graph memory APIs skeleton
- hipDeviceGet/SetGraphMemAttr

- hipDeviceGraphMemTrim

- there is no memory pool for graphs currently

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I11db76ea7ea1c7732175fc93264448052357e8dc


[ROCm/clr commit: e8194dca76]
2022-06-15 14:47:16 -04:00
Sourabh Betigeri 2c9c07aaa8 SWDEV-331301 - Fixes to return error if the childGraph topologies of instantiated childGraphNode and to-be updated childGraphNode do not match
Change-Id: I372317a4df13e5cd352f46525d820246fe4ca8f2


[ROCm/clr commit: c3db564e94]
2022-06-15 13:39:15 -04:00
Jeremy Newton 45f1f89a97 SWDEV-335990 - Use GNUInstallDirs
This is attempt two of a5b6de5037

GNUInstallDirs is used to allow the user to customize the install paths
of HIP, rather than using hardcoded locations.

See documentation for more information:
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

Note that libdir must be overriden to "lib" before including
GNUInstallDirs, because by default, cmake tries to detect the libdir
path, but ROCm packaging would like to use lib by default for all
targets. This does not stop the user (or distros) from overriding.

Also note this change does no take into account the changes needed to
non-cmake files, such as perl scripts, so not all paths combinations are
necessarily functional.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: I521c44dc34404b136141682c2777257b23ffa6e8


[ROCm/clr commit: 112b6370a5]
2022-06-15 13:14:47 -04:00
haoyuan2 8126f235e2 SWDEV-338781 - fix blender crash issue on Navi1x
remove incorrect control logic which caused seg fault on Navi1x

Change-Id: Ic56e8a73c53062bd86adcf57d0b66e00e21734ec


[ROCm/clr commit: 6937fcae3a]
2022-06-15 10:54:57 -04:00
Chauncey Hui 67fea7365d SWDEV-2 - Change OpenCL version number from 3471 to 3472
[ROCm/clr commit: f897a01278]
2022-06-15 03:00:08 -04:00
Saleel Kudchadker b3ad41f6e4 SWDEV-335780 - Indicate if handler is queued
Maintain status of handler callback. For event records we no longer
submit callbacks to reduce the load on the async handler thread. However
without a callback we leak command memory/decrement refcounts. Indicate
status of the handler which we can use to queue a callback when
finish is called.

Change-Id: I89fd02f3d047a0e8162664ee17581a14795f1928


[ROCm/clr commit: 5df34a2f7a]
2022-06-14 20:55:06 -04:00
Saleel Kudchadker d0e5a9583a SWDEV-335780 - Revert commit
This reverts commit a206abcaa1.

Change-Id: I589d495b448a5ecc7def9dbca3f70b033a962f45


[ROCm/clr commit: 1cea2c0412]
2022-06-14 19:08:22 -04:00
Sourabh Betigeri 5d26e66ed7 SWDEV-318237 SWDEV-330173 - Fixes kernel parameter corruption when multiple nodes of the same kernelNode exist
Change-Id: I6437593be46b7b5afc3d77cdd887ad4139978ad3


[ROCm/clr commit: 5549c8cd1b]
2022-06-14 18:06:21 -04:00
haoyuan2 33ea8b153e SWDEV-338564 - fix test hang issue
only check task finish with valid queue

Change-Id: Ib2bd1360235a07f825a09c57453ccbff7951f17f


[ROCm/clr commit: cfe1efd6b0]
2022-06-14 15:34:30 -04:00
Sourabh Betigeri f3d7a42714 SWDEV-340453 - Fixes coding error. Missing condition in a negative scenario
Change-Id: Ic4b71e143ec883ca73a2511a367ac034444ec7de


[ROCm/clr commit: 2f9e92757c]
2022-06-14 12:24:10 -04:00
German Andryeyev acf2856677 SWDEV-339296 - Delay hidden heap allocation till the usage
Move hidden heap creation to the kernel launch to make sure it's
allocated on the actual first usage.

Change-Id: I1b65a82fc06d9129ed45a69765bf14ea3d945b04


[ROCm/clr commit: 4975f69337]
2022-06-14 12:18:34 -04:00
German Andryeyev 2b3296a4ef SWDEV-259998 - Change the location of RGP init calls
Move StartLateDeviceInit() and FinishDeviceInit() calls in RGP
server to avoid a timeout

Change-Id: Ifd681859c7dc76259d7296aa8cc15305d563c9b2


[ROCm/clr commit: ecea224bcf]
2022-06-13 18:05:44 -04:00
sdashmiz 92f5d16599 SWDEV-321698 - remove Memcpy1D type
- Memcpy1D node type is not complying with cuda

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: If8113f5e699de0c62d98effc4580a2e0fee9a950


[ROCm/clr commit: 13c875eaf0]
2022-06-13 08:31:02 -04:00
Chauncey Hui c07ca3d681 SWDEV-2 - Change OpenCL version number from 3470 to 3471
[ROCm/clr commit: ad9300b47b]
2022-06-11 03:00:05 -04:00
Christophe Paquot f6a235ff2e SWDEV-322620 - Virtual Memory Management
Implements hipMemRetainAllocationHandle
HIP layer updates the svmPtr of the amd::memory
ROCCLR just manages the MemObjMap
This is because HIP knows the orignal (generic) address of the
physical memory whereas ROCCLR doesn't keep track of that

Change-Id: Ied26d7f814bc468f5cf586c967020737b9aa9e9f


[ROCm/clr commit: faa7ee48ba]
2022-06-10 17:48:07 -04:00
agunashe af679a5f1c SWDEV-337331 - Windows graph fixes iteration2
API fixed hipGraphAddDependencies

Change-Id: I1248c00d788c392c71e64c5070fe09653125bb34


[ROCm/clr commit: 9e7b44511a]
2022-06-10 16:42:54 -04:00
sdashmiz 9be23b6b1f SWDEV-334857 - hipModuleGetTexRef compatibilty issue
- make the defualt texref value compatible with cuda

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I2ae980e435f3b0fc15b237741e3f2b97c4257e12


[ROCm/clr commit: 8d93ff521f]
2022-06-10 15:13:29 -04:00
Ajay 70189c7e2e SWDEV-327563 - support hipStreamWrite32/64 and hipStreamWait32/64 funcs
Windows complains about undefined symbol for
hipStreamWrite32/64 and hipStreamWait32/64 -
commit hash 08435a972b

Change-Id: I48b9a6591cab3a05baaedbc26030914dd930fb68


[ROCm/clr commit: de026633c0]
2022-06-09 20:59:46 -04:00
Ajay 65d3357dbc SWDEV-337331 - graph feature on Windows
Fixes for hipGraphInstantiate OutofMemory issue and
soft hang of hipStreamSynchronize.
Change-Id: Ic2bb97582c5978ef2e4eb3a1b124483aa412838e


[ROCm/clr commit: c06bfa6bef]
2022-06-09 12:04:51 -04:00
sdashmiz 3f588bf604 SWDEV-318833 - Get and Set attribute for kernel nodes
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie51aa4b56661cbb8c5b4eb1dbaad327377084ffb
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>


[ROCm/clr commit: efd2d55e9d]
2022-06-09 09:47:05 -04:00
Aakash Sudhanwa d23814bc40 Revert "SWDEV-335990 - Use GNUInstallDirs"
This reverts commit a5b6de5037.

Reason for revert: <Breaking all the staging builds. this is breaking components which are using find_package(HIP)>

Change-Id: Ic7340fb461a5efdd170a0988731e0885538a11d6


[ROCm/clr commit: 43c650cf48]
2022-06-07 18:18:06 -04:00
Satyanvesh Dittakavi 9d8d473134 SWDEV-327030 - Fix incorrect checks to find components in CMake
Change-Id: Ib7b9bd82255af897a0f82bba8049c7d41379ae96


[ROCm/clr commit: 3bdc72d6ca]
2022-06-07 04:41:52 -04:00
Jeremy Newton a5b6de5037 SWDEV-335990 - Use GNUInstallDirs
GNUInstallDirs is used to allow the user to customize the install paths
of HIP, rather than using hardcoded locations.

See documentation for more information:
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

Note that libdir must be overriden to "lib" before including
GNUInstallDirs, because by default, cmake tries to detect the libdir
path, but ROCm packaging would like to use lib by default for all
targets. This does not stop the user (or distros) from overriding.

Also note this change does no take into account the changes needed to
non-cmake files, such as perl scripts, so not all paths combinations are
necessarily functional.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: Iae80f47c47ea0a74fc1c221b6eea82b557601394


[ROCm/clr commit: bf4df229c9]
2022-06-06 23:43:05 -04:00
Christophe Paquot dc2aab85b2 SWDEV-322620 - Virtual Memory Management
Introducing a VirtualMemObj map as it is needed to differentiate
between virtual address ranges and actual physical memory
This is because a whole VA range can have several physical memories
as chunks.

Change-Id: Ie2a972b4faf3f7d552cfa53e77898f80ad75740a


[ROCm/clr commit: 905088e4e7]
2022-06-06 11:32:22 -07:00
Todd tiantuo Li 4f86eae6f8 SWDEV-339551 - Prevent ICD from loading outdated amdocl binary
1.Keep track of library name in KHRicdVendorRec
2.Check if library with the same name has already been loaded before adding it in ICD list
CL#1760530

Change-Id: I1e0356422c71963788b76019b0d8db5b8542f9ee


[ROCm/clr commit: ed40c24fa3]
2022-06-06 05:42:19 -07:00
Cordell Bloor 3805867b8b Merge "SWDEV-337169 - Fix CRLF in oclperf.exclude" into amd-staging
[ROCm/clr commit: 7fdb3d3c97]
2022-06-02 14:59:52 -04:00
Chauncey Hui d08bc8107c SWDEV-2 - Change OpenCL version number from 3469 to 3470
[ROCm/clr commit: 58aaa8472e]
2022-06-01 03:00:07 -04:00
Rakesh Roy f80bffb4ab SWDEV-337776 - Fix hipStreamEndCapture API
- Return hipErrorInvalidValue when pGraph is nullptr

Change-Id: I8846f4448eb15117f98421632885330f132c4fce


[ROCm/clr commit: e2874d5e22]
2022-06-01 00:20:23 -04:00
Sourabh Betigeri ea9847c1fd SWDEV-320640 - Fixes to return right error codes in hipStreamUpdateCaptureDependencies() for negative scenarios
Change-Id: I3c4c54f8955fa9bb17eb595544005fe9f0e8a5f0


[ROCm/clr commit: 5a057af564]
2022-05-31 14:09:22 -04:00