Commit Graph

8938 Commits

Author SHA1 Message Date
fxmarty-amd c58ee9e73b fix normalization (#789) 2025-07-08 08:50:41 -04:00
Pryor, Adam ca9d8c4bae Adam/bill cleanup (#209)
Co-authored-by: Bill(Shuzhou) Liu <shuzhou.liu@amd.com>
2025-07-07 15:41:22 -05:00
Sajina PK b0ff07b4fe Conditionally include backtraces in ROCPROFSYS_THROW based on verbosity (#272)
* Conditionally include backtraces in ROCPROFSYS_THROW based on verbosity

Modify ROCPROFSYS_THROW to only include backtraces when:
  debug mode is enabled, OR
  verbose level is >= 2, OR
  running in CI environment

* Fix formatting errors
2025-07-07 14:14:02 -04:00
Bhardwaj, Gopesh dd745ed9c7 Ignoring aligned attribute warning (#70)
ignoring aligned attribute warning
2025-07-07 09:34:39 -05:00
Apurv Mishra 3115384874 kfdtest: Temporarily blacklist KFDEvictTest suite
blacklist the KFDEvictTest suite until the defects
SWDEV 535386 and 537002, where these test cases fail
inconsistently, are fixed

Signed-off-by: Apurv Mishra <Apurv.Mishra@amd.com>
2025-07-04 11:47:20 -04:00
Roy, Rakesh 30e239d1b7 Fix find_if build error for RHEL10 (#499)
overriding Jonathan's final approval ( as it is a long weekend in US/NA)
adding algorithm header to recognize stdlib's find_if looks fine
2025-07-04 09:20:23 -04:00
Castillo, Juan bab82d98b7 [SWDEV-539845] Add support for board voltage (#92)
* Add the API and CLI to show the board voltage.

---------

Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com>
Signed-off-by: Juan Castillo <juan.castillo@amd.com>
Co-authored-by: Liu, Shuzhou (Bill) <Shuzhou.Liu@amd.com>
2025-07-03 01:58:50 -05:00
Cheruvally, Aravindan 55ab9b2bda SWDEV-530465 Update share/doc/<pkgnm> License folder (#86)
Update share/doc/ folder for license/docs to reflect correct package name.
Signed-off-by: Cheruvally, Aravindan <Aravindan.Cheruvally@amd.com>
2025-07-03 01:56:50 -05:00
cfallows-amd 61a9381edf Adjust csv output list for test_block_SPI for MI350 (#785)
Adjusting expected output list for test_block_SPI for MI350 series products.
Run formatter.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-07-03 01:58:11 -04:00
jamessiddeley-amd a6463f5e98 additional-code-coverage-compute (#763)
* added additional functions to test_utils.py

* added code coverage for db_connector.py

* Update test_profile_general.py

Added additional roofline test cases

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* updated coverage mi_gpu_spec.py 73% -> 94%

* added parser.py coverage

* removed redundant comments

* added test_utils and test_db_connector

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
2025-07-02 13:29:10 -04:00
Galantsev, Dmitrii 6c32364d19 Exposed the energy count and current socket power metrics to profilers like PAPI (#225) 2025-07-02 09:50:09 -05:00
Adam McDaniel f688c9938d Exposed the energy count and current socket power metrics to profilers like PAPI 2025-07-02 09:47:17 -05:00
Galantsev, Dmitrii 731be3f743 Revert "rsmi_init: Do not complain loudly when no driver is found"
This reverts commit 8ca4207d5c.
2025-07-02 09:45:41 -05:00
cfallows-amd a59b1ea6e6 Fix method return for python version compatibility (#784)
Support for python3.8 and above means union defined in one of the methods was throwing errors for anything less than python3.10. Swapping out | operand for Optional[] resolves errors on systems using <3.10. No functional changes.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-07-02 10:36:37 -04:00
vedithal-amd 894046f283 Fix rocprofiler sdk list counters (#765) 2025-07-02 09:41:51 -04:00
Chris Freehill 12430fe25a rocr: Fix isa entries for gfx906/sramecc
Some of the entries for gfx906 in the ISA table in isa.cpp
had "any" for "sramecc-" instead of "disabled". This fixes
that.
2025-07-02 08:40:30 -05:00
Bhardwaj, Gopesh e7616c3aad Adding OpenMP usage with rocprofv3 (#472)
* Adding openmp usage with rocprofv3

* minor changes

* Fixing missing line
2025-07-02 12:25:24 +05:30
Su, Daniel 9cca903417 External CI: change amd-master trigger to amd-mainline (#10) 2025-07-01 18:22:05 -05:00
Yang, Chun 5e99084425 Enabled RPB for Navi48 (#115)
* Enabled RPB for Navi48

* Fixing RPB addresses

* Removing non-Navi files

* Removing RPB enum not needed
2025-07-01 22:05:28 +00:00
Baraldi, Giovanni c0c08b2f08 [rocprofv3] Fix ATT library path (#476)
* Fix library path

* Update docs

* Review comments

* Update source/bin/rocprofv3.py

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
2025-07-01 22:08:29 +02:00
Ma, Bing 7710e8bca3 [pmc_builder] Centralize the programming for GFX_INDEX and PERFMON_CNTL (#133)
Prepare multiple GC instances with different programming sequence for GFX_INDEX and PERFMON_CNTL.
2025-07-01 09:22:46 -07:00
Nagaraj, Sriraksha 1524ceb84d [SDK] Internal event id for AQL packet increased to 64-bit unsigned int (#380)
* event id to 64 bit size

* review comments

* review comments

* review comments

* fix

* handle exception

* fix formatting issue

* fix tests
2025-06-30 17:54:37 -05:00
Madsen, Jonathan 3590ecc10e [SDK] Fix buffer tracing stringify of stack-allocated char* buffer (#429)
* [SDK] Fix buffer tracing stringify of stack-allocated char* buffer

* Formatting

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-06-30 17:51:26 -05:00
Madsen, Jonathan 730b4e0a54 [CI] Use rocprof-azure-gpuless-emu-runner-set for build-docs-from-source job (#493) 2025-06-30 17:50:43 -05:00
Trowbridge, Ian 0904b6e34d [rocprofv3] Add check for Stream Stack Pointer before use (#465)
* Added null check for stream_stack before get_stream_id is called

* Rename function and add check for stream strack before pop

* Removed empty check for stream stack and adding error log for get_stream_id in stream.cpp
2025-06-30 17:49:48 -05:00
Jonathan Luu 463d6b60d5 SWDEV-531400 Remove file reorganization backwards compatibility (rdc) 2025-06-30 15:20:26 -07:00
Madsen, Jonathan 99e262ca4a [CI] Disable conversion script validation (#492)
- pytest fails when you selectively disable all the tests in the suite
2025-06-30 17:02:53 -05:00
Kuricheti, Mythreya 7842dfe839 [SDK] Filter agents that are not CPU or GPU (#374)
* Filter HSA agents

* Review comments
2025-06-30 15:54:48 -05:00
Madsen, Jonathan f0fe04b95e [CI] Disable other unstable tests (#491)
Disable other unstable tests

- validation test_validate_counter_collection_pmc1 for conversion script
- increase timeout for tests/rocprofv3/pc-sampling execution phase
2025-06-30 15:53:30 -05:00
Madsen, Jonathan 69f71b8097 [CI] Disable other unstable tests (#490)
* Disable other unstable tests

* Disable validating test_total_runtime in kernel-tracing

* The disabled tests will be stabilized and re-enabled by ROCm 7.0.1 or ROCm 7.1
2025-06-30 15:42:38 -05:00
Elwazir, Ammar 80fcffeb5a Update sync-mainline.yaml 2025-06-30 15:24:35 -05:00
Elwazir, Ammar 57143911c3 Update sync-staging.yaml 2025-06-30 15:24:13 -05:00
Madsen, Jonathan 640ca55ac0 [CI] Testing stability (#486)
* [CI] Testing Stability

- CMake option ROCPROFILER_DISABLE_UNSTABLE_CTESTS
  - used for tests which periodically fail around 1 out of every 10 runs
  - set to ON while instability remains, this needs to set to OFF in ROCm 7.1 or, ideally, ROCm 7.0.1
- Use FIXTURES_SETUP and FIXTURES_REQUIRED for some tests
- replace "threw an exception" with "${ROCPROFILER_DEFAULT_FAIL_REGEX}" for misc FAIL_REGULAR_EXPRESSIONS

* Remove contents of all EXCLUDE_{TESTS,LABEL}_REGEX from CI workflow

* Disable patch git step in code-coverage run

* Tweak spin time of reproducible runtime

* Removed patch git step in code-coverage run

* Update ROCPROFILER_DEFAULT_FAIL_REGEX

* Mark test-counter-collection tests as unstable

- add fixtures setup/required

* Remove ATTACHED_FILES_ON_FAIL

- CDash doesn't store enable downloading these properly anyway

* Relax collection-period fuzzing window

* Disable unstable collection-period test

- too unstable

* formatting

* Disable unstable device_counting_service_test.async_counters

* Suppress perfetto internal data race errors

* Switch code-coverage CI jobs to mi300 runner

* Timeout increases

* rocprofv3-test-rocpd updates

- add fixtures
- switch executable
- redefine input/output paths

* Revert code-coverage job to mi300a runner

* Update rocprofv3-test-rocpd-execute-multiproc

- reduce problem size

* disable multiproc rocpd

* Split code-coverage into separate workflow

- network issues cause this job to fail frequently
- when in a separate workflow, it can be restarted easily

* Fixtures for rocprofv3-test-trace-hip-in-libraries

* Disable unstable device_counting_service_test.sync_counters

* Potential fix for code scanning alert no. 171: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Switch code-coverage to run on rocprof-azure

- mi300a EMU runner set is unstable (network issues)

* tests/rocprofv3/pc-sampling SKIP_REGULAR_EXPRESSION

* Update rocprofv3-test-list-avail-trace-execute

- reduce log level and increase timeout

* rocprofv3: Prevent recursive call to rocprofv3_error_signal_handler + log chaining

* rocprofv3: Use ROCP_ERROR + std::exit instead of ROCP_FATAL

- should help with SKIP_REGULAR_EXPRESSION

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-06-30 15:07:37 -05:00
Chris Freehill f1bd89bd0d rocr/rocrtst: Update to c++17 2025-06-30 14:02:24 -05:00
Elwazir, Ammar 5962747bf7 Adding Manual Trigger for mainline and staging public sync (#489)
* Update sync-staging.yaml

* Update sync-mainline.yaml
2025-06-30 11:13:50 -05:00
xuchen-amd 222dbdc6bd Remove cell backgrouund colors. (#778) 2025-06-28 10:38:28 -04:00
Galantsev, Dmitrii 035cd2c371 fixup! CHORE - Ignore gersemi commit 2025-06-27 17:34:28 -05:00
Galantsev, Dmitrii f6023092c7 CI - Fix cmake-format
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-06-27 17:25:51 -05:00
Galantsev, Dmitrii a57edc0598 CHORE - Ignore gersemi commit
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-06-27 17:25:51 -05:00
Galantsev, Dmitrii 40545dcb49 CMAKE - Format with gersemi
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-06-27 17:25:51 -05:00
Galantsev, Dmitrii 680b7a8dd8 CMAKE - Add gersemi to replace cmake-format
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-06-27 17:25:51 -05:00
jamessiddeley-amd 1bb7bf4dd4 added 0400 analysis config yaml files (#779) 2025-06-27 16:21:19 -04:00
Galantsev, Dmitrii e73eaf8115 Profiler - Remove rocprofiler-v1 remnants
Also force unset HSA_TOOLS_LIB so it doesn't break rocprofiler-sdk

Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-06-27 13:15:52 -05:00
vedithal-amd 6e1bbb5efb Fix SPI block counter limit (#780)
* Fix SPI counter collection limit

* Update counter collection limits from aqlprofile

* Remove special handling for MI 350 SPI pipe counters
2025-06-27 14:07:56 -04:00
Pranjal Swarup 4e5029221b Update RCCL-tests in examples folder (#261)
- Create a local copy for ROCm/rccl-tests for our examples.
- Update argument parsing to no longer use getopt_long.
- Workaround for Dyninst instrumentation.

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-06-27 11:44:13 -04:00
Honglei Huang d874b8003a rocr/driver: add SetTrapHandler API to driver interface
This commit introduces a new SetTrapHandler API to the driver interface

- Implemented SetTrapHandler in KfdDriver to set trap handlers using
  hsaKmtSetTrapHandler.
- Added a stub implementation of SetTrapHandler in XdnaDriver that returns
  HSA_STATUS_ERROR.
- Updated the driver interface in driver.h to include the new SetTrapHandler
  method.
- Modified GpuAgent to use driver().SetTrapHandler instead of directly calling
  hsaKmtSetTrapHandler.

Signed-off-by: Honglei Huang <Honglei1.Huang@amd.com>
2025-06-27 23:32:53 +08:00
Bhardwaj, Gopesh 074d9d95ec SWDEV-539836 Do not parse private/internal members (#56) 2025-06-27 20:47:30 +05:30
Fei Zheng f5bc717fe1 Documentation update for FP8 on MI300 (#766) 2025-06-26 13:35:36 -06:00
Kandula, Venkateshwar reddy 375866383b [SDK] Add gfx950 targets for tests and samples (#399)
* add gfx950 targets.

* add gfx950 targets to ci workflows.

* Format.

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
Co-authored-by: Vaddireddy, Sushma <Sushma.Vaddireddy@amd.com>
2025-06-26 14:25:08 -05:00
Trowbridge, Ian 1f8b8c5e9f Modified perfetto output for HIP stream display (#431)
* Modified perfetto output for HIP stream display

* Moved stream_map file location and changed perfetto output names Private_Segment_Size and Group_Segment_Size to Scratch_Size and LDS_Block_Size respectively

* Used const_cast to remove const modifier on void*

* Reverted stream_map changes, now using tool_metadata map to track mapping between stream ptrs and stream IDs

* Removed buffer tracing args in perfetto, added tool_...hip buffer record struct that stores the HIP stream ID for display purposes

* Updated rocpd perfetto.cpp to reflect stream changes. Still need to add vgpr values and stream ID for HIP API

* Changes pass-by const reference to pass-by const value
2025-06-26 14:22:50 -05:00