Commit Graph

8 Commits

Author SHA1 Message Date
Chris Freehill 9d70b6a420 rocrtst fixes for hsa_signal cleanup and aql packet dispatch
In several places aql packets were written to queue all at once
instead of doing the header atomically. These cases have been
fixed.

There were a few hsa_signal leaked that have been addressed.

There was some duplication of code that has been addressed.

Addresses ROCMOPS-456

Change-Id: Ia1869bc370f92e49ac560301df47741d5f76978e


[ROCm/ROCR-Runtime commit: 081a2cc875]
2019-06-21 17:34:10 -05:00
Sean Keely 904723af7c Fix IPC related hangs/faults in rocrtst.
IPC was failing due to calling fork when HSA was open.  The fix
was correcting incomplete cleanup in several other tests.

TestBase::Close (via CommonCleanUp) now checks that HSA is properly
closed between tests.

rocrtstPerf.Memory_Async_Copy uses hwloc which uses OpenCL which
has no shutdown routine.  Consequently this test can not cleanup
properly.  I added a hack to force HSA refcount to the value
it should have if OpenCL were cleaning up but this leaks resources
and potentially puts hwloc & OpenCL in a bad state.

OpenCL loads LLVM which installs some exit handlers.  Those handlers
can't execute in a child process and can't be removed since OpenCL
doesn't cleanup.  IPC hacks around this by aborting rather than exiting
in the child process.

Change-Id: I92326a73d7b11632208717d99728e6dafdc7d3ca


[ROCm/ROCR-Runtime commit: bb980462e7]
2019-06-19 01:03:52 -04:00
rohit pathania 72073d5f4a Resubmitted added and modified common utilities functions for rocrtest with faile to open file fix
Change-Id: Ie45668df1a15c1be7e8bdb10b967b98fb3024252


[ROCm/ROCR-Runtime commit: 7310312291]
2017-12-18 05:06:22 -04:00
Kent Russell 061789c3fd Revert "added and modified common utilities functions for rocrtest"
This reverts commit 4c4869bf50.

Change-Id: I825b210ce4fc831f8a978faf1c7d83d54408efa4


[ROCm/ROCR-Runtime commit: c3a880db7d]
2017-12-15 06:04:50 -05:00
rohit pathania 4c4869bf50 added and modified common utilities functions for rocrtest
Change-Id: I80afa33a46b3d95058be306869e7ed54b2b7df64


[ROCm/ROCR-Runtime commit: 7e46704abb]
2017-12-14 12:01:16 -05:00
Chris Freehill 90b3fee7f5 Remove dependency on hsa-runtime-tools
Change-Id: Ic4ce2bcbf1176e7eb859db39f21e7185691837e1


[ROCm/ROCR-Runtime commit: c85322d93d]
2017-08-17 15:39:35 -04:00
Chris Freehill bcd0bd4e38 Added dispatch time, async copy and test template rocrtst tests
Change-Id: I57a844ee65c36bd61616ee6d60d358303f51db56


[ROCm/ROCR-Runtime commit: a12c5628ea]
2017-07-17 10:30:26 -05:00
Chris Freehill 9f1065771a Refactored performance test code
Commented and flattened binary search sample.

Change-Id: Ib783292207c956d16003195924a3bcfbbde5039f


[ROCm/ROCR-Runtime commit: 8161ebb915]
2017-05-11 14:45:45 -04:00