AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
766 Commits 3 Branches 0 Tags
f4511e7280b2e1d7d5e3890f067ec67ca3e5b6da
Commit Graph

149 Commits

Author SHA1 Message Date
Cole Ramos f4511e7280 Force encoding before Omniperf execution (#299) 
* Force encoding before Omniperf execution

Signed-off-by: colramos-amd <colramos@amd.com>

* Fix circular dependency in utils module

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-06 17:01:07 -06:00
Jason Ray 994aea9f0e bump statman-stopwatch to 2.18 (#220) 
* Lock Pandas to version 1.4.3 for tutorial

Signed-off-by: colramos-amd <colramos@amd.com>

* Establish connection between kernel related flags in Analyze Mode (#187)

Signed-off-by: colramos-amd <colramos@amd.com>

* Fixing bug in kernel/dispatch filter pytest

Signed-off-by: colramos-amd <colramos@amd.com>

* More CI logic errors fixed

Signed-off-by: colramos-amd <colramos@amd.com>

* Update CHANGES

Signed-off-by: Cole Ramos <colramos@amd.com>

* Update CHANGES

Signed-off-by: Cole Ramos <colramos@amd.com>

* Update README.md

Signed-off-by: Cole Ramos <colramos@amd.com>

* bump statman-stopwatch to 2.18

Signed-off-by: Jason Ray <jayray.net@gmail.com>

* Fix merge mistakes

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Jason Ray <jayray.net@gmail.com>
Co-authored-by: colramos-amd <colramos@amd.com>
 2024-03-05 11:16:23 -06:00
colramos-amd a44e07d928 Account for missing GRBM_GUI_ACTIVE in roof-only mode (#103) 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-05 10:43:24 -06:00
Karl W Schulz f94da3228d apply formatter 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-03 15:20:21 -06:00
colramos-amd ea9783f105 Fix typo, patch issue in kernel filtering in standalone GUI, and error on version mismatch 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-03 14:38:28 -06:00
Karl W Schulz ca59cbe3a3 apply formatter 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-02 12:28:34 -06:00
coleramos425 7b8cf17254 Fix missing median values 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-03-01 18:00:17 -06:00
coleramos425 cdeb2c7e85 Add custom decorator to avoid using kw_only 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-03-01 17:49:22 -06:00
coleramos425 1dc4553091 CMake and Python format 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
coleramos425 1c3e7598a6 Remove hardcoded gfx90a in gen_sysinfo util 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
coleramos425 eaf701abf0 More formatting! 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd d6f45411eb Python formatting 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis 817774be5e print version out of table 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nick Curtis 5b5d4c9a23 Update src/utils/specs.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Nick Curtis <6463881+skyreflectedinmirrors@users.noreply.github.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis de384467f5 push missing rabulate through get_table_string 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis 200961ffd9 Re-implement machine-specs to contain documentation, units, etc. Print using tabulate 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
coleramos425 5ebd2dbc74 Re-enable multi kernel filtering 
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis c10cc0ede2 fix for improper display of % of peak for instruction mix panel 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 3197553ca6 Add version to specs/sysinfo output in order to throw warning for new fields 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 09f1455308 Added consistent 'Channel' headers to l2_per_chan, removed hardcoded 32 channels, and removed printed Nones (#276) 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 0d516f05b4 Fix bug in GUI kernel filtering 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis 20d93703fc correct small negatives in remote read/write traffic due to running in different passes 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis 2c3c5fba35 fix dependency ordering in builtins 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis 18dfc35c14 typo 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis c5e4a33c07 catch missing per-XCDs 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd c17e39189f Enhance correct_sys_info() func and err checking 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd a70dc4999d Hide L2Banks in sysinfo and update roofline module 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd d2c3d7faf9 Misc fix for kernel name shortener 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd bd794abb12 Fix Mi300 clk timings using GRBM_GUI_ACTIVE from #255 
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 2001908fd8 Carry over fixed numSQCs calc from #247 
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 3ce140d04b Including remaining metric fixes from #251 
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 86b6c8e848 Renaming global spec vars. Replacing L2Banks with total_l2_chan (#251) 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 3b1b8d7b5b Reorganize the specs module to reduce duplicate code 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
JoseSantosAMD 4ad124a207 Fix off by one out of range kernel filtering (#287) 
* Fi off by one out of range kernel filtering

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* reformat

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

---------

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
 2024-02-29 12:38:37 -06:00
JoseSantosAMD f42aa6c7e0 Supress warning: RuntimeWarning: Mean of empty slice (#271) 
* Supress warning: RuntimeWarning: Mean of empty slice

Signed-off-by: Jose Santos <josantos@login1.hpcfund>

* Move import to top

Signed-off-by: Jose Santos <josantos@login1.hpcfund>

* Specify type of RuntimeWarning in catcher. Safer approach

Signed-off-by: colramos-amd <colramos@amd.com>

* Comply to formatting

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: Jose Santos <josantos@login1.hpcfund>
Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Jose Santos <josantos@login1.hpcfund>
Co-authored-by: colramos-amd <colramos@amd.com>
 2024-02-29 12:14:46 -06:00
Karl W Schulz f2235b7f1d Fix for rocm-smi not getting mclk for MI100 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-26 11:47:56 -06:00
Karl W Schulz 76873dd0c4 more code formatting updates 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-22 16:02:25 -06:00
Karl W Schulz 5a27189c82 more code formatting updates 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-22 16:02:25 -06:00
Karl W Schulz 79b877d679 code formatting updates 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-22 16:02:25 -06:00
Nick Curtis 852cc13f2a Fix clocks (#246) 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
 2024-02-13 20:22:11 -06:00
Nick Curtis c60f031558 Fix hbmBW calculation, (#243) 
* Fix hbmBW calculation, currently we're reading the wrong value of the mclk out of rocm-smi

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

* Fix for earlier smi

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

---------

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
 2024-02-13 20:19:56 -06:00
colramos-amd b7d5d3b64b Modify yaml configs to reflect new combined Top Stats 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-02-13 19:56:46 -06:00
colramos-amd bd83f68412 Enable the revamped Top Stats section in standalone GUI 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-02-13 19:18:31 -06:00
colramos-amd 2526e14802 Combine kernel and dispatch stats in the Top Stats section of analysis 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-02-13 19:17:41 -06:00
colramos-amd 7bb211a465 Fix logic for roofline field in sysinfo 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-02-12 17:07:55 -06:00
colramos-amd 33a2cd34ce Revert sbios fix. Catch commas 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-02-08 12:52:07 -06:00
Nick Curtis c8f4f74255 Escape sbios, can have commas on some systems (#241) 
* escape sbios, can have commas on some systems

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

* Prefer to cast to str in original function

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: colramos-amd <colramos@amd.com>
 2024-02-08 12:40:52 -06:00
colramos-amd d7b78da250 Add new l2 cache per channel headers to supported fields 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-02-06 16:19:40 -06:00
colramos-amd 48911111be Enable standalone GUI with new metric reordering 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-02-06 16:19:40 -06:00
colramos-amd 66fcfd3def General spell check and typo fixing 
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-02-06 16:19:40 -06:00