SWDEV-143465 - Stop building static C++ kernels on CI+
Changed stack logic:
1. Stop supporting AMDIL on CI+ devices: "AMDIL doesn't support device ..." will be reported.
2. Stop handling OpenCL extension options in RT: if "-x spir" or "-x clc++" option is specified, it wouldn't force legacy AMDIL compiler anymore.
3. Start reporting error on "-legacy" option in HSAIL compiler. If we reach HSAIL compiler, then it means that there are conflicting options. Report them all, possible options are: -frontend=edg, -cl-std=CL2.0 (>= 2.0), -binary_is_spirv.
Already submitted changes in stack logic:
1. Start reporting error for SI devices on HSAIL path.
2. Start handling OpenCL extension options on HSAIL path: report error on "-x spir" or "-x clc++" options.
[Testing]
rga offline for all the targets supported by HSAIL and AMDIL (from Family_SI up to Family_VI):
tahiti, pitcairn, capeverde, spectre, spooky, kalindi, hawaii, oland, bonaire, hainan, carrizo, iceland, tonga, fiji, stoney, baffin, ellesmere.
[Reviewed] by German and Stas (http://ocltc.amd.com/reviews/r/14270)
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/backends/common/v0_8/if_acl.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#97 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#582 edit
SWDEV-2 - Change OpenCL version number from 2590 to 2591.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2338 edit
SWDEV-143465 - Fix crashes while mixed work with hsail and amdil (legacy) paths
Redirect (where it is possible) ACL API calls from HSAIL lib to legacy AMDIL lib if target is AMDIL.
For those functions (aclCreateFromBinary, aclReadFromMem), where redirect is impossible, explicit loadLibrary for AMDIL lib and call of corresponding function from AMDIL lib is performed.
[Reviewed] by Stas (http://ocltc.amd.com/reviews/r/14238)
[Testing] rga offline for all the targets supported by HSAIL and AMDIL (from Family_SI up to Family_VI):
tahiti, pitcairn, capeverde, spectre, spooky, kalindi, hawaii, oland, bonaire, hainan, carrizo, iceland, tonga, fiji, stoney, baffin, ellesmere.
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/acl.cpp#45 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/aclValidation.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/aclValidation.h#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.cpp#29 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.h#30 edit
SWDEV-2 - Change OpenCL version number from 2589 to 2590.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2337 edit
- Added a new target "clangformat" which formats the code using the
clang-format tool found in HCC package.
- Renamed target "static_check" to "cppcheck".
- Use find_program() macro to make the build system more robust.
Change-Id: Ifefbf36f23ff7ef27a870120d5b9170d0cc8aa52
SWDEV-2 - Change OpenCL version number from 2588 to 2589.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2336 edit
SWDEV-2 - Change OpenCL version number from 2587 to 2588.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2335 edit
SWDEV-143465 - HSAIL - Add checks for OpenCL extension and device family
FAMILY_SI devices and OpenCL extensions clc++ and spir are not supported by HSAIL.
Affected only offline compilation via ACL API.
[Reviewed] by Stas, http://ocltc.amd.com/reviews/r/14240
[Testing] aoc2, rga
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#96 edit
SWDEV-2 - Change OpenCL version number from 2586 to 2587.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2334 edit
/srv/HIP/hipify-clang/src/main.cpp:134:19: error: no member named 'dbgs' in namespace 'llvm'
DEBUG(llvm::dbgs() << "Skipped some replacements.\n");
~~~~~~^
SWDEV-2 - Change OpenCL version number from 2585 to 2586.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2333 edit
SWDEV-2 - Change OpenCL version number from 2584 to 2585.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2332 edit
SWDEV-2 - Change OpenCL version number from 2583 to 2584.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2331 edit
SWDEV-2 - Change OpenCL version number from 2582 to 2583.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2330 edit
SWDEV-144231 - [CQE OCL][DTB][Perf][DTB-BLOCKER] 10% Performance drop observed while running Subtests of IndigoBench due to faulty CL#1507569
-Wavelimiter has more negative impact than improvements in a few benchmarks.
- Reduce the number of adaptive samples during the search to 4 per each wave count.
- Add worstWave_ to skip sampling with low performance settings.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.hpp#7 edit
SWDEV-2 - Change OpenCL version number from 2581 to 2582.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2329 edit
SWDEV-143822 - [CQE OCL][Vega10][OCLtst][DTB-Blocker][QR] 8 out of 50 failures are observed with OCLPerf 32bit test; due to Faulty CL# 1502648
- Limit the cache size to 1GB with 32 bit
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#41 edit
Due to support of cuRAND headers.
+ compound test on all headers is added;
+ missing entities are added with updating the doc;
+ a couple cuRAND tests are added (https://github.com/ROCmSoftwarePlatform/rocRAND/tree/master/benchmark):
- the following CUDA entities are still unsupported by hipRAND:
curandMakeMTGP32Constants
curandMakeMTGP32KernelState
curandGetDirectionVectors32
curandDirectionVectorSet_t
CURAND_DIRECTION_VECTORS_32_JOEKUO6
curandStateSobol64_t
curandStateScrambledSobol64_t
curandGenerateLongLong
- and the following - by HIP:
cudaRuntimeGetVersion
- those entities are handled by CHECK-NOT directive for now.
SWDEV-2 - Change OpenCL version number from 2580 to 2581.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2328 edit
foreman
Maneesh Gupta
Alex Voicu
Jenkins
Evgeny Mankov
Evgeny Mankov
Rahul Garg