AI/rocm-systems
2
0
Förgrening 0
Kod Ärenden Pull-förfrågningar Actions Packages Projekt Släpp Wiki Aktiviteter
13 197 Incheckningar 3 Grenar 0 Taggar
f6c8bbf4dcc2ec0022ea4faa5a9d75afb2a58a11
Commit-Graf

13197 Incheckningar

This Branch
This Branch
Alla brancher
Upphovsman SHA1 Meddelande Datum
Icarus Sparry 9f31801831 Correct quoting of arguments 
The hipcc script takes arguments and uses this to build up a new
command. Characters which are special to the shell need to be quoted
to prevent them being interpreted.

In particular adding
     --Wl,--enable-new-dtags -Wl,--rpath,'$ORIGIN:$ORIGIN/../lib'
to the command should pass quoted dollar signs into the resulting
string so the shell passes them on, rather than substituting the
values.

The arguments are processed in a conventional loop, but can be altered
during the course of the loop, and also by linker response files.

Tested by running
  HIPCC_VERBOSE=7 HIP_COMPILER=clang hipcc --cxxflags \
      fred.c -Wl,,--rpath,'$ORIGIN:$ORIGIN:/../lib'
and observing "-Wl,--rpath,\$ORIGIN\:\$ORIGIN\:..\/lib" in the
displayed hipcc-cmd output (and ignoring the errors due to rocm not
being installed)

Change-Id: I26b62f09ff3518cceeb85fa8823bb12a95c1c78e
Signed-off-by: Icarus Sparry <icarus.sparry@amd.com>
 2020-05-10 18:16:48 -04:00
Vlad Sytchenko a88e52ba80 Correct HIP_FUNC_ATTRIBUTE_NUM_REGS query 
Change-Id: I526cc7871c690260df0fa8c1b3b4b15fbc5af219
 2020-05-09 12:42:30 -04:00
Chauncey Hui da8c217e6f SWDEV-2 - Change OpenCL version number from 3139 to 3140 2020-05-09 03:00:03 -04:00
jujiang 1662b25dc6 SWDEV-230009-Cltrace log is not created as expected-Update return type to vdi_agent 
Change-Id: Ice4083d0d3a061867f886119a4cc541e2048a328
 2020-05-08 18:56:25 -04:00
Christophe Paquot 2a02026696 Add gpu().hasPendingDispatch() in the SDMA path 
SWDEV-234947

Change-Id: I8aa501f8755d136708b0d12ee3c30229c238660d
 2020-05-08 18:19:51 -04:00
Christophe Paquot 6c05f34e6d Merge "Don't add a null command to waitList in hipMemcpy" into amd-master-next 2020-05-08 17:01:38 -04:00
Christophe Paquot 8c2c4c3b27 Don't add a null command to waitList in hipMemcpy 
SWDEV-235345

Change-Id: Ib1abd0ba6414d081891a9f5209df083c45734aee
 2020-05-08 12:43:41 -07:00
Vlad Sytchenko b5f9d2f818 Correct HIP_FUNC_ATTRIBUTE_MAX_THREADS_PER_BLOCK query 
We should be returning the max workgroup size calculated by the compiler.

Change-Id: If86590efbb9b291f470bdbe87e5df992e661c539
 2020-05-08 14:36:47 -04:00
Vlad Sytchenko 276bfc9667 Fix confusion in hipFuncGetAttribute() 
Cuda shared == OpenCL local

Cuda local == OpenCL private

Change-Id: I5a204945ecde35919b9e9def20bbb2662fffea2b
 2020-05-08 14:36:36 -04:00
Jason Tang 372ebe7b00 Add dependency of hsa-rocr-dev and hsa-ext-rocr-dev 
in-line with hip-on-vdi.

Change-Id: Ib0e1a5180eef409cfd0f1b5b9a42a2b663dfc0d3
 2020-05-08 13:23:37 -04:00
Matt Arsenault 1ff46e24c5 Don't add llvm includes to rocclr build 
There are no llvm includes here.

Change-Id: I0567c6e47e717580819f3854782ba08501bd069d
 2020-05-08 12:24:49 -04:00
Anusha Godavarthy Surya 59cf312bcd Merge "SWDEV-233950:link to /opt/rocm/hip/lib/cmake left behind during uninstall" into amd-master-next 2020-05-08 12:12:06 -04:00
agodavar e069cf6511 SWDEV-234447:Fix error Use of uninitialized value in concatenation (.) 
Change-Id: Ia6f8d23f100826438f152c175d10ac3096ee024e
 2020-05-08 12:07:24 -04:00
Matt Arsenault 72675bf079 Don't write generated version.h to source directory 
Change-Id: Ib4e7c3171cd227725ae35fed66167df528a4c431
 2020-05-08 10:59:28 -04:00
Vlad Sytchenko 6e985845b3 Take into account dynamic LDS size when validating the launch parameters. 
Bottom layers don't error check this value, so we might and up writing a bad value to a register and cause the SPI to hang.

Change-Id: I6da4ae71c66a25c63ebb804da4afe4ca7fb831b7
 2020-05-08 09:37:06 -04:00
Aaron Enye Shi c70a32c5a7 SWDEV-234954 - Fix hipconfig on Windows 
Before setting the HIP_RUNTIME and HIP_COMPILER variables, first check the environment if these are set. We should prioritize the environment settings. For windows, it will be set, and also explicitly call perl when invoking hipconfig.

Change-Id: I89ad267285239e6d8a897dc681c4af5906e7b9d8
 2020-05-08 13:27:36 +00:00
agodavar 89415b66f0 SWDEV-233950:link to /opt/rocm/hip/lib/cmake left behind during uninstall 
Change-Id: Ideb76b73916881469e39b7a0a4d68d7ec098b4a8
Signed-off-by: agodavar <Anusha.GodavarthySurya@amd.com>
 2020-05-08 07:36:28 -04:00
Chauncey Hui 06ee6f209a SWDEV-2 - Change OpenCL version number from 3138 to 3139 2020-05-08 03:00:03 -04:00
Sarbojit Sarkar 94699a7a6f Enabling hipGetDeviceFlags required in [SWDEV-229170] 
Change-Id: I998d37e5847f9651345554bada86df6fce86d1eb
 2020-05-08 01:37:23 -04:00
Vlad Sytchenko 10bf21829c Merge branch 'amd-master-next' into amd-npi-next 
Change-Id: Id97c6b8c875731250049a5b9dc8062311ae291ad
 2020-05-07 17:17:21 -04:00
Matt Arsenault 5e28b28044 Fix generated hip_prof_str.h install again 
Change-Id: I92ea4bedbcdc92974998c00ca7f0c00098791cb5
 2020-05-07 12:40:39 -04:00
Aaron En Ye Shi dc795978b5 Merge "Fix missed VDI names in hip-on-rocclr" into amd-master-next 2020-05-07 12:30:51 -04:00
agodavar 8f204466e9 Fix hip-config.cmake build error in rocBLAS 
Change-Id: I097f0dac0f67bfc22e9991350bf63bc7bfa8b269
 2020-05-07 12:24:20 -04:00
Michael LIAO 12fcfee41d Fix build failure. 
- Also fix `-Wreorder` warning. NFC.

Change-Id: I766fdc622c9107f901a55498bdc8fef3d821d1b7
 2020-05-07 10:39:10 -04:00
Michael LIAO 503ef06555 Clear executable permission. 
Change-Id: Ia0d363b1ba89d7947e5b5a55cb67edba86f0515e
 2020-05-07 10:38:58 -04:00
Aaron Enye Shi 88ce9d5a10 Fix missed VDI names in hip-on-rocclr 
Change-Id: I830feb37a043656136648e92a0c6f1eaae8402d7
 2020-05-07 08:37:28 -04:00
Tao Sang 94bc7375af Merge "Support performance tests" into amd-master-next 2020-05-07 07:15:09 -04:00
Chauncey Hui 3c7f376ec0 SWDEV-2 - Change OpenCL version number from 3137 to 3138 2020-05-07 03:00:03 -04:00
Rahul Garg 8644e77b9f Merge "Remove HIP_MARKER left overs due to HIP PR 2032" into amd-master-next 2020-05-07 01:36:57 -04:00
Anusha Godavarthy Surya 8d2c9f8f0c Merge "SWDEV-233749 Added support for parallel build and link" into amd-master-next 2020-05-07 00:29:24 -04:00
Rahul Garg 4c05fd9d4c Remove HIP_MARKER left overs due to HIP PR 2032 
Change-Id: Ieae68dd3b12c92b1d6830619ca4c6ae43c400225
 2020-05-06 20:26:18 -04:00
Christophe Paquot e1cfe54975 Merge "SWDEV-232464 - Need to initialize image with ptr passed since they can pass image not of type __ClangOffloadBundler." into amd-master-next 2020-05-06 16:42:50 -04:00
Christophe Paquot 59398a74c0 Merge "Skip iHipWaitActiveStreams if stream is NonBlocking" into amd-master-next 2020-05-06 16:32:51 -04:00
agodavar ba2991a38a SWDEV-233749 Added support for parallel build and link 
Change-Id: Id227ea1fe7574612c33a8e6d91fc59a29490a35f
 2020-05-06 14:54:39 -04:00
German Andryeyev 3446d4e638 Switch PAL version to 592 
Change-Id: I7e90b8fd55c57d8d49e4ec1273ab671f96197bae
 2020-05-06 14:51:32 -04:00
jujiang 08b66a4b1b SWDEV-230009-Cltrace log is not created as expected-Create dynamic library 
Change-Id: I813d14c093d222c82bec6824b52cc7839f89cef5
 2020-05-06 14:32:00 -04:00
kjayapra-amd 8f38c3260e SWDEV-232464 - Need to initialize image with ptr passed since they can pass image not of type __ClangOffloadBundler. 
Change-Id: I2c50042220a0230bc445ed21728f114a229c53e1
 2020-05-06 14:25:43 -04:00
Tao Sang f99c3ac337 Support performance tests 
Support performance tests while direct tests commands keep unchanged.
To build performance tests, run "make build_perf".
To run all performance testis, run "make perf".
To run specific tests, for example, run
/usr/bin/ctest -C performance -R performance_tests/perfDispatch --verbose
To run individual test, for example, run
performance_tests/memory/hipPerfMemMallocCpyFree

Change-Id: I168c1b9ef1ec21b392d48648d0c71e8fbd37d57b
 2020-05-06 14:06:07 -04:00
Christophe Paquot 0a103a5c49 Skip iHipWaitActiveStreams if stream is NonBlocking 
SWDEV-234484

Change-Id: I279bdc8485d8218e0aaa89d094c08a84f002a608
 2020-05-06 10:36:53 -07:00
Matt Arsenault f1de138a61 Don't use relative include path 
The header base path is already in the include set.

Change-Id: Id83abaa921d720ae103e3281161b875fcf84493d
 2020-05-06 11:59:39 -04:00
Aakash Sudhanwa 8e6d7dffe3 rocclr/CMakeLists.txt: Fixing unresolved merge conflict 
Change-Id: I09b9a955b0f1ece8d278112a22bc8aef31b57258
Signed-off-by: Aakash Sudhanwa <Aakash.Sudhanwa@amd.com>
 2020-05-06 07:24:25 -07:00
Payam dba0e72de2 name change vdi to rocclr 
Change-Id: I06d198bbb4a499e153b290b73a92afed3553b252
 2020-05-06 09:14:30 -04:00
Chauncey Hui 0981ba433b SWDEV-2 - Change OpenCL version number from 3136 to 3137 2020-05-06 03:00:03 -04:00
Payam d6100a9547 name change vdi to rocclr 
Change-Id: I856d6ac1a9a83d89715d6e33dec4aa17abc2f2f2
 2020-05-06 00:54:45 -04:00
Karthik Jayaprakash 259a6fc649 Merge "SWDEV-229840 - Fixing compilation error with right var name." into amd-master-next 2020-05-05 18:17:22 -04:00
Yaxun Liu 35f18e76bd Merge "Fix hipcc for -E" into amd-master-next 2020-05-05 18:00:49 -04:00
Alex Xie bfbc8cd09b SWDEV-234684 - hipmemcpy optimization does not work in tests 
Change-Id: I899d172c5b2af88c796fe9a36f97d15ac45caf94
 2020-05-05 15:58:03 -04:00
kjayapra-amd 102cbcdeac SWDEV-229840 - Fixing compilation error with right var name. 
Change-Id: I9f5278638271c384874004eb17085d29ca14ec3a
 2020-05-05 14:59:24 -04:00
kjayapra-amd 1687e8c90c SWDEV-209747 - Add compiletime variable DEV_LOG_ENABLE 
Change-Id: Ie8ff8abafa6b5e0f83209da42778688a047562c3
 2020-05-05 14:48:55 -04:00
Yaxun (Sam) Liu 48d89d670e Fix hipcc for -E 
-E is for preprocessing only, which should be compile only.

This is required by enabling sccache.

Change-Id: Ia0a0acb6a04abd03a9cb5b3c13cf7446837f37b4
 2020-05-05 14:30:25 -04:00