Commit Graph

13197 Commits

Author SHA1 Message Date
Payam a52975bc03 reverting part of http://gerrit-git.amd.com/c/compute/ec/hip/+/326145
the test still fails

Change-Id: I2e5968115a717e8482be670d9fb8472e391922d7
2020-03-04 13:49:58 -05:00
Payam 9106a7dff4 clean up
Change-Id: I1a5bbd12bba35af5d52f9ddc0df71dd0d004d122
2020-03-04 13:35:49 -05:00
agodavar ae465bc338 Enable tests hipTestDeviceSymbol,hipTestConstant and p2p_copy_coherency on hip-vdi
SWDEV-225266: [HIP-VDI] HIP-VDI disabled tests (p2p_copy_coherency.cpp)
SWDEV-225388: hipTestDeviceSymbol.cpp & hipTestConstant.cpp failed to build on hip-vdi

For hipTestDeviceSymbol.cpp & hipTestConstant.cpp tests:
Currently "__HIP_VDI__" flag is enabled in CMakeLists.txt, but when application is compiled with hipcc,  
__HIP_VDI__ is not defined to differentiate if compiled for VDI/HCC for headers.

For ./src/runtimeApi/memory/p2p_copy_coherency.cpp:
Fixed compilation issue to include only when compile for HCC runtime "<hc_am.hpp> not found"
Currently test is disabled to run on all platforms. When validated on multi-GPU machine,
memcpy between multiple GPUs via GPU synchronization is not working on hcc and vdi path.
Need to validate on nvidia machine to know if test is valid. Disabled GPU synchronization test for now.

For ./src/runtimeApi/module/hipModuleTexture2dDrv.cpp:
updated test to generate tex2d_kernel.code object in build directory. Currently ctest looks for it in build directory.

Change-Id: I629d395a919c2440d921422716944c7940ed6010
2020-03-04 10:07:09 -05:00
Chauncey Hui cc9f32ed27 SWDEV-2 - Change OpenCL version number from 3102 to 3103 2020-03-04 03:00:02 -05:00
Evgeny Mankov 3be5375bde Merge pull request #1905 from emankov/hipify-clang
[HIP][cmake] Remove dependency from hipify-clang
2020-03-04 07:42:48 +03:00
Saleel Kudchadker f4caaeb308 Merge "Add -Wno-ignored-attributes flag to mute warnings" into amd-master-next 2020-03-03 20:39:16 -05:00
Vladislav Sytchenko 14810044f7 Fix Windows build.
Calm down warning C4715: not all control paths return a value.

Change-Id: I99d939b84770a499bb6a0edcc3bc0bf12961a711
2020-03-03 16:14:12 -05:00
Jason Tang f51ff32113 Seperate PAL and ROCm
Change-Id: I7d0fbbab88c0541f17274da6e8850f2c6783dcd1
2020-03-03 16:06:51 -05:00
Aryan Salmanpour 7bfb990ef7 [HIP] add hip specific properties for cooperative kernel multi device 2020-03-03 13:25:36 -05:00
Vladislav Sytchenko 243a3c2aa4 SWDEV-224335
cl_bool needed to be replaced with uint32_t instead of bool. This is due to cl_bool being a typedef of cl_uint32.

Currently clGetDeviceInfo() reports incorrect size for the return value, due to cl_bool being 4 bytes and c++ bool being 1 byte.

Change-Id: I647a4b8873627059865c84c8ca27694dbc0916de
2020-03-03 11:50:37 -05:00
Vladislav Sytchenko 818a65ff66 SWDEV-219799
Add missing __hip_pinned_shadow__ attribute to the hipModuleTexture2dDrv test.

Change-Id: I2c213a4108611c1af691388f268cac429b81a313
2020-03-03 11:49:00 -05:00
Evgeny Mankov ff7165a73c [HIP][cmake] Remove dependency from hipify-clang
[Reason] Upcoming hipify-clang's splitting out into a new repository https://github.com/ROCm-Developer-Tools/HIPIFY.
2020-03-03 12:07:13 +03:00
Chauncey Hui 8038b8262c SWDEV-2 - Change OpenCL version number from 3101 to 3102 2020-03-03 03:00:03 -05:00
German Andryeyev b93d997fb7 SWDEV-193956 - [hipclang-vdi-rocm][perf]
~45% to 50% of Performance drop on rocBLAS_int8 test

Enable cudaSetDeviceFlags() api call. Use active wait by default
for all devices.

Change-Id: Ifc2ebe3dd9b0aa3fdbfbc9cb5c2cd8b3b726124f
2020-03-02 18:35:56 -05:00
Vladislav Sytchenko d28b77bf23 Fix hipMemcpy3d (partially)
Incoming changes from upstream split the struct hipMemcpy3DParms into two separate ones - hipMemcpy3DParms and HIP_MEMCPY3D, which are cudaMemcpy3DParms and CUDA_MEMCPY3D equivalents respectively.

Note that HIP_MEMCPY3D is missing half the members of CUDA_MEMCPY3D (this should be fixed in PR#1887). Work around this by using a substitute _HIP_MEMCPY3D struct for now.

Change-Id: Ic15134e6deb260189b662b3804d2309a9b8473e9
2020-03-01 13:52:05 -05:00
German Andryeyev 622c714165 SWDEV-79445
Add MS HWS support. PAL reports just one compute engine
in that mode and runtime needs extra logic to detect RT queues.

Change-Id: I011f1f1b18dec6a7195a4f1fe939f8029bc269ae
2020-02-28 19:05:17 -05:00
Payam 93aa3ca565 updating hip debug target for VDI
Change-Id: Ia08af89e2ee461e75e888e495984d3b1d9a6a858
2020-02-28 18:13:50 -05:00
Payam 727219eb0a updated hip-targets for VDI
Change-Id: I268f1dbf04e3439ca1f3dd1cfbbc2f40667c00f9
2020-02-28 18:02:02 -05:00
Alex Voicu 3441cd7f16 Annotate __constant__ 2020-02-28 22:54:00 +02:00
Jatin Chaudhary dacc90f415 [dtests] __shfl_up and __shfl_down tests (#1899) 2020-02-28 16:48:15 +05:30
Siu Chi Chan eebba4799c improve code object loading error message (#1889) 2020-02-28 16:47:40 +05:30
saleelk 40a28e767e Fix HIPRTC headers to export C style symbols (#1879) 2020-02-28 16:47:29 +05:30
Rahul Garg 6be7537cf9 Remove deprecated HIP markers (#1876) 2020-02-28 16:47:15 +05:30
Rahul Garg 1c794045e0 Add hipDrvOccupancyMaxActiveBlocksPerMultiprocessor[WithFlags] (#1854)
Equivalent to cuOccupancyMaxActiveBlocksPerMultiprocessor[WithFlags].
2020-02-28 16:46:55 +05:30
jiabaxie e747efe2b4 Cleaned up error messages for HipEnvVarDriver test (#1825)
There were several error messages that appeared even if the hipEnvVarDriver.exe test passes and executes successfully. Now it is cleaned up. The following are those instances:

* When popen searches for directed_test directory but does not find it, it outputs an error, then finds the hipEnvVar at the same level. Currently the fix will prompt the test to only output an error if both searches for hipEnvVar fails.
* When assertion is used towards the later half of the test, conditions were set to specifically hide the devices, resulting in No Hip Device detected in the latter half of the test. The fix will make these errors not appear as they are intended to not find any devices. Assertions themselves are untouched.

HipEnvVarDriver.cpp has also been refactored. Reading HipEnvVar will now happen in a helper function for getDeviceNumber and getDevicePCIBusNumRemote, as the code to read HipEnvVar were really similar in them.
2020-02-28 16:46:12 +05:30
Saleel Kudchadker d292b4eee9 Add -Wno-ignored-attributes flag to mute warnings
Change-Id: Ib9ad75554c0ddfe025e7d500f057830f7ad2ef5b
2020-02-27 10:52:13 -08:00
Alex Voicu cea5489f00 Address post-staging issues in #1809 (#1894)
Fixes SWDEV-223910 and SWDEV-223663
2020-02-27 16:21:12 +05:30
Maneesh Gupta 3b4b58bda6 bump version to 3.2 (#1898)
- Bump version to 3.2
- [ci] Enable tests on ROCm 3.1
2020-02-27 16:18:31 +05:30
Christophe Paquot e9af4c8794 Blocking and default streams' sync:
Add hip::syncStreams(dev) to sync blocking streams on a given device.
hip::syncStreams(void) should only sync streams on the current device.

Change-Id: Ib6b0735215fa0ed12c646ebd029e9763ee3712ce
2020-02-26 08:54:00 -08:00
Nick Curtis a094c87038 fix long shuffle implementations for windows (#1895)
Fixes for SWDEV-223694
2020-02-26 15:53:56 +05:30
Yaxun (Sam) Liu ff4479fcc7 Fix hipcc for extra -mllvm option (#1885) 2020-02-26 15:53:43 +05:30
Chauncey Hui 3bfaa242c8 SWDEV-2 - Change OpenCL version number from 3100 to 3101 2020-02-26 03:00:03 -05:00
Payam 03b8524dbd removing 3 tests temporarily to enable hiptests
Change-Id: I8c45791aaf88628850462aff90979c147cb85f64
2020-02-25 19:01:34 -05:00
Payam Ghafari 630e28fcf1 Merge "removed excutable permission from source files" into amd-master-next 2020-02-25 17:44:43 -05:00
Vladislav Sytchenko 86f9f23764 Merge "Bump c++ version to 14." into amd-master-next 2020-02-25 17:00:27 -05:00
Vladislav Sytchenko 2500692d4d Merge "hipBindTexture() should handle nullptr offset." into amd-master-next 2020-02-25 17:00:18 -05:00
Payam eb4bd38c27 removed excutable permission from source files
Change-Id: Iae8639a96c55a098e28de41c5a3f38a07acbe25c
2020-02-25 16:16:47 -05:00
Tao Sang 1d22c5b925 Merge "Generating hiprtc lib with hcc+hip-clang" into amd-master-next 2020-02-25 14:46:24 -05:00
Vladislav Sytchenko 21ec6d005e Bump c++ version to 14.
This is to match our p4 build.

Change-Id: I084b07968ced98cca216146a0228cc36e9f56ab3
2020-02-25 14:41:55 -05:00
Vladislav Sytchenko fd76d220a5 hipBindTexture() should handle nullptr offset.
If a user passes a ptr that was allocated by hipMalloc(), the offset is guaranteed to be 0 and NULL may be passed as the offset parameter. We shouldn't return an error in this case.

Change-Id: I4a8d645121e5a17d5e2861a0629356a3599de9ee
2020-02-25 13:50:34 -05:00
Saleel Kudchadker d5938efcce Merge "Use the context variant of getNullStream" into amd-master-next 2020-02-25 13:03:22 -05:00
Vladislav Sytchenko 019d1feea5 Remove OpenCL Single Buffer Allocation Restriction
Change-Id: I5c37a7f08b02ed74ec6984c6da9ffa5dc9bf0f52
2020-02-25 11:41:18 -05:00
Payam 0eea98b755 removed AMD referenced internal url
http://172.24.5.22:8888/palamida/InventoryDetails.htm?inventoryId=80447&projectId=1704

Change-Id: I917942cfddd165018904afda7a1ab76cdbc91595
2020-02-25 11:08:19 -05:00
Saleel Kudchadker 1ccaea7ca8 Use the context variant of getNullStream
Do not create a new queue to call finish in hipFree if none was
created earlier elsewhere.
Change-Id: I87bb191e6b186ddbe607ab29d11e3ae5bc2ac8e6
2020-02-25 00:13:43 -08:00
Chauncey Hui beda512630 SWDEV-2 - Change OpenCL version number from 3099 to 3100 2020-02-25 03:00:02 -05:00
Payam 19791a242b clean up
Change-Id: Ic0201ffd1231f05d265165c62b475f768756991c
2020-02-25 02:13:12 -05:00
Payam 02835e5591 changed variable name to VDI
Change-Id: I9ab338b50714b0df2db1fa485134e1dad80b68c0
2020-02-25 02:11:24 -05:00
Christophe Paquot 2bdfc73649 Fixed a few multithreaded potential issues
Also make D2H and H2D keep track of the chain of events
when we need to use a different HostQueue.

Change-Id: I1c5da6ea6104b37ad7aac00f0eb8ea9371e6ba1c
2020-02-24 20:14:10 -08:00
Payam Ghafari 4a2109b3ce Merge "updated hip-targets for hip-vdi" into amd-master-next 2020-02-24 18:15:56 -05:00
Payam ade5994ede updated hip-targets for hip-vdi
Change-Id: Ib65e9011b25e368b8e03db1b4f14aa1ad076f4bc
2020-02-24 17:37:21 -05:00