Commit gráf

952 Commit-ok

Szerző SHA1 Üzenet Dátum
Danylo Lytovchenko f7338717ae SWDEV-470698 - fix formatting, add format check workflow (#657) 2025-08-20 19:58:06 +05:30
jamessiddeley-amd 5840940caa [rocprof-compute] Generalize Roofline (#325)
* per kernel analysis Roofline

* added per-kernel eval_metric calculation with display

* fixed typo

* updated tty.py show_all()

* formatting

* fixed ctest failures and updated equations

* formatting

* updated metric descriptoins

* review tweaks

* update docs

* added roofline gui analysis

* updated GUI docs

* updated print statement

* comment tweaks and ran ruff formatting
2025-08-20 09:58:08 -04:00
Rahul Manocha f4158ed3b7 SWDEV-546295 - fix param conversions for hipMemcpy3DBatchAsync (#641)
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-08-19 20:30:03 -07:00
systems-assistant[bot] 1f86010ca2 ROCpd support [Part 2] (#109)
* Rocpd part 2, caching

* Fix shadowed variables

* backward compatibility

* Fixed designated initializers

* Fix timemory include

* Remove benchmark & Fix build issues for rhel

* Add missing bracket

* Fix shadowing and pedantic

* Fix pedantic pt2

* Fix duplicated SDK calls

* Add decay in get_size_impl

* Rename sample cache to trace cache

* Add cache storage supported types

* Resolving track naming in sampling module

* fix sampling of flushing thread

* fix sampling of flushing thread 2

* throw exception upon store while buffer storage is not running

* Prevent fork crashing

* Fix rebase issue

* Applied suggestions from code review

* Change flushing thread to use PTL

* Fix agent creation order

* Fix stream id ci throw

* Remove force setup of rocprofiler-sdk

* Code cleanup

* Change initialization for agent

* Add missing namespace

* Fix the mismatch within the tool_agent->device_id

* Switch from using handle to use agent type index

* Fix pmc info comparator in metadata registry

---------

Co-authored-by: Aleksandar <aleksandar.djordjevic@amd.com>
Co-authored-by: Milan Radosavljevic <milan.radosavljevic@amd.com>
Co-authored-by: Marjan Antic <marantic@amd.com>
2025-08-19 22:01:04 -04:00
systems-assistant[bot] 351d598869 [Docs] Adding AQLprofile info (#150)
* Adding AQLprofile info

* update aqlprofile text

---------

Co-authored-by: Matt Williams <Matt.Williams+amdeng@amd.com>
2025-08-19 08:44:25 -07:00
systems-assistant[bot] c746ba6d31 Fix compilation with libc++ (#148)
`interop.cpp` uses `std::find_if` without a relevant include file, breaking compilation with Clang/libc++.

Co-authored-by: Sv. Lockal <lockalsash@gmail.com>
2025-08-19 08:42:03 -07:00
Giovanni Lenzi Baraldi ff43893902 Fix decoder description (#513) 2025-08-19 08:35:22 -07:00
Joseph Macaranas a22b6f3aca Merge commit 'ed7fae51d884a17cd3bd96c7973d1f1f78b5f3a5' into develop 2025-08-18 16:23:12 -04:00
systems-assistant[bot] bc455989d9 Merge commit 'b0519e8441273e20bbcbe1bb7b56cdf55369f514' into develop 2025-08-18 18:08:07 +00:00
systems-assistant[bot] c95526c57e Merge commit '55b54866fb50f264b064b20814679385ffd2847c' into develop 2025-08-18 18:08:05 +00:00
systems-assistant[bot] 23d4f23d7f Merge commit '0ac913e64c988e6b9ea8e86d74292cdf44c5d255' into develop 2025-08-18 18:08:03 +00:00
Jason Bonnell 24332bb65b [rocprofiler-systems] Update containers workflow to generate matrix from file (#369)
* Use matrix data from containers.yml in rocprofiler-systems-containers.yml

* add on pull_request to rocprofiler-systems-containers.yml

* update yq command in rocprofiler-systems-containers.yml

* ensure no indenting in json output

* update output definition in prepare_release_matrix

* added container-ci.yml for ci containers

* move ordering of steps in rocprofiler-systems-containers.yml

* Update projects/rocprofiler-systems/docker/containers-ci.yml

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

* only push containers when running on schedule or push

* Formatting fix

Cleaning trailing whitespace.

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-08-18 13:17:17 -04:00
Peter Park b4e336aef3 [rocm-smi-lib] docs: fix changelog heading ROCm 6.5.0 -> ROCm 7.0.0 (#363) 2025-08-18 11:46:02 -04:00
Aleksandar Djordjevic c58e3e92c1 Fix rocprof-sys-run --help command (#359)
Handle the `--help` parameter in the same way it is handled in other tools such as `rocprof-sys-sample` and `rocprof-sys-instrument`.
2025-08-15 17:28:08 -04:00
Kian Cossettini 947adacb3a [rocprofiler-systems] Fixed build-docker script failure on sparse checkout (#364)
Created `containers.yml` file in docker folder.
Updated `build-docker.sh` script to read from this file to determine supported OS + ROCm combinations.
2025-08-15 13:50:43 -04:00
hkasivis 53ba025a2e libhsakmt: Don't use MADV_DONTFORK for paged memory (#356)
Also advice parameter of madvise() system call is not a bitmask. So fix
that also

v2: Use MAP_SHARED instead of MAP_PRIVATE. This avoids MMU notifiers and
    evictions.

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
2025-08-15 09:22:20 -04:00
jokim-amd 700afd2d17 Re-Enable IPC DMA Bufs by default
Let ROCr use the new IPC-DMA bufs path.
2025-08-14 18:49:09 -04:00
jamessiddeley-amd 2936a468aa [rocprof-compute] updated formatting workflow and docs (#348)
* updated formatting workflow and docs

* restored requirements.txt
2025-08-14 14:12:24 -04:00
systems-assistant[bot] 3fd8af5974 rocr: SvmPrefetch to a particular node (#294)
Previously regardless of hsa_agent passed the prefetch is always driven
to node 0, now the agent of interest may be properly prefetched.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
Co-authored-by: Sunday Clement <Sunday.Clement@amd.com>
Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
2025-08-14 09:52:45 -04:00
Giovanni Lenzi Baraldi 75eb06dc18 Add realtime clock agent info to ATT records (#319)
* Add agent info to ATT records

* Fix names

* Update projects/aqlprofile/src/pm4/sqtt_builder.h
2025-08-14 13:35:00 +02:00
Jonathan R. Madsen 9df2c1ec68 [rocprofiler-sdk] Fix formatting, linting, and CI workflows (#345)
* [rocprofiler-sdk] Fix formatting and lint workflows

- several formatting workflows were silently failing when listing files

* format metrics_test.h

* Improve formatting job robustness

* Source formatting workflow does not use container

* Use PyPi clang-format

* Format rocpd/source/csv.cpp source

* Fix rocprofiler-sdk CI workflow

- fix invalid context access

* Update run-ci.py

- fix ctest_update

* Update run-ci.py

- handle old checkout in ROCm/rocprofiler-sdk
2025-08-14 00:02:23 -05:00
Luca Bruni e28900793b Add Google logging initializer to OMPT start tool to prevent benign warning. (#337) 2025-08-13 18:39:49 -05:00
systems-assistant[bot] dd37d215fd Add documentation describing ROCPROFSYS_USE_RCCP (#110)
* Add documentation describing ROCPROFSYS_USE_RCCP

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update wordlist

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update CHANGELOGS.md

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-08-13 18:01:18 -04:00
vedithal-amd 80b7e6baee Backport CHANGELOG change from rc4 cherry pick (#342)
* Backport from https://github.com/ROCm/rocprofiler-compute/pull/860
2025-08-13 14:49:53 -04:00
David Yat Sin 875fb40a03 Dayatsin/develop vmm pointer info (#305)
* rocr: hsa_amd_pointer_info to support VMEM pointers

Extend hsa_amd_pointer_info to support virtual memory addresses.

If hsa_amd_pointer_info is called on an address that is reserved but not
mapped to memory, then the pointer type will be reported as
HSA_EXT_POINTER_TYPE_RESERVED_ADDR.

If hsa_amd_pointer_info is called on an address that is mapped, then the
pointer type will be reported as HSA_EXT_POINTER_TYPE_HSA_VMEM

* rocrtst: VirtMemory_Basic_Test test for pointer info

Extend rocrtstFunc.VirtMemory_Basic_Test to test for
hsa_amd_pointer_info

* rocrtst: Add SVM Memory Test
2025-08-13 14:21:47 -04:00
Dmitrii a2d3f4a0e0 rdc: Profiler - improve metrics path detection (#333)
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-08-13 12:33:17 -05:00
mat3ix c41050d01f rocr: SDMA improvements (#326)
- When SDMA queue gets full when copying 2GB or more it blocks async
copy api
- Improve/format logging
2025-08-13 10:25:29 -04:00
xuchen-amd 483315fd0a Fix amd_smi lookup logic to account for amd-smi>=26.0.0 (#320) 2025-08-13 10:21:45 -04:00
Ammar ELWazir 28977999ad Switching from RHEL 8 to RHEL 9 (#318)
* Switching from RHEL 8 to RHEL 9

* Switching from RHEL 8 to RHEL 9

* Switching from RHEL 8 to RHEL 9

* Fixing ROCPD for older Python Versions

* Formatting and checking if SQRT is available or not

* Formatting and checking if SQRT is available or not

* Formatting and checking if SQRT is available or not

* Formatting and checking if SQRT is available or not

* Formatting and checking if SQRT is available or not

* Update projects/rocprofiler-sdk/source/lib/python/rocpd/summary.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update summary.py

* Update summary.py

* Update projects/rocprofiler-sdk/source/lib/python/rocpd/summary.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update projects/rocprofiler-sdk/source/lib/python/rocpd/summary.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update summary.py

* Update summary.py

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-08-13 08:53:38 -05:00
David Galiffi 311e279596 Add "branch" requirement to "push" workflows. (#329)
* Add "branch" requirement to "push" workflows.

* Deleted obsolete workflow files

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Fix path to the `check-copyright.sh` in `pre-commit-config.yaml`

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-08-13 09:42:49 -04:00
systems-assistant[bot] d0a18e0eb9 [cmake] - Update search for LibElf (#256)
There is an issue with TheRock build currently. They have
a local source build of elfutils they want to use instead
of a system package. Currently, rocr uses it's own
FindLibElf.cmake module and this is inhibiting the build
from finding the libelf config built by TheRock.

Now we will first search in config mode and fallback to
module mode if nothing is found.

Authored-by: Ethan Stewart <ethan.stewart@amd.com>
Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
2025-08-13 09:13:45 -04:00
systems-assistant[bot] 76fd78d394 Merge commit '499e2ee044e15ebdf2c5cae1ee3ea282736ed66a' into develop 2025-08-13 12:09:50 +00:00
David Yat Sin 6f09eb3418 rocminfo: unset executable flag (#314)
Co-authored-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
2025-08-12 21:13:45 -04:00
David Yat Sin 080fa938c6 rocr: Update rocr-runtime github metadata (#275)
Remove old .github directory.
Update main CODEOWNERS file for project/rocr-runtime.
2025-08-12 21:11:49 -04:00
systems-assistant[bot] fff63d428e Merge commit '2305f8ae565389cfc348a747c467c004909d7a90' into develop 2025-08-13 00:24:58 +00:00
David Yat Sin a80c19285e rocminfo: Fix comparison to None (#313)
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):

> Comparisons to singletons like None should always be done with
is or is not, never the equality operators.

Author: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
2025-08-12 17:14:49 -04:00
vedithal-amd 63f31859e4 Fix instruction cache metrics (#276)
* Fix IL1 Latency metric

* Add SQC_ICACHE_INFLIGHT_LEVEL counter and corresponding accumulation
  counter to counter definitions

* Add missing coll_level

* Fix descriptions and tests
2025-08-12 14:03:11 -04:00
Milan Radosavljevic b793b183a4 Update rocprofiler-systems github workflows (#193)
* Fix rocprofiler-systems CI

* Fix 'Documentation' jobs

* Python Linting fix

* Add python 3.11, 3.12

* Fix python linting

* Re-add ubuntu-noble workflow

* Remove old workflows from project folder

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update rocprofiler-systems workflows

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: Jason Bonnell <Jason.Bonnell@amd.com>

* Retire ubuntu-focal workflow

* Fix path to validation file in `build-docker.sh`

* Update .github/workflows/rocprofiler-systems-python.yml

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

* Revert dockerfile

* Retire rocprofiler-systems-ubuntu-focal workflow

* Include .github directory in cpack workflow sparse-checkout step

* Revert git from ubuntu ci image

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: Jason Bonnell <Jason.Bonnell@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-08-12 19:42:01 +02:00
xuchen-amd 9a4983feac Fix fstring formatting. (#315) 2025-08-12 11:54:58 -04:00
Giovanni Lenzi Baraldi cb77f5af5c Adding new trace decoder record types and new ATT parameters (#195)
* Adding new trace decoder record types and new ATT parameters

* Add compatiblity with decoder 0.1.2

* Added RT

* Format

* Add logging to sdata values

* Review comment

* Review comments

* Update projects/rocprofiler-sdk/source/include/rocprofiler-sdk/experimental/thread-trace/trace_decoder_types.h
2025-08-12 14:31:12 +02:00
systems-assistant[bot] 83971da05e Merge commit 'ea2d79c3e260d5728ecbc843f5367a12e9c301c4' into develop 2025-08-12 12:09:54 +00:00
systems-assistant[bot] 576faeac43 Merge commit 'c60888b0cd135739477e62d400a61138333f1b08' into develop 2025-08-12 12:09:52 +00:00
systems-assistant[bot] d5d702a0cd Merge commit '0dde3ce5898815296008b8461a5396a5c3c25a07' into develop 2025-08-12 00:25:16 +00:00
systems-assistant[bot] 2dc8e2f2d4 Merge commit '0d9428135c73bd8d14432f1d8cd64076f5ebfea2' into develop 2025-08-12 00:25:14 +00:00
Joseph Macaranas 762c088758 Add 'projects/rocm-core/' from commit '942821090f1a81d7ad55f910dffdba93c2cdca8a'
git-subtree-dir: projects/rocm-core
git-subtree-mainline: 92e841646c
git-subtree-split: 942821090f
2025-08-11 18:27:37 -04:00
Joseph Macaranas 92e841646c Reset adding rocm-core to super-repo 2025-08-11 18:26:52 -04:00
xuchen-amd 0929e6ecc1 [rocprofiler-compute] Update amd smi lookup (#223) 2025-08-11 17:37:33 -04:00
cfallows-amd 3258c69b60 Fix cmake formatting (#222)
Fix formatting of CMakeLists.txt for cmake-format check

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-08-11 16:40:09 -04:00
Ammar ELWazir 11362bb5a6 Fixing CDash AQLProfile (#252) 2025-08-11 14:42:12 -05:00
Ammar ELWazir 22c07f02da ROCProfiler CI Clean up & Testing (#240)
* CI Clean up & Testing

* CI Clean up & Testing
2025-08-11 14:26:09 -05:00