AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
64,169 Commits 3 Branches 0 Tags
f7338717aeb56fbe394c0683539a0cf2f7f3ded7
Commit Graph

63 Commits

Author SHA1 Message Date
Danylo Lytovchenko f7338717ae SWDEV-470698 - fix formatting, add format check workflow (#657) 2025-08-20 19:58:06 +05:30
GunaShekar, Ajay 76328ecfde SWDEV-546179 - hipModuleGetFunctionCount AMD impl (#782) 
* SWDEV-546179 - hipModuleGetFunctionCount AMD impl

* SWDEV-546179 - return invalid for count ptr

* SWDEV-546179 - hipModuleGetFunctionCount CHANGELOG.md update

[ROCm/clr commit: dfb46db2fb]
 2025-08-13 20:28:12 -07:00
Manocha, Rahul 4a93a614e5 SWDEV-539710 - Defer allocation of managed variable (#652) 
Co-authored-by: Rahul Manocha <rmanocha@amd.com>

[ROCm/clr commit: 3f6f9d6081]
 2025-07-31 08:30:23 -07:00
Sang, Tao 7fd322af90 SWDEV-508776 - support VGPRs validation (#274) 
Clarify some VGPRs terms description.
Fix some wrong query logics of availableVGPRs_ and
availableRegistersPerCU_ in device info.
Add hipDeviceAttributeMaxAvailableVgprsPerThread
attribute query.
Remove hardcoding of following
 info_.vgprAllocGranularity_
 info_.vgprsPerSimd_

[ROCm/clr commit: 397f303d97]
 2025-07-09 10:46:52 -04:00
Jayaprakash, Karthik 4ea2d9a5ee SWDEV-531711 - Report correct error code based on device failure. (#286) 
[ROCm/clr commit: f5b8db33f1]
 2025-05-17 06:33:13 -04:00
Jayaprakash, Karthik 5dff283f4e SWDEV-526855 - Modify the SIMDPerCU calculation for gfx1250/1. (#275) 
[ROCm/clr commit: acb1f7e8d5]
 2025-05-12 11:09:03 -04:00
Jayaprakash, Karthik cde2a250ec SWDEV-493805 - Cleaning up launch parameters arguments. (#241) 
[ROCm/clr commit: fa55557f46]
 2025-05-06 15:06:13 -04:00
Saleel Kudchadker 21ae9ef25e SWDEV-508225 - Improve fat binary handling 
Change-Id: I78a9951f2f4c4c743c1205b1e40aac215054e27d


[ROCm/clr commit: 08af3eb484]
 2025-01-28 14:38:21 -05:00
Marko Arandjelovic 8647bb483b SWDEV-504084 - Make hipModuleGetFunction use the device the module is loaded on 
If a module is loaded on one device, hipModuleGetFunction and other similar APIs should be able to run successfully from another device.

Change-Id: I96084cbd6c6dcf2a81019779a6ab1842ef2f35d1


[ROCm/clr commit: c46f843b99]
 2025-01-16 10:16:42 -05:00
Ioannis Assiouras 67c93c3bad SWDEV-505503 - Use internal device synchronize function in __hipUnregisterFatBinary 
This is to avoid calling the HIP_INIT macro during the shutdown process.

Change-Id: I2e65f6e10491918a17445ee1e8ddd08286070358


[ROCm/clr commit: 5e3a29078d]
 2025-01-15 18:57:34 -05:00
Sebastian Luzynski f421f02546 SWDEV-465085 - replace asserts inside API calls 
This change replaces some asserts, that were only available in debug
mode, with standard error handling.

Signed-off-by: Sebastian Luzynski <Sebastian.Luzynski@amd.com>
Change-Id: I112f9e56f921abd72daf0d11e4ecdcb7b1a9f9e6


[ROCm/clr commit: 019abdc3bd]
 2024-11-29 04:11:39 -05:00
Ioannis Assiouras eae7d9bdc8 SWDEV-496003 - Add support for dynamic functions in hipFuncSetAttribute 
Modified hipFuncSetAttribute to handle pointers to dynamic functions
returned by hipModuleGetFunction.

Change-Id: I54b98f9d31a79630dd7edcd363fad81f1d89219b


[ROCm/clr commit: 1a710dabcf]
 2024-11-19 04:50:15 -05:00
Vladana Stojiljkovic 7ff9aa117d SWDEV-493526 - Create kernel node when hipLaunchByPtr is captured 
Change-Id: Id3493485dfdb468436ab33e6d7cb19b6b0066fd4


[ROCm/clr commit: e08df57502]
 2024-10-31 12:41:31 -04:00
Jaydeep Patel 566984676e SWDEV-487988 - Reserve event flag in hip::Event. 
Don't create new hip:Function if it is already registered.

Change-Id: I3ecd5d61146659be6ba434717b0f21d3fc04cfc9


[ROCm/clr commit: a6c5c6a95a]
 2024-10-08 05:29:32 -04:00
pghafari 1157776b30 SWDEV-479260,SWDEV-483599 - Check griddim Y,Z <= 65536 
Gfx12 has 16 bits for grid dim Y/Z. Detect gfxIp and return error if dim y/z > 16 bits

Change-Id: I43dd14affc9e4073d0b1232e7523967f0180fa31


[ROCm/clr commit: 0a918c8f96]
 2024-09-23 11:36:13 -04:00
Jatin Chaudhary 0a850d8725 SWDEV-466747 - call device sync once while unregistering 
Basically embed hipDeviceSync in std::call_once.

Change-Id: I29ca926d61ed80e21acba5c388a8256d913487e4


[ROCm/clr commit: f8beeede22]
 2024-09-23 08:00:10 -04:00
Jaydeep Patel 82474ca1db SWDEV-465220 - Validate stream on which Kernel is planned to be launched. 
Change-Id: I34c679bd888c275584c11ad3e8346d4d542976f9


[ROCm/clr commit: b0047d690a]
 2024-08-06 00:31:22 -04:00
kjayapra-amd 2335c92a1a SWDEV-455041 - Continue processing fat binary even if other code object bundle processing fail. 
Change-Id: Iea553ab0265c08341f915644075ce2b6ed9b3200


[ROCm/clr commit: 863c56262e]
 2024-04-20 14:25:49 -04:00
Sourabh Betigeri 26b7b7b951 SWDEV-453577 - Fixes to account for right CU count based on WGP or CU mode 
Change-Id: Ib9739f9917bc6ff69cc76f444d909311922ebc1e


[ROCm/clr commit: fcfe2ec88b]
 2024-04-15 11:53:43 -04:00
Jaydeep Patel c4239ed8e8 SWDEV-446992 - Request can be for bytes OR dptr OR both. 
Change-Id: Ib479c744b90125b74d99cbf18b7f4b8cf765bf1c


[ROCm/clr commit: 09328f45b3]
 2024-03-26 11:10:24 -04:00
Ioannis Assiouras a3b6fd539f SWDEV-449146 - Call hipDeviceSynchronize before removeFatBinary 
Added call to hipDeviceSynchronize in __hipUnregisterFatBinary
to ensure that all HSA async signal handlers complete before removeFatBinary

Change-Id: I756fecca1c2a5eae092613d8079de266399e5685


[ROCm/clr commit: ad32e604c7]
 2024-03-20 23:40:46 +00:00
jiabaxie b251260e2a SWDEV-437702 - implement hipGetProcAddress 
This should be used in place of dlsym or GetProcAddress (linux and windows respectively)

Change-Id: I5501b538e03892e8e5a2282678d848fcaf21d911


[ROCm/clr commit: 0479cdb3dd]
 2024-02-08 11:26:02 -05:00
German 7883f1e6f7 SWDEV-430809 - Replace hipErrorSharedObjectInitFailed vs hipErrorNoBinaryForGpu 
hipErrorSharedObjectInitFailed should be used for interop objects.

Change-Id: Id3bcffaac3b511021f2fd57e9b156a897b646db0


[ROCm/clr commit: 68d442f29a]
 2023-12-14 10:35:10 -05:00
Satyanvesh Dittakavi 542044aadc SWDEV-434846 - Correct the vgprs per simd for MI300 
Change-Id: Id4862da7611f64392bfc1538fb644801ec0a9e7f


[ROCm/clr commit: b2102fe939]
 2023-12-13 03:06:21 -05:00
Saleel Kudchadker f969d89aa4 SWDEV-301667 - Logging refactor 
- Remove newline from logging as log function internally inserts a new
line

Change-Id: I25eb2242a1f1e87cf811bcc373d1d485b2e027a8


[ROCm/clr commit: 058b2702db]
 2023-12-07 12:12:57 -05:00
Anusha GodavarthySurya 3bdedf0cc7 SWDEV-351966 - Dispatch table for hip runtime 
Change-Id: Ie4a44fa8cf1ff9c152146070bbbf6b0636d4e325


[ROCm/clr commit: 5e21f0c6bd]
 2023-11-22 01:11:19 -05:00
kjayapra-amd 22bc3d52a3 SWDEV-417244 - Create Unique File Desc Store and guarantee no duplicates fds are opened. 
Change-Id: I7be7fee52b673f0b1b3facdfbd847b57f2a47cde


[ROCm/clr commit: 85b645731c]
 2023-09-13 17:03:18 -04:00
Rahul Garg 87bbe33acd SWDEV-418360 - Continue parsing modules even when some module don't have 
right binaries built for current device

Change-Id: Icc6a4233fbcede9b2dc6feb78e6bfbd761684c7f


[ROCm/clr commit: c9cf3bdc16]
 2023-08-31 14:54:59 -04:00
kjayapra-amd 69406243e2 SWDEV-378006 - Adding a new guarantee macro to support printing args. 
Change-Id: I2083ddaf8058759bdace7d3bb1e8e3670cbeddd2


[ROCm/clr commit: 7f41a96ffb]
 2023-05-03 12:43:16 -04:00
Jatin Chaudhary 646af29dc5 SWDEV-1 - Fix incorrect SGPR usage in VGPR calculation. Pointed out by #58 issue on hipamd public repo 
Change-Id: I8c27c0da254521714c92369990aa10f6fc09c246


[ROCm/clr commit: 54f73e430b]
 2023-05-02 03:53:18 -04:00
Ioannis Assiouras 2ccaf82efc SWDEV-373630 - Added input checks in hipOccupancy query functions. 
Change-Id: I2b3e47a094acf5968e714bd853c4497995ef386b


[ROCm/clr commit: a38296158c]
 2023-03-09 20:45:02 -05:00
Ioannis Assiouras 0936f32b27 SWDEV-373630 - Added checks for invalid flags in hipOccupancy query functions 
Change-Id: Ice1df4d3722354f40c8b02ba35ed122f9b2e2f2d


[ROCm/clr commit: 5837d83e46]
 2023-03-06 15:10:07 -05:00
Jaydeep Patel 37769589f3 SWDEV-383056 - Don't sync with dst device for hipMemcpyAsync. 
Change-Id: I28530e6bd870d617507592576295fc9e7eed1475


[ROCm/clr commit: 57fa5938fe]
 2023-02-28 23:21:01 -05:00
Sourabh Betigeri 23aa33200c SWDEV-378778 - Returns with error logged when compiled for a diffferent gpu arch 
Change-Id: I34fb03c4f76d08278246d29028db0eb21a7aa529


[ROCm/clr commit: 88dc5cd386]
 2023-02-28 15:59:59 -05:00
Ioannis Assiouras 2633e62801 SWDEV-381402 - Derive hip::Stream from amd::HostQueue 
Change-Id: I6c1aca5eb350c32d974ae4ffcc725705355956d8


[ROCm/clr commit: e3633dc8f4]
 2023-02-21 18:12:03 -05:00
kjayapra-amd b9f94c082b SWDEV-381898 - Move the lock after code object loading since COMGR is thread safe now and VDI also have locks. 
Change-Id: I15547f3ae3711d12a1ddf5cb7e9abd40a95ded89


[ROCm/clr commit: 68139f9ddb]
 2023-02-15 10:23:28 -05:00
Anusha GodavarthySurya e333f99dec SWDEV-373173 - Handle kernel compilation WGP/cumode in occupancy calculation 
Change-Id: Id0225683a578c3275a35f8f807a57b6379746392


[ROCm/clr commit: ce8f441c14]
 2023-01-18 03:27:30 -05:00
Anusha GodavarthySurya a7a887ab05 SWDEV-373173 - Correct max VGPRs and VGPR Granularity in Occupancy calculation 
Change-Id: I36010f3991f809c61f0c4388b8daa8d3e9b8cc9d


[ROCm/clr commit: 27c5189bca]
 2023-01-18 03:27:21 -05:00
Ajay 01f4d7eac3 SWDEV-369618 - hipOccupancyMaxPotentialBlockSizeVariableSMemWithFlags invalid flag scenario 
Change-Id: I07df2640be71a6b0aed160d54e80ffdeb85ec554


[ROCm/clr commit: 3e4ed8d917]
 2023-01-05 23:40:29 -05:00
Anusha GodavarthySurya 7f56e0e09c SWDEV-373173 - Correct max VGPRs and VGPR Granularity in Occupancy calculation for different asics 
Change-Id: Ib213ed8767a793a832776fba7c0811c2f023a8ad


[ROCm/clr commit: 067c7316ba]
 2023-01-04 01:34:40 -05:00
Ioannis Assiouras c4d2a2c557 SWDEV-374400, SWDEV-374404 - Change error message in hipFuncGetAttribute(s) to match nvidia. 
Change-Id: I95b69a49ced24115f0aebc288ea067a49b770aca


[ROCm/clr commit: 97c5f772c6]
 2022-12-20 12:49:17 -05:00
Rakesh Roy 9ec5dee45c SWDEV-368881 - Revert enable hipLaunchCooperativeKernel for hipRTC compiled function 
This reverts commit f870f04dd9.

Reason for revert: Doesn't match with CUDA behavior

Change-Id: I413f3d241f864c1e7c21681c5fff8f216ef54306


[ROCm/clr commit: 4f5d180ca7]
 2022-11-30 03:58:29 -05:00
Rakesh Roy f870f04dd9 SWDEV-368881 - Enable hipLaunchCooperativeKernel for hipRTC compiled function 
- Add helper function to validate whether a dynamic function is present or not
- If getStatFunc fails, then check whether the function passed is a valid dynamic function

Change-Id: I4141172f42dce7ff689709560c483e602b5dad4b


[ROCm/clr commit: b4d8586a11]
 2022-11-29 00:35:43 -05:00
German 15e4fa1264 SWDEV-1 - Clean-up map file in Linux 
Change-Id: Ibfad648c8ec9897a0895057c501d383875e95730


[ROCm/clr commit: 4471ed1210]
 2022-11-28 17:16:23 -05:00
Rakesh Roy f149b21399 SWDEV-351969 - TLS Optimization 
- Aggregate all TLS(Thread Local Storage) variables into a single class
- This is to improve cache accesses per thread

Change-Id: Ic8361eaeae290fff00254684e309471958365eb9


[ROCm/clr commit: 8b391ef18c]
 2022-10-09 22:08:14 -04:00
Saleel Kudchadker ad9557a00b SWDEV-301667 - Pass all params to API Init 
- Correct return for ihipLaunchKernel

Change-Id: I66e81fa635473e6e728936e4cfba9f1bc7f018ad


[ROCm/clr commit: df278887fe]
 2022-09-15 22:20:02 -07:00
Laurent Morichetti 2f467284bb SWDEV-351980 - Acquire the code object lock in StatCO::getStatFuncName 
Change-Id: I52ce2530d12fbe47e575feb2aab39bbfdfebd201


[ROCm/clr commit: a682934251]
 2022-08-16 19:43:15 -04:00
Jaydeep Patel cbc97ad59a SWDEV-329516 - Propogate hipErrorSharedObjectInitFailed from getStatFunc. 
Change-Id: I60160f8d0c0dab20649a4e7c03448f4ae9a9c95b


[ROCm/clr commit: c61701323e]
 2022-08-02 01:50:50 -04:00
Ammar ELWazir f72cedce81 SWDEV-345650 - Solving hipKernelNameRefByPtr Stream Issue 
Stream is not important to get the kernel
name from Function that can be found in
the functions_ map.

Change-Id: I164bc3ebcc5552359856e76204d8b124ba0d2f34


[ROCm/clr commit: fb8690f812]
 2022-07-15 15:38:39 -04:00
Sarbojit Sarkar 86481e460d SWDEV-333073 - HIP_INIT_API to handle no return case 
Change-Id: I78d43e88cc196047a4cb5d6fcf756339c0e46e80


[ROCm/clr commit: 1074b22c48]
 2022-06-24 12:53:18 -04:00