Jaydeep Patel
f9e27bcdd4
SWDEV-377804 - Initial commit to support hipGraphInstantiateFlagAutoFreeOnLaunch
...
Change-Id: I7a35becb6c98a6ff70264e141317d98be7457a37
2023-02-01 11:51:39 -05:00
sdashmiz
34d087da93
SWDEV-361623 - correct remove edge behaviour
...
- remove node dependency before checking parents
- reduce edge level acording to new value of node
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: Id4bff1684f7e0b42beeebc4d2e009bfdb507fb5f
2023-01-31 12:48:59 -05:00
sdashmiz
b251c8fdb2
SWDEV-374368 - dependency list should not have duplicate
...
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I67e1c8203f10916b98408e2004e6c64e96b1933b
2023-01-30 10:28:35 -05:00
sdashmiz
23edcd3e23
SWDEV-374389 - correct update dependency behaviour
...
- nodes should belong to graph
- num of passed dependency cant be larger than graph nodes
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: Ia6f2283546bc44edee705b0483bfe506b7b1177a
2023-01-30 10:05:52 -05:00
Ajay GunaShekar
1f4176062b
SWDEV-372757 - Don't destroy null queue in MT
...
This reverts commit f39655c0c8 .
Reason for revert: patch does not fix all stream hangs. So another patch was merged which fixes all issues.
Change-Id: I332d1ea29c23747b46b7667fe3e34e0ceefd2b23
2023-01-25 23:41:16 -05:00
sdashmiz
a4dd362a1d
SWDEV-379151 - correct error status
...
- if the stream is null ptr and there is capture ongoing return an error
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: Iff33e4aebc253fb7bb56daf5c455722d726c6705
2023-01-25 15:06:38 -05:00
Jaydeep Patel
70bfc6145b
SWDEV-379125 - Check only if there is attr set for graph kernel node.
...
Change-Id: I8768b33ad27e75eb753d99d682edf60b31b240df
2023-01-24 09:51:12 +00:00
Satyanvesh Dittakavi
0ccd41050b
SWDEV-372396 - Address the errors in hiprtc headers with -Werror
...
Change-Id: Ied553216dfc2ff8b5c72de617cb47b6ca8f52063
2023-01-23 17:25:42 +00:00
German
b685930bee
SWDEV-377991 - Rmove Liquidflash logic
...
Change-Id: I1c2169c1a8c7449c59cc15074af039c48fc1ef31
2023-01-19 09:58:07 -05:00
pghafari
76b0b4d635
SWDEV-369551 - invalid stream check in hipMemcpy
...
Change-Id: I6762af93cd566a38f7d04994b87a76e744b19043
2023-01-18 20:02:28 -05:00
pghafari
d491ee7385
SWDEV-374381 - updated error check
...
for hipGraphAddMemcpyNodeFrom/ToSymbol
Change-Id: I4de063a5a9307148bf4da0e8a2edc1d3b01a8b9a
2023-01-18 19:59:32 -05:00
Anusha GodavarthySurya
d422ad0ec1
SWDEV-376407 - Track manual nodes added during capture
...
Change-Id: Ic44f842c303eed0eff08b6ee5922976d96a52c71
2023-01-18 03:27:41 -05:00
Anusha GodavarthySurya
ce8f441c14
SWDEV-373173 - Handle kernel compilation WGP/cumode in occupancy calculation
...
Change-Id: Id0225683a578c3275a35f8f807a57b6379746392
2023-01-18 03:27:30 -05:00
Anusha GodavarthySurya
27c5189bca
SWDEV-373173 - Correct max VGPRs and VGPR Granularity in Occupancy calculation
...
Change-Id: I36010f3991f809c61f0c4388b8daa8d3e9b8cc9d
2023-01-18 03:27:21 -05:00
pghafari
a9cbff0a49
SWDEV-374361, SWDEV-374362, SWDEV-374364, SWDEV-374365 - error checking
...
Change-Id: I0b729976ed794239fa54e1ad2965133b319d2f5d
2023-01-17 23:10:22 -05:00
sdashmiz
52bf09aac6
SWDEV-374374 - memset memory mapping should not change
...
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I4cc3b1ac5a59fe5c9ae060f4d5d189dc63ca450c
2023-01-17 14:41:24 -05:00
German Andryeyev
39db0ec297
SWDEV-355281 - Use offset from FindMemObj
...
Change-Id: I53ce2c1ef2e3a580b8b12312b693c2476f0885d2
2023-01-17 10:01:49 -05:00
pghafari
2e60edbe0e
SWDEV-369570 - MaxSharedMemoryPerBloc check
...
Change-Id: I74d216a5d9316758bb611eb241ba85222194ce8b
2023-01-17 07:52:15 -05:00
pghafari
236a725d67
SWDEV-374380 - hipGraphAddMemcpyNode1D errorCheck
...
Change-Id: I50501de139e3898783c1cc9c91c5ed3ed2564f3b
2023-01-17 07:49:23 -05:00
Satyanvesh Dittakavi
842b9d0b56
SWDEV-373231 - Support hip atomics header with HIPRTC
...
Change-Id: Ic500dfb66ed5ef0c4b672dfd0595409d0e8caaf5
2023-01-17 00:31:07 -05:00
sdashmiz
be966acb0c
SWDEV-360031 - check for stream capture finish.
...
- stream capture should be done before any sync APIs.
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I3d65f67ee68777be71f97f48d460ccaefdd4e1af
2023-01-16 13:09:24 -05:00
sdashmiz
338307ef2c
SWDEV-374390 - add correct error
...
- null stream should return error on host function
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I17659ad7af0814091dbf6cb4a2cb2644514551f0
2023-01-16 13:08:23 -05:00
Jaydeep Patel
7eecbdd9db
SWDEV-374360 - Handle free for external memory.
...
Change-Id: Ibfaf30eef371499a3c1f931a73cce76c83d8f7f3
2023-01-16 13:07:01 -05:00
Jaydeep Patel
fdecc1b351
SWDEV-375366 - SWDEV-375351 - Handle HtoH case for graph mem cpy impl.
...
Change-Id: I5a8c3c3c22db045f714b0443b8d70a8c6b4a8cea
2023-01-16 11:37:57 -05:00
Ioannis Assiouras
0d2e0d1621
SWDEV-374403 - Added input sanity checks for hipLaunchCooperativeKernelMultiDevice and hipExtLaunchMultiKernelMultiDevice
...
Change-Id: Iebef5ae68439d87549fdf9559de51c6c79c64392
2023-01-13 19:48:42 -05:00
German Andryeyev
eef47ca24a
SWDEV-353281 - Initial support of memalloc in graph
...
Add memory allocation support in graph. Current implementation uses
cache from mempool to hold the allocations which belong to the graph.
Also the resource tracking is disabled at this moment because mempool
operates with hip::Stream objects, but graph has execution with
amd::HostQueue objects.
Change-Id: I54fe3250126d24f5a26ada975f37d429bb4ef17b
2023-01-13 13:06:59 -05:00
Satyanvesh Dittakavi
873bc03034
SWDEV-369552 - SWDEV-369553 - SWDEV-369555 - Fix hipMemAdvise
...
- API should return error if the size passed is more than the
bytes allocated
- Passing invalid device should return error except for the
advise hipMemAdviseSetReadMostly
Change-Id: I1c4c15136b825215bf1e1f5ee7a9a08e5895d870
2023-01-13 12:53:31 -05:00
Rakesh Roy
a427d3cd10
SWDEV-374369 - Fix hipGraphAdd*Node* APIs invalid behavior
...
- Return hipErrorInvalidValue if dependencies array contains a node from
different graph
Change-Id: I0dcfaaaeb50a89848ac546a0b86b185977e2128c
2023-01-13 12:09:42 -05:00
Anusha GodavarthySurya
33eef6d95e
SWDEV-364576 - use hipLimitMallocHeapSize to set initial heap buffer size
...
Change-Id: I2f1d3b229bc28571ce6c55f93f8ef73dda516b50
2023-01-12 23:34:29 -05:00
Jaydeep Patel
bb486b04c6
SWDEV-374383 - Check from and to if no of dependencies are more than 0, Check from and to node are belongs to graph pass in.
...
Change-Id: I0cdafb497147f9ac7f84d40203a21e9eefd595a3
2023-01-11 11:43:22 -05:00
Rakesh Roy
b321e2afc6
SWDEV-368881 - Implement hipModuleLaunchCooperative* APIs
...
- Add implementation for hipModuleLaunchCooperativeKernel, hipModuleLaunchCooperativeKernelMultiDevice APIs
Change-Id: I2a80264e458549211c34b413397a08b57d021147
2023-01-10 13:50:20 -05:00
Ajay
c6a7ce66bb
SWDEV-369556 - Unit_hipMemGetAddressRange_Negative cases
...
- return value for invalid device ptr
- offset greater than size
Change-Id: I8bcf878c3c1c0a29836ea664bfb9048e1114b74e
2023-01-10 06:57:54 -05:00
Jiabao Xie
03200953e5
SWDEV-374375 - moving nullptr check into hipGraphNode::isValidNode
...
Change-Id: Ic9264521d6f0b36ffc948ca9feeaa70eb6e98eb6
2023-01-09 16:27:38 -05:00
Jacob Lambert
7dd54c746e
SWDEV-356171 - Adding support for name lowering for bitcodes (-fgpu-rdc) via
...
Comgr mangled name fetching APIs
Change-Id: I10ce2b1288c459e3e61218d68a270aba2148376e
2023-01-09 14:49:51 -05:00
kjayapra-amd
0c8c08cf51
SWDEV-361374 - Adding support for hipPointerSetAttributes
...
Change-Id: I56710b808854acefca07b3b5898deebee38063e9
2023-01-09 12:36:57 -05:00
Juan Manuel MARTINEZ CAAMAÑO
c391af49dc
SWDEV-290637 - Specify a working directory when calling hip_embed_pch.sh
...
Consider the case where cmake is invoked as follows:
cd <parent_dir>
cmake -S<source_dir> -B<build_dir> ...
If `WORKING_DIRECTORY` parameter is not specified in `execute_command`,
`hip_pch.o` is created outside `<build_dir>`, in `<parent_dir>/hip_pch.o`.
Change-Id: I751f4390628315ad70c36148e09824c19c93ae9e
2023-01-09 03:17:07 -05:00
German
f39655c0c8
SWDEV-372757 - Don't destroy null queue in MT
...
Skip destruction of the null queue for MT. Windows can destroy worker
thread on exit during the stream destruction, causing a race condition.
Change-Id: I3e4bc3ab2b477d38c0aec1fc59e6f1af0f8f6b0f
2023-01-09 00:03:09 -05:00
Jiabao Xie
e5490697cc
SWDEV-374375 - Added checks to see if hip graph nodes are valid
...
Change-Id: I9e6eabf0e4a9100de6f9d26bf5b815957f12d4f2
2023-01-06 16:58:56 -05:00
pghafari
7615fba2d5
SWDEV-375135 - adding error string
...
Change-Id: I73276462627a47d405c8439d8a843ac266fc5d38
2023-01-06 16:31:35 -05:00
pghafari
335a24d1a0
SWDEV-369042 - updating to GetError to match cuda
...
Change-Id: I0ec2330443b26cb1c8cedba942f31fb1267cd09d
2023-01-06 05:33:41 -05:00
Juan Manuel MARTINEZ CAAMAÑO
537df06c4f
SWDEV-290384 - Missing hiprtcResult case in hiprtcGetErrorString
...
Change-Id: I11d18ff19f6f6f1b36febf87a586bc9ffb95af10
2023-01-06 03:38:44 -05:00
Satyanvesh Dittakavi
516acd4e60
SWDEV-375020 - Revert "SWDEV-370552 - Improve hiprtc performance by passing the right flags to comgr"
...
This reverts commit 627e689ad7 .
Reason: Adding "-Xclang" and "-disable-llvm-passes" in hiprtc
compilation seem to cause perf issues and memory fault in few apps.
Change-Id: I12ff46293c7b7afb24d570351736d884d2881b77
2023-01-06 00:09:06 -05:00
Ajay
3e4ed8d917
SWDEV-369618 - hipOccupancyMaxPotentialBlockSizeVariableSMemWithFlags invalid flag scenario
...
Change-Id: I07df2640be71a6b0aed160d54e80ffdeb85ec554
2023-01-05 23:40:29 -05:00
Jaydeep Patel
7c32f66e67
SWDEV-374372 - Return invalid value if pitch is less than width in bytes.
...
Change-Id: I33806d747cd344250d02e217de8e9b6d5a7f83c1
2023-01-05 10:40:14 -05:00
Jaydeep Patel
67792dd858
SWDEV-374373 - Occupied size should be within range.
...
Change-Id: I20e24c628c51154c2f8f36dca0a6fa4ead1ee6d0
2023-01-05 08:02:20 -05:00
Anusha GodavarthySurya
067c7316ba
SWDEV-373173 - Correct max VGPRs and VGPR Granularity in Occupancy calculation for different asics
...
Change-Id: Ib213ed8767a793a832776fba7c0811c2f023a8ad
2023-01-04 01:34:40 -05:00
German Andryeyev
38ad6234f9
SWDEV-360031 - Erase destroyed stream from capture
...
Parallel streams can be destroyed during capture. Make sure runtime
removes the destoryed streams from the list of parallel captured streams
Change-Id: I46b6cbb951e8711f0bf02f2826c3b890b2541ffe
2023-01-03 13:34:07 -05:00
Satyanvesh Dittakavi
409f23d905
SWDEV-374371 - hipGraphAddMemsetNode should return error if width is 0
...
Change-Id: I1cd4be271f65c9cade8dddb6d00191e1b74c96bc
2023-01-03 10:29:16 -05:00
sdashmiz
ce60d47b61
SWDEV-370309 - GetNodes should do levelorder
...
- GetNode should retrun nodes based on the dependency between them
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: Ie8ecdd976f8dc9d9b5dc2adc6ae8f879912c8169
2023-01-03 04:54:55 -05:00
Jaydeep Patel
f2b0542442
SWDEV-374370 - Propogate element size to blit kernel.
...
Change-Id: I8a3355c62947265be34e6a2befd26f86b3dc6cd2
2023-01-01 23:54:09 -05:00