Commit gráf

5545 Commit-ok

Szerző SHA1 Üzenet Dátum
Vladislav Sytchenko 779d723ac2 hipMemset2D and hipMemset3D tests should be passing by default.
[ROCm/hip commit: c747b77ac1]
2019-10-16 11:02:38 -04:00
Evgeny Mankov 187eeb86bc [HIPIFY] Refactor a couple of matcher functions
+ Separate out GetSubstrLocation function for finding substr SourceLocation in a given SourceRange


[ROCm/hip commit: 809a67a4f6]
2019-10-16 13:43:56 +03:00
Evgeny Mankov dcbe9432bd [HIPIFY][CUB][#1460] Implement cubFunctionTemplateDecl matcher
+ Add cub_02.cu test
+ Partial fixes #1460


[ROCm/hip commit: 6960574850]
2019-10-16 13:08:11 +03:00
kjayapra-amd c6fd681dd5 Use the correct return type in runTest in 11_texture_driver sample. (#1546)
Fixes SWDEV-203394.
Currently in runTest() returns true, even if the texture reference copy does not happen. Using the existing testResult Flag to return from runTest().

[ROCm/hip commit: fbb98f4950]
2019-10-16 10:52:15 +05:30
vsytch eaa616bf6d Update hipMathFunctions, hipTestHalf and hipTestNativeHalf tests to support Navi10 and Navi14. (#1545)
[ROCm/hip commit: 2fb734ef5f]
2019-10-16 10:51:48 +05:30
kpyzhov cba73a44ef [hipcc] Temporary add -D_OPENMP to clang options to workaround cmake issue (#1540)
* Temporary add -D_OPENMP to clang options in hipcc to allow using CMake OpenMP detection with hip-clang (until updated CMake version is available).

[ROCm/hip commit: 596bf4e326]
2019-10-16 10:51:28 +05:30
Nick Curtis d2e9718d23 Guard against division by zero for no VGPR usage (e.g., in an empty kernel) (#1528)
* guard against division by zero for no VGPR usage (e.g., in an empty kernel)

* fix bracket format

* clean up parenthesis


[ROCm/hip commit: 73ca2b0083]
2019-10-16 10:49:56 +05:30
Jatin Chaudhary 22978cb1a3 Adding code object manager to rtc (#1526)
Adding Code Object Manager file to rtc to resolve address of Bundled_code_object in libhiprtc.so

[ROCm/hip commit: c47c2c4f9a]
2019-10-16 10:49:16 +05:30
Xiaozhu Meng 8d8bc72f6a Fix struct declaration for C (#1524)
This change is necessary for HPCToolkit to use Roctracer to produce code centric profiling view.

[ROCm/hip commit: e9adb8e932]
2019-10-16 10:48:55 +05:30
Yaxun (Sam) Liu 73763f8748 Add -fhip-new-launch-api to hipcc for HIP/VDI
[ROCm/hip commit: 4d5cb8351c]
2019-10-15 21:47:33 -04:00
foreman 185c445b9a P4 to Git Change 2013937 by kjayapra@1_HIPWS_LNX1_PAL on 2019/10/15 17:40:44
SWDEV-203394 - Setting Array Channel Desc in hipArrayCreate.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#77 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#22 edit


[ROCm/hip commit: 87dbe184aa]
2019-10-15 16:43:10 -05:00
Vladislav Sytchenko 948dd510eb In the hipMemset2D and hipMemset3D tests synchronize with the default stream after performing an async memset.
[ROCm/hip commit: f5af263aba]
2019-10-15 17:15:49 -04:00
Vladislav Sytchenko 6180a9edb3 Update indentation in the hipMemset3D test. Replace all tabs with four spaces.
[ROCm/hip commit: 346bfa90d6]
2019-10-15 15:29:14 -04:00
Vladislav Sytchenko 5a29d10dbb Add async subtest to hipMemSet3D
[ROCm/hip commit: 00425bdf3d]
2019-10-15 14:24:04 -04:00
Vladislav Sytchenko 28089f61b6 hipMemset2D test should pass only if both async and sync subtests pass.
[ROCm/hip commit: 3db2ecc52b]
2019-10-15 14:20:14 -04:00
Vladislav Sytchenko 370d039d24 Update the declarations of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async. These functions are type aware and take in as their third argument the number of elements in the buffer, not the buffer size. Change the name of this argument from sizeBytes to count to align with the above description.
[ROCm/hip commit: 0b52c1d9d8]
2019-10-15 14:18:42 -04:00
Evgeny Mankov 46918133df Merge pull request #1541 from emankov/doc
[HIPIFY][cmake] Make CMakeLists.txt compatible with default cmake 3.5.2 for Ubuntu 16.04

[ROCm/hip commit: dd665f446c]
2019-10-15 17:11:39 +03:00
Evgeny Mankov 44ca50dfd0 [HIPIFY][tests] Exclude tests for the libs, which are not defined in cmake command line
+ affects cuDNN and CUB tests, paths to libraries of which are defined by CUDA_DNN_ROOT_DIR and CUDA_CUB_ROOT_DIR
+ Warn about excluding and why, for instance:
  "WARN: cuDNN tests are excluded due to unset CUDA_DNN_ROOT_DIR"


[ROCm/hip commit: 3444834e3a]
2019-10-15 14:20:23 +03:00
Evgeny Mankov e49e3bfffa [HIPIFY][cmake] Make CMakeLists.txt compatible with default cmake 3.5.2 for Ubuntu 16.04
+ Update README.md accordingly


[ROCm/hip commit: d57c9a844b]
2019-10-15 11:26:03 +03:00
Anusha Godavarthy Surya e74d2cff3f Added unbind texture to samples and tests
[ROCm/hip commit: d5b1e887e9]
2019-10-15 11:34:15 +05:30
Evgeny Mankov 8456642b3d [HIPIFY] HipifyAction code clean-up
[ROCm/hip commit: c0f62157f9]
2019-10-14 18:08:29 +03:00
Evgeny Mankov b3f8782fb9 [HIPIFY][build fix] Add missing new source file
[ROCm/hip commit: 2994fb3429]
2019-10-14 16:32:57 +03:00
Evgeny Mankov 1554bb5e4e Merge pull request #1534 from emankov/hipify-clang
[HIPIFY][CUB] Initial support (hipify-clang only)

[ROCm/hip commit: 4ffcb0b26f]
2019-10-14 15:57:09 +03:00
Evgeny Mankov d174cad0aa [HIPIFY][CUB] Add missing unit test
[ROCm/hip commit: 92fb5a3a94]
2019-10-14 12:03:20 +03:00
Evgeny Mankov 3deccebb07 [HIPIFY][CUB] Initial support (hipify-clang only)
+ Add one matcher (will be more)
+ Update Maps and Statistics
+ Add cub_01.cu unit test
+ Update lit harness to support standalone CUB
+ Update README.md
+ Update hipify-perl (only CUB header is supported for now)

[IMPORTANT]
clang (and hipify-clang) works correctly only with official NVLabs version on GitHub.
Compilation of CUB from official CUDA release has conflicts with THRUST.
Thus, to compile CUB sources, option "-I" should be specified to the cloned CUB from NVLAB on GitHub.


[ROCm/hip commit: 277d3b8369]
2019-10-14 11:55:55 +03:00
foreman a2841a5929 P4 to Git Change 2012424 by axie@axie_win_opencl_ssd on 2019/10/11 14:32:12
SWDEV-206239 - [hipclang-vdi-rocm][perf]RCCL: finegrain VRAM does not work
	xGMI may not work. Otherwise, several GPUs and CPU can access the same host memory atomically by API hipExtMallocWithFlags

	Tests:
	http://ocltc:8111/viewModification.html?modId=127344&personal=true&init=1&tab=vcsModificationBuilds

	ReviewBoard: http://ocltc.amd.com/reviews/r/18109/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#76 edit


[ROCm/hip commit: 001f07ae83]
2019-10-11 14:43:24 -04:00
Evgeny Mankov a4b08bcfa3 [HIP] Fix typo in a comment
[ROCm/hip commit: 28c23a7b1a]
2019-10-11 15:20:58 +03:00
Evgeny Mankov 0331004a44 [HIP][fix] Prefix libraryPropertyType to fix build of rocFFT and TensorFlow
[ROCm/hip commit: 337b7ce06a]
2019-10-11 15:18:08 +03:00
foreman 2058d5033f P4 to Git Change 2011990 by eshcherb@evgeny-hip on 2019/10/10 20:09:32
SWDEV-197287 - HIP tracing layer: any-api-id removing

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#3 edit
... //depot/stg/opencl/drivers/opencl/hip_prof_gen.py#3 edit


[ROCm/hip commit: 980623d5e1]
2019-10-10 20:23:33 -04:00
Evgeny Mankov 20be535ea7 [HIPIFY][perl] Add "important" notice
# IMPORTANT: Do not change this file manually: it is generated by hipify-clang --perl


[ROCm/hip commit: 876af8f381]
2019-10-10 18:25:26 +03:00
Jatin Chaudhary adf925d497 Re enable test RTC (#1516)
Adding target resolution in hiprtc tests and reenable them.

[ROCm/hip commit: 32eb6d3bec]
2019-10-10 19:59:55 +05:30
Maneesh Gupta 1a842e0a58 tracing layer unifying with hcc: removing API_ID_ANY (#1514)
[ROCm/hip commit: 3ae52f86b1]
2019-10-10 19:59:05 +05:30
ansurya b37210badc Fix for directed tests failure (#1511)
directed_tests/runtimeApi/module/hipLaunchCooperativeKernel.tst - Disabling test temporarily until driver support is available.
directed_tests/runtimeApi/memory/hipArray.tst - Disabling test temporarily to reimplement it correctly.

[ROCm/hip commit: 87834500b9]
2019-10-10 19:58:41 +05:30
Evgeny Mankov 0ac55b1a9d [HIP] Introduce library_types.h as a common header for libs (#1509)
* [HIP] Introduce library_types.h as a common header for libs

[Reason]
Currently, hipFFT, hipBLAS and other HIP libs use their own data types, prefixed with HIPFFT or HIPBLAS, whereas in CUDA those types are common and declared in library_types.h

[TODO]
Switch hipFFT, hipBLAS and other HIP libs to use common library_types.h.

* [HIP] Move include for library_types.h to hip_runtime.h

[Reason]
Repeat CUDA's behaviour, where library_types.h is included in cuda_runtime.h


[ROCm/hip commit: 94eb4155dd]
2019-10-10 19:57:28 +05:30
srinivamd fe7c030148 remove dependencies on /opt/rocm path (#1379)
* remove hard coded dependencies on /opt/rocm path

[ROCm/hip commit: 908e14d176]
2019-10-10 19:56:55 +05:30
Evgeny Mankov b4d99584dc [HIPIFY][test] Update allocators.cu test
[ROCm/hip commit: 88cb3504ff]
2019-10-10 17:20:41 +03:00
Anusha Godavarthy Surya 04080d4bb1 Fix undefine ref to hipUbindTexture for texture types
[ROCm/hip commit: af5f195e46]
2019-10-09 16:26:06 +05:30
Evgeny 8c0b43156e tracing layer unifying with hcc: removing API_ID_ANY
[ROCm/hip commit: 4e93833035]
2019-10-08 19:09:43 -05:00
Evgeny Mankov a8b7ebefb0 Merge pull request #1513 from emankov/hipify-clang
[HIPIFY][doc] Add a few words about hipify-perl

[ROCm/hip commit: 4a4a620389]
2019-10-08 22:30:25 +03:00
Evgeny Mankov 7aa4b75259 [HIPIFY][doc] Add a few words about hipify-perl
+ Update testing and versions


[ROCm/hip commit: de1b81b78a]
2019-10-08 22:27:48 +03:00
foreman 6285c64be1 P4 to Git Change 2010058 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/10/08 14:44:53
SWDEV-144570 - Implementation of APIs hipMemsetD8Async, hipMemAllocPitch, hipMemAllocHost and template for hipMemsetD16, hipMemsetD16Async.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#30 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#29 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#75 edit


[ROCm/hip commit: e455ddb5b3]
2019-10-08 14:55:27 -04:00
foreman 2005705374 P4 to Git Change 2009953 by eshcherb@evgeny-hip on 2019/10/08 12:36:36
SWDEV-197287 - HIP tracing layer instrumentation - Windows link issues.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_intercept.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#2 edit


[ROCm/hip commit: 3990498a1e]
2019-10-08 12:46:05 -04:00
Evgeny Mankov 69ea727e92 [HIPIFY][#1487][fix] Translate correctly kernel names prefixed with namespace
+ Modify CUDA2HIP_perl for the fix
+ Add ns_kernel_launch.cu test
+ Update hipify-perl by hipify-clang -perl


[ROCm/hip commit: 3286ffdfc0]
2019-10-08 15:58:48 +03:00
foreman 1ae22b2688 P4 to Git Change 2009236 by eshcherb@evgeny-hip on 2019/10/07 11:49:55
SWDEV-197287 - HIP tracing layer instrumentation

	hip_prof_str.h - generated header; as a next step a genrator will be integrated in HIP makefile (similar to HIP-HCC)
	prof_protocol.h - temporarily included in HIP sources. Provided by roctracer-proto package. HIP-HCC CMake has parameter to set a path to the header.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/build/Makefile.hip#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#19 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_intercept.cpp#1 add
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#44 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#74 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#43 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#44 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#1 add
... //depot/stg/opencl/drivers/opencl/api/hip/hip_profile.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#25 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/prof_protocol.h#1 add
... //depot/stg/opencl/drivers/opencl/hip_prof_gen.py#1 add
... //depot/stg/opencl/drivers/opencl/make/hip.git/include/hip/hcc_detail/hip_prof_str.h#2 delete


[ROCm/hip commit: 6e7f1dea66]
2019-10-07 11:55:30 -04:00
Evgeny Mankov a05383fc4c [HIPIFY] Sync with HIP
+ Update hipify-perl accordingly


[ROCm/hip commit: 6aa7540be8]
2019-10-07 14:44:05 +03:00
Evgeny Mankov 512adfd735 [HIPIFY] Remove duplicates
+ C++ maps and docs affected, hipify-perl left unchanged


[ROCm/hip commit: b744ec4548]
2019-10-07 14:33:04 +03:00
Maneesh Gupta 5aedf2d61b [ci] Enable tests on ROCm 2.9 (#1503)
[ROCm/hip commit: 87651cffc2]
2019-10-07 14:12:08 +05:30
Rahul Garg 4f899d487c Fix PCI Domain ID query (#1424)
* Fix PCI Domain ID query

* Update BDF comment


[ROCm/hip commit: 96530cba3b]
2019-10-07 14:11:52 +05:30
Evgeny Mankov ffee68f4f9 [HIPIFY][SPARSE] sync with hipSPARSE
+ Update doc and hipify-perl accordingly


[ROCm/hip commit: 410f6c4a95]
2019-10-05 15:53:04 +03:00
foreman 5f8c952ecf P4 to Git Change 2008906 by axie@axie-hip-vdi-pal2 on 2019/10/04 18:55:34
SWDEV-189650 - [HIP-CLANG][HIP/VDI/PAL] Hangs on test hip_threadfence_system
	1. In HIP + VDI + ROCm, allow SVM atomic in VEGA10 and later ASIC. GFX8 (Tonga) was enabled before.
	2. In HIP + VDI + PAL Linux driver, allow SVM atomic in VEGA10 and later ASIC.

	Tests:
	1. In HIP + VDI + ROCm, hip_threadfence_system test passed.
	2. In HIP + VDI + PAL + Linux , hip_threadfence_system test passed.
	3. OpenCL + PAL, clinfo and ocltest runtime test pass.
	4. OpenCL + ROCM, clinfo and ocltest runtime test pass.
	5. Windows 10, VEGA 10, clinfo and and ocltest runtime test pass. hip_threadfence_system test passed by skipping the test.

	Teamcity presubmission test:
	http://ocltc.amd.com:8111/viewModification.html?modId=127083&personal=true&tab=vcsModificationBuilds
	http://ocltc.amd.com:8111/viewModification.html?modId=127076&personal=true&tab=vcsModificationBuilds

	ReviewBoard: http://ocltc.amd.com/reviews/r/18077/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#73 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#171 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#80 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.hpp#31 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#134 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#44 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#320 edit


[ROCm/hip commit: 5db4c83423]
2019-10-04 19:02:35 -04:00